New issue
Advanced search Search tips

Issue 753924 link

Starred by 4 users

Issue metadata

Status: Verified
Owner:
Closed: Jun 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 2
Type: Bug

Blocking:
issue 671916



Sign in to add a comment

[MacViewsBrowser] New windows don't animate in

Project Member Reported by sdy@chromium.org, Aug 9 2017

Issue description

Chrome Version: 62.0.3188.0 (MacViews)
OS: macOS 10.12.6 (16G29)

What steps will reproduce the problem?
(1) Open a new window.

What is the expected result?
It starts small and transparent and grows to its full size and opacity with a quick animation.

What happens instead?
The window appears all at once.
 

Comment 1 by sdy@chromium.org, Aug 18 2017

Description: Show this description
Labels: M-68
[Bulk Edit]
Applying M-68 milestone per email discussion with ellyjones@. Pls change it if milestone is incorrectly applied. 
Labels: -M-68 Target-68
Owner: sdy@chromium.org
Status: Assigned (was: Available)
MacViews triage: to sdy@ for fix in M-68.

Comment 4 by gov...@chromium.org, Mar 27 2018

Labels: M-68

Comment 5 by gov...@chromium.org, Mar 29 2018

** Bulk Edit **

FYI: Starting 04/13 M68 will be in canary, M68 Dev promotion will be on 04/26.

Comment 6 by sdy@chromium.org, Apr 12 2018

Cc: sdy@chromium.org
 Issue 826273  has been merged into this issue.

Comment 7 by sdy@chromium.org, Apr 16 2018

Labels: Sprint-1

Comment 8 by gov...@chromium.org, Apr 25 2018

Pls mark the bug as fixed if CL is landed in trunk and nothing else is pending. Thank you.

Comment 9 by sdy@chromium.org, May 7 2018

Labels: -Sprint-1 Sprint-2
Any progress here?
Labels: -Target-68 Target-69
Project Member

Comment 12 by bugdroid1@chromium.org, Jun 28 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/74529e7da95616537ecd53821247a5cd985347be

commit 74529e7da95616537ecd53821247a5cd985347be
Author: Sidney San Martín <sdy@chromium.org>
Date: Thu Jun 28 14:55:30 2018

Animate in new browser windows on macOS.

Bug:  753924 
Change-Id: I4656a4f3d409bb6aada86654f675dc0e51cb93d2
Reviewed-on: https://chromium-review.googlesource.com/1117601
Reviewed-by: Avi Drissman <avi@chromium.org>
Commit-Queue: Sidney San Martín <sdy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#571122}
[modify] https://crrev.com/74529e7da95616537ecd53821247a5cd985347be/chrome/browser/ui/views/frame/browser_frame_mac.mm

Comment 13 by sdy@chromium.org, Jun 28 2018

Status: Fixed (was: Assigned)
Should be fixed in the next canary.
Labels: Needs-Feedback
Tested this issue on Mac OS 10.13.3 on the reported version 67.0.3381.0 and latest Canary 69.0.3476.0 as per  issue 826273 .

1. Launched Chrome, enabled the flag #views-browser-windows and relaunched Chrome
2. Hit Cmd+N and the window immediately opens to its full size.
Attached is the screen cast for reference.

sdy@ Request you to check and confirm if anything is missed from our end in verifying the issue?

Thanks..
753924-M69.mp4
924 KB View Download

Comment 15 by sdy@chromium.org, Jun 29 2018

Status: Verified (was: Fixed)
The animation is brief but I can see it in your screen recording:
Screen Shot 2018-06-29 at 11.37.25 AM.png
357 KB View Download
This causes the devtools to animate in as well, and tabs torn off of the tab strip.
jleedev@ Can you please open a new report, if you think this is a bug? Please post the reportnumber here. Thanks.
Labels: -M-68 Group-MacOS_Platform_Integration_and_Participation
Just to follow up on this Re: #17,

Tabs torn off are not animating off in recent canaries, so I can't report anything about that. Devtools is slightly distracting but not worth reporting IMHO.

Sign in to add a comment