New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 753923 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Nov 18
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Feature



Sign in to add a comment

mosys: move dep out of virtual/target-chromium-os and pull in only when needed

Project Member Reported by vapier@chromium.org, Aug 9 2017

Issue description

we have some systems (like lakitu) where mosys (and flashrom) don't make sense.  we should pull this out of virtual/target-chromium-os and have it be pulled in only by the packages that actually utilize `mosys`.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Aug 10 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/276e90e010d5e275a63cd569c2161bb355b4092c

commit 276e90e010d5e275a63cd569c2161bb355b4092c
Author: Mike Frysinger <vapier@chromium.org>
Date: Thu Aug 10 04:46:14 2017

power_manager: add mosys dep

The mosys_eventlog feature needs as it'll execute `mosys`.

BUG= chromium:753923 
TEST=precq passes

Change-Id: I64566b1184b744d75f814d4908552fd52ca1adeb
Reviewed-on: https://chromium-review.googlesource.com/608845
Commit-Ready: Mike Frysinger <vapier@chromium.org>
Tested-by: Mike Frysinger <vapier@chromium.org>
Reviewed-by: Dan Erat <derat@chromium.org>

[modify] https://crrev.com/276e90e010d5e275a63cd569c2161bb355b4092c/chromeos-base/power_manager/power_manager-9999.ebuild

Project Member

Comment 2 by bugdroid1@chromium.org, Aug 10 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/3c647d9a46639774336449205b3319ad4817dd03

commit 3c647d9a46639774336449205b3319ad4817dd03
Author: Mike Frysinger <vapier@chromium.org>
Date: Thu Aug 10 06:33:06 2017

touch_updater: add mosys dep

The scripts use this to get the chassis id.

BUG= chromium:753923 
TEST=precq passes

Change-Id: Ie13192903d234400c89e9d107d2283b01db0776d
Reviewed-on: https://chromium-review.googlesource.com/609030
Commit-Ready: Mike Frysinger <vapier@chromium.org>
Tested-by: Mike Frysinger <vapier@chromium.org>
Reviewed-by: Wei-Ning Huang <wnhuang@chromium.org>

[modify] https://crrev.com/3c647d9a46639774336449205b3319ad4817dd03/chromeos-base/touch_updater/touch_updater-9999.ebuild

Project Member

Comment 3 by bugdroid1@chromium.org, Aug 14 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/cb5310e6b5dba62f3a06ee4add779352fd8944ac

commit cb5310e6b5dba62f3a06ee4add779352fd8944ac
Author: Mike Frysinger <vapier@chromium.org>
Date: Mon Aug 14 16:18:42 2017

chromeos-initramfs: add missing deps for factory netboot

Looking at factory_netboot/Makefile, there are a number of programs that
we pull into the initramfs but don't actually depend on in the ebuild.

BUG= chromium:753923 
TEST=precq passes

Change-Id: I583731989d0eda0b68f06b583ddd7bd98c859d82
Reviewed-on: https://chromium-review.googlesource.com/609028
Commit-Ready: Mike Frysinger <vapier@chromium.org>
Tested-by: Mike Frysinger <vapier@chromium.org>
Reviewed-by: Hung-Te Lin <hungte@chromium.org>

[modify] https://crrev.com/cb5310e6b5dba62f3a06ee4add779352fd8944ac/chromeos-base/chromeos-initramfs/chromeos-initramfs-9999.ebuild

Project Member

Comment 4 by sheriffbot@chromium.org, Aug 15

Labels: Hotlist-Recharge-Cold
Status: Untriaged (was: Available)
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue.

Sorry for the inconvenience if the bug really should have been left as Available.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Owner: vapier@chromium.org
Status: Assigned (was: Untriaged)
Can this be closed?
Project Member

Comment 6 by bugdroid1@chromium.org, Nov 18

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/74dc89dc620f808804a55287eba81266ff5a3795

commit 74dc89dc620f808804a55287eba81266ff5a3795
Author: Mike Frysinger <vapier@chromium.org>
Date: Sun Nov 18 00:41:42 2018

target-chromium-os: drop mosys requirement

Any package that needs mosys should depend on it.

BUG= chromium:753923 
TEST=precq passes

Change-Id: I6ba2cff60e45b63e496961bdaa198eed1059e712
Reviewed-on: https://chromium-review.googlesource.com/1330168
Commit-Ready: Mike Frysinger <vapier@chromium.org>
Tested-by: Mike Frysinger <vapier@chromium.org>
Reviewed-by: Chirantan Ekbote <chirantan@chromium.org>

[rename] https://crrev.com/74dc89dc620f808804a55287eba81266ff5a3795/virtual/target-chromium-os/target-chromium-os-1-r112.ebuild
[modify] https://crrev.com/74dc89dc620f808804a55287eba81266ff5a3795/virtual/target-chromium-os/target-chromium-os-1.ebuild

Status: Fixed (was: Assigned)

Sign in to add a comment