New issue
Advanced search Search tips

Issue 753905 link

Starred by 1 user

Issue metadata

Status: Duplicate
Merged: issue 744674
Owner:
Closed: Aug 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 1
Type: Bug-Regression



Sign in to add a comment

M61 regression: tiles when scrolling

Project Member Reported by pdr@chromium.org, Aug 9 2017

Issue description

Chrome Version: 62.0.3180.0/Canary
OS: Android

What steps will reproduce the problem?
(1) Visit http://www.torrentlab.com/torrent/Home/LaboratoryCapabilities/EnvironmentalAnalysisServices/DrinkingWater.html
(2) Zoom all the way in.
(3) Pan around the page

What is the expected result?
No black squares.

What happens instead?
Black squares (see video).

 
torrent_tiles.mp4
28.3 MB Download
Labels: -Pri-2 PaintTeamTriaged-20170809 BugSource-Team Pri-1
Up the priority to get a bisect.

Comment 2 by pdr@chromium.org, Aug 9 2017

In case anyone is worried: the phone in the video says confidential but it is actually a very old phone that's no longer in production.

Comment 3 by hdodda@chromium.org, Aug 10 2017

Labels: OS-Android

Comment 4 by pdr@chromium.org, Aug 17 2017

Cc: vmp...@chromium.org mtklein@chromium.org
Labels: -M-62 M-61
Owner: fmalita@chromium.org
Summary: M61 regression: tiles when scrolling (was: Regression: black tiles when scrolling)
I manually bisected this to:
https://chromium.googlesource.com/chromium/src/+log/8022c043c4621720ad51f240e8c74d8eb4a38f85..9e7a7feaa60f341658c71414f9c45d5d9544ceed?pretty=fuller&n=10000

Enable Skia rasterpipeline for tiling
https://chromium.googlesource.com/chromium/src/+/c785be2815a779a528834a06e2e4d00d9fe3dfce

The regression no longer shows black tiles but still shows extreme tiling compared to before. Repro steps:
(1) Visit http://www.torrentlab.com/torrent/Home/LaboratoryCapabilities/EnvironmentalAnalysisServices/DrinkingWater.html
(2) Zoom all the way in.
(3) Pan top the top-right corner
(3) Pan up and down, notice full-screen tiles.

Cc: fmalita@chromium.org reed@google.com
Owner: mtklein@chromium.org
Looks like slow SW rasterization (not filling the compositor tiles fast enough).  Incidentally, I would expect some sort of checker-boarding, not black tiles...

@pdr do you happen to know why GPU rasterization is disabled on this device?  Maybe 'cause it's old/unsupported?  Did you manage to repro on any other device?

We've been operating under the assumption that Android == Ganesh.  If that's not always the case, then I believe raster pipeline can potentially be much slower on arm.  Punting to mtklein to confirm.

Comment 6 by pdr@chromium.org, Aug 17 2017

The video is from a Nexus 6 but this repros on a Google Pixel too. GPU raster should be enabled. Don't worry about the black tiles; the issue is that checkerboarding increased significantly.
Hmm, can you verify that GPU rasterization is enabled?  That change only affects sw raster.
(the tile size in the video also hints at sw raster - they look square/256x256, unlike GPU tiles)
I was able to repro on an N5x, and can confirm this occurs with GPU rasterization enabled.

I'm guessing there must be something causing us to veto that page and fall back to sw.
Owner: fmalita@chromium.org
Since https://chromium.googlesource.com/chromium/src/+/c785be2815a779a528834a06e2e4d00d9fe3dfce is also the remaining bit for  issue 744674 , I'll see if we can still revert cleanly in Skia.  Then we can re-evaluate after M61.
Project Member

Comment 11 by bugdroid1@chromium.org, Aug 18 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b9e02f8f670683edaac8b9e6c7a6ce23a5a71194

commit b9e02f8f670683edaac8b9e6c7a6ce23a5a71194
Author: Florin Malita <fmalita@chromium.org>
Date: Fri Aug 18 16:57:23 2017

Disable Skia raster pipeline for image tiling

Adding SK_SUPPORT_LEGACY_TILED_BITMAPS.

This is a revert of https://chromium-review.googlesource.com/545816.

BUG= 753905 , 744674 

Change-Id: I078f076e75fb868a50927efb8fc4e2de65339533
Reviewed-on: https://chromium-review.googlesource.com/620528
Commit-Queue: Florin Malita <fmalita@chromium.org>
Reviewed-by: Mike Klein <mtklein@google.com>
Reviewed-by: Mike Klein <mtklein@chromium.org>
Cr-Commit-Position: refs/heads/master@{#495583}
[modify] https://crrev.com/b9e02f8f670683edaac8b9e6c7a6ce23a5a71194/skia/config/SkUserConfig.h
[modify] https://crrev.com/b9e02f8f670683edaac8b9e6c7a6ce23a5a71194/third_party/WebKit/LayoutTests/fast/backgrounds/size/backgroundSize07-expected.png
[modify] https://crrev.com/b9e02f8f670683edaac8b9e6c7a6ce23a5a71194/third_party/WebKit/LayoutTests/fast/backgrounds/size/backgroundSize08-expected.png
[modify] https://crrev.com/b9e02f8f670683edaac8b9e6c7a6ce23a5a71194/third_party/WebKit/LayoutTests/fast/borders/border-image-slice-constrained-expected.png
[modify] https://crrev.com/b9e02f8f670683edaac8b9e6c7a6ce23a5a71194/third_party/WebKit/LayoutTests/images/color-profile-border-image-expected.png
[modify] https://crrev.com/b9e02f8f670683edaac8b9e6c7a6ce23a5a71194/third_party/WebKit/LayoutTests/platform/linux/fast/backgrounds/repeat/mask-negative-offset-repeat-expected.png
[modify] https://crrev.com/b9e02f8f670683edaac8b9e6c7a6ce23a5a71194/third_party/WebKit/LayoutTests/platform/linux/fast/backgrounds/size/backgroundSize16-expected.png
[modify] https://crrev.com/b9e02f8f670683edaac8b9e6c7a6ce23a5a71194/third_party/WebKit/LayoutTests/platform/linux/fast/borders/border-image-border-radius-expected.png
[modify] https://crrev.com/b9e02f8f670683edaac8b9e6c7a6ce23a5a71194/third_party/WebKit/LayoutTests/platform/linux/fast/borders/border-image-scaled-expected.png
[modify] https://crrev.com/b9e02f8f670683edaac8b9e6c7a6ce23a5a71194/third_party/WebKit/LayoutTests/platform/linux/fast/borders/scaled-border-image-expected.png
[modify] https://crrev.com/b9e02f8f670683edaac8b9e6c7a6ce23a5a71194/third_party/WebKit/LayoutTests/platform/linux/ietestcenter/css3/bordersbackgrounds/background-size-aspect-ratio-expected.png
[modify] https://crrev.com/b9e02f8f670683edaac8b9e6c7a6ce23a5a71194/third_party/WebKit/LayoutTests/platform/linux/paint/spellmarkers/document-markers-expected.png
[modify] https://crrev.com/b9e02f8f670683edaac8b9e6c7a6ce23a5a71194/third_party/WebKit/LayoutTests/platform/linux/paint/spellmarkers/document-markers-zoom-125-expected.png
[modify] https://crrev.com/b9e02f8f670683edaac8b9e6c7a6ce23a5a71194/third_party/WebKit/LayoutTests/platform/linux/paint/spellmarkers/document-markers-zoom-150-expected.png
[modify] https://crrev.com/b9e02f8f670683edaac8b9e6c7a6ce23a5a71194/third_party/WebKit/LayoutTests/platform/linux/paint/spellmarkers/document-markers-zoom-175-expected.png
[modify] https://crrev.com/b9e02f8f670683edaac8b9e6c7a6ce23a5a71194/third_party/WebKit/LayoutTests/platform/linux/paint/spellmarkers/document-markers-zoom-200-expected.png
[modify] https://crrev.com/b9e02f8f670683edaac8b9e6c7a6ce23a5a71194/third_party/WebKit/LayoutTests/platform/linux/paint/spellmarkers/document-markers-zoom-250-expected.png
[modify] https://crrev.com/b9e02f8f670683edaac8b9e6c7a6ce23a5a71194/third_party/WebKit/LayoutTests/platform/linux/paint/spellmarkers/inline-spelling-markers-hidpi-composited-expected.png
[modify] https://crrev.com/b9e02f8f670683edaac8b9e6c7a6ce23a5a71194/third_party/WebKit/LayoutTests/platform/linux/paint/spellmarkers/inline-spelling-markers-hidpi-expected.png
[modify] https://crrev.com/b9e02f8f670683edaac8b9e6c7a6ce23a5a71194/third_party/WebKit/LayoutTests/platform/linux/paint/spellmarkers/inline_spelling_markers-expected.png
[modify] https://crrev.com/b9e02f8f670683edaac8b9e6c7a6ce23a5a71194/third_party/WebKit/LayoutTests/platform/linux/svg/as-border-image/svg-as-border-image-expected.png
[modify] https://crrev.com/b9e02f8f670683edaac8b9e6c7a6ce23a5a71194/third_party/WebKit/LayoutTests/platform/linux/virtual/exotic-color-space/images/color-profile-border-image-expected.png
[modify] https://crrev.com/b9e02f8f670683edaac8b9e6c7a6ce23a5a71194/third_party/WebKit/LayoutTests/platform/linux/virtual/exotic-color-space/images/color-profile-border-image-source-expected.png
[modify] https://crrev.com/b9e02f8f670683edaac8b9e6c7a6ce23a5a71194/third_party/WebKit/LayoutTests/platform/linux/virtual/exotic-color-space/images/color-profile-group-expected.png
[modify] https://crrev.com/b9e02f8f670683edaac8b9e6c7a6ce23a5a71194/third_party/WebKit/LayoutTests/platform/mac-mac10.11/paint/spellmarkers/document-markers-zoom-150-expected.png
[modify] https://crrev.com/b9e02f8f670683edaac8b9e6c7a6ce23a5a71194/third_party/WebKit/LayoutTests/platform/mac-mac10.9/ietestcenter/css3/bordersbackgrounds/background-size-aspect-ratio-expected.png
[modify] https://crrev.com/b9e02f8f670683edaac8b9e6c7a6ce23a5a71194/third_party/WebKit/LayoutTests/platform/mac-retina/paint/spellmarkers/document-markers-zoom-150-expected.png
[modify] https://crrev.com/b9e02f8f670683edaac8b9e6c7a6ce23a5a71194/third_party/WebKit/LayoutTests/platform/mac/css3/background/background-large-position-and-size-remains-stable-expected.png
[modify] https://crrev.com/b9e02f8f670683edaac8b9e6c7a6ce23a5a71194/third_party/WebKit/LayoutTests/platform/mac/fast/backgrounds/repeat/mask-negative-offset-repeat-expected.png
[modify] https://crrev.com/b9e02f8f670683edaac8b9e6c7a6ce23a5a71194/third_party/WebKit/LayoutTests/platform/mac/fast/backgrounds/size/backgroundSize16-expected.png
[modify] https://crrev.com/b9e02f8f670683edaac8b9e6c7a6ce23a5a71194/third_party/WebKit/LayoutTests/platform/mac/fast/borders/border-image-01-expected.png
[modify] https://crrev.com/b9e02f8f670683edaac8b9e6c7a6ce23a5a71194/third_party/WebKit/LayoutTests/platform/mac/fast/borders/border-image-border-radius-expected.png
[modify] https://crrev.com/b9e02f8f670683edaac8b9e6c7a6ce23a5a71194/third_party/WebKit/LayoutTests/platform/mac/fast/borders/border-image-longhand-expected.png
[modify] https://crrev.com/b9e02f8f670683edaac8b9e6c7a6ce23a5a71194/third_party/WebKit/LayoutTests/platform/mac/fast/borders/border-image-outset-expected.png
[modify] https://crrev.com/b9e02f8f670683edaac8b9e6c7a6ce23a5a71194/third_party/WebKit/LayoutTests/platform/mac/fast/borders/border-image-outset-in-shorthand-expected.png
[modify] https://crrev.com/b9e02f8f670683edaac8b9e6c7a6ce23a5a71194/third_party/WebKit/LayoutTests/platform/mac/fast/borders/border-image-outset-split-inline-expected.png
[modify] https://crrev.com/b9e02f8f670683edaac8b9e6c7a6ce23a5a71194/third_party/WebKit/LayoutTests/platform/mac/fast/borders/border-image-repeat-expected.png
[modify] https://crrev.com/b9e02f8f670683edaac8b9e6c7a6ce23a5a71194/third_party/WebKit/LayoutTests/platform/mac/fast/borders/border-image-repeat-round-expected.png
[modify] https://crrev.com/b9e02f8f670683edaac8b9e6c7a6ce23a5a71194/third_party/WebKit/LayoutTests/platform/mac/fast/borders/border-image-scale-transform-expected.png
[modify] https://crrev.com/b9e02f8f670683edaac8b9e6c7a6ce23a5a71194/third_party/WebKit/LayoutTests/platform/mac/fast/borders/border-image-scaled-expected.png
[modify] https://crrev.com/b9e02f8f670683edaac8b9e6c7a6ce23a5a71194/third_party/WebKit/LayoutTests/platform/mac/fast/borders/border-image-scrambled-expected.png
[modify] https://crrev.com/b9e02f8f670683edaac8b9e6c7a6ce23a5a71194/third_party/WebKit/LayoutTests/platform/mac/fast/borders/border-image-slices-expected.png
[modify] https://crrev.com/b9e02f8f670683edaac8b9e6c7a6ce23a5a71194/third_party/WebKit/LayoutTests/platform/mac/fast/borders/border-image-source-expected.png
[modify] https://crrev.com/b9e02f8f670683edaac8b9e6c7a6ce23a5a71194/third_party/WebKit/LayoutTests/platform/mac/fast/borders/scaled-border-image-expected.png
[modify] https://crrev.com/b9e02f8f670683edaac8b9e6c7a6ce23a5a71194/third_party/WebKit/LayoutTests/platform/mac/fast/writing-mode/border-image-vertical-lr-expected.png
[modify] https://crrev.com/b9e02f8f670683edaac8b9e6c7a6ce23a5a71194/third_party/WebKit/LayoutTests/platform/mac/fast/writing-mode/border-image-vertical-rl-expected.png
[modify] https://crrev.com/b9e02f8f670683edaac8b9e6c7a6ce23a5a71194/third_party/WebKit/LayoutTests/platform/mac/ietestcenter/css3/bordersbackgrounds/background-size-aspect-ratio-expected.png
[modify] https://crrev.com/b9e02f8f670683edaac8b9e6c7a6ce23a5a71194/third_party/WebKit/LayoutTests/platform/mac/images/color-profile-border-image-source-expected.png
[modify] https://crrev.com/b9e02f8f670683edaac8b9e6c7a6ce23a5a71194/third_party/WebKit/LayoutTests/platform/mac/images/color-profile-group-expected.png
[modify] https://crrev.com/b9e02f8f670683edaac8b9e6c7a6ce23a5a71194/third_party/WebKit/LayoutTests/platform/mac/paint/spellmarkers/document-markers-expected.png
[modify] https://crrev.com/b9e02f8f670683edaac8b9e6c7a6ce23a5a71194/third_party/WebKit/LayoutTests/platform/mac/paint/spellmarkers/document-markers-zoom-125-expected.png
[modify] https://crrev.com/b9e02f8f670683edaac8b9e6c7a6ce23a5a71194/third_party/WebKit/LayoutTests/platform/mac/paint/spellmarkers/document-markers-zoom-175-expected.png
[modify] https://crrev.com/b9e02f8f670683edaac8b9e6c7a6ce23a5a71194/third_party/WebKit/LayoutTests/platform/mac/paint/spellmarkers/document-markers-zoom-200-expected.png
[modify] https://crrev.com/b9e02f8f670683edaac8b9e6c7a6ce23a5a71194/third_party/WebKit/LayoutTests/platform/mac/paint/spellmarkers/document-markers-zoom-250-expected.png
[add] https://crrev.com/b9e02f8f670683edaac8b9e6c7a6ce23a5a71194/third_party/WebKit/LayoutTests/platform/mac/virtual/exotic-color-space/images/color-profile-border-image-expected.png
[modify] https://crrev.com/b9e02f8f670683edaac8b9e6c7a6ce23a5a71194/third_party/WebKit/LayoutTests/platform/mac/virtual/exotic-color-space/images/color-profile-border-image-source-expected.png
[modify] https://crrev.com/b9e02f8f670683edaac8b9e6c7a6ce23a5a71194/third_party/WebKit/LayoutTests/platform/mac/virtual/exotic-color-space/images/color-profile-group-expected.png
[modify] https://crrev.com/b9e02f8f670683edaac8b9e6c7a6ce23a5a71194/third_party/WebKit/LayoutTests/platform/win/css3/background/background-large-position-and-size-remains-stable-expected.png
[modify] https://crrev.com/b9e02f8f670683edaac8b9e6c7a6ce23a5a71194/third_party/WebKit/LayoutTests/platform/win/fast/backgrounds/repeat/mask-negative-offset-repeat-expected.png
[modify] https://crrev.com/b9e02f8f670683edaac8b9e6c7a6ce23a5a71194/third_party/WebKit/LayoutTests/platform/win/fast/backgrounds/size/backgroundSize16-expected.png
[modify] https://crrev.com/b9e02f8f670683edaac8b9e6c7a6ce23a5a71194/third_party/WebKit/LayoutTests/platform/win/fast/borders/border-image-01-expected.png
[modify] https://crrev.com/b9e02f8f670683edaac8b9e6c7a6ce23a5a71194/third_party/WebKit/LayoutTests/platform/win/fast/borders/border-image-border-radius-expected.png
[modify] https://crrev.com/b9e02f8f670683edaac8b9e6c7a6ce23a5a71194/third_party/WebKit/LayoutTests/platform/win/fast/borders/border-image-longhand-expected.png
[modify] https://crrev.com/b9e02f8f670683edaac8b9e6c7a6ce23a5a71194/third_party/WebKit/LayoutTests/platform/win/fast/borders/border-image-outset-expected.png
[modify] https://crrev.com/b9e02f8f670683edaac8b9e6c7a6ce23a5a71194/third_party/WebKit/LayoutTests/platform/win/fast/borders/border-image-outset-in-shorthand-expected.png
[modify] https://crrev.com/b9e02f8f670683edaac8b9e6c7a6ce23a5a71194/third_party/WebKit/LayoutTests/platform/win/fast/borders/border-image-outset-split-inline-expected.png
[modify] https://crrev.com/b9e02f8f670683edaac8b9e6c7a6ce23a5a71194/third_party/WebKit/LayoutTests/platform/win/fast/borders/border-image-repeat-expected.png
[modify] https://crrev.com/b9e02f8f670683edaac8b9e6c7a6ce23a5a71194/third_party/WebKit/LayoutTests/platform/win/fast/borders/border-image-repeat-round-expected.png
[modify] https://crrev.com/b9e02f8f670683edaac8b9e6c7a6ce23a5a71194/third_party/WebKit/LayoutTests/platform/win/fast/borders/border-image-scale-transform-expected.png
[modify] https://crrev.com/b9e02f8f670683edaac8b9e6c7a6ce23a5a71194/third_party/WebKit/LayoutTests/platform/win/fast/borders/border-image-scaled-expected.png
[modify] https://crrev.com/b9e02f8f670683edaac8b9e6c7a6ce23a5a71194/third_party/WebKit/LayoutTests/platform/win/fast/borders/border-image-scrambled-expected.png
[modify] https://crrev.com/b9e02f8f670683edaac8b9e6c7a6ce23a5a71194/third_party/WebKit/LayoutTests/platform/win/fast/borders/border-image-slices-expected.png
[modify] https://crrev.com/b9e02f8f670683edaac8b9e6c7a6ce23a5a71194/third_party/WebKit/LayoutTests/platform/win/fast/borders/border-image-source-expected.png
[modify] https://crrev.com/b9e02f8f670683edaac8b9e6c7a6ce23a5a71194/third_party/WebKit/LayoutTests/platform/win/fast/borders/scaled-border-image-expected.png
[modify] https://crrev.com/b9e02f8f670683edaac8b9e6c7a6ce23a5a71194/third_party/WebKit/LayoutTests/platform/win/fast/writing-mode/border-image-vertical-lr-expected.png
[modify] https://crrev.com/b9e02f8f670683edaac8b9e6c7a6ce23a5a71194/third_party/WebKit/LayoutTests/platform/win/fast/writing-mode/border-image-vertical-rl-expected.png
[modify] https://crrev.com/b9e02f8f670683edaac8b9e6c7a6ce23a5a71194/third_party/WebKit/LayoutTests/platform/win/ietestcenter/css3/bordersbackgrounds/background-size-aspect-ratio-expected.png
[modify] https://crrev.com/b9e02f8f670683edaac8b9e6c7a6ce23a5a71194/third_party/WebKit/LayoutTests/platform/win/images/color-profile-border-image-source-expected.png
[modify] https://crrev.com/b9e02f8f670683edaac8b9e6c7a6ce23a5a71194/third_party/WebKit/LayoutTests/platform/win/images/color-profile-group-expected.png
[modify] https://crrev.com/b9e02f8f670683edaac8b9e6c7a6ce23a5a71194/third_party/WebKit/LayoutTests/platform/win/paint/spellmarkers/document-markers-expected.png
[modify] https://crrev.com/b9e02f8f670683edaac8b9e6c7a6ce23a5a71194/third_party/WebKit/LayoutTests/platform/win/paint/spellmarkers/document-markers-zoom-125-expected.png
[modify] https://crrev.com/b9e02f8f670683edaac8b9e6c7a6ce23a5a71194/third_party/WebKit/LayoutTests/platform/win/paint/spellmarkers/document-markers-zoom-150-expected.png
[modify] https://crrev.com/b9e02f8f670683edaac8b9e6c7a6ce23a5a71194/third_party/WebKit/LayoutTests/platform/win/paint/spellmarkers/document-markers-zoom-175-expected.png
[modify] https://crrev.com/b9e02f8f670683edaac8b9e6c7a6ce23a5a71194/third_party/WebKit/LayoutTests/platform/win/paint/spellmarkers/document-markers-zoom-200-expected.png
[modify] https://crrev.com/b9e02f8f670683edaac8b9e6c7a6ce23a5a71194/third_party/WebKit/LayoutTests/platform/win/paint/spellmarkers/document-markers-zoom-250-expected.png
[modify] https://crrev.com/b9e02f8f670683edaac8b9e6c7a6ce23a5a71194/third_party/WebKit/LayoutTests/platform/win/svg/as-border-image/svg-as-border-image-expected.png
[modify] https://crrev.com/b9e02f8f670683edaac8b9e6c7a6ce23a5a71194/third_party/WebKit/LayoutTests/platform/win/virtual/exotic-color-space/images/color-profile-border-image-expected.png
[modify] https://crrev.com/b9e02f8f670683edaac8b9e6c7a6ce23a5a71194/third_party/WebKit/LayoutTests/platform/win/virtual/exotic-color-space/images/color-profile-border-image-source-expected.png
[modify] https://crrev.com/b9e02f8f670683edaac8b9e6c7a6ce23a5a71194/third_party/WebKit/LayoutTests/platform/win/virtual/exotic-color-space/images/color-profile-group-expected.png
[delete] https://crrev.com/301887042430c3a02596ab96fa5cb092b3b637df/third_party/WebKit/LayoutTests/virtual/exotic-color-space/images/color-profile-border-image-expected.png

Labels: ReleaseBlock-Stable
Labels: -Needs-Bisect
Mergedinto: 744674
Status: Duplicate (was: Assigned)
Should be fixed now, merging to M61 in  issue 744674 .
Project Member

Comment 15 by bugdroid1@chromium.org, Aug 21 2017

Labels: merge-merged-3163
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9484e8f2c369cdfdd77e83dea7e0495196e45f56

commit 9484e8f2c369cdfdd77e83dea7e0495196e45f56
Author: Florin Malita <fmalita@chromium.org>
Date: Mon Aug 21 15:15:56 2017

Disable Skia raster pipeline for image tiling

Adding SK_SUPPORT_LEGACY_TILED_BITMAPS.

This is a revert of https://chromium-review.googlesource.com/545816.

BUG= 753905 , 744674 
TBR=fmalita@chromium.org

(cherry picked from commit b9e02f8f670683edaac8b9e6c7a6ce23a5a71194)

Change-Id: I078f076e75fb868a50927efb8fc4e2de65339533
Reviewed-on: https://chromium-review.googlesource.com/620528
Commit-Queue: Florin Malita <fmalita@chromium.org>
Reviewed-by: Mike Klein <mtklein@google.com>
Reviewed-by: Mike Klein <mtklein@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#495583}
Reviewed-on: https://chromium-review.googlesource.com/623988
Reviewed-by: Florin Malita <fmalita@chromium.org>
Cr-Commit-Position: refs/branch-heads/3163@{#697}
Cr-Branched-From: ff259bab28b35d242e10186cd63af7ed404fae0d-refs/heads/master@{#488528}
[modify] https://crrev.com/9484e8f2c369cdfdd77e83dea7e0495196e45f56/skia/config/SkUserConfig.h

Sign in to add a comment