Issue metadata
Sign in to add a comment
|
DCHECK failure in var->mode() == VAR in scopes.cc |
||||||||||||||||||||
Issue descriptionDetailed report: https://clusterfuzz.com/testcase?key=5521703332741120 Fuzzer: inferno_js_fuzzer_c Job Type: linux_asan_d8_dbg Platform Id: linux Crash Type: DCHECK failure Crash Address: Crash State: var->mode() == VAR in scopes.cc v8::internal::Scope::DeclareVariableName v8::internal::Scope::DeclareVariableName Sanitizer: address (ASAN) Regressed: V8: 47247:47248 Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=5521703332741120 Issue filed automatically. See https://github.com/google/clusterfuzz-tools for more information.
,
Aug 10 2017
ClusterFuzz has detected this issue as fixed in range 47248:47249. Detailed report: https://clusterfuzz.com/testcase?key=5521703332741120 Fuzzer: inferno_js_fuzzer_c Job Type: linux_asan_d8_dbg Platform Id: linux Crash Type: DCHECK failure Crash Address: Crash State: var->mode() == VAR in scopes.cc v8::internal::Scope::DeclareVariableName v8::internal::Scope::DeclareVariableName Sanitizer: address (ASAN) Regressed: V8: 47247:47248 Fixed: V8: 47248:47249 Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=5521703332741120 See https://github.com/google/clusterfuzz-tools for more information. If you suspect that the result above is incorrect, try re-doing that job on the test case report page.
,
Aug 10 2017
ClusterFuzz testcase 5521703332741120 is verified as fixed, so closing issue as verified. If this is incorrect, please add ClusterFuzz-Wrong label and re-open the issue.
,
Aug 10 2017
The regressing commit is the one flipping FLAG_experimental_preparser_scope_analysis on, and the "fixing" commit is flipping it off. So this needs to be fixed anyway.
Reduced test case:
function __f_1() {
let myvar = 'level1';
if (true) {
var myvar = 'level2';
}
}
,
Aug 10 2017
,
Aug 12 2017
The following revision refers to this bug: https://chromium.googlesource.com/v8/v8.git/+/70f691315929cf408fafee7811bef635045523a8 commit 70f691315929cf408fafee7811bef635045523a8 Author: Marja Hölttä <marja@chromium.org> Date: Sat Aug 12 16:43:40 2017 [parser] Skipping inner funcs: remove untrue DCHECK. - See bug for the reduced test case. - Not adding a regression test here: I don't want to assert that PreParser doesn't detect the redeclaration error, OTOH I don't want to make it detect the error either (in order to not couple detecting the error with FLAG_experimental_preparser_analysis). BUG= chromium:753896 , v8:5516 Change-Id: I0f1beffe30e5cb48d6dbec35181980864e6df153 Reviewed-on: https://chromium-review.googlesource.com/608976 Reviewed-by: Adam Klein <adamk@chromium.org> Commit-Queue: Marja Hölttä <marja@chromium.org> Cr-Commit-Position: refs/heads/master@{#47326} [modify] https://crrev.com/70f691315929cf408fafee7811bef635045523a8/src/ast/scopes.cc [modify] https://crrev.com/70f691315929cf408fafee7811bef635045523a8/test/cctest/parsing/test-preparser.cc
,
Nov 16 2017
This bug has been closed for more than 14 weeks. Removing security view restrictions. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Jul 28
|
|||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||
Comment 1 by elawrence@chromium.org
, Aug 9 2017Status: Assigned (was: Untriaged)