New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 753889 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Aug 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 1
Type: Bug

Blocking:
issue 753740



Sign in to add a comment

Toolbar issue when navigating from downloads home activity to Chrome home

Project Member Reported by jming@chromium.org, Aug 9 2017

Issue description

Launching the downloads home activity and then navigating to Chrome home is showing the issue with NTP bottomsheet. 

This was exposed by new behavior introduced in crbug.com/753740.
 
Cc: twelling...@chromium.org k...@chromium.org
Components: UI>Browser>Mobile>NavPanel
Labels: -Pri-3 Hotlist-Chrome-Home OS-Android Pri-1
Owner: ----
Status: Available (was: Assigned)
Marking this as available for anyone with Chrome Home cycles. I can always pick it up in a couple of weeks if nobody gets to it.

ktam@, I have this as a P1 to fix for M62 but feel free to de-prioritize if you disagree.

Repro steps:
1) Download a file Chrome can't open e.g. a PDF
2) Go to tab switcher
3) Tap on download notification, Chrome Home will open with downloads selected
4) Switch back to home tab

Video attached.
ch_download_notification_bug.mp4
7.0 MB View Download

Comment 2 by kings...@google.com, Aug 10 2017

Labels: Fine-Pri-1.5

Comment 3 by jming@chromium.org, Aug 10 2017

Issue 753740 has been merged into this issue.
Owner: huayinz@chromium.org
Status: Assigned (was: Available)
Project Member

Comment 5 by bugdroid1@chromium.org, Aug 24 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1dab5057fcc3690962eedd4cb32ee36f7011d3aa

commit 1dab5057fcc3690962eedd4cb32ee36f7011d3aa
Author: Becky Zhou <huayinz@chromium.org>
Date: Thu Aug 24 22:04:22 2017

[Chrome Home] Fix toolbar issue when navigating download to home

When download page should be opened from notification or snackbar,
A new tab will be created if currently in tab switcher,
otherwise download page will be opened in the current tab.


Bug:  753889 
Change-Id: I271c31ecc5e46efd308c9c1bde84fa3e260d5ded
Reviewed-on: https://chromium-review.googlesource.com/627267
Reviewed-by: Theresa <twellington@chromium.org>
Commit-Queue: Becky Zhou <huayinz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#497206}
[modify] https://crrev.com/1dab5057fcc3690962eedd4cb32ee36f7011d3aa/chrome/android/java/src/org/chromium/chrome/browser/widget/bottomsheet/BottomSheet.java
[modify] https://crrev.com/1dab5057fcc3690962eedd4cb32ee36f7011d3aa/chrome/android/java/src/org/chromium/chrome/browser/widget/bottomsheet/BottomSheetContentController.java
[modify] https://crrev.com/1dab5057fcc3690962eedd4cb32ee36f7011d3aa/chrome/android/java/src/org/chromium/chrome/browser/widget/bottomsheet/BottomSheetNewTabController.java

Status: Fixed (was: Assigned)

Sign in to add a comment