New issue
Advanced search Search tips

Issue 753886 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Aug 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Update third_party/yasm to 1.3.0

Project Member Reported by davidben@chromium.org, Aug 9 2017

Issue description

1.3.0 was released three years ago and supports Intel SHA and ADX instructions. That will let us re-land https://boringssl.googlesource.com/boringssl/+/83d1a3d3c81c119f0fa7504525a6822b82790da0 without Windows hacks.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Aug 9 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6e06e7d62a1fd3c614f8f47bc78177305145c644

commit 6e06e7d62a1fd3c614f8f47bc78177305145c644
Author: David Benjamin <davidben@chromium.org>
Date: Wed Aug 09 22:29:16 2017

Remove third_party/yasm/binaries.

These do not appear to be used and were not updated when we switched to yasm
1.2.0.

Bug:  753886 
Change-Id: I95d065810e75fc0fa5d31cce50d4173d764225a0
Reviewed-on: https://chromium-review.googlesource.com/609021
Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
Commit-Queue: David Benjamin <davidben@chromium.org>
Cr-Commit-Position: refs/heads/master@{#493162}
[modify] https://crrev.com/6e06e7d62a1fd3c614f8f47bc78177305145c644/DEPS

Project Member

Comment 2 by bugdroid1@chromium.org, Aug 10 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/deps/yasm/patched-yasm/+/6cec381ab72af2e1302290d6ec19385b66b10871

commit 6cec381ab72af2e1302290d6ec19385b66b10871
Author: David Benjamin <davidben@google.com>
Date: Wed Aug 09 23:18:16 2017

Sync with upstream yasm 1.2.0 source tarball.

This is in preparation for updating to yasm 1.3.0. The update to 1.2.0
did not fully sync with the source tarball, which means yasm 1.3.0 must
either be updated piecemeal or be an unreviewable mess. The goal here is
to separate the irrelevant unreviewable mess from the relevant and
hopefully less unreviewable mess.

This CL was created by replacing this directory with the 1.2.0 tarball,
looking through the diff, and recovering our patches.

To review, look at the file list and verify that nothing is touched that
would affected Chromium. By my count, there is:

Mkfiles/* - random build files for other buildsystems
*/tests/* - test files
modules/preprocs/gas/ - a module that we forgot to enable but presumably
    don't use.
* - miscellaenous goop

Bug:  753886 
Change-Id: Id2204b0f358bd3ae2bf44afc75254fc4b2088f4e

[add] https://crrev.com/6cec381ab72af2e1302290d6ec19385b66b10871/modules/arch/x86/tests/shift64.hex
[add] https://crrev.com/6cec381ab72af2e1302290d6ec19385b66b10871/modules/parsers/nasm/tests/dirwarning.asm
[add] https://crrev.com/6cec381ab72af2e1302290d6ec19385b66b10871/modules/arch/x86/tests/gas32/gas-farjump.hex
[add] https://crrev.com/6cec381ab72af2e1302290d6ec19385b66b10871/modules/parsers/gas/tests/bin/reptnested.hex
[add] https://crrev.com/6cec381ab72af2e1302290d6ec19385b66b10871/modules/arch/x86/tests/xop-basic.hex
[modify] https://crrev.com/6cec381ab72af2e1302290d6ec19385b66b10871/tools/re2c/mbo_getopt.h
[add] https://crrev.com/6cec381ab72af2e1302290d6ec19385b66b10871/modules/objfmts/macho/tests/nasm32/macho32-pic.asm
[delete] https://crrev.com/7da28c6c7c6a1387217352ce02b31754deb54d2a/modules/arch/x86/tests/sse5-cc.hex
[add] https://crrev.com/6cec381ab72af2e1302290d6ec19385b66b10871/libyasm/tests/value-shr-symexpr.hex
[add] https://crrev.com/6cec381ab72af2e1302290d6ec19385b66b10871/modules/preprocs/gas/gas-eval.h
[add] https://crrev.com/6cec381ab72af2e1302290d6ec19385b66b10871/modules/arch/x86/tests/rdrnd.hex
[add] https://crrev.com/6cec381ab72af2e1302290d6ec19385b66b10871/modules/arch/x86/tests/bmi2.asm
[add] https://crrev.com/6cec381ab72af2e1302290d6ec19385b66b10871/Mkfiles/vc10/ytasm.vcxproj
[add] https://crrev.com/6cec381ab72af2e1302290d6ec19385b66b10871/frontends/vsyasm/Makefile.inc
[add] https://crrev.com/6cec381ab72af2e1302290d6ec19385b66b10871/modules/dbgfmts/dwarf2/tests/gen64/dwarf2_gen64_test.sh
[add] https://crrev.com/6cec381ab72af2e1302290d6ec19385b66b10871/modules/arch/x86/tests/avx16.asm
[add] https://crrev.com/6cec381ab72af2e1302290d6ec19385b66b10871/Mkfiles/vc10/config.h
[add] https://crrev.com/6cec381ab72af2e1302290d6ec19385b66b10871/modules/parsers/nasm/tests/strucbase.hex
[add] https://crrev.com/6cec381ab72af2e1302290d6ec19385b66b10871/modules/preprocs/tasm/tests/tasm-assume-comment.hex
[add] https://crrev.com/6cec381ab72af2e1302290d6ec19385b66b10871/modules/objfmts/win32/tests/gas/win32def.hex
[add] https://crrev.com/6cec381ab72af2e1302290d6ec19385b66b10871/modules/preprocs/gas/gas-eval.c
[add] https://crrev.com/6cec381ab72af2e1302290d6ec19385b66b10871/modules/preprocs/tasm/tests/tasm-comment-instr.hex
[add] https://crrev.com/6cec381ab72af2e1302290d6ec19385b66b10871/modules/preprocs/tasm/Makefile.inc
[add] https://crrev.com/6cec381ab72af2e1302290d6ec19385b66b10871/modules/arch/x86/tests/pinsrb.hex
[add] https://crrev.com/6cec381ab72af2e1302290d6ec19385b66b10871/modules/arch/x86/tests/larlsl.asm
[add] https://crrev.com/6cec381ab72af2e1302290d6ec19385b66b10871/Mkfiles/vc10/genmodule/genmodule.vcxproj.filters
[add] https://crrev.com/6cec381ab72af2e1302290d6ec19385b66b10871/modules/arch/x86/tests/vsib-err.asm
[delete] https://crrev.com/7da28c6c7c6a1387217352ce02b31754deb54d2a/config/ltmain.sh
[add] https://crrev.com/6cec381ab72af2e1302290d6ec19385b66b10871/modules/arch/x86/tests/f16c.asm
[add] https://crrev.com/6cec381ab72af2e1302290d6ec19385b66b10871/modules/arch/x86/tests/bmi1.asm
[add] https://crrev.com/6cec381ab72af2e1302290d6ec19385b66b10871/modules/arch/x86/tests/gas32/gas-pop.asm
[add] https://crrev.com/6cec381ab72af2e1302290d6ec19385b66b10871/modules/arch/x86/tests/amd-fma4.asm
[add] https://crrev.com/6cec381ab72af2e1302290d6ec19385b66b10871/Mkfiles/vc10/out_copy_rename.bat
[add] https://crrev.com/6cec381ab72af2e1302290d6ec19385b66b10871/modules/parsers/gas/tests/bin/gas-intel_syntax-noprefix.asm
[add] https://crrev.com/6cec381ab72af2e1302290d6ec19385b66b10871/modules/arch/x86/tests/gas32/gas-loop32.asm
[add] https://crrev.com/6cec381ab72af2e1302290d6ec19385b66b10871/Mkfiles/vc10/genmacro/genmacro.vcxproj.filters
[delete] https://crrev.com/7da28c6c7c6a1387217352ce02b31754deb54d2a/modules/arch/x86/tests/sse5-basic.asm
[add] https://crrev.com/6cec381ab72af2e1302290d6ec19385b66b10871/modules/arch/x86/tests/eptvpid.hex
[add] https://crrev.com/6cec381ab72af2e1302290d6ec19385b66b10871/modules/objfmts/win64/tests/win64-imagebase.hex
[add] https://crrev.com/6cec381ab72af2e1302290d6ec19385b66b10871/Mkfiles/vc10/genmodule/run.bat
[add] https://crrev.com/6cec381ab72af2e1302290d6ec19385b66b10871/modules/arch/x86/tests/gas64/gas-loop64.hex
[add] https://crrev.com/6cec381ab72af2e1302290d6ec19385b66b10871/modules/objfmts/elf/tests/gas32/elf_gas32_got.asm
[add] https://crrev.com/6cec381ab72af2e1302290d6ec19385b66b10871/modules/objfmts/macho/tests/nasm32/macho32-pic.hex
[add] https://crrev.com/6cec381ab72af2e1302290d6ec19385b66b10871/modules/preprocs/tasm/tests/tasm-comment-instr.asm
[add] https://crrev.com/6cec381ab72af2e1302290d6ec19385b66b10871/modules/arch/x86/tests/fsgsbase.hex
[add] https://crrev.com/6cec381ab72af2e1302290d6ec19385b66b10871/libyasm/tests/timesfwd.hex
[add] https://crrev.com/6cec381ab72af2e1302290d6ec19385b66b10871/Mkfiles/vc9/YASM-VERSION.h
[add] https://crrev.com/6cec381ab72af2e1302290d6ec19385b66b10871/modules/arch/x86/tests/amd-fma4.hex
[add] https://crrev.com/6cec381ab72af2e1302290d6ec19385b66b10871/Mkfiles/vc10/libyasm/libyasm.vcxproj.filters
[delete] https://crrev.com/7da28c6c7c6a1387217352ce02b31754deb54d2a/m4/pyrex.m4
[delete] https://crrev.com/7da28c6c7c6a1387217352ce02b31754deb54d2a/modules/arch/x86/tests/sse5-err.errwarn
[add] https://crrev.com/6cec381ab72af2e1302290d6ec19385b66b10871/modules/preprocs/tasm/tests/tasm-assume-comment.asm
[add] https://crrev.com/6cec381ab72af2e1302290d6ec19385b66b10871/m4/cython.m4
[delete] https://crrev.com/7da28c6c7c6a1387217352ce02b31754deb54d2a/modules/arch/x86/tests/sse5-all.asm
[add] https://crrev.com/6cec381ab72af2e1302290d6ec19385b66b10871/Mkfiles/vc10/re2c/re2c.vcxproj.filters
[add] https://crrev.com/6cec381ab72af2e1302290d6ec19385b66b10871/Mkfiles/vc10/genmacro/genmacro.vcxproj
[add] https://crrev.com/6cec381ab72af2e1302290d6ec19385b66b10871/Mkfiles/vc10/crt_secure_no_deprecate.props
[add] https://crrev.com/6cec381ab72af2e1302290d6ec19385b66b10871/Mkfiles/vc10/re2c/run.bat
[add] https://crrev.com/6cec381ab72af2e1302290d6ec19385b66b10871/modules/arch/x86/tests/lzcnt.hex
[delete] https://crrev.com/7da28c6c7c6a1387217352ce02b31754deb54d2a/modules/arch/x86/tests/sse5-all.hex
[add] https://crrev.com/6cec381ab72af2e1302290d6ec19385b66b10871/Mkfiles/vc10/vsyasm.props
[add] https://crrev.com/6cec381ab72af2e1302290d6ec19385b66b10871/modules/arch/x86/tests/bmi1.hex
[add] https://crrev.com/6cec381ab72af2e1302290d6ec19385b66b10871/version
[add] https://crrev.com/6cec381ab72af2e1302290d6ec19385b66b10871/modules/objfmts/elf/tests/amd64/multiplefixup.asm
[add] https://crrev.com/6cec381ab72af2e1302290d6ec19385b66b10871/modules/arch/x86/tests/gas32/gas-pop.hex
[add] https://crrev.com/6cec381ab72af2e1302290d6ec19385b66b10871/modules/objfmts/elf/tests/gas32/elf_gas32_got.hex
[modify] https://crrev.com/6cec381ab72af2e1302290d6ec19385b66b10871/tools/re2c/mbo_getopt.c
[add] https://crrev.com/6cec381ab72af2e1302290d6ec19385b66b10871/modules/objfmts/win32/tests/gas/win32secrel32.asm
[add] https://crrev.com/6cec381ab72af2e1302290d6ec19385b66b10871/Mkfiles/vc10/re2c/re2c.vcxproj
[add] https://crrev.com/6cec381ab72af2e1302290d6ec19385b66b10871/modules/arch/x86/tests/xop-all.hex
[add] https://crrev.com/6cec381ab72af2e1302290d6ec19385b66b10871/libyasm/tests/expr-simplify-identity.asm
[add] https://crrev.com/6cec381ab72af2e1302290d6ec19385b66b10871/Mkfiles/vc10/vsyasm.targets
[add] https://crrev.com/6cec381ab72af2e1302290d6ec19385b66b10871/Mkfiles/dj/YASM-VERSION.h
[delete] https://crrev.com/7da28c6c7c6a1387217352ce02b31754deb54d2a/modules/arch/x86/tests/sse5-basic.hex
[add] https://crrev.com/6cec381ab72af2e1302290d6ec19385b66b10871/modules/preprocs/nasm/tests/scope-err.asm
[add] https://crrev.com/6cec381ab72af2e1302290d6ec19385b66b10871/modules/arch/x86/tests/vsib-err.errwarn
[add] https://crrev.com/6cec381ab72af2e1302290d6ec19385b66b10871/modules/arch/x86/tests/avx2.hex
[add] https://crrev.com/6cec381ab72af2e1302290d6ec19385b66b10871/modules/parsers/gas/tests/bin/gas-str.hex
[add] https://crrev.com/6cec381ab72af2e1302290d6ec19385b66b10871/modules/arch/x86/tests/avx16.hex
[rename] https://crrev.com/6cec381ab72af2e1302290d6ec19385b66b10871/modules/parsers/gas/tests/bin/reptnested.asm
[add] https://crrev.com/6cec381ab72af2e1302290d6ec19385b66b10871/modules/objfmts/elf/tests/amd64/multiplefixup.hex
[add] https://crrev.com/6cec381ab72af2e1302290d6ec19385b66b10871/modules/arch/x86/tests/xop-basic.asm
[add] https://crrev.com/6cec381ab72af2e1302290d6ec19385b66b10871/modules/arch/x86/tests/bmi2.hex
[add] https://crrev.com/6cec381ab72af2e1302290d6ec19385b66b10871/modules/arch/x86/tests/xop-all.asm
[add] https://crrev.com/6cec381ab72af2e1302290d6ec19385b66b10871/Mkfiles/vc10/genperf/genperf.vcxproj
[add] https://crrev.com/6cec381ab72af2e1302290d6ec19385b66b10871/Mkfiles/vc10/crt_secure_no_deprecate.vsprops
[add] https://crrev.com/6cec381ab72af2e1302290d6ec19385b66b10871/modules/arch/x86/tests/xop-cc.hex
[add] https://crrev.com/6cec381ab72af2e1302290d6ec19385b66b10871/modules/arch/x86/tests/gas32/gas-farjump.asm
[add] https://crrev.com/6cec381ab72af2e1302290d6ec19385b66b10871/libyasm/tests/timesfwd.asm
[add] https://crrev.com/6cec381ab72af2e1302290d6ec19385b66b10871/Mkfiles/vc10/yasm.vcxproj.filters
[add] https://crrev.com/6cec381ab72af2e1302290d6ec19385b66b10871/modules/parsers/nasm/tests/dirwarning.errwarn
[add] https://crrev.com/6cec381ab72af2e1302290d6ec19385b66b10871/Mkfiles/vc10/vsyasm.vcxproj
[add] https://crrev.com/6cec381ab72af2e1302290d6ec19385b66b10871/modules/arch/x86/tests/vsib.asm
[add] https://crrev.com/6cec381ab72af2e1302290d6ec19385b66b10871/modules/arch/x86/tests/xop-cc.asm
[add] https://crrev.com/6cec381ab72af2e1302290d6ec19385b66b10871/Mkfiles/vc10/YASM-VERSION.h
[add] https://crrev.com/6cec381ab72af2e1302290d6ec19385b66b10871/modules/arch/x86/tests/gas32/gas-invlpg.hex
[add] https://crrev.com/6cec381ab72af2e1302290d6ec19385b66b10871/modules/parsers/gas/tests/bin/gas-macro.hex
[add] https://crrev.com/6cec381ab72af2e1302290d6ec19385b66b10871/modules/objfmts/macho/tests/nasm32/macho32-size.hex
[add] https://crrev.com/6cec381ab72af2e1302290d6ec19385b66b10871/Mkfiles/vc10/modules/modules.vcxproj
[add] https://crrev.com/6cec381ab72af2e1302290d6ec19385b66b10871/modules/arch/x86/tests/gas32/gas-loop32.hex
[add] https://crrev.com/6cec381ab72af2e1302290d6ec19385b66b10871/Mkfiles/vc10/genperf/genperf.vcxproj.filters
[add] https://crrev.com/6cec381ab72af2e1302290d6ec19385b66b10871/Mkfiles/vc10/readme.vc10.txt
[add] https://crrev.com/6cec381ab72af2e1302290d6ec19385b66b10871/modules/arch/x86/tests/larlsl.hex
[add] https://crrev.com/6cec381ab72af2e1302290d6ec19385b66b10871/Mkfiles/vc10/modules/modules.vcxproj.filters
[add] https://crrev.com/6cec381ab72af2e1302290d6ec19385b66b10871/Mkfiles/vc10/genversion/genversion.vcxproj
[add] https://crrev.com/6cec381ab72af2e1302290d6ec19385b66b10871/modules/parsers/nasm/tests/strucbase.asm
[add] https://crrev.com/6cec381ab72af2e1302290d6ec19385b66b10871/modules/objfmts/win32/tests/gas/win32def.asm
[add] https://crrev.com/6cec381ab72af2e1302290d6ec19385b66b10871/modules/arch/x86/tests/f16c.hex
[add] https://crrev.com/6cec381ab72af2e1302290d6ec19385b66b10871/Mkfiles/vc9/vsyasm.vcproj
[add] https://crrev.com/6cec381ab72af2e1302290d6ec19385b66b10871/modules/preprocs/gas/Makefile.inc
[add] https://crrev.com/6cec381ab72af2e1302290d6ec19385b66b10871/modules/arch/x86/tests/pinsrb.asm
[add] https://crrev.com/6cec381ab72af2e1302290d6ec19385b66b10871/modules/preprocs/gas/gas-preproc.c
[add] https://crrev.com/6cec381ab72af2e1302290d6ec19385b66b10871/Mkfiles/vc10/libyasm-stdint.h
[add] https://crrev.com/6cec381ab72af2e1302290d6ec19385b66b10871/Mkfiles/vc10/genperf/run.bat
[add] https://crrev.com/6cec381ab72af2e1302290d6ec19385b66b10871/modules/arch/x86/tests/fsgsbase.asm
[add] https://crrev.com/6cec381ab72af2e1302290d6ec19385b66b10871/modules/arch/x86/tests/smx.hex
[add] https://crrev.com/6cec381ab72af2e1302290d6ec19385b66b10871/modules/dbgfmts/dwarf2/tests/gen64/dwarf64_pathname.asm
[add] https://crrev.com/6cec381ab72af2e1302290d6ec19385b66b10871/modules/arch/x86/tests/vsib.hex
[add] https://crrev.com/6cec381ab72af2e1302290d6ec19385b66b10871/Mkfiles/vc10/vsyasm.xml
[add] https://crrev.com/6cec381ab72af2e1302290d6ec19385b66b10871/libyasm/tests/expr-simplify-identity.hex
[add] https://crrev.com/6cec381ab72af2e1302290d6ec19385b66b10871/modules/arch/x86/tests/lfs64.asm
[add] https://crrev.com/6cec381ab72af2e1302290d6ec19385b66b10871/modules/arch/x86/tests/smx.asm
[add] https://crrev.com/6cec381ab72af2e1302290d6ec19385b66b10871/modules/arch/x86/tests/gas32/gas-invlpg.asm
[add] https://crrev.com/6cec381ab72af2e1302290d6ec19385b66b10871/Mkfiles/vc10/yasm.vcxproj
[add] https://crrev.com/6cec381ab72af2e1302290d6ec19385b66b10871/modules/dbgfmts/dwarf2/tests/gen64/Makefile.inc
[modify] https://crrev.com/6cec381ab72af2e1302290d6ec19385b66b10871/modules/objfmts/elf/tests/elfmanysym.asm
[add] https://crrev.com/6cec381ab72af2e1302290d6ec19385b66b10871/Mkfiles/vc10/genstring/genstring.vcxproj.filters
[add] https://crrev.com/6cec381ab72af2e1302290d6ec19385b66b10871/modules/objfmts/macho/tests/nasm32/macho32-pext.hex
[add] https://crrev.com/6cec381ab72af2e1302290d6ec19385b66b10871/modules/objfmts/win32/tests/gas/win32secrel32.hex
[add] https://crrev.com/6cec381ab72af2e1302290d6ec19385b66b10871/modules/objfmts/macho/tests/nasm32/macho32-pext.asm
[add] https://crrev.com/6cec381ab72af2e1302290d6ec19385b66b10871/Mkfiles/vc10/genversion/run.bat
[add] https://crrev.com/6cec381ab72af2e1302290d6ec19385b66b10871/modules/preprocs/gas/tests/Makefile.inc
[add] https://crrev.com/6cec381ab72af2e1302290d6ec19385b66b10871/modules/parsers/nasm/tests/dirwarning.hex
[add] https://crrev.com/6cec381ab72af2e1302290d6ec19385b66b10871/modules/arch/x86/tests/avx2.asm
[add] https://crrev.com/6cec381ab72af2e1302290d6ec19385b66b10871/modules/parsers/gas/tests/bin/gas-str.asm
[add] https://crrev.com/6cec381ab72af2e1302290d6ec19385b66b10871/modules/arch/x86/tests/shift64.asm
[add] https://crrev.com/6cec381ab72af2e1302290d6ec19385b66b10871/Mkfiles/vc10/libyasm/libyasm.vcxproj
[add] https://crrev.com/6cec381ab72af2e1302290d6ec19385b66b10871/modules/dbgfmts/dwarf2/tests/gen64/dwarf64_pathname.hex
[add] https://crrev.com/6cec381ab72af2e1302290d6ec19385b66b10871/modules/arch/x86/tests/invpcid.asm
[add] https://crrev.com/6cec381ab72af2e1302290d6ec19385b66b10871/YASM-VERSION-GEN.sh
[add] https://crrev.com/6cec381ab72af2e1302290d6ec19385b66b10871/Mkfiles/vc10/genstring/run.bat
[add] https://crrev.com/6cec381ab72af2e1302290d6ec19385b66b10871/modules/arch/x86/tests/rdrnd.asm
[delete] https://crrev.com/7da28c6c7c6a1387217352ce02b31754deb54d2a/modules/parsers/gas/tests/bin/reptnested-err.errwarn
[add] https://crrev.com/6cec381ab72af2e1302290d6ec19385b66b10871/modules/arch/x86/tests/vsib2-err.asm
[add] https://crrev.com/6cec381ab72af2e1302290d6ec19385b66b10871/libyasm/tests/value-shr-symexpr.asm
[add] https://crrev.com/6cec381ab72af2e1302290d6ec19385b66b10871/frontends/vsyasm/vsyasm.c
[add] https://crrev.com/6cec381ab72af2e1302290d6ec19385b66b10871/Mkfiles/vc10/genversion/genversion.vcxproj.filters
[delete] https://crrev.com/7da28c6c7c6a1387217352ce02b31754deb54d2a/modules/arch/x86/tests/sse5-err.asm
[add] https://crrev.com/6cec381ab72af2e1302290d6ec19385b66b10871/modules/arch/x86/tests/eptvpid.asm
[add] https://crrev.com/6cec381ab72af2e1302290d6ec19385b66b10871/modules/arch/x86/tests/lfs64.hex
[add] https://crrev.com/6cec381ab72af2e1302290d6ec19385b66b10871/modules/parsers/gas/tests/bin/gas-intel_syntax-noprefix.hex
[add] https://crrev.com/6cec381ab72af2e1302290d6ec19385b66b10871/modules/arch/x86/tests/gas64/gas-loop64.asm
[add] https://crrev.com/6cec381ab72af2e1302290d6ec19385b66b10871/modules/preprocs/tasm/tests/tasmpp_test.sh
[add] https://crrev.com/6cec381ab72af2e1302290d6ec19385b66b10871/Mkfiles/vc10/yasm.sln
[add] https://crrev.com/6cec381ab72af2e1302290d6ec19385b66b10871/Mkfiles/vc10/genmodule/genmodule.vcxproj
[add] https://crrev.com/6cec381ab72af2e1302290d6ec19385b66b10871/modules/objfmts/macho/tests/nasm32/macho32-size.asm
[add] https://crrev.com/6cec381ab72af2e1302290d6ec19385b66b10871/modules/preprocs/nasm/tests/scope-err.errwarn
[delete] https://crrev.com/7da28c6c7c6a1387217352ce02b31754deb54d2a/modules/arch/x86/tests/sse5-cc.asm
[add] https://crrev.com/6cec381ab72af2e1302290d6ec19385b66b10871/modules/arch/x86/tests/lzcnt.asm
[add] https://crrev.com/6cec381ab72af2e1302290d6ec19385b66b10871/modules/arch/x86/tests/vsib2-err.errwarn
[add] https://crrev.com/6cec381ab72af2e1302290d6ec19385b66b10871/modules/parsers/gas/tests/bin/gas-macro.asm
[add] https://crrev.com/6cec381ab72af2e1302290d6ec19385b66b10871/modules/arch/x86/tests/invpcid.hex
[modify] https://crrev.com/6cec381ab72af2e1302290d6ec19385b66b10871/modules/objfmts/bin/tests/bin-rip.asm
[add] https://crrev.com/6cec381ab72af2e1302290d6ec19385b66b10871/modules/objfmts/win64/tests/win64-imagebase.asm
[add] https://crrev.com/6cec381ab72af2e1302290d6ec19385b66b10871/Mkfiles/vc10/genstring/genstring.vcxproj
[add] https://crrev.com/6cec381ab72af2e1302290d6ec19385b66b10871/modules/preprocs/tasm/tests/Makefile.inc
[add] https://crrev.com/6cec381ab72af2e1302290d6ec19385b66b10871/Mkfiles/vc10/genmacro/run.bat

Project Member

Comment 3 by bugdroid1@chromium.org, Aug 10 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/deps/yasm/patched-yasm/+/013500cc2c8215b17d26de52eadb126345878f31

commit 013500cc2c8215b17d26de52eadb126345878f31
Author: David Benjamin <davidben@google.com>
Date: Wed Aug 09 23:20:14 2017

Update to yasm 1.3.0.

Our previously cherry-picked patches are now in 1.3.0. I've (re-)applied
the following patches.

- The old CHROMIUM.diff to remove __DATE__ dependency.

- genmodule was previously patched to add an output argument.
  This was reapplied and then tweaked so the output argument is
  optional, so upstream's build still works. (That simplifies
  the update process in Chromium.)

- genperf prints something to stderr on some non-fatal errors.
  This has been patched out.

- gen_x86_insn.py was previously patched to add an output
  argument. This was discarded because the Chromium build will
  use upstream's pre-generated files, to simplify the build
  and align with upstream.

The patches themselves are in
https://chromium-review.googlesource.com/c/608869 because
README.chromium and the patches are in a different repository.

Bug:  753886 
Change-Id: I50c6fa5eebf0e24e4e7ea0ee597a43941b275fec

[add] https://crrev.com/013500cc2c8215b17d26de52eadb126345878f31/modules/dbgfmts/codeview/CMakeLists.txt
[add] https://crrev.com/013500cc2c8215b17d26de52eadb126345878f31/plugins/README
[add] https://crrev.com/013500cc2c8215b17d26de52eadb126345878f31/modules/arch/CMakeLists.txt
[modify] https://crrev.com/013500cc2c8215b17d26de52eadb126345878f31/po/Makevars
[modify] https://crrev.com/013500cc2c8215b17d26de52eadb126345878f31/modules/objfmts/rdf/rdf-objfmt.c
[modify] https://crrev.com/013500cc2c8215b17d26de52eadb126345878f31/m4/lib-prefix.m4
[modify] https://crrev.com/013500cc2c8215b17d26de52eadb126345878f31/m4/lib-link.m4
[modify] https://crrev.com/013500cc2c8215b17d26de52eadb126345878f31/modules/dbgfmts/codeview/cv-symline.c
[add] https://crrev.com/013500cc2c8215b17d26de52eadb126345878f31/frontends/yasm/genstring.py
[add] https://crrev.com/013500cc2c8215b17d26de52eadb126345878f31/modules/objfmts/elf/tests/gasx32/elf_gasx32_reloc.hex
[add] https://crrev.com/013500cc2c8215b17d26de52eadb126345878f31/modules/objfmts/elf/tests/gasx32/crosssect.hex
[add] https://crrev.com/013500cc2c8215b17d26de52eadb126345878f31/modules/objfmts/elf/tests/gasx32/elf_gasx32_curpos.hex
[modify] https://crrev.com/013500cc2c8215b17d26de52eadb126345878f31/config.h.in
[modify] https://crrev.com/013500cc2c8215b17d26de52eadb126345878f31/frontends/yasm/yasm.c
[modify] https://crrev.com/013500cc2c8215b17d26de52eadb126345878f31/m4/progtest.m4
[add] https://crrev.com/013500cc2c8215b17d26de52eadb126345878f31/Mkfiles/vc12/readme.vc12.txt
[add] https://crrev.com/013500cc2c8215b17d26de52eadb126345878f31/Mkfiles/vc12/yasm.vcxproj.filters
[add] https://crrev.com/013500cc2c8215b17d26de52eadb126345878f31/frontends/yasm/yasm-plugin.h
[add] https://crrev.com/013500cc2c8215b17d26de52eadb126345878f31/modules/listfmts/CMakeLists.txt
[add] https://crrev.com/013500cc2c8215b17d26de52eadb126345878f31/frontends/yasm/yasm-plugin.c
[add] https://crrev.com/013500cc2c8215b17d26de52eadb126345878f31/modules/dbgfmts/dwarf2/CMakeLists.txt
[modify] https://crrev.com/013500cc2c8215b17d26de52eadb126345878f31/modules/arch/x86/x86arch.c
[add] https://crrev.com/013500cc2c8215b17d26de52eadb126345878f31/modules/dbgfmts/stabs/CMakeLists.txt
[modify] https://crrev.com/013500cc2c8215b17d26de52eadb126345878f31/config/depcomp
[add] https://crrev.com/013500cc2c8215b17d26de52eadb126345878f31/modules/objfmts/elf/tests/x32/elfsox32.hex
[add] https://crrev.com/013500cc2c8215b17d26de52eadb126345878f31/modules/objfmts/elf/elf-x86-x32.c
[modify] https://crrev.com/013500cc2c8215b17d26de52eadb126345878f31/modules/arch/x86/x86arch.h
[modify] https://crrev.com/013500cc2c8215b17d26de52eadb126345878f31/yasm_arch.7
[add] https://crrev.com/013500cc2c8215b17d26de52eadb126345878f31/modules/objfmts/elf/tests/x32/gotpcrel.hex
[add] https://crrev.com/013500cc2c8215b17d26de52eadb126345878f31/Mkfiles/vc12/config.h
[add] https://crrev.com/013500cc2c8215b17d26de52eadb126345878f31/modules/preprocs/CMakeLists.txt
[modify] https://crrev.com/013500cc2c8215b17d26de52eadb126345878f31/modules/arch/x86/x86expr.c
[add] https://crrev.com/013500cc2c8215b17d26de52eadb126345878f31/Mkfiles/vc12/libyasm/libyasm.vcxproj.filters
[add] https://crrev.com/013500cc2c8215b17d26de52eadb126345878f31/modules/objfmts/elf/tests/gasx32/elf_gasx32_ssym.asm
[add] https://crrev.com/013500cc2c8215b17d26de52eadb126345878f31/modules/preprocs/gas/CMakeLists.txt
[modify] https://crrev.com/013500cc2c8215b17d26de52eadb126345878f31/ChangeLog
[add] https://crrev.com/013500cc2c8215b17d26de52eadb126345878f31/modules/objfmts/elf/tests/x32/gotpcrel.asm
[add] https://crrev.com/013500cc2c8215b17d26de52eadb126345878f31/cmake/modules/DummyCFile.c
[add] https://crrev.com/013500cc2c8215b17d26de52eadb126345878f31/modules/objfmts/win64/tests/win64-function.asm
[add] https://crrev.com/013500cc2c8215b17d26de52eadb126345878f31/plugins/dbg/dbg-objfmt.c
[add] https://crrev.com/013500cc2c8215b17d26de52eadb126345878f31/tools/genmacro/CMakeLists.txt
[modify] https://crrev.com/013500cc2c8215b17d26de52eadb126345878f31/config/install-sh
[modify] https://crrev.com/013500cc2c8215b17d26de52eadb126345878f31/modules/arch/x86/tests/xop-all.hex
[add] https://crrev.com/013500cc2c8215b17d26de52eadb126345878f31/Mkfiles/vc12/vsyasm.xml
[modify] https://crrev.com/013500cc2c8215b17d26de52eadb126345878f31/config/config.sub
[add] https://crrev.com/013500cc2c8215b17d26de52eadb126345878f31/modules/objfmts/bin/CMakeLists.txt
[modify] https://crrev.com/013500cc2c8215b17d26de52eadb126345878f31/version
[modify] https://crrev.com/013500cc2c8215b17d26de52eadb126345878f31/modules/objfmts/win64/tests/Makefile.inc
[add] https://crrev.com/013500cc2c8215b17d26de52eadb126345878f31/modules/objfmts/xdf/CMakeLists.txt
[add] https://crrev.com/013500cc2c8215b17d26de52eadb126345878f31/Mkfiles/vc12/vsyasm.vcxproj
[modify] https://crrev.com/013500cc2c8215b17d26de52eadb126345878f31/Mkfiles/vc9/YASM-VERSION.h
[modify] https://crrev.com/013500cc2c8215b17d26de52eadb126345878f31/x86insn_nasm.gperf
[modify] https://crrev.com/013500cc2c8215b17d26de52eadb126345878f31/po/yasm.pot
[add] https://crrev.com/013500cc2c8215b17d26de52eadb126345878f31/cmake/modules/VersionGen.cmake
[add] https://crrev.com/013500cc2c8215b17d26de52eadb126345878f31/modules/arch/x86/CMakeLists.txt
[modify] https://crrev.com/013500cc2c8215b17d26de52eadb126345878f31/libyasm/assocdat.c
[modify] https://crrev.com/013500cc2c8215b17d26de52eadb126345878f31/m4/cython.m4
[add] https://crrev.com/013500cc2c8215b17d26de52eadb126345878f31/tools/CMakeLists.txt
[modify] https://crrev.com/013500cc2c8215b17d26de52eadb126345878f31/modules/objfmts/xdf/xdf-objfmt.c
[add] https://crrev.com/013500cc2c8215b17d26de52eadb126345878f31/modules/parsers/gas/CMakeLists.txt
[add] https://crrev.com/013500cc2c8215b17d26de52eadb126345878f31/modules/dbgfmts/CMakeLists.txt
[modify] https://crrev.com/013500cc2c8215b17d26de52eadb126345878f31/libyasm/section.c
[modify] https://crrev.com/013500cc2c8215b17d26de52eadb126345878f31/m4/nls.m4
[add] https://crrev.com/013500cc2c8215b17d26de52eadb126345878f31/Mkfiles/vc12/libyasm/libyasm.vcxproj
[add] https://crrev.com/013500cc2c8215b17d26de52eadb126345878f31/plugins/x86/README
[add] https://crrev.com/013500cc2c8215b17d26de52eadb126345878f31/plugins/dbg/README
[add] https://crrev.com/013500cc2c8215b17d26de52eadb126345878f31/modules/objfmts/dbg/CMakeLists.txt
[add] https://crrev.com/013500cc2c8215b17d26de52eadb126345878f31/modules/objfmts/elf/tests/x32/elf-rip.asm
[modify] https://crrev.com/013500cc2c8215b17d26de52eadb126345878f31/config/missing
[modify] https://crrev.com/013500cc2c8215b17d26de52eadb126345878f31/Mkfiles/Makefile.flat
[add] https://crrev.com/013500cc2c8215b17d26de52eadb126345878f31/modules/objfmts/elf/tests/gasx32/Makefile.inc
[add] https://crrev.com/013500cc2c8215b17d26de52eadb126345878f31/modules/objfmts/elf/tests/gasx32/elf_gasx32_ssym.hex
[add] https://crrev.com/013500cc2c8215b17d26de52eadb126345878f31/cmake/CMakeLists.txt
[add] https://crrev.com/013500cc2c8215b17d26de52eadb126345878f31/modules/objfmts/elf/tests/x32/elf-rip.hex
[modify] https://crrev.com/013500cc2c8215b17d26de52eadb126345878f31/modules/dbgfmts/dwarf2/dwarf2-line.c
[modify] https://crrev.com/013500cc2c8215b17d26de52eadb126345878f31/Mkfiles/dj/YASM-VERSION.h
[add] https://crrev.com/013500cc2c8215b17d26de52eadb126345878f31/modules/objfmts/rdf/CMakeLists.txt
[add] https://crrev.com/013500cc2c8215b17d26de52eadb126345878f31/Mkfiles/vc12/modules/modules.vcxproj
[add] https://crrev.com/013500cc2c8215b17d26de52eadb126345878f31/Mkfiles/vc12/out_copy_rename.bat
[modify] https://crrev.com/013500cc2c8215b17d26de52eadb126345878f31/ABOUT-NLS
[add] https://crrev.com/013500cc2c8215b17d26de52eadb126345878f31/modules/arch/lc3b/CMakeLists.txt
[add] https://crrev.com/013500cc2c8215b17d26de52eadb126345878f31/Mkfiles/vc12/modules/modules.vcxproj.filters
[modify] https://crrev.com/013500cc2c8215b17d26de52eadb126345878f31/config/config.rpath
[modify] https://crrev.com/013500cc2c8215b17d26de52eadb126345878f31/modules/dbgfmts/stabs/stabs-dbgfmt.c
[add] https://crrev.com/013500cc2c8215b17d26de52eadb126345878f31/config.h.cmake
[modify] https://crrev.com/013500cc2c8215b17d26de52eadb126345878f31/modules/arch/x86/gen_x86_insn.py
[add] https://crrev.com/013500cc2c8215b17d26de52eadb126345878f31/modules/CMakeLists.txt
[modify] https://crrev.com/013500cc2c8215b17d26de52eadb126345878f31/yasm_objfmts.7
[modify] https://crrev.com/013500cc2c8215b17d26de52eadb126345878f31/modules/arch/x86/x86id.c
[modify] https://crrev.com/013500cc2c8215b17d26de52eadb126345878f31/config/config.guess
[modify] https://crrev.com/013500cc2c8215b17d26de52eadb126345878f31/libyasm/symrec.h
[add] https://crrev.com/013500cc2c8215b17d26de52eadb126345878f31/libyasm/cmake-module.c
[add] https://crrev.com/013500cc2c8215b17d26de52eadb126345878f31/tools/re2c/CMakeLists.txt
[add] https://crrev.com/013500cc2c8215b17d26de52eadb126345878f31/modules/objfmts/macho/CMakeLists.txt
[modify] https://crrev.com/013500cc2c8215b17d26de52eadb126345878f31/modules/arch/x86/x86cpu.gperf
[modify] https://crrev.com/013500cc2c8215b17d26de52eadb126345878f31/tools/genperf/perfect.c
[add] https://crrev.com/013500cc2c8215b17d26de52eadb126345878f31/modules/objfmts/elf/tests/x32/Makefile.inc
[add] https://crrev.com/013500cc2c8215b17d26de52eadb126345878f31/cmake/modules/YasmMacros.cmake
[add] https://crrev.com/013500cc2c8215b17d26de52eadb126345878f31/Mkfiles/vc12/yasm.sln
[modify] https://crrev.com/013500cc2c8215b17d26de52eadb126345878f31/po/ChangeLog
[add] https://crrev.com/013500cc2c8215b17d26de52eadb126345878f31/modules/objfmts/CMakeLists.txt
[add] https://crrev.com/013500cc2c8215b17d26de52eadb126345878f31/modules/objfmts/elf/tests/gasx32/elf_gasx32_curpos.asm
[modify] https://crrev.com/013500cc2c8215b17d26de52eadb126345878f31/Mkfiles/vc10/YASM-VERSION.h
[add] https://crrev.com/013500cc2c8215b17d26de52eadb126345878f31/tools/genperf/CMakeLists.txt
[modify] https://crrev.com/013500cc2c8215b17d26de52eadb126345878f31/modules/parsers/gas/gas-parse.c
[add] https://crrev.com/013500cc2c8215b17d26de52eadb126345878f31/modules/objfmts/coff/CMakeLists.txt
[add] https://crrev.com/013500cc2c8215b17d26de52eadb126345878f31/plugins/dbg/CMakeLists.txt
[modify] https://crrev.com/013500cc2c8215b17d26de52eadb126345878f31/x86insns.c
[add] https://crrev.com/013500cc2c8215b17d26de52eadb126345878f31/config/test-driver
[add] https://crrev.com/013500cc2c8215b17d26de52eadb126345878f31/modules/preprocs/cpp/CMakeLists.txt
[add] https://crrev.com/013500cc2c8215b17d26de52eadb126345878f31/frontends/vsyasm/CMakeLists.txt
[modify] https://crrev.com/013500cc2c8215b17d26de52eadb126345878f31/frontends/tasm/tasm.c
[add] https://crrev.com/013500cc2c8215b17d26de52eadb126345878f31/frontends/CMakeLists.txt
[add] https://crrev.com/013500cc2c8215b17d26de52eadb126345878f31/modules/objfmts/elf/tests/gasx32/elf_gasx32_reloc.asm
[modify] https://crrev.com/013500cc2c8215b17d26de52eadb126345878f31/Mkfiles/vc10/modules/modules.vcxproj
[add] https://crrev.com/013500cc2c8215b17d26de52eadb126345878f31/Mkfiles/vc12/crt_secure_no_deprecate.vsprops
[add] https://crrev.com/013500cc2c8215b17d26de52eadb126345878f31/modules/parsers/CMakeLists.txt
[add] https://crrev.com/013500cc2c8215b17d26de52eadb126345878f31/modules/objfmts/elf/tests/x32/elf_x32_test.sh
[modify] https://crrev.com/013500cc2c8215b17d26de52eadb126345878f31/configure
[modify] https://crrev.com/013500cc2c8215b17d26de52eadb126345878f31/Mkfiles/Makefile.dj
[add] https://crrev.com/013500cc2c8215b17d26de52eadb126345878f31/plugins/dbg/init_plugin.c
[modify] https://crrev.com/013500cc2c8215b17d26de52eadb126345878f31/Mkfiles/vc10/modules/modules.vcxproj.filters
[modify] https://crrev.com/013500cc2c8215b17d26de52eadb126345878f31/Mkfiles/vc10/genversion/genversion.vcxproj
[modify] https://crrev.com/013500cc2c8215b17d26de52eadb126345878f31/modules/dbgfmts/codeview/cv8.txt
[modify] https://crrev.com/013500cc2c8215b17d26de52eadb126345878f31/m4/gettext.m4
[add] https://crrev.com/013500cc2c8215b17d26de52eadb126345878f31/modules/parsers/nasm/CMakeLists.txt
[add] https://crrev.com/013500cc2c8215b17d26de52eadb126345878f31/frontends/yasm/CMakeLists.txt
[add] https://crrev.com/013500cc2c8215b17d26de52eadb126345878f31/modules/objfmts/elf/tests/gasx32/crosssect.asm
[add] https://crrev.com/013500cc2c8215b17d26de52eadb126345878f31/cmake/modules/CMakeLists.txt
[add] https://crrev.com/013500cc2c8215b17d26de52eadb126345878f31/libyasm-stdint.h.cmake
[add] https://crrev.com/013500cc2c8215b17d26de52eadb126345878f31/modules/objfmts/win64/tests/win64-function.hex
[modify] https://crrev.com/013500cc2c8215b17d26de52eadb126345878f31/Mkfiles/vc10/genperf/run.bat
[add] https://crrev.com/013500cc2c8215b17d26de52eadb126345878f31/modules/preprocs/raw/CMakeLists.txt
[modify] https://crrev.com/013500cc2c8215b17d26de52eadb126345878f31/modules/objfmts/elf/elf-objfmt.c
[add] https://crrev.com/013500cc2c8215b17d26de52eadb126345878f31/config/compile
[add] https://crrev.com/013500cc2c8215b17d26de52eadb126345878f31/modules/objfmts/elf/CMakeLists.txt
[modify] https://crrev.com/013500cc2c8215b17d26de52eadb126345878f31/m4/iconv.m4
[modify] https://crrev.com/013500cc2c8215b17d26de52eadb126345878f31/modules/objfmts/yasm_objfmts.xml
[modify] https://crrev.com/013500cc2c8215b17d26de52eadb126345878f31/modules/arch/x86/x86bc.c
[add] https://crrev.com/013500cc2c8215b17d26de52eadb126345878f31/modules/listfmts/nasm/CMakeLists.txt
[add] https://crrev.com/013500cc2c8215b17d26de52eadb126345878f31/modules/dbgfmts/null/CMakeLists.txt
[modify] https://crrev.com/013500cc2c8215b17d26de52eadb126345878f31/Makefile.in
[add] https://crrev.com/013500cc2c8215b17d26de52eadb126345878f31/plugins/x86/CMakeLists.txt
[modify] https://crrev.com/013500cc2c8215b17d26de52eadb126345878f31/modules/objfmts/macho/macho-objfmt.c
[modify] https://crrev.com/013500cc2c8215b17d26de52eadb126345878f31/configure.ac
[add] https://crrev.com/013500cc2c8215b17d26de52eadb126345878f31/Mkfiles/vc12/YASM-VERSION.h
[add] https://crrev.com/013500cc2c8215b17d26de52eadb126345878f31/CMakeLists.txt
[add] https://crrev.com/013500cc2c8215b17d26de52eadb126345878f31/plugins/x86/init_plugin.c
[modify] https://crrev.com/013500cc2c8215b17d26de52eadb126345878f31/COPYING
[modify] https://crrev.com/013500cc2c8215b17d26de52eadb126345878f31/libyasm/expr.h
[modify] https://crrev.com/013500cc2c8215b17d26de52eadb126345878f31/aclocal.m4
[add] https://crrev.com/013500cc2c8215b17d26de52eadb126345878f31/modules/preprocs/nasm/CMakeLists.txt
[add] https://crrev.com/013500cc2c8215b17d26de52eadb126345878f31/modules/objfmts/elf/tests/gasx32/elf_gasx32_test.sh
[add] https://crrev.com/013500cc2c8215b17d26de52eadb126345878f31/modules/objfmts/elf/tests/x32/multiplefixup.hex
[add] https://crrev.com/013500cc2c8215b17d26de52eadb126345878f31/Mkfiles/vc12/yasm.vcxproj
[modify] https://crrev.com/013500cc2c8215b17d26de52eadb126345878f31/po/Rules-quot
[add] https://crrev.com/013500cc2c8215b17d26de52eadb126345878f31/modules/objfmts/elf/tests/x32/multiplefixup.asm
[add] https://crrev.com/013500cc2c8215b17d26de52eadb126345878f31/frontends/tasm/CMakeLists.txt
[modify] https://crrev.com/013500cc2c8215b17d26de52eadb126345878f31/m4/lib-ld.m4
[modify] https://crrev.com/013500cc2c8215b17d26de52eadb126345878f31/Makefile.am
[modify] https://crrev.com/013500cc2c8215b17d26de52eadb126345878f31/po/Makefile.in.in
[add] https://crrev.com/013500cc2c8215b17d26de52eadb126345878f31/Mkfiles/vc12/vsyasm.props
[modify] https://crrev.com/013500cc2c8215b17d26de52eadb126345878f31/m4/po.m4
[modify] https://crrev.com/013500cc2c8215b17d26de52eadb126345878f31/frontends/vsyasm/vsyasm.c
[add] https://crrev.com/013500cc2c8215b17d26de52eadb126345878f31/Mkfiles/vc12/crt_secure_no_deprecate.props
[add] https://crrev.com/013500cc2c8215b17d26de52eadb126345878f31/modules/objfmts/elf/tests/x32/elfsox32.asm
[modify] https://crrev.com/013500cc2c8215b17d26de52eadb126345878f31/modules/objfmts/coff/coff-objfmt.c
[modify] https://crrev.com/013500cc2c8215b17d26de52eadb126345878f31/modules/arch/yasm_arch.xml
[modify] https://crrev.com/013500cc2c8215b17d26de52eadb126345878f31/modules/preprocs/nasm/nasm-pp.c
[modify] https://crrev.com/013500cc2c8215b17d26de52eadb126345878f31/frontends/tasm/tasm-options.c
[add] https://crrev.com/013500cc2c8215b17d26de52eadb126345878f31/Mkfiles/vc12/ytasm.vcxproj
[add] https://crrev.com/013500cc2c8215b17d26de52eadb126345878f31/ConfigureChecks.cmake
[modify] https://crrev.com/013500cc2c8215b17d26de52eadb126345878f31/modules/objfmts/elf/elf.c
[modify] https://crrev.com/013500cc2c8215b17d26de52eadb126345878f31/libyasm/bytecode.h
[modify] https://crrev.com/013500cc2c8215b17d26de52eadb126345878f31/modules/objfmts/elf/tests/Makefile.inc
[modify] https://crrev.com/013500cc2c8215b17d26de52eadb126345878f31/libyasm/genmodule.c
[modify] https://crrev.com/013500cc2c8215b17d26de52eadb126345878f31/YASM-VERSION-GEN.sh
[add] https://crrev.com/013500cc2c8215b17d26de52eadb126345878f31/libyasm/CMakeLists.txt
[add] https://crrev.com/013500cc2c8215b17d26de52eadb126345878f31/Mkfiles/vc12/vsyasm.targets
[modify] https://crrev.com/013500cc2c8215b17d26de52eadb126345878f31/x86insn_gas.gperf
[modify] https://crrev.com/013500cc2c8215b17d26de52eadb126345878f31/modules/objfmts/elf/Makefile.inc

Project Member

Comment 4 by bugdroid1@chromium.org, Aug 11 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/34865fdd1020a8f95b8288665bfefb203951b431

commit 34865fdd1020a8f95b8288665bfefb203951b431
Author: David Benjamin <davidben@chromium.org>
Date: Fri Aug 11 03:26:44 2017

Update to yasm 1.3.0.

The patches we cherry-picked from upstream are all included in 1.3.0.
I've also added patches which were previously missing and rewritten the
instructions to match GN. In config/win, stdint.h is removed because
MSVC provides it these days. I've also removed the Python build step
because upstream ships the generated files these days.

To reduce diff noise in the future, I've also trimmed all the generated
Makefiles we'd check in so it only includes the one line we care about and
is platform-independent. As this list does not appear to change even in
upstream, we should perhaps send them a patch to be less clever.

Bug:  753886 
Change-Id: Iaec9ea3bed8f81b31e19b997812467f81b95d6ce
Reviewed-on: https://chromium-review.googlesource.com/608869
Commit-Queue: David Benjamin <davidben@chromium.org>
Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#493656}
[modify] https://crrev.com/34865fdd1020a8f95b8288665bfefb203951b431/DEPS
[modify] https://crrev.com/34865fdd1020a8f95b8288665bfefb203951b431/third_party/yasm/BUILD.gn
[delete] https://crrev.com/b2e2af995d573d98314e9b10a2ddcae41e036334/third_party/yasm/CHROMIUM.diff
[modify] https://crrev.com/34865fdd1020a8f95b8288665bfefb203951b431/third_party/yasm/README.chromium
[add] https://crrev.com/34865fdd1020a8f95b8288665bfefb203951b431/third_party/yasm/deterministic.diff
[add] https://crrev.com/34865fdd1020a8f95b8288665bfefb203951b431/third_party/yasm/genmodule.diff
[add] https://crrev.com/34865fdd1020a8f95b8288665bfefb203951b431/third_party/yasm/genperf.diff
[add] https://crrev.com/34865fdd1020a8f95b8288665bfefb203951b431/third_party/yasm/source/config/Makefile
[delete] https://crrev.com/b2e2af995d573d98314e9b10a2ddcae41e036334/third_party/yasm/source/config/android/Makefile
[modify] https://crrev.com/34865fdd1020a8f95b8288665bfefb203951b431/third_party/yasm/source/config/android/config.h
[modify] https://crrev.com/34865fdd1020a8f95b8288665bfefb203951b431/third_party/yasm/source/config/android/libyasm-stdint.h
[delete] https://crrev.com/b2e2af995d573d98314e9b10a2ddcae41e036334/third_party/yasm/source/config/ios/Makefile
[modify] https://crrev.com/34865fdd1020a8f95b8288665bfefb203951b431/third_party/yasm/source/config/ios/config.h
[modify] https://crrev.com/34865fdd1020a8f95b8288665bfefb203951b431/third_party/yasm/source/config/ios/libyasm-stdint.h
[delete] https://crrev.com/b2e2af995d573d98314e9b10a2ddcae41e036334/third_party/yasm/source/config/linux/Makefile
[modify] https://crrev.com/34865fdd1020a8f95b8288665bfefb203951b431/third_party/yasm/source/config/linux/config.h
[modify] https://crrev.com/34865fdd1020a8f95b8288665bfefb203951b431/third_party/yasm/source/config/linux/libyasm-stdint.h
[delete] https://crrev.com/b2e2af995d573d98314e9b10a2ddcae41e036334/third_party/yasm/source/config/mac/Makefile
[modify] https://crrev.com/34865fdd1020a8f95b8288665bfefb203951b431/third_party/yasm/source/config/mac/config.h
[modify] https://crrev.com/34865fdd1020a8f95b8288665bfefb203951b431/third_party/yasm/source/config/mac/libyasm-stdint.h
[delete] https://crrev.com/b2e2af995d573d98314e9b10a2ddcae41e036334/third_party/yasm/source/config/openbsd/Makefile
[delete] https://crrev.com/b2e2af995d573d98314e9b10a2ddcae41e036334/third_party/yasm/source/config/win/Makefile
[modify] https://crrev.com/34865fdd1020a8f95b8288665bfefb203951b431/third_party/yasm/source/config/win/config.h
[modify] https://crrev.com/34865fdd1020a8f95b8288665bfefb203951b431/third_party/yasm/source/config/win/libyasm-stdint.h
[delete] https://crrev.com/b2e2af995d573d98314e9b10a2ddcae41e036334/third_party/yasm/source/config/win/stdint.h

Status: Fixed (was: Assigned)

Sign in to add a comment