Remove some OOBE screens for VMs |
|||||||||||||
Issue descriptionAndroid Emulator users will very often create new VM images to test their Android apps. Since that happens often we don't want them to have to go through OOBE every single time, it hurts UX. Candidates for removal: - 'Welcome!' screen - 'Connect to network' screen, since VMs don't have wifi and will auto-connect to Ethernet - 'Google Chrome OS terms'. They should be accepted once and for all when enabling Chrome OS support in Android Emulator - 'Checking for updates' screen, since those VM images won't auto-update. We still need to keep the user sign-in screens since a real user login is required. Is it possible to add a switch to skip those OOBE screens and make that behaviour dependent on a USE flag? We can then enable that USE flag for VM targets and leave it disabled for normal boards.
,
Aug 9 2017
,
Sep 13 2017
I've noticed a "Howdy" screen that recently started showing up on first login. It would be good to add that screen to the list at the same time.
,
Sep 19 2017
,
Sep 28 2017
We are using "SkipToLoginForTesting" method in tests. It might not be enough to just call it when some command-line option is present, but this could be a starting point.
,
Oct 24 2017
Is that still on track for M-63?
,
Oct 31 2017
Any update?
,
Nov 8 2017
I could probably take this on
,
Nov 22 2017
Not going to get to this anytime soon actually.
,
Nov 22 2017
,
Nov 22 2017
,
Jan 4 2018
Caught up with rkc@, making this a P1 for M66. @alemate, let me know if you want to discuss this at all!
,
Jan 4 2018
I have time to do this now, and familiarity with the code. I'll take it unless Alex really wants to do it.
,
Jan 4 2018
,
Jan 4 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/5d5770004b70e1d1e57e075f258591e1ac39559b commit 5d5770004b70e1d1e57e075f258591e1ac39559b Author: Achuith Bhandarkar <achuith@chromium.org> Date: Thu Jan 04 22:21:45 2018 [oobe]: Add flag --oobe-skip-to-login This flag skips to the user login screen. BUG= 753870 TEST=manual Change-Id: I3682b825d8177b8676718f421335f4af1d940937 Reviewed-on: https://chromium-review.googlesource.com/850582 Commit-Queue: Achuith Bhandarkar <achuith@chromium.org> Reviewed-by: Alexander Alekseev <alemate@chromium.org> Cr-Commit-Position: refs/heads/master@{#527116} [modify] https://crrev.com/5d5770004b70e1d1e57e075f258591e1ac39559b/chrome/browser/chromeos/login/wizard_controller.cc [modify] https://crrev.com/5d5770004b70e1d1e57e075f258591e1ac39559b/chromeos/chromeos_switches.cc [modify] https://crrev.com/5d5770004b70e1d1e57e075f258591e1ac39559b/chromeos/chromeos_switches.h
,
Jan 4 2018
Hey Nicolas, so the chrome side change is in, and using the flag --oobe-skip-to-login does what you want. There are 2 ways forward from here. A USE flag as you suggest that appends this runtime flag to chrome. Would you be willing to take this on? Secondly, it's possible to run this in the VM: echo --oobe-skip-to-login >> /etc/chrome_dev.conf; restart ui and this will skip to the login page as well, but this requires login to the VM so is probably not desirable.
,
Jan 4 2018
Ok, nm, I think these 2 CLs should do it. Testing now. https://chromium-review.googlesource.com/851057 https://chromium-review.googlesource.com/851058
,
Jan 5 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform2/+/2facb026e69de03835f66825d1e4d863cc7f1af1 commit 2facb026e69de03835f66825d1e4d863cc7f1af1 Author: Achuith Bhandarkar <achuith@chromium.org> Date: Fri Jan 05 20:10:03 2018 login: Support for oobe_skip_to_login BUG= chromium:753870 TEST=manual Change-Id: I16a1e1c1baa343998dbe81fea508c8017c59de87 Reviewed-on: https://chromium-review.googlesource.com/851057 Commit-Ready: Achuith Bhandarkar <achuith@chromium.org> Tested-by: Achuith Bhandarkar <achuith@chromium.org> Reviewed-by: Dan Erat <derat@chromium.org> [modify] https://crrev.com/2facb026e69de03835f66825d1e4d863cc7f1af1/login_manager/chrome_setup.cc
,
Jan 5 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/3f9c5d25f9d14ea6ff565a8949eae7f6e73265b7 commit 3f9c5d25f9d14ea6ff565a8949eae7f6e73265b7 Author: Achuith Bhandarkar <achuith@chromium.org> Date: Fri Jan 05 20:10:04 2018 [libchromeos-use-flags]: Use flag oobe_skip_to_login BUG= chromium:753870 TEST=None Change-Id: I1e433a112544eea5316babdfdab81ae0557fb504 Reviewed-on: https://chromium-review.googlesource.com/851058 Commit-Ready: Achuith Bhandarkar <achuith@chromium.org> Tested-by: Achuith Bhandarkar <achuith@chromium.org> Reviewed-by: Nicolas Norvez <norvez@chromium.org> [rename] https://crrev.com/3f9c5d25f9d14ea6ff565a8949eae7f6e73265b7/chromeos-base/libchromeos-use-flags/libchromeos-use-flags-0.0.1-r43.ebuild [modify] https://crrev.com/3f9c5d25f9d14ea6ff565a8949eae7f6e73265b7/chromeos-base/libchromeos-use-flags/libchromeos-use-flags-0.0.1.ebuild
,
Jan 7 2018
I tried: USE=oobe_skip_to_login build_packages After building images and flashing to a test DUT, I was able to verify that the --oobe-skip-to-login flag was present using ps. The flag skips the initial oobe screens and lands you on the user login screen. Closing as fixed. Please verify, Nicolas.
,
Jan 7 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/fa0fbd04bd63be9d9d8e6e5b329e36d3b0e53001 commit fa0fbd04bd63be9d9d8e6e5b329e36d3b0e53001 Author: Achuith Bhandarkar <achuith@chromium.org> Date: Sun Jan 07 19:42:39 2018 [oobe]: Fix --oobe-skip-to-login. For test DUTs, it's possible to have OobeComplete and EulaAccepted be true, and yet be on the starting OOBE screen. BUG= chromium:753870 TEST=manual Change-Id: Ie5365b747fc706fdb000e8f8f6473eacd63cbc6e Reviewed-on: https://chromium-review.googlesource.com/852797 Reviewed-by: Alexander Alekseev <alemate@chromium.org> Commit-Queue: Achuith Bhandarkar <achuith@chromium.org> Cr-Commit-Position: refs/heads/master@{#527544} [modify] https://crrev.com/fa0fbd04bd63be9d9d8e6e5b329e36d3b0e53001/chrome/browser/chromeos/login/wizard_controller.cc
,
Jan 8 2018
Thanks Achuith! Assigning the bug to myself for remaining CL that turns on the feature for novato https://chrome-internal-review.googlesource.com/c/chromeos/overlays/overlay-novato-private/+/540158 There are still some post-login screen that are on (the "Howdy" one and a new "Sync disclosure"), we can move the discussion about those to a different bug.
,
Jan 8 2018
Can you tell me how to get these screens to show up? Are they novato specific? I haven't seen them
,
Jan 8 2018
I don't think they are specific to novato, betty 10290.0.0 has them too. I don't have a physical device available, but I'm guessing they're present too. If you use a fresh image (right after powerwash?) and sign in with a test account for the first time you should see them. I think they're https://cs.chromium.org/search/?q=IDS_LOGIN_SYNC_CONSENT_SCREEN_TITLE&sq=package:chromium&type=cs and https://cs.chromium.org/search/?q=IDS_FIRST_RUN_GREETING_STEP_HEADER&sq=package:chromium&type=cs
,
Jan 8 2018
The following revision refers to this bug: https://chrome-internal.googlesource.com/chromeos/overlays/overlay-novato-private/+/bddfb1223b156d6366e99edf2dcd2ff423f2af1b commit bddfb1223b156d6366e99edf2dcd2ff423f2af1b Author: Nicolas Norvez <norvez@google.com> Date: Mon Jan 08 22:39:49 2018
,
Jan 9 2018
We can use this bug for the post-login screens. We can use --oobe-skip-post-login (which currently doesn't handle these new screens). I'm seeing a different problem where immediately after online login, we go to the signin screen. It's not a crash (though the crash dialog is visible on subsequent login), and there's nothing in the logs to indicate what went wrong.
,
Jan 9 2018
,
Jan 9 2018
This is the relevant code: https://cs.chromium.org/chromium/src/chrome/browser/chromeos/login/session/user_session_manager.cc?l=1452-1478 if --oobe-skip-post-login is specified, we don't open the Terms of Service screen (which is not relevant to user accounts). The Terms of Service screen leads into the Sync Screen: https://cs.chromium.org/chromium/src/chrome/browser/chromeos/login/wizard_controller.cc?l=881 We would skip this with --oobe-skip-post-login
,
Jan 12 2018
The following revision refers to this bug: https://chrome-internal.googlesource.com/chromeos/overlays/overlay-novato-private/+/20a944bf3118828f295103cbc72cf42b1f0ea8ec commit 20a944bf3118828f295103cbc72cf42b1f0ea8ec Author: Nicolas Norvez <norvez@google.com> Date: Fri Jan 12 19:43:38 2018
,
Jan 12 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/18fa86aa431c87903c328e27ded15ded98dd4918 commit 18fa86aa431c87903c328e27ded15ded98dd4918 Author: Nicolas Norvez <norvez@chromium.org> Date: Fri Jan 12 19:43:40 2018 libchromeos-use-flags: add USE flag oobe_skip_postlogin BUG= chromium:753870 TEST=manual build Change-Id: I3cba7ea5cd2523c34457241269a73fbf55bc1edc Reviewed-on: https://chromium-review.googlesource.com/862182 Commit-Ready: Nicolas Norvez <norvez@chromium.org> Tested-by: Nicolas Norvez <norvez@chromium.org> Reviewed-by: Achuith Bhandarkar <achuith@chromium.org> [rename] https://crrev.com/18fa86aa431c87903c328e27ded15ded98dd4918/chromeos-base/libchromeos-use-flags/libchromeos-use-flags-0.0.1-r44.ebuild [modify] https://crrev.com/18fa86aa431c87903c328e27ded15ded98dd4918/chromeos-base/libchromeos-use-flags/libchromeos-use-flags-0.0.1.ebuild
,
Jan 12 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform2/+/bdce8d9c094d39e4a26277bdfa4ae4c1c1b9dfb4 commit bdce8d9c094d39e4a26277bdfa4ae4c1c1b9dfb4 Author: Nicolas Norvez <norvez@chromium.org> Date: Fri Jan 12 19:43:37 2018 login: support oobe_skip_postlogin Support oobe_skip_postlogin that skips OOBE screens after first signin. BUG= chromium:753870 TEST=manual test, post signin oobe screens are skipped. Change-Id: Ifb01028ff27eec0a012ad6ea7438a62950c16f3f Reviewed-on: https://chromium-review.googlesource.com/862106 Commit-Ready: Nicolas Norvez <norvez@chromium.org> Tested-by: Nicolas Norvez <norvez@chromium.org> Reviewed-by: Achuith Bhandarkar <achuith@chromium.org> Reviewed-by: Dan Erat <derat@chromium.org> [modify] https://crrev.com/bdce8d9c094d39e4a26277bdfa4ae4c1c1b9dfb4/login_manager/chrome_setup.cc
,
Jan 12 2018
novato now uses --oobe-skip-to-login and --oobe-skip-postlogin to skip the OOBE screens.
,
Jan 18 2018
The following revision refers to this bug: https://chromium.googlesource.com/catapult/+/e2262fc1bc51fef0b7d5a3a40ec592841bf78064 commit e2262fc1bc51fef0b7d5a3a40ec592841bf78064 Author: Achuith Bhandarkar <achuith@chromium.org> Date: Thu Jan 18 19:39:07 2018 [oobe]: Use --oobe-skip-to-login instead of Oobe.skipToLoginForTesting. BUG= chromium:753870 TEST=testGaiaLogin TBR=nednguyen@google.com Change-Id: Ia5a0514431b4f010802fccce97608f6d2fedf2a9 Reviewed-on: https://chromium-review.googlesource.com/871434 Reviewed-by: Achuith Bhandarkar <achuith@chromium.org> Commit-Queue: Achuith Bhandarkar <achuith@chromium.org> [modify] https://crrev.com/e2262fc1bc51fef0b7d5a3a40ec592841bf78064/telemetry/telemetry/internal/backends/chrome/oobe.py [modify] https://crrev.com/e2262fc1bc51fef0b7d5a3a40ec592841bf78064/telemetry/telemetry/internal/backends/chrome/cros_browser_backend.py
,
Jan 19 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/db246834025692b4cea01d5614564b2a7cbd61e5 commit db246834025692b4cea01d5614564b2a7cbd61e5 Author: catapult-deps-roller@chromium.org <catapult-deps-roller@chromium.org> Date: Fri Jan 19 12:54:03 2018 Roll src/third_party/catapult/ b4706e732..51d9354bb (9 commits) https://chromium.googlesource.com/catapult.git/+log/b4706e73204b..51d9354bb0d4 $ git log b4706e732..51d9354bb --date=short --no-merges --format='%ad %ae %s' 2018-01-19 perezju Fix Fakes for telemetry_gpu_unittests to pass. 2018-01-18 kbr Use vpython's wheels for the cv2 and numpy libraries. 2018-01-17 dtu [pinpoint] Shorten display name for patches. 2018-01-18 simonhatch Dashboard - Remove bisect fyi bot code. 2018-01-18 eakuefner [Dashboard] Generate old-style rows for histogram uploads 2018-01-18 charliea Log wmic exit code when it fails 2018-01-18 achuith [oobe]: Use --oobe-skip-to-login instead of Oobe.skipToLoginForTesting. 2018-01-17 perezju [Telemetry] Migrate cros_test_case.CrOSTestCase to new browser API 2018-01-18 perezju Reland "[Telemetry] Migrate SeriallyExecutedBrowserTestCase to new API" Created with: roll-dep src/third_party/catapult BUG= 801578 , 776804 , 753870 The AutoRoll server is located here: https://catapult-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=sullivan@chromium.org Change-Id: I0836e5381460acc83837bce9ed5e752e233c0344 Reviewed-on: https://chromium-review.googlesource.com/875904 Reviewed-by: <catapult-deps-roller@chromium.org> Commit-Queue: <catapult-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#530493} [modify] https://crrev.com/db246834025692b4cea01d5614564b2a7cbd61e5/DEPS |
|||||||||||||
►
Sign in to add a comment |
|||||||||||||
Comment 1 by zalcorn@chromium.org
, Aug 9 2017