Network error/config UI looks strange |
||||||
Issue descriptionSee attached screen shots. The first one is trying to open Gaia when the device is offline. The 2nd one is the network config UI during kiosk app launch. Both seems having wrong style. wzang@, passing to you to triage. Feel free to re-assign. Thanks.
,
Aug 9 2017
,
Aug 12 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/bde4aa426d9409fee6c9a56a0d7216fe99e33ed6 commit bde4aa426d9409fee6c9a56a0d7216fe99e33ed6 Author: Wenzhao Zang <wzang@chromium.org> Date: Sat Aug 12 05:29:26 2017 Always notify account picker of window size changes Also updates network error screen to match spec Bug: 753869 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I945b731ed29959971679e17755d3efb725c48420 Reviewed-on: https://chromium-review.googlesource.com/612743 Commit-Queue: Wenzhao (Colin) Zang <wzang@chromium.org> Commit-Queue: Alexander Alekseev <alemate@chromium.org> Reviewed-by: Alexander Alekseev <alemate@chromium.org> Cr-Commit-Position: refs/heads/master@{#493959} [modify] https://crrev.com/bde4aa426d9409fee6c9a56a0d7216fe99e33ed6/chrome/browser/resources/chromeos/login/screen_error_message.css [modify] https://crrev.com/bde4aa426d9409fee6c9a56a0d7216fe99e33ed6/chrome/browser/resources/chromeos/login/screen_error_message.html [modify] https://crrev.com/bde4aa426d9409fee6c9a56a0d7216fe99e33ed6/ui/login/account_picker/md_user_pod_row.js [modify] https://crrev.com/bde4aa426d9409fee6c9a56a0d7216fe99e33ed6/ui/login/display_manager.js
,
Aug 12 2017
,
Aug 13 2017
This bug requires manual review: M61 has already been promoted to the beta branch, so this requires manual review Please contact the milestone owner if you have questions. Owners: amineer@(Android), cmasso@(iOS), ketakid@(ChromeOS), govind@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Aug 14 2017
Approving merge for M61 Chrome OS.
,
Aug 14 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/54216be1304accaaa3823a07e6e04a8355e1f3aa commit 54216be1304accaaa3823a07e6e04a8355e1f3aa Author: Wenzhao Zang <wzang@chromium.org> Date: Mon Aug 14 17:37:00 2017 Always notify account picker of window size changes Also updates network error screen to match spec TBR=wzang@chromium.org (cherry picked from commit bde4aa426d9409fee6c9a56a0d7216fe99e33ed6) Bug: 753869 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I945b731ed29959971679e17755d3efb725c48420 Reviewed-on: https://chromium-review.googlesource.com/612743 Commit-Queue: Wenzhao (Colin) Zang <wzang@chromium.org> Commit-Queue: Alexander Alekseev <alemate@chromium.org> Reviewed-by: Alexander Alekseev <alemate@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#493959} Reviewed-on: https://chromium-review.googlesource.com/613509 Reviewed-by: Wenzhao (Colin) Zang <wzang@chromium.org> Cr-Commit-Position: refs/branch-heads/3163@{#530} Cr-Branched-From: ff259bab28b35d242e10186cd63af7ed404fae0d-refs/heads/master@{#488528} [modify] https://crrev.com/54216be1304accaaa3823a07e6e04a8355e1f3aa/chrome/browser/resources/chromeos/login/screen_error_message.css [modify] https://crrev.com/54216be1304accaaa3823a07e6e04a8355e1f3aa/chrome/browser/resources/chromeos/login/screen_error_message.html [modify] https://crrev.com/54216be1304accaaa3823a07e6e04a8355e1f3aa/ui/login/account_picker/md_user_pod_row.js [modify] https://crrev.com/54216be1304accaaa3823a07e6e04a8355e1f3aa/ui/login/display_manager.js
,
Jan 22 2018
|
||||||
►
Sign in to add a comment |
||||||
Comment 1 by xiy...@chromium.org
, Aug 9 2017