As per comments on https://chromium-review.googlesource.com/c/578253 and https://chromium-review.googlesource.com/c/604268/ It would be nice if the fusion sensor also receives a notification if its souce sensors are in CONTINUOUS reporting mode. By doing this, the fusion sensor doesn't need to maintain its own high frequency timer.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/268fcc4c8121e10684da6ba4c95e5b2909e287b1 commit 268fcc4c8121e10684da6ba4c95e5b2909e287b1 Author: Jun Cai <juncai@chromium.org> Date: Sat Aug 12 00:43:03 2017 Refactor PlatformSensor::Client to receive internal notification As per comments on https://chromium-review.googlesource.com/c/578253/ and https://chromium-review.googlesource.com/c/604268/ It would be nice if the fusion sensor also receives a notification if its source sensors are in CONTINUOUS reporting mode. By doing this, the fusion sensor doesn't need to maintain its own high frequency timer. This CL adds a |receive_reading_changed_internal_notification_| flag to let the PlatformSensor::Client choose if it would like to receive sensor reading change internal notification. This flag doesn't affect the notification sent out to the mojo clients, it is controlled by the |notify_clients| parameter. Bug: 753863 , 733707 Change-Id: I95cc3754c81e59dfaf3e6598bac780dd08e9ec44 Reviewed-on: https://chromium-review.googlesource.com/610895 Commit-Queue: Jun Cai <juncai@chromium.org> Reviewed-by: Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#493908} [modify] https://crrev.com/268fcc4c8121e10684da6ba4c95e5b2909e287b1/services/device/generic_sensor/absolute_orientation_euler_angles_fusion_algorithm_using_accelerometer_and_magnetometer.cc [modify] https://crrev.com/268fcc4c8121e10684da6ba4c95e5b2909e287b1/services/device/generic_sensor/generic_sensor_service_unittest.cc [modify] https://crrev.com/268fcc4c8121e10684da6ba4c95e5b2909e287b1/services/device/generic_sensor/platform_sensor.cc [modify] https://crrev.com/268fcc4c8121e10684da6ba4c95e5b2909e287b1/services/device/generic_sensor/platform_sensor.h [modify] https://crrev.com/268fcc4c8121e10684da6ba4c95e5b2909e287b1/services/device/generic_sensor/platform_sensor_accelerometer_mac.cc [modify] https://crrev.com/268fcc4c8121e10684da6ba4c95e5b2909e287b1/services/device/generic_sensor/platform_sensor_ambient_light_mac.cc [modify] https://crrev.com/268fcc4c8121e10684da6ba4c95e5b2909e287b1/services/device/generic_sensor/platform_sensor_and_provider_unittest_linux.cc [modify] https://crrev.com/268fcc4c8121e10684da6ba4c95e5b2909e287b1/services/device/generic_sensor/platform_sensor_android.cc [modify] https://crrev.com/268fcc4c8121e10684da6ba4c95e5b2909e287b1/services/device/generic_sensor/platform_sensor_fusion.cc [modify] https://crrev.com/268fcc4c8121e10684da6ba4c95e5b2909e287b1/services/device/generic_sensor/platform_sensor_fusion.h [modify] https://crrev.com/268fcc4c8121e10684da6ba4c95e5b2909e287b1/services/device/generic_sensor/platform_sensor_linux.cc [modify] https://crrev.com/268fcc4c8121e10684da6ba4c95e5b2909e287b1/services/device/generic_sensor/platform_sensor_win.cc [modify] https://crrev.com/268fcc4c8121e10684da6ba4c95e5b2909e287b1/services/device/generic_sensor/sensor_impl.cc
Comment 1 by juncai@chromium.org
, Aug 9 2017