New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 753821 link

Starred by 1 user
Status: Verified
Owner:
gambard@chromium.org
Closed: Aug 2017
Cc:
ios-bugs@chromium.org
█ ramyan@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 3
Type: Bug



Sign in to add a comment

No toast when adding item to Reading List

Project Member Reported by gambard@chromium.org, Aug 9 2017 
What steps will reproduce the problem?
(1) Open NTP with ContentSuggestions
(2) Long press on an Article
(3) Tap on Read Later

What is the expected result?
A "item added to your reading list" toast show be displayed.

What happens instead?
Nothing
Project Member

Comment 1 by bugdroid1@chromium.org, Aug 10 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c9215b63dc020da1b8c7e9e2090307716bbc3084

commit c9215b63dc020da1b8c7e9e2090307716bbc3084
Author: gambard <gambard@chromium.org>
Date: Thu Aug 10 07:02:34 2017

Toast when add ContentSuggestion to Reading List

Using the command option allows the call to be forwarded to the BVC
where the item is added to the Reading List and a toast is displayed.
Adding directly the item to the Reading List as it was done here did
not trigger a toast.

Bug:  753821 
Change-Id: I3789a916c4281a0cbde0ef32f443d9a7fcc0c289
Reviewed-on: https://chromium-review.googlesource.com/608238
Commit-Queue: Gauthier Ambard <gambard@chromium.org>
Reviewed-by: Elodie Banel <lod@chromium.org>
Cr-Commit-Position: refs/heads/master@{#493312}
[modify] https://crrev.com/c9215b63dc020da1b8c7e9e2090307716bbc3084/ios/chrome/browser/content_suggestions/content_suggestions_coordinator.mm

Comment 2 by gambard@chromium.org, Aug 10 2017

Status: Fixed (was: Assigned)

Comment 3 by srikanthg@chromium.org, Aug 15 2017

Status: Verified (was: Fixed)
"Added to Reading List" toast message displayed when adding items to reading list from Content Suggestions.

Verified on M62.0.3086.0 canary
Device: iPhone6s, iPhone7Plus, iPad Pro
iOS: 10.3.3, 11.0
►

Sign in to add a comment