The initial screenshots for the cl that adds an eye icon next to the password field in linux/windows/chromeos platforms.
The long username case is having exact same problem that is described here:  crbug.com/758157 . And will be fixed along with the manage password bubble case.

Deleted: eyeicon.png 36.9 KB

	eyeicon.png 36.9 KB View Download

Deleted: eyeiconlongpassword.png 36.8 KB

	eyeiconlongpassword.png 36.8 KB View Download

Deleted: eyeiconlongusernamebroken.png 40.1 KB

	eyeiconlongusernamebroken.png 40.1 KB View Download

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/06ecac3c66bd05d49e0a401443d1f3d6aa4d909d

commit 06ecac3c66bd05d49e0a401443d1f3d6aa4d909d
Author: Irmak Kavasoglu <irmakk@google.com>
Date: Tue Aug 29 08:53:54 2017

Added an eye icon and a flag for password selection feature

This is the first cl of the password selection feature.
An eye icon is added as trailing to the credentials row in pending
password state of password manager bubble. The icon does nothing.
Screenshots are added to the bug.

Also, a flag is added to guard the code.

The description of the experiment can be found here:
https://docs.google.com/document/d/1YJXYjd2xLvHjDRl-pP6BmjQ76Dyom-t5oMYvPdfVp-w/edit#heading=h.sga7dqjoybbj

Known issue: For long usernames, the username overlaps the eye icon.
This is a filed bug for manage passwords state( crbug.com/758157 ).
The layout uses exact same schema as manage passwords state, and
will be updated when the bug is fixed (probably with my next cl).

Ui probably will be updated after another ui review.

Bug: 753806
Change-Id: Ibf90e03b56e5fcfcde7410dfc6f3c81349ec6214
Reviewed-on: https://chromium-review.googlesource.com/629020
Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org>
Reviewed-by: Tatiana Gornak <melandory@chromium.org>
Commit-Queue: Irmak Kavasoğlu <irmakk@google.com>
Cr-Commit-Position: refs/heads/master@{#498054}
[modify] https://crrev.com/06ecac3c66bd05d49e0a401443d1f3d6aa4d909d/chrome/app/generated_resources.grd
[rename] https://crrev.com/06ecac3c66bd05d49e0a401443d1f3d6aa4d909d/chrome/app/theme/default_100_percent/common/hide_password.png
[rename] https://crrev.com/06ecac3c66bd05d49e0a401443d1f3d6aa4d909d/chrome/app/theme/default_100_percent/common/hide_password_hover.png
[rename] https://crrev.com/06ecac3c66bd05d49e0a401443d1f3d6aa4d909d/chrome/app/theme/default_100_percent/common/show_password.png
[rename] https://crrev.com/06ecac3c66bd05d49e0a401443d1f3d6aa4d909d/chrome/app/theme/default_100_percent/common/show_password_hover.png
[rename] https://crrev.com/06ecac3c66bd05d49e0a401443d1f3d6aa4d909d/chrome/app/theme/default_200_percent/common/hide_password.png
[rename] https://crrev.com/06ecac3c66bd05d49e0a401443d1f3d6aa4d909d/chrome/app/theme/default_200_percent/common/hide_password_hover.png
[rename] https://crrev.com/06ecac3c66bd05d49e0a401443d1f3d6aa4d909d/chrome/app/theme/default_200_percent/common/show_password.png
[rename] https://crrev.com/06ecac3c66bd05d49e0a401443d1f3d6aa4d909d/chrome/app/theme/default_200_percent/common/show_password_hover.png
[modify] https://crrev.com/06ecac3c66bd05d49e0a401443d1f3d6aa4d909d/chrome/app/theme/theme_resources.grd
[modify] https://crrev.com/06ecac3c66bd05d49e0a401443d1f3d6aa4d909d/chrome/browser/chromeos/options/wifi_config_view.cc
[modify] https://crrev.com/06ecac3c66bd05d49e0a401443d1f3d6aa4d909d/chrome/browser/chromeos/options/wimax_config_view.cc
[modify] https://crrev.com/06ecac3c66bd05d49e0a401443d1f3d6aa4d909d/chrome/browser/ui/views/passwords/manage_passwords_bubble_view.cc
[modify] https://crrev.com/06ecac3c66bd05d49e0a401443d1f3d6aa4d909d/components/password_manager/core/common/password_manager_features.cc
[modify] https://crrev.com/06ecac3c66bd05d49e0a401443d1f3d6aa4d909d/components/password_manager/core/common/password_manager_features.h

Screenshots of the eye icon for the mac platform.

If you are wondering why eye icon is not aligned with the button, that is because the x button in manage passwords bubble is not aligned also and we are using the same pattern as it. I can update it if it needs to be aligned - though in that case I suggest I update manage bubble's x button as well. :)

Deleted: withouteye.png 41.7 KB

	withouteye.png 41.7 KB View Download

Deleted: witheye.png 45.4 KB

	witheye.png 45.4 KB View Download

Deleted: manage.png 42.8 KB

	manage.png 42.8 KB View Download

Screenshot for the hovered eye icon on mac platform

Deleted: Screen Shot 2017-08-30 at 10.28.08 AM.png 47.6 KB

	Screen Shot 2017-08-30 at 10.28.08 AM.png 47.6 KB View Download

Screenshot for the highlighted eye icon

Deleted: Screen Shot 2017-08-30 at 6.15.27 PM.png 46.7 KB

	Screen Shot 2017-08-30 at 6.15.27 PM.png 46.7 KB View Download

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/394e0a571f44f712098f8eea31129f21c51ed892

commit 394e0a571f44f712098f8eea31129f21c51ed892
Author: Irmak Kavasoğlu <irmakk@google.com>
Date: Thu Aug 31 08:18:23 2017

Added eye icon to the save password bubble on mac platform

This cl is the mac version of the cl
https://chromium-review.googlesource.com/c/chromium/src/+/629020

This cl adds an eye icon to the right of the password field in save
bubble of the password manager. The code is guarded by the flag of the
feature. More about the feature here:
https://docs.google.com/document/d/1YJXYjd2xLvHjDRl-pP6BmjQ76Dyom-t5oMYvPdfVp-w/edit#heading=h.sga7dqjoybbj

Screenshots are added to the bug.

Bug: 753806
Change-Id: I1035843dd1b8fa084d0079c1c2a67bfd5b05170a
Reviewed-on: https://chromium-review.googlesource.com/641434
Commit-Queue: Irmak Kavasoğlu <irmakk@google.com>
Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#498784}
[modify] https://crrev.com/394e0a571f44f712098f8eea31129f21c51ed892/chrome/browser/ui/cocoa/passwords/password_item_views.h
[modify] https://crrev.com/394e0a571f44f712098f8eea31129f21c51ed892/chrome/browser/ui/cocoa/passwords/passwords_list_view_controller.mm

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/96bf2ae8a150effdeeafa01fbc6f2c5e2cec5134

commit 96bf2ae8a150effdeeafa01fbc6f2c5e2cec5134
Author: Irmak Kavasoglu <irmakk@google.com>
Date: Mon Sep 04 11:28:21 2017

Collecting all possible passwords for future use in password selection

This cl follows the pattern |other_possible_usernames| variable uses. 
I have introduced a new variable, |other_possible_passwords|, in 
the password form structure. This is going to be used to create a drop-down 
of all possible passwords.

Extra explanation to make the cl easier to read:
We have LocateSpecificPasswords function. This function takes in all 
password fields in a page, and tries to understand what they are. It
returns true for single password case, two passwords case
(password update), and three passwords case if only first or last 2
passwords are matching (password update with verification).
So this function returns false for the cases with 0 and 
3 or more passwords. In those cases, it doesnt know what to do,
and returns (see line #529 in conversion utils).

With this cl, I add one extra check before GetPasswordForm returns
false. If we have password selection enabled, and we have several
passwords which we don't know what to do with, I add them to the
|other_possible_passwords| and assign the first one as the main
password.

The GetPasswordForm function is called in 
CreatePasswordFormFromUnownedInputElements, and depending on the
result, either the created one or a brand new password form is
used. What I aim to do is, in the specific case where we have
multiple passwords which we don't know what to do with, instead
of using a brand new password form we will use the existing one
with |other_possible_passwords|.

I still am not fully familiar with the structure this part of the
code uses, so if I am missing some cases or following the wrong
path, please feel free to advise me better ones. :)

Bug: 753806
Change-Id: I29e30a424a8e743e917da0fadd63dcea4b036221
Reviewed-on: https://chromium-review.googlesource.com/640700
Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org>
Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org>
Reviewed-by: Tatiana Gornak <melandory@chromium.org>
Commit-Queue: Irmak Kavasoğlu <irmakk@google.com>
Cr-Commit-Position: refs/heads/master@{#499480}
[modify] https://crrev.com/96bf2ae8a150effdeeafa01fbc6f2c5e2cec5134/components/autofill/content/renderer/DEPS
[modify] https://crrev.com/96bf2ae8a150effdeeafa01fbc6f2c5e2cec5134/components/autofill/content/renderer/password_form_conversion_utils.cc
[modify] https://crrev.com/96bf2ae8a150effdeeafa01fbc6f2c5e2cec5134/components/autofill/content/renderer/password_form_conversion_utils_browsertest.cc
[modify] https://crrev.com/96bf2ae8a150effdeeafa01fbc6f2c5e2cec5134/components/autofill/core/common/password_form.h

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1fabaca2b8e5416fd3ce612acc65cdaf18a6a147

commit 1fabaca2b8e5416fd3ce612acc65cdaf18a6a147
Author: Irmak Kavasoglu <irmakk@google.com>
Date: Wed Sep 06 09:21:54 2017

Added |other_possible_passwords| to autofill types

This cl is adding a new variable to the autofill types classes.

We are implementing a new feature called password selection. Short
description would be; when there are multiple passwords on a page
and password manager is triggered for a save prompt, we want to give
user a dropdown of all possible passwords they can choose from.
More on the feature here;
https://docs.google.com/document/d/1YJXYjd2xLvHjDRl-pP6BmjQ76Dyom-t5oMYvPdfVp-w/edit#heading=h.sga7dqjoybbj

Current state of the feature is that we collect the possible passwords
in a variable called |other_possible_passwords| in password form.

When going from this line:
https://cs.chromium.org/chromium/src/components/autofill/content/renderer/password_autofill_agent.cc?l=1827
To this line:
https://cs.chromium.org/chromium/src/components/password_manager/content/browser/content_password_manager_driver.cc?l=139
The variable was losing its content. To keep the content, I have added
it to the mojo files as well. It mostly follows the pattern of
|other_possible_usernames|.

Bug: 753806
Change-Id: I49fdb8e927a7d31bccf361df7a37e33a6a28adbc
Reviewed-on: https://chromium-review.googlesource.com/648981
Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org>
Reviewed-by: Ken Buchanan <kenrb@chromium.org>
Commit-Queue: Irmak Kavasoğlu <irmakk@google.com>
Cr-Commit-Position: refs/heads/master@{#499916}
[modify] https://crrev.com/1fabaca2b8e5416fd3ce612acc65cdaf18a6a147/components/autofill/content/common/autofill_param_traits_macros.h
[modify] https://crrev.com/1fabaca2b8e5416fd3ce612acc65cdaf18a6a147/components/autofill/content/common/autofill_types.mojom
[modify] https://crrev.com/1fabaca2b8e5416fd3ce612acc65cdaf18a6a147/components/autofill/content/common/autofill_types_struct_traits.cc
[modify] https://crrev.com/1fabaca2b8e5416fd3ce612acc65cdaf18a6a147/components/autofill/content/common/autofill_types_struct_traits.h
[modify] https://crrev.com/1fabaca2b8e5416fd3ce612acc65cdaf18a6a147/components/autofill/content/common/autofill_types_struct_traits_unittest.cc

Screenshots for the dropdown on Linux platform.

nodropdown.png shows a case where there isnt any other possible passwords, so the dropdown is not there.

Deleted: beforeclickingedit.png 327 KB

	beforeclickingedit.png 327 KB View Download

Deleted: editingmode.png 176 KB

	editingmode.png 176 KB View Download

Deleted: dropdown.png 176 KB

	dropdown.png 176 KB View Download

Deleted: nodropdown.png 36.1 KB

	nodropdown.png 36.1 KB View Download

Thanks Irmak for the screenshot. For sake of completeness, could you also add pictures where passwords are revealed? 

Hi, that part hasn't been implemented yet. I will add them once I implement them. O:)

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e00a132d356b5b1508a94f096cf029dad8eafa87

commit e00a132d356b5b1508a94f096cf029dad8eafa87
Author: Irmak Kavasoglu <irmakk@google.com>
Date: Thu Sep 07 18:30:52 2017

Pass |other_possible_passwords| to |pending_credentials| from |saved_form| in password form manager

While creating the pending credentials, I realized that we assign
variables of pending_credentials in CreatePendingCredentialsForNewCredentials
manually. I passed other_possible_passwords with the others and
now the variable can finally reach the bubble.

Warning: For the variable to reach the bubble, we still need
https://chromium-review.googlesource.com/c/chromium/src/+/648981 to be
submitted. But we need this cl too, and they are not dependent on
each other so I am sending this one while that one is being reviewed.:)

Bug: 753806
Change-Id: I72c7a995e45ac95c10d386c1c51ba8ad1dab7141
Reviewed-on: https://chromium-review.googlesource.com/649650
Commit-Queue: Irmak Kavasoğlu <irmakk@google.com>
Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#500336}
[modify] https://crrev.com/e00a132d356b5b1508a94f096cf029dad8eafa87/chrome/browser/password_manager/password_manager_browsertest.cc
[modify] https://crrev.com/e00a132d356b5b1508a94f096cf029dad8eafa87/components/password_manager/core/browser/password_form_manager.cc
[modify] https://crrev.com/e00a132d356b5b1508a94f096cf029dad8eafa87/components/password_manager/core/browser/password_form_manager_unittest.cc

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f088ebda1508bcc1c35f13f2d670442c6083b0ee

commit f088ebda1508bcc1c35f13f2d670442c6083b0ee
Author: Irmak Kavasoglu <irmakk@google.com>
Date: Fri Sep 08 14:11:48 2017

Implemented drop down for edit mode in save bubble

This cl is a part of the implementation for the password selection
feature.

When the save password bubble is shown and user clicks on edit button,
- if password selection feature is on
- if other_possible_passwords variable is not empty
there will be a dropdown for the passwords.

The initial focus after clicking edit button is still on editable
username field. User stays in edit mode as long as the focus is on
username or password fields. If user moves focus to somewhere else,
edit mode is turned off.

This cl does NOT cover any logic for the dropdown. The selection from
the password will disappear if user leaves editing mode. The selection
will not be saved if user clicks save button.

Bug: 753806
Change-Id: I0f37b23b2e78ffdee15dd982d70f69473f0f79e6
Reviewed-on: https://chromium-review.googlesource.com/654899
Commit-Queue: Irmak Kavasoğlu <irmakk@google.com>
Reviewed-by: Tatiana Gornak <melandory@chromium.org>
Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#500584}
[modify] https://crrev.com/f088ebda1508bcc1c35f13f2d670442c6083b0ee/chrome/browser/ui/views/passwords/manage_passwords_bubble_view.cc

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/909f27dd19e54dd99eb54a3151570e653a5e3cef

commit 909f27dd19e54dd99eb54a3151570e653a5e3cef
Author: Maxim Kolosovskiy <kolos@chromium.org>
Date: Mon Sep 11 12:55:07 2017

[Password Manager] Let Password Manager work even if field values are confusing

Befor this CL, GetPasswordForm returned no form if it was unclear what fields should be saved. For such cases, let's simply save the first password.

The password selection (crbug.com/753806) will let user to correct password value.

Bug:  725883 , 753806
Change-Id: I8bf6f48f964ea4e2d2189fe1a10bedb3c850487c
Reviewed-on: https://chromium-review.googlesource.com/657818
Commit-Queue: Maxim Kolosovskiy <kolos@chromium.org>
Reviewed-by: Vadym Doroshenko <dvadym@chromium.org>
Cr-Commit-Position: refs/heads/master@{#500899}
[modify] https://crrev.com/909f27dd19e54dd99eb54a3151570e653a5e3cef/chrome/renderer/autofill/password_autofill_agent_browsertest.cc
[modify] https://crrev.com/909f27dd19e54dd99eb54a3151570e653a5e3cef/components/autofill/content/renderer/password_form_conversion_utils.cc
[modify] https://crrev.com/909f27dd19e54dd99eb54a3151570e653a5e3cef/components/autofill/content/renderer/password_form_conversion_utils_browsertest.cc

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0d04c1eb92d29fb5087d5bf26bfb8404af1429a7

commit 0d04c1eb92d29fb5087d5bf26bfb8404af1429a7
Author: Irmak Kavasoglu <irmakk@google.com>
Date: Mon Sep 11 14:47:48 2017

Other possible passwords now contains all possible passwords

The other_possible_passwords variable contained all possible passwords
except for the main one (the password_value in the pending_credentials).
This cl makes other possible passwords include the main password as well.

Bug: 753806
Change-Id: I3512e0d73babfc255fa3cec5f75675d65e33ce0c
Reviewed-on: https://chromium-review.googlesource.com/660077
Commit-Queue: Irmak Kavasoğlu <irmakk@google.com>
Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#500913}
[modify] https://crrev.com/0d04c1eb92d29fb5087d5bf26bfb8404af1429a7/chrome/browser/password_manager/password_manager_browsertest.cc
[modify] https://crrev.com/0d04c1eb92d29fb5087d5bf26bfb8404af1429a7/chrome/browser/ui/views/passwords/manage_passwords_bubble_view.cc
[modify] https://crrev.com/0d04c1eb92d29fb5087d5bf26bfb8404af1429a7/components/autofill/content/renderer/password_form_conversion_utils.cc
[modify] https://crrev.com/0d04c1eb92d29fb5087d5bf26bfb8404af1429a7/components/autofill/content/renderer/password_form_conversion_utils_browsertest.cc
[modify] https://crrev.com/0d04c1eb92d29fb5087d5bf26bfb8404af1429a7/components/autofill/core/common/password_form.h

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c3cb92129e6c392e5c17f275bc36797cee856d96

commit c3cb92129e6c392e5c17f275bc36797cee856d96
Author: Irmak Kavasoglu <irmakk@google.com>
Date: Mon Sep 11 19:19:13 2017

Keeping the selection after edit mode is turned off

Currently, if user selects a value from the password dropdown and exits
the editing mode, the slection is lost. This cl keeps the selection and
updates the password field to the selected password value.

This cl does not include saving the selected password. It is only for
ui part.

Bug: 753806
Change-Id: If1a254dca746776ab90bfe060bf0ed2218a223ff
Reviewed-on: https://chromium-review.googlesource.com/657640
Commit-Queue: Irmak Kavasoğlu <irmakk@google.com>
Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#500993}
[modify] https://crrev.com/c3cb92129e6c392e5c17f275bc36797cee856d96/chrome/browser/ui/passwords/manage_passwords_bubble_model.cc
[modify] https://crrev.com/c3cb92129e6c392e5c17f275bc36797cee856d96/chrome/browser/ui/passwords/manage_passwords_bubble_model.h
[modify] https://crrev.com/c3cb92129e6c392e5c17f275bc36797cee856d96/chrome/browser/ui/views/passwords/manage_passwords_bubble_view.cc

A video demonstrating the eye icon functionality.

Deleted: eyeicon.avi 13.3 MB

eyeicon.avi 13.3 MB Download

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/34ae69b5023bb06e80890d4d59b64275c82c73d5

commit 34ae69b5023bb06e80890d4d59b64275c82c73d5
Author: Irmak Kavasoglu <irmakk@google.com>
Date: Tue Sep 12 17:01:57 2017

Password selection works on linux platform

This cl completes the password selection feature functionality for
linux/chromeos/windows platforms. Now we are actually saving the
selected password when user clicks save button.

Bug: 753806
Change-Id: Ia61c2f49bf43b4c7fc456cb99ed0eb5582e89df5
Reviewed-on: https://chromium-review.googlesource.com/663317
Commit-Queue: Irmak Kavasoğlu <irmakk@google.com>
Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#501315}
[modify] https://crrev.com/34ae69b5023bb06e80890d4d59b64275c82c73d5/chrome/browser/password_manager/password_manager_test_base.cc
[modify] https://crrev.com/34ae69b5023bb06e80890d4d59b64275c82c73d5/chrome/browser/ui/cocoa/passwords/save_pending_password_view_controller_unittest.mm
[modify] https://crrev.com/34ae69b5023bb06e80890d4d59b64275c82c73d5/chrome/browser/ui/passwords/manage_passwords_bubble_model.cc
[modify] https://crrev.com/34ae69b5023bb06e80890d4d59b64275c82c73d5/chrome/browser/ui/passwords/manage_passwords_bubble_model_unittest.cc
[modify] https://crrev.com/34ae69b5023bb06e80890d4d59b64275c82c73d5/chrome/browser/ui/passwords/manage_passwords_ui_controller.cc
[modify] https://crrev.com/34ae69b5023bb06e80890d4d59b64275c82c73d5/chrome/browser/ui/passwords/manage_passwords_ui_controller.h
[modify] https://crrev.com/34ae69b5023bb06e80890d4d59b64275c82c73d5/chrome/browser/ui/passwords/manage_passwords_ui_controller_mock.h
[modify] https://crrev.com/34ae69b5023bb06e80890d4d59b64275c82c73d5/chrome/browser/ui/passwords/manage_passwords_ui_controller_unittest.cc
[modify] https://crrev.com/34ae69b5023bb06e80890d4d59b64275c82c73d5/chrome/browser/ui/passwords/passwords_model_delegate.h
[modify] https://crrev.com/34ae69b5023bb06e80890d4d59b64275c82c73d5/chrome/browser/ui/passwords/passwords_model_delegate_mock.h
[modify] https://crrev.com/34ae69b5023bb06e80890d4d59b64275c82c73d5/components/password_manager/core/browser/password_form_manager.cc
[modify] https://crrev.com/34ae69b5023bb06e80890d4d59b64275c82c73d5/components/password_manager/core/browser/password_form_manager.h
[modify] https://crrev.com/34ae69b5023bb06e80890d4d59b64275c82c73d5/components/password_manager/core/browser/password_form_manager_unittest.cc

Thanks Irmak. The video looks good.

However, I still think the passwords should be listed in the selector in the same order as they appeared on the form.

I agree, I will work on that and submit another cl for it hopefully today ^^

irmakk@ left. CL for #20 is here https://chromium-review.googlesource.com/c/chromium/src/+/663863

+vasilii
please coordinate internally, who takes care of which pieces. Thanks.

I'll add a combobox on Mac.

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/18416c62a372cf7ddf5bb0f426e3ab4b7454c545

commit 18416c62a372cf7ddf5bb0f426e3ab4b7454c545
Author: Maxim Kolosovskiy <kolos@chromium.org>
Date: Mon Sep 18 22:14:06 2017

Preserve order of passwords in the password selector

This is a minor change. I have changed the local other_possible_passwords
from set to vector, to be able to keep the order of the passwords
within a page. This change is for password selection feature.

This CL was started by irmakk@ in https://chromium-review.googlesource.com/c/chromium/src/+/663863. 

Bug: 753806
Change-Id: Iee9e801dcfe82f1ad47c46d69ff754a00e72431c
Reviewed-on: https://chromium-review.googlesource.com/671225
Commit-Queue: Maxim Kolosovskiy <kolos@chromium.org>
Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#502691}
[modify] https://crrev.com/18416c62a372cf7ddf5bb0f426e3ab4b7454c545/components/autofill/content/renderer/password_form_conversion_utils.cc
[modify] https://crrev.com/18416c62a372cf7ddf5bb0f426e3ab4b7454c545/components/autofill/content/renderer/password_form_conversion_utils_browsertest.cc

I can take care about general logic and Linux/Windows/ChromeOS stuff. 

These CL should be finished
https://chromium-review.googlesource.com/c/chromium/src/+/664890
https://chromium-review.googlesource.com/c/chromium/src/+/663360

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d97b9461be5fade45144a5e17dfb6adcf0d05723

commit d97b9461be5fade45144a5e17dfb6adcf0d05723
Author: Maxim Kolosovskiy <kolos@chromium.org>
Date: Tue Sep 19 20:10:39 2017

[Password Manager] Add flag for password selector and eye icon

Bug: 753806
Change-Id: I9c735122920dbc20a543125d9fa3fd0dc076845a
Reviewed-on: https://chromium-review.googlesource.com/672823
Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org>
Commit-Queue: Maxim Kolosovskiy <kolos@chromium.org>
Cr-Commit-Position: refs/heads/master@{#502932}
[modify] https://crrev.com/d97b9461be5fade45144a5e17dfb6adcf0d05723/chrome/browser/about_flags.cc
[modify] https://crrev.com/d97b9461be5fade45144a5e17dfb6adcf0d05723/chrome/browser/flag_descriptions.cc
[modify] https://crrev.com/d97b9461be5fade45144a5e17dfb6adcf0d05723/chrome/browser/flag_descriptions.h
[modify] https://crrev.com/d97b9461be5fade45144a5e17dfb6adcf0d05723/tools/metrics/histograms/enums.xml

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2eec96d99e63985ace97a70114d322b7b35b759f

commit 2eec96d99e63985ace97a70114d322b7b35b759f
Author: Vasilii Sukhanov <vasilii@chromium.org>
Date: Fri Sep 22 11:54:33 2017

Eye icon works in the save bubble on Views.

The eye icon of the password selection feature is fully functional now.
Screen video is added to the bug.

Bug: 753806
Change-Id: I3129b89aa8b3a3305aae56005171735b6fe98835
Reviewed-on: https://chromium-review.googlesource.com/677402
Reviewed-by: Tatiana Gornak <melandory@chromium.org>
Commit-Queue: Vasilii Sukhanov <vasilii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#503717}
[modify] https://crrev.com/2eec96d99e63985ace97a70114d322b7b35b759f/chrome/browser/ui/views/passwords/manage_password_items_view.cc
[modify] https://crrev.com/2eec96d99e63985ace97a70114d322b7b35b759f/chrome/browser/ui/views/passwords/manage_password_items_view.h
[modify] https://crrev.com/2eec96d99e63985ace97a70114d322b7b35b759f/chrome/browser/ui/views/passwords/manage_passwords_bubble_view.cc

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/79a0cd8c97666817afc1de8f5a9836610562f0c3

commit 79a0cd8c97666817afc1de8f5a9836610562f0c3
Author: Irmak Kavasoglu <irmakkavasoglu@gmail.com>
Date: Fri Sep 22 12:56:55 2017

Enabled password selection by default

This cl enables the password selection feature for the password manager
by default.

Bug: 753806
Change-Id: Iad7e968f4e6366742d8df72f8fad09e28bf7d472
Reviewed-on: https://chromium-review.googlesource.com/677459
Commit-Queue: Vasilii Sukhanov <vasilii@chromium.org>
Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#503721}
[modify] https://crrev.com/79a0cd8c97666817afc1de8f5a9836610562f0c3/AUTHORS
[modify] https://crrev.com/79a0cd8c97666817afc1de8f5a9836610562f0c3/components/password_manager/core/common/password_manager_features.cc

Timer for eye icon is required.

One more must-have thing:  Issue 769237 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/40f1676bd7e00f3e91799cbd60d1f267d8a63f91

commit 40f1676bd7e00f3e91799cbd60d1f267d8a63f91
Author: Maxim Kolosovskiy <kolos@chromium.org>
Date: Thu Sep 28 12:16:16 2017

[Password Manager] Introduce strings for new layout of save prompt

New layout introduces two labels: "Username" and "Password". 

Bug:  769666 , 753806
Change-Id: I04adfef7da32a6c03697d83b57ef764cf31a3496
Reviewed-on: https://chromium-review.googlesource.com/690114
Commit-Queue: Maxim Kolosovskiy <kolos@chromium.org>
Reviewed-by: Jochen Eisinger <jochen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#504973}
[modify] https://crrev.com/40f1676bd7e00f3e91799cbd60d1f267d8a63f91/chrome/app/generated_resources.grd

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/237e14beeb60edc2c664c013486806772f6c362c

commit 237e14beeb60edc2c664c013486806772f6c362c
Author: Irmak Kavasoglu <irmakkavasoglu@gmail.com>
Date: Thu Oct 05 19:29:11 2017

Renamed |other_possible_passwords| to |all_possible_passwords|

Other possible passwords variable of the password form is currently
holding all possible passwords. See this cl:
https://chromium-review.googlesource.com/c/chromium/src/+/660077

This cl renames the variable accordingly.

Bug: 753806
Change-Id: Id6e19b876392039704d1f23a8b42d1ca18e79ea6
Reviewed-on: https://chromium-review.googlesource.com/693014
Commit-Queue: Maxim Kolosovskiy <kolos@chromium.org>
Reviewed-by: Mike West <mkwst@chromium.org>
Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org>
Reviewed-by: Maxim Kolosovskiy <kolos@chromium.org>
Cr-Commit-Position: refs/heads/master@{#506823}
[modify] https://crrev.com/237e14beeb60edc2c664c013486806772f6c362c/chrome/browser/password_manager/password_manager_browsertest.cc
[modify] https://crrev.com/237e14beeb60edc2c664c013486806772f6c362c/chrome/browser/ui/views/passwords/manage_passwords_bubble_view.cc
[modify] https://crrev.com/237e14beeb60edc2c664c013486806772f6c362c/components/autofill/content/common/autofill_param_traits_macros.h
[modify] https://crrev.com/237e14beeb60edc2c664c013486806772f6c362c/components/autofill/content/common/autofill_types.mojom
[modify] https://crrev.com/237e14beeb60edc2c664c013486806772f6c362c/components/autofill/content/common/autofill_types_struct_traits.cc
[modify] https://crrev.com/237e14beeb60edc2c664c013486806772f6c362c/components/autofill/content/common/autofill_types_struct_traits.h
[modify] https://crrev.com/237e14beeb60edc2c664c013486806772f6c362c/components/autofill/content/common/autofill_types_struct_traits_unittest.cc
[modify] https://crrev.com/237e14beeb60edc2c664c013486806772f6c362c/components/autofill/content/renderer/password_form_conversion_utils.cc
[modify] https://crrev.com/237e14beeb60edc2c664c013486806772f6c362c/components/autofill/content/renderer/password_form_conversion_utils_browsertest.cc
[modify] https://crrev.com/237e14beeb60edc2c664c013486806772f6c362c/components/autofill/core/common/password_form.h
[modify] https://crrev.com/237e14beeb60edc2c664c013486806772f6c362c/components/password_manager/core/browser/password_form_manager.cc
[modify] https://crrev.com/237e14beeb60edc2c664c013486806772f6c362c/components/password_manager/core/browser/password_form_manager_unittest.cc

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0df1998e9c61734616c8b07ff4d44feccd45f9fb

commit 0df1998e9c61734616c8b07ff4d44feccd45f9fb
Author: Maxim Kolosovskiy <kolos@chromium.org>
Date: Fri Oct 06 06:43:27 2017

[Password Manager] Don't change eye icon on hover

On hover, the eye icon in save prompt becomes black. Otherwise, it is gray which looks disabled. Let the eye icon look the same.

Bug: 753806, 770049 
Change-Id: I4de84d6b8c9b7d8e9036688922fb18b2bff0727b
Reviewed-on: https://chromium-review.googlesource.com/690479
Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org>
Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
Commit-Queue: Maxim Kolosovskiy <kolos@chromium.org>
Cr-Commit-Position: refs/heads/master@{#506998}
[rename] https://crrev.com/0df1998e9c61734616c8b07ff4d44feccd45f9fb/chrome/app/theme/default_100_percent/cros/hide_password.png
[rename] https://crrev.com/0df1998e9c61734616c8b07ff4d44feccd45f9fb/chrome/app/theme/default_100_percent/cros/show_password.png
[rename] https://crrev.com/0df1998e9c61734616c8b07ff4d44feccd45f9fb/chrome/app/theme/default_200_percent/cros/hide_password.png
[rename] https://crrev.com/0df1998e9c61734616c8b07ff4d44feccd45f9fb/chrome/app/theme/default_200_percent/cros/show_password.png
[modify] https://crrev.com/0df1998e9c61734616c8b07ff4d44feccd45f9fb/chrome/app/theme/theme_resources.grd
[modify] https://crrev.com/0df1998e9c61734616c8b07ff4d44feccd45f9fb/chrome/browser/ui/cocoa/passwords/passwords_list_view_controller.mm
[modify] https://crrev.com/0df1998e9c61734616c8b07ff4d44feccd45f9fb/chrome/browser/ui/views/passwords/manage_passwords_bubble_view.cc

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d76f69e404111092958a4f5086cdd0e18833f33b

commit d76f69e404111092958a4f5086cdd0e18833f33b
Author: Irmak Kavasoglu <irmakkavasoglu@gmail.com>
Date: Mon Oct 09 08:48:39 2017

Added function AllPossiblePasswordsToString

This cl creates the function to serialize all possible passwords
variable in password_form. The function is used when converting
password form to JSON. Also added field check for == operator.

Bug: 753806
Change-Id: I4fcc95a334089bc663c27cc6403a165357d6fde8
Reviewed-on: https://chromium-review.googlesource.com/706788
Commit-Queue: Vasilii Sukhanov <vasilii@chromium.org>
Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#507340}
[modify] https://crrev.com/d76f69e404111092958a4f5086cdd0e18833f33b/components/autofill/content/renderer/password_form_conversion_utils_browsertest.cc
[modify] https://crrev.com/d76f69e404111092958a4f5086cdd0e18833f33b/components/autofill/core/common/password_form.cc
[modify] https://crrev.com/d76f69e404111092958a4f5086cdd0e18833f33b/components/autofill/core/common/password_form.h

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3cd5c31543289280b3303b756f3021389713e032

commit 3cd5c31543289280b3303b756f3021389713e032
Author: Maxim Kolosovskiy <kolos@chromium.org>
Date: Mon Oct 09 13:23:01 2017

[Password Manager] Set accessible names for username field and password selector in a prompt

Bug: 753806
Change-Id: Ie80f98bc455e3f7a9882c0c91d36ac626ff8b272
Reviewed-on: https://chromium-review.googlesource.com/707012
Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org>
Commit-Queue: Maxim Kolosovskiy <kolos@chromium.org>
Cr-Commit-Position: refs/heads/master@{#507365}
[modify] https://crrev.com/3cd5c31543289280b3303b756f3021389713e032/chrome/browser/ui/views/passwords/manage_password_items_view.cc
[modify] https://crrev.com/3cd5c31543289280b3303b756f3021389713e032/chrome/browser/ui/views/passwords/manage_passwords_bubble_view.cc

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/cb22bad2eb6379beb3c9c2ca0ac2aec7eed63dcc

commit cb22bad2eb6379beb3c9c2ca0ac2aec7eed63dcc
Author: Vasilii Sukhanov <vasilii@chromium.org>
Date: Tue Oct 10 11:33:44 2017

Implement password selection and viewing on Mac.

The CL changes the layout of the password bubble on Mac according to the mocks.
The password selection combobox and eye icon are now fully functional.

Bug:  769666 ,753806, 768781 
Change-Id: Iac6f6186f07bad3da2e5f66407ddc782b61f1842
Reviewed-on: https://chromium-review.googlesource.com/708261
Reviewed-by: Tatiana Gornak <melandory@chromium.org>
Commit-Queue: Vasilii Sukhanov <vasilii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#507639}
[modify] https://crrev.com/cb22bad2eb6379beb3c9c2ca0ac2aec7eed63dcc/chrome/browser/ui/cocoa/passwords/base_passwords_controller_test.mm
[modify] https://crrev.com/cb22bad2eb6379beb3c9c2ca0ac2aec7eed63dcc/chrome/browser/ui/cocoa/passwords/password_item_views.h
[modify] https://crrev.com/cb22bad2eb6379beb3c9c2ca0ac2aec7eed63dcc/chrome/browser/ui/cocoa/passwords/passwords_bubble_utils.h
[modify] https://crrev.com/cb22bad2eb6379beb3c9c2ca0ac2aec7eed63dcc/chrome/browser/ui/cocoa/passwords/passwords_bubble_utils.mm
[modify] https://crrev.com/cb22bad2eb6379beb3c9c2ca0ac2aec7eed63dcc/chrome/browser/ui/cocoa/passwords/passwords_list_view_controller.mm
[modify] https://crrev.com/cb22bad2eb6379beb3c9c2ca0ac2aec7eed63dcc/chrome/browser/ui/cocoa/passwords/save_pending_password_view_controller.h
[modify] https://crrev.com/cb22bad2eb6379beb3c9c2ca0ac2aec7eed63dcc/chrome/browser/ui/cocoa/passwords/save_pending_password_view_controller.mm
[modify] https://crrev.com/cb22bad2eb6379beb3c9c2ca0ac2aec7eed63dcc/chrome/browser/ui/cocoa/passwords/save_pending_password_view_controller_unittest.mm