New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 753770 link

Starred by 1 user
Status: Verified
Owner:
gambard@chromium.org
Closed: Aug 2017
Cc:
ios-bugs@chromium.org
█ ramyan@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 3
Type: Bug



Sign in to add a comment

Fake omnibox width is not updated on iPad's rotation

Project Member Reported by gambard@chromium.org, Aug 9 2017 
Device: iPad

What steps will reproduce the problem?
(1) Open ContentSuggestions on portrait
(2) Rotate the iPad to landscape

What is the expected result?
The omnibox width should increase (as seen when opening a new tab).

What happens instead?
The omnibox has the same width as portrait.

Comment 1 by gambard@chromium.org, Aug 9 2017

Labels: hotlist-ContentSuggestions
Project Member

Comment 2 by bugdroid1@chromium.org, Aug 10 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8891434cbfd1e0e00e1ede0881a8ad606f5c714e

commit 8891434cbfd1e0e00e1ede0881a8ad606f5c714e
Author: gambard <gambard@chromium.org>
Date: Thu Aug 10 12:10:11 2017

Change omnibox width upon rotation

When the device is rotated, the omnibox width might change.
This CL ensures the omnibox has the new width.

Bug:  753770 
Change-Id: Ib58b826bfc86a9063a615351ebe0a03f1000620a
Reviewed-on: https://chromium-review.googlesource.com/608229
Reviewed-by: Jean-François Geyelin <jif@chromium.org>
Reviewed-by: Mark Cogan <marq@chromium.org>
Commit-Queue: Gauthier Ambard <gambard@chromium.org>
Cr-Commit-Position: refs/heads/master@{#493363}
[modify] https://crrev.com/8891434cbfd1e0e00e1ede0881a8ad606f5c714e/ios/chrome/browser/content_suggestions/content_suggestions_header_view_controller.mm
[modify] https://crrev.com/8891434cbfd1e0e00e1ede0881a8ad606f5c714e/ios/chrome/browser/ui/content_suggestions/content_suggestions_header_controlling.h
[modify] https://crrev.com/8891434cbfd1e0e00e1ede0881a8ad606f5c714e/ios/chrome/browser/ui/content_suggestions/content_suggestions_header_synchronizer.mm
[modify] https://crrev.com/8891434cbfd1e0e00e1ede0881a8ad606f5c714e/ios/chrome/browser/ui/content_suggestions/content_suggestions_header_synchronizer_unittest.mm
[modify] https://crrev.com/8891434cbfd1e0e00e1ede0881a8ad606f5c714e/ios/chrome/browser/ui/content_suggestions/content_suggestions_header_synchronizing.h
[modify] https://crrev.com/8891434cbfd1e0e00e1ede0881a8ad606f5c714e/ios/chrome/browser/ui/content_suggestions/content_suggestions_view_controller.mm
[modify] https://crrev.com/8891434cbfd1e0e00e1ede0881a8ad606f5c714e/ios/clean/chrome/browser/ui/ntp/ntp_home_header_view_controller.mm

Comment 3 by gambard@chromium.org, Aug 10 2017

Status: Fixed (was: Assigned)

Comment 4 by srikanthg@chromium.org, Aug 15 2017

Status: Verified (was: Fixed)
Omnibox width has changed after rotating the device from portrait to landscape mode.

Verified on M62.0.3086.0 canary
Device: iPad Pro
iOS: 10.3.3
►

Sign in to add a comment