New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 753734 link

Starred by 1 user
Status: Fixed
Owner:
olivierrobin@chromium.org
Closed: Aug 2017
Cc:
█ cma...@chromium.org
justincohen@chromium.org
ios-bugs@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 2
Type: Bug



Sign in to add a comment

DCHECK hit in iOS11 beta 5 on opening external URL

Project Member Reported by olivierrobin@chromium.org, Aug 9 2017 
It appears that openURL is now called before applicationDidBecomeActive like with iOS10.
Remove the DCHECK.

This DCHECK was introduced as a fix for cb/749037

Note: I did not check if all path are restored on the iOS10 behavior, so keeping the fix from cb/749037 and just removing the DCHECK seems safer.
Project Member

Comment 1 by bugdroid1@chromium.org, Aug 9 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/14750f84300a01d87bc3144363733da3d97a745e

commit 14750f84300a01d87bc3144363733da3d97a745e
Author: Olivier Robin <olivierrobin@chromium.org>
Date: Wed Aug 09 10:09:09 2017

Remove DCHECK in OpenURL

On iOS11 beta5, it is possible for the application to be inactive when
calling openURL.
Remove the DCHECK.

Bug:  753734 
Change-Id: I627038932c5d2359c3c5199234defddf035101a3
Reviewed-on: https://chromium-review.googlesource.com/607871
Reviewed-by: Mark Cogan <marq@chromium.org>
Commit-Queue: Olivier Robin <olivierrobin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#492933}
[modify] https://crrev.com/14750f84300a01d87bc3144363733da3d97a745e/ios/chrome/app/main_application_delegate.mm

Comment 2 by olivierrobin@chromium.org, Aug 10 2017

Labels: ReleaseBlock-Stable M-61 Merge-Request-61
Status: Fixed (was: Started)
Project Member

Comment 3 by sheriffbot@chromium.org, Aug 10 2017

Labels: -Merge-Request-61 Merge-Review-61 Hotlist-Merge-Review
This bug requires manual review: Less than 22 days to go before AppStore submit on M61
Please contact the milestone owner if you have questions.
Owners: amineer@(Android), cmasso@(iOS), ketakid@(ChromeOS), govind@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 4 by cma...@chromium.org, Aug 11 2017

Labels: -Hotlist-Merge-Review -Merge-Review-61 Merge-Approved-61
Merge approved for M61 branch 3163 once local compilation / verification of the fix on that branch is complete.
Project Member

Comment 5 by sheriffbot@chromium.org, Aug 15 2017

Cc: cma...@chromium.org
This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible!

If all merges have been completed, please remove any remaining Merge-Approved labels from this issue.

Thanks for your time! To disable nags, add the Disable-Nags label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 6 by sheriffbot@chromium.org, Aug 18 2017 

This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible!

If all merges have been completed, please remove any remaining Merge-Approved labels from this issue.

Thanks for your time! To disable nags, add the Disable-Nags label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 7 by olivierrobin@chromium.org, Dec 3

Labels: -Merge-Approved-61 Merge-Merged-61
►

Sign in to add a comment