New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 753732 link

Starred by 1 user
Status: Verified
Owner:
gambard@chromium.org
Closed: Aug 2017
Cc:
ios-bugs@chromium.org
█ ramyan@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 3
Type: Bug



Sign in to add a comment

ContentSuggestions fake omnibox does not take full width on landscape

Project Member Reported by gambard@chromium.org, Aug 9 2017 
What steps will reproduce the problem?
(1) Open a NTP
(2) Change orientation to landscape
(3) Scroll down

What is the expected result?
The omnibox should take the full width of the screen.

What happens instead?
There is a small padding on both sides
Project Member

Comment 1 by bugdroid1@chromium.org, Aug 9 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/05179d103117b983eaa87585d35943f299c3c3fb

commit 05179d103117b983eaa87585d35943f299c3c3fb
Author: gambard <gambard@chromium.org>
Date: Wed Aug 09 10:02:32 2017

Fix bugs in ContentSuggestions

When the fake omnibox was pinned to top on landscape, it did not take
the full screen width.
This CL fixes it by removing the padding on the inset for the header
section.
It also fixes a bug where the command handler for the header controller
was not set.

Bug:  753732 
Change-Id: I5ffe272f7d1b02223f3e9dac85cad79ae52b61fa
Reviewed-on: https://chromium-review.googlesource.com/607890
Commit-Queue: Gauthier Ambard <gambard@chromium.org>
Reviewed-by: Elodie Banel <lod@chromium.org>
Cr-Commit-Position: refs/heads/master@{#492930}
[modify] https://crrev.com/05179d103117b983eaa87585d35943f299c3c3fb/ios/chrome/browser/content_suggestions/content_suggestions_coordinator.mm
[modify] https://crrev.com/05179d103117b983eaa87585d35943f299c3c3fb/ios/chrome/browser/ui/content_suggestions/content_suggestions_view_controller.mm

Comment 2 by mvanouwe...@chromium.org, Aug 9 2017

Labels: zine-triaged

Comment 3 by gambard@chromium.org, Aug 9 2017

Status: Fixed (was: Assigned)

Comment 4 by shbarezer@chromium.org, Aug 15 2017

Status: Verified (was: Fixed)
Verified in 62.0.3186.0 canary, iPhone6 iOS 10.3.3, iPhone7 iOS11

ContentSuggestions fake omnibox is take full width on landscape.
Looks good.
►

Sign in to add a comment