New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 753726 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
Closed: Mar 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Android , Windows , Chrome , Mac
Pri: 2
Type: Bug



Sign in to add a comment

Merge REMB-candidates fix to M61.

Project Member Reported by eladalon@chromium.org, Aug 9 2017

Issue description

Please merge the CL attached to webrtc:7860 into M61. It fixes a bug with interoperation between Google Chrome and Microsoft Edge.
 
Arihant, perhaps you could add a few details that would make it more likely for this to be approved?
Project Member

Comment 2 by sheriffbot@chromium.org, Aug 9 2017

Labels: -Merge-Request-61 Merge-Review-61 Hotlist-Merge-Review
This bug requires manual review: M61 has already been promoted to the beta branch, so this requires manual review
Please contact the milestone owner if you have questions.
Owners: amineer@(Android), cmasso@(iOS), ketakid@(ChromeOS), govind@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Pls apply appropriate OSs. Thank you.
Starting with M60, the SDP had REMB rtcp flag enabled only for video (as expected) but the REMB packets had audio SSRC instead of video SSRC. This breaks the interop scenario for Edge and Skype affecting the bandwidth estimation components suffering in Video quality. I verified the fix with M62 canary and it seems to have fixed the problem.

Comment 5 by holmer@chromium.org, Aug 10 2017

Labels: OS-Chrome OS-Linux OS-Mac OS-Windows
Thanks, Arihant and Stefan.
Labels: OS-Android

Comment 8 by gov...@chromium.org, Aug 10 2017

Before we approve merge to M61, please answer followings:
* Is this M61 regression? Is it critical?
* Is the change well baked/verified in Canary, having enough automation tests coverage and safe to merge to M61?
* Any other important details to justify the merge.

Please note M61 is already in Beta, so merge bar is very high. Thank you.

Comment 9 by eladalon@webrtc.org, Aug 11 2017

* This regression was introduced in M60.
* The change has been baking in dev-channel for 3 days now.
* Arihant has confirmed that the change solves the bug.
* We (Stefan and I) have verified that REMB still works as expected in Chrome to Chrome calls.
Cc: abdulsyed@chromium.org
Labels: -Merge-Review-61 Merge-Rejected-61
Thank you  eladalon@.
As this is not M61 regression and P2, I'm rejecting merge to M61. Please let me know if there is any concern here.

+abdulsyed@ as FYI
Owner: holmer@chromium.org
Status: Fixed (was: Assigned)

Sign in to add a comment