New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 753700 link

Starred by 6 users

Issue metadata

Status: Fixed
Owner:
Closed: Aug 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 1
Type: Bug-Regression


Show other hotlists

Hotlists containing this issue:
Hotlist-1


Sign in to add a comment

PDF not printing correctly, preview is fine

Reported by t...@anoebis.be, Aug 9 2017

Issue description

UserAgent: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/60.0.3112.90 Safari/537.36

Steps to reproduce the problem:
1. Open PDF
2. Preview looks ok
3. Print: some parts are missing

What is the expected behavior?

What went wrong?
Some parts of the page are missing. See attached files. Printing from Acrobat Reader works fine. An example of the PDF is attached as well.

Did this work before? Yes Not sure - users started calling yesterday, so I guess the previous version was ok

Chrome version: 60.0.3112.90  Channel: stable
OS Version: 10.0
Flash Version:
 
bad print from chrome.jpg
906 KB View Download
good print from acrobat reader.jpg
1.0 MB View Download
testfile.PDF
85.9 KB Download
Components: Internals>Plugins>PDF
Labels: -Pri-2 Pri-1
Status: Available (was: Unconfirmed)
Reproduced and confirmed this is a regression from 59 to 60. Happened on Windows 7, did not happen on Linux.
Cc: weili@chromium.org
Components: Internals>Printing
Owner: thestig@chromium.org
Can confirm issue is related to v60. We are experiencing the same with embedded images on PDF and printed from Chrome.

Works fine v58 and v59. No image on v60.


test.pdf
1.5 MB Download
Owner: rbpotter@chromium.org
Status: Assigned (was: Available)
Project Member

Comment 6 by bugdroid1@chromium.org, Aug 10 2017

The following revision refers to this bug:
  https://pdfium.googlesource.com/pdfium/+/0f6ceba6bf6a966c1946aec2ff985dc2728fd71b

commit 0f6ceba6bf6a966c1946aec2ff985dc2728fd71b
Author: rbpotter <rbpotter@chromium.org>
Date: Thu Aug 10 21:36:19 2017

Temporarily disable image mask individual rendering

Bug:  chromium:753700 
Change-Id: I28589739f4258fa62f3f853aa91bc6cffd7d96ba
Reviewed-on: https://pdfium-review.googlesource.com/10611
Commit-Queue: Rebekah Potter <rbpotter@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>

[modify] https://crrev.com/0f6ceba6bf6a966c1946aec2ff985dc2728fd71b/fpdfsdk/fpdfview.cpp

Cc: brajkumar@chromium.org rbpotter@chromium.org
 Issue 755038  has been merged into this issue.
Should be fixed on the latest Canary (62.0.3185.0). Both the PDF examples printed correctly here on Windows 10 with that build. If anyone still has this issue on Canary, please update so we can investigate what might still be going wrong.

Comment 9 by t...@anoebis.be, Aug 16 2017

I installed Canary and tested with a couple of our PDFs and it seems to be fixed indeed. 
Project Member

Comment 10 by bugdroid1@chromium.org, Aug 17 2017

The following revision refers to this bug:
  https://pdfium.googlesource.com/pdfium/+/8d7672e941fa58326c4c6aeac47418e9b36527e9

commit 8d7672e941fa58326c4c6aeac47418e9b36527e9
Author: rbpotter <rbpotter@chromium.org>
Date: Thu Aug 17 00:06:48 2017

Fix some issues with individual image mask rendering

Re-enable individual image mask rendering to improve spool sizes, with
bug fixes and improvements:
- Fix bug with missing images by ensuring all masks are recorded
- Fix printing to landscape paper sizes
- Improve spool sizes by processing the location of the masks in the
progressive renderer when rendering to the printer instead of needlessly
fully rendering them (they will be rendered as bitmaps anyway).

Bug:  chromium:753700 
Change-Id: I86bdcce9f10855274c56ba2ddae2c2522b36426d
Reviewed-on: https://pdfium-review.googlesource.com/11115
Commit-Queue: Rebekah Potter <rbpotter@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>

[modify] https://crrev.com/8d7672e941fa58326c4c6aeac47418e9b36527e9/core/fpdfapi/render/cpdf_progressiverenderer.cpp
[modify] https://crrev.com/8d7672e941fa58326c4c6aeac47418e9b36527e9/core/fpdfapi/page/cpdf_streamcontentparser.cpp
[modify] https://crrev.com/8d7672e941fa58326c4c6aeac47418e9b36527e9/core/fpdfapi/render/cpdf_renderstatus.h
[modify] https://crrev.com/8d7672e941fa58326c4c6aeac47418e9b36527e9/fpdfsdk/fpdfview.cpp
[modify] https://crrev.com/8d7672e941fa58326c4c6aeac47418e9b36527e9/core/fpdfapi/render/cpdf_renderstatus.cpp

Project Member

Comment 11 by bugdroid1@chromium.org, Aug 23 2017

The following revision refers to this bug:
  https://pdfium.googlesource.com/pdfium/+/77d8317f2e6bb9c75d96390fdf843b86694ba6d2

commit 77d8317f2e6bb9c75d96390fdf843b86694ba6d2
Author: Dan Sinclair <dsinclair@chromium.org>
Date: Wed Aug 23 12:52:19 2017

Verify image returned from AddImage

The ::AddImage call can return a nullptr if there is no stream provided.
This CL adds the missing null check on the returned object when lookikng
at the image.

Bug:  chromium:756418 ,  chromium:753700 
Change-Id: I48032c0f421c8889827540ae91f404ef0f503bfe
Reviewed-on: https://pdfium-review.googlesource.com/11532
Reviewed-by: Rebekah Potter <rbpotter@chromium.org>
Commit-Queue: dsinclair <dsinclair@chromium.org>

[modify] https://crrev.com/77d8317f2e6bb9c75d96390fdf843b86694ba6d2/core/fpdfapi/page/cpdf_streamcontentparser.cpp

Comment 12 by russe...@gmail.com, Aug 25 2017

Can this issue be fixed without Canary? I need this to work without additional software due to these being work computers controlled by corporate IT.
Cc: thestig@chromium.org
Labels: Merge-Request-61
Requesting merge for initial quick-fix CL (comment 6) to 61, which restores the M59 behavior and is a relatively small change that should be straightforward to merge.

We can let the subsequent improvements/fixes (comments 10-11) roll out normally in M62.
Project Member

Comment 14 by sheriffbot@chromium.org, Aug 29 2017

Labels: -Merge-Request-61 Merge-Review-61 Hotlist-Merge-Review
This bug requires manual review: We are only 6 days from stable.
Please contact the milestone owner if you have questions.
Owners: amineer@(Android), cmasso@(iOS), ketakid@(ChromeOS), govind@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Cc: pbomm...@chromium.org
Thank you  rbpotter@.
We already cut M61 Beta RC for release tomorrow. So if merge this fix (cl listed at comment 6) will directly to M61 Stable. This is M60 regression. Can't this wait until M62? 

Can probably wait until M62, as this is only a subset of PDFs and as you mention regressed in M60. Requested as it is obviously a significant issue for users who work with those PDFs regularly, and the change is a revert back to M59 rather than a new addition/fix. However, definitely understand if we are too close to M61 stable at this point.
It should be safe to merge, since we are reverting back to the M59 behavior, which is less efficient in terms of spool job size, but correctness is more important. The merged CL is Windows only and only affects printing.
Labels: -Merge-Review-61 Merge-Approved-61
Approving merge for CL listed at #6 to M61 branch 3163 based on comments #13, #16 and #17. Please merge ASAP. Thank you.
Project Member

Comment 19 by bugdroid1@chromium.org, Aug 30 2017

Labels: -merge-approved-61 merge-merged-3163
The following revision refers to this bug:
  https://pdfium.googlesource.com/pdfium/+/0a49b11d0215c386cafe739c552780542cbe5824

commit 0a49b11d0215c386cafe739c552780542cbe5824
Author: Lei Zhang <thestig@chromium.org>
Date: Wed Aug 30 22:44:56 2017

M61: Temporarily disable image mask individual rendering

Bug:  chromium:753700 
Change-Id: I28589739f4258fa62f3f853aa91bc6cffd7d96ba
Reviewed-on: https://pdfium-review.googlesource.com/10611
Commit-Queue: Rebekah Potter <rbpotter@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
TBR=rbpotter@chromium.org
(cherry picked from commit 0f6ceba6bf6a966c1946aec2ff985dc2728fd71b)
Reviewed-on: https://pdfium-review.googlesource.com/12510
Commit-Queue: Lei Zhang <thestig@chromium.org>

[modify] https://crrev.com/0a49b11d0215c386cafe739c552780542cbe5824/fpdfsdk/fpdfview.cpp

Status: Fixed (was: Assigned)
Merge to M61 in PDFium. On branches, Chrome pulls the latest corresponding PDFium branch, so there's no need for a DEPS roll.
Labels: TE-Verified-M61 TE-Verified-61.0.3163.73
Tested the issue on Windows-10 using chrome latest Beta M61-61.0.3163.73 on Printer-RICOH(MPC3003) by following steps mentioned in the original comment. Observed that PDF print is displaying as expected. Hence adding TE-Verified label.

Please find the screen shot for reference.

Thank you!
753700.pdf
405 KB Download

Sign in to add a comment