Flaky timeout of browser_tests: BrowserTest.WindowOpenClose |
||||
Issue descriptionBrowserTets.WindowOpenClose is timeout on Win7 Tests (dbg). Failing build log: https://build.chromium.org/p/chromium.win/builders/Win7%20Tests%20%28dbg%29%281%29/builds/62159 Flakiness dashboard: https://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=BrowserTest.WindowOpenClose I'm not sure about who is appropriate owner of this. I set jochen@ as an owner since you've re-enabled the test in ancient times (https://crrev.com/95dadd3).
,
Aug 9 2017
Test has been disabled, so let's move the priority down to P2 and remove the flag for sheriff.
,
Aug 9 2017
,
Sep 28 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ef2761dfd88608e475d8baae9b95275e7c51a402 commit ef2761dfd88608e475d8baae9b95275e7c51a402 Author: Jochen Eisinger <jochen@chromium.org> Date: Thu Sep 28 07:45:55 2017 Revert "Disabled flaky browser test on win dbg: BrowserTest.WindowOpenClose" This reverts commit efb9b0e0a6080c30fc6e4082f093524ea19ee41f. Reason for revert: Can't get it to timeout locally, so giving it another try on the bots Original change's description: > Disabled flaky browser test on win dbg: BrowserTest.WindowOpenClose > > BrowserTest.WindowOpenClose is time-out on Win7 Tests (dbg). > > TBR=jochen@chromium.org > > Bug: 753691 > Change-Id: Ia7297809f7bdc54088f4b9d6d9d05c55c2302ee9 > Reviewed-on: https://chromium-review.googlesource.com/607749 > Commit-Queue: Makoto Shimazu <shimazu@chromium.org> > Reviewed-by: Makoto Shimazu <shimazu@chromium.org> > Cr-Commit-Position: refs/heads/master@{#492887} TBR=shimazu@chromium.org,jochen@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 753691 Change-Id: I2dc503042d24f38d6632b995af5d34be1206e994 Reviewed-on: https://chromium-review.googlesource.com/689374 Reviewed-by: Jochen Eisinger <jochen@chromium.org> Commit-Queue: Jochen Eisinger <jochen@chromium.org> Cr-Commit-Position: refs/heads/master@{#504933} [modify] https://crrev.com/ef2761dfd88608e475d8baae9b95275e7c51a402/chrome/browser/ui/browser_browsertest.cc
,
Oct 4 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b03b4b214fce5369825cac36c24e3aafafce0f5d commit b03b4b214fce5369825cac36c24e3aafafce0f5d Author: Jochen Eisinger <jochen@chromium.org> Date: Wed Oct 04 10:31:45 2017 Add debug output for BrowserTest.WindowOpenClose The test flakily times out on Win7 (dbg). Attempt to figure out why. BUG=753691 R=mkwst@chromium.org Change-Id: I31440d7ccbde267f30b54584d65c5fa0834c4a31 Reviewed-on: https://chromium-review.googlesource.com/695161 Reviewed-by: Mike West <mkwst@chromium.org> Commit-Queue: Jochen Eisinger <jochen@chromium.org> Cr-Commit-Position: refs/heads/master@{#506357} [modify] https://crrev.com/b03b4b214fce5369825cac36c24e3aafafce0f5d/chrome/test/data/window.close.html
,
Oct 24 2017
This just failed again, perhaps helpful for your investigation? https://uberchromegw.corp.google.com/i/chromium.win/builders/Win7%20Tests%20%28dbg%29%281%29/builds/64200
,
Oct 25 2017
Sami, Alexander. I'm trying to understand why this timer seems to take very long to get executed / doesn't execute at all (?): https://cs.chromium.org/chromium/src/chrome/test/data/window.close.html?rcl=9bcef7f21b943e423d91dab4104422eff753fd35&l=34 I wonder whether we might consider the main page to be a background page and throttle the timer into oblivion?
,
Oct 26 2017
It's possible. Sounds like you can't repro, but if you figure out a way to do it you could try this flag to get a trace which tells the scheduling state of each window: --trace-startup=*,disabled-by-default-renderer-scheduler --trace-startup-duration=5 (tweak as necessary)
,
Nov 17 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/91d4c55c32a7a2fc775612e50a8763a8d079d70c commit 91d4c55c32a7a2fc775612e50a8763a8d079d70c Author: Jochen Eisinger <jochen@chromium.org> Date: Fri Nov 17 10:22:47 2017 Check whether timer throttling makes BrowserTest.WindowOpenClose flaky BUG=753691 R=skyostil@chromium.org Change-Id: I3cfb174a725cdb659bf220ac392b7584a95131c0 Reviewed-on: https://chromium-review.googlesource.com/775158 Reviewed-by: Mike West <mkwst@chromium.org> Commit-Queue: Jochen Eisinger <jochen@chromium.org> Cr-Commit-Position: refs/heads/master@{#517358} [modify] https://crrev.com/91d4c55c32a7a2fc775612e50a8763a8d079d70c/chrome/browser/ui/browser_browsertest.cc
,
Nov 20 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/525bd4d190ceb070138b4dcce943c3b8f952623a commit 525bd4d190ceb070138b4dcce943c3b8f952623a Author: Jochen Eisinger <jochen@chromium.org> Date: Mon Nov 20 11:13:34 2017 Decrease timeout for BrowserTest.WindowOpenClose BUG=753691 R=mkwst@chromium.org Change-Id: I35261847b2cfa42f5bec2c05960bf331479c8945 Reviewed-on: https://chromium-review.googlesource.com/778322 Reviewed-by: Mike West <mkwst@chromium.org> Commit-Queue: Jochen Eisinger <jochen@chromium.org> Cr-Commit-Position: refs/heads/master@{#517795} [modify] https://crrev.com/525bd4d190ceb070138b4dcce943c3b8f952623a/chrome/test/data/window.close.html
,
Nov 27 2017
i give up, the test appears to be just slow on windows dbg
,
Nov 28 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/2472a91b7dc8c204e5db94ab9aa6646b0f3a0e3c commit 2472a91b7dc8c204e5db94ab9aa6646b0f3a0e3c Author: Jochen Eisinger <jochen@chromium.org> Date: Tue Nov 28 09:36:38 2017 Remove debug code and split WindowOpenClose Maybe it's less prone to time out, if we split it up.. BUG=753691 R=mkwst@chromium.org Change-Id: Ie4cbb6e1312c8ab850b1c552d1127e12f41da523 Reviewed-on: https://chromium-review.googlesource.com/789889 Commit-Queue: Jochen Eisinger <jochen@chromium.org> Reviewed-by: Mike West <mkwst@chromium.org> Cr-Commit-Position: refs/heads/master@{#519625} [modify] https://crrev.com/2472a91b7dc8c204e5db94ab9aa6646b0f3a0e3c/chrome/browser/ui/browser_browsertest.cc [modify] https://crrev.com/2472a91b7dc8c204e5db94ab9aa6646b0f3a0e3c/chrome/test/data/window.close.html
,
Dec 19 2017
so after some more debugging, it looks like the renderer is just busy parsing & loading the three tabs, so it doesn't get around to execute the setTimeout before the entire test times out. Guess I can open the new windows in a separate process and hope that helps.
,
Dec 20 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/967f5be830336258d739d9e15662af980d0d2036 commit 967f5be830336258d739d9e15662af980d0d2036 Author: Jochen Eisinger <jochen@chromium.org> Date: Wed Dec 20 08:12:53 2017 Change BrowserTest.WindowOpenClose to use multiple processes It looks like HTML parsing on win dbg is so slow that the final task that will end the test might get delayed for more than 30s resulting in flaky timeouts. Test this theory by opening the new tabs in new processes, so the tasks has a higher likelihood of being executed on time. R=mkwst@chromium.org BUG=753691 Change-Id: Ia745e531a9a3f01851af199344b6863ca41758fa Reviewed-on: https://chromium-review.googlesource.com/833939 Commit-Queue: Mike West <mkwst@chromium.org> Reviewed-by: Mike West <mkwst@chromium.org> Cr-Commit-Position: refs/heads/master@{#525287} [modify] https://crrev.com/967f5be830336258d739d9e15662af980d0d2036/chrome/browser/ui/browser_browsertest.cc [modify] https://crrev.com/967f5be830336258d739d9e15662af980d0d2036/chrome/test/data/window.close.html
,
Jan 23 2018
,
Jan 23 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e882055a93f01986af5a770cac8b36a18a0fafbb commit e882055a93f01986af5a770cac8b36a18a0fafbb Author: Jochen Eisinger <jochen@chromium.org> Date: Tue Jan 23 20:32:20 2018 Disable BrowserTest.WindowOpenClose3 on win (dbg) BUG=753691 R=ellyjones@chromium.org Change-Id: I474706ba795c9a1951a898b09a54161439372116 Reviewed-on: https://chromium-review.googlesource.com/881173 Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Jochen Eisinger <jochen@chromium.org> Cr-Commit-Position: refs/heads/master@{#531336} [modify] https://crrev.com/e882055a93f01986af5a770cac8b36a18a0fafbb/chrome/browser/ui/browser_browsertest.cc
,
Feb 8 2018
Some small changes to Mac have caused this test to fail on that platform too.
,
Jul 23
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e8df742a7fd06d904c08bdd027dd4fa8b90a065f commit e8df742a7fd06d904c08bdd027dd4fa8b90a065f Author: Jochen Eisinger <jochen@chromium.org> Date: Mon Jul 23 19:25:41 2018 Reenable BrowserTest.WindowOpenClose3 on Mac We no longer should wait for frames in tests, so this should pass again R=ccameron@chromium.org BUG=772576,753691 Change-Id: I9ff676c05fff3fa2d79e1a22edb4ec25ef5e5806 Reviewed-on: https://chromium-review.googlesource.com/1146191 Reviewed-by: ccameron <ccameron@chromium.org> Commit-Queue: Jochen Eisinger <jochen@chromium.org> Cr-Commit-Position: refs/heads/master@{#577219} [modify] https://crrev.com/e8df742a7fd06d904c08bdd027dd4fa8b90a065f/chrome/browser/ui/browser_browsertest.cc |
||||
►
Sign in to add a comment |
||||
Comment 1 by bugdroid1@chromium.org
, Aug 9 2017