New issue
Advanced search Search tips

Issue 753658 link

Starred by 6 users

Issue metadata

Status: Fixed
Owner:
Closed: Jan 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Task
Proj-Servicification

Blocking:
issue 598073
issue 803149



Sign in to add a comment

Move content/network to services/network

Project Member Reported by kinuko@chromium.org, Aug 9 2017

Issue description

Context:
https://groups.google.com/a/chromium.org/forum/#!topic/network-service-dev/pTa5Wyyu3NA

Spreadsheet:
https://docs.google.com/spreadsheets/d/1jlA0eSqI3zxej6DmE0imB7Ti4kIDJ4_hd2tdGW51pW0/edit

We eventually want to move everything that's needed by mojom::URLLoader into /services/network. Before we make bigger file moving we can start with simple enums / structs that are used in content::ResourceRequest (== mojom::URLRequest) there, which actually allows us to simplify a lot of awkward dups.
 

Comment 1 by kinuko@chromium.org, Aug 10 2017

Summary: Move content::Resource{Request,Response} into /services/network (was: Move content::ResourceRequest into /services/network)
Project Member

Comment 2 by bugdroid1@chromium.org, Aug 10 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2ab4ee36ec9392134e83f60f72b29f10a2d89e22

commit 2ab4ee36ec9392134e83f60f72b29f10a2d89e22
Author: Matt Falkenhagen <falken@chromium.org>
Date: Thu Aug 10 10:43:10 2017

Introduce services/network/public/interfaces

This moves blink::mojom::FetchResponseType to services/network, since it'll be
needed here for mojom::URLLoader.  Also, this fixes the flaky build failures
caused by FetchResponseType by declaring the proper deps for it.

Bug: 750883, 746197, 753658
Change-Id: Id3ae4e5a1be24f91bf1a27ffa8f680b86708f77a
Reviewed-on: https://chromium-review.googlesource.com/607737
Commit-Queue: Matt Falkenhagen <falken@chromium.org>
Commit-Queue: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Matt Falkenhagen <falken@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Yutaka Hirano <yhirano@chromium.org>
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Cr-Commit-Position: refs/heads/master@{#493350}
[modify] https://crrev.com/2ab4ee36ec9392134e83f60f72b29f10a2d89e22/content/browser/BUILD.gn
[modify] https://crrev.com/2ab4ee36ec9392134e83f60f72b29f10a2d89e22/content/browser/background_fetch/background_fetch_data_manager.cc
[modify] https://crrev.com/2ab4ee36ec9392134e83f60f72b29f10a2d89e22/content/browser/background_fetch/background_fetch_service_unittest.cc
[modify] https://crrev.com/2ab4ee36ec9392134e83f60f72b29f10a2d89e22/content/browser/cache_storage/cache_storage_cache.cc
[modify] https://crrev.com/2ab4ee36ec9392134e83f60f72b29f10a2d89e22/content/browser/cache_storage/cache_storage_cache_unittest.cc
[modify] https://crrev.com/2ab4ee36ec9392134e83f60f72b29f10a2d89e22/content/browser/cache_storage/cache_storage_manager_unittest.cc
[modify] https://crrev.com/2ab4ee36ec9392134e83f60f72b29f10a2d89e22/content/browser/service_worker/embedded_worker_test_helper.cc
[modify] https://crrev.com/2ab4ee36ec9392134e83f60f72b29f10a2d89e22/content/browser/service_worker/service_worker_response_info.cc
[modify] https://crrev.com/2ab4ee36ec9392134e83f60f72b29f10a2d89e22/content/browser/service_worker/service_worker_response_info.h
[modify] https://crrev.com/2ab4ee36ec9392134e83f60f72b29f10a2d89e22/content/browser/service_worker/service_worker_url_loader_job_unittest.cc
[modify] https://crrev.com/2ab4ee36ec9392134e83f60f72b29f10a2d89e22/content/browser/service_worker/service_worker_url_request_job.cc
[modify] https://crrev.com/2ab4ee36ec9392134e83f60f72b29f10a2d89e22/content/browser/service_worker/service_worker_url_request_job.h
[modify] https://crrev.com/2ab4ee36ec9392134e83f60f72b29f10a2d89e22/content/browser/service_worker/service_worker_url_request_job_unittest.cc
[modify] https://crrev.com/2ab4ee36ec9392134e83f60f72b29f10a2d89e22/content/common/BUILD.gn
[modify] https://crrev.com/2ab4ee36ec9392134e83f60f72b29f10a2d89e22/content/common/DEPS
[modify] https://crrev.com/2ab4ee36ec9392134e83f60f72b29f10a2d89e22/content/common/service_worker/service_worker_messages.h
[modify] https://crrev.com/2ab4ee36ec9392134e83f60f72b29f10a2d89e22/content/common/service_worker/service_worker_types.cc
[modify] https://crrev.com/2ab4ee36ec9392134e83f60f72b29f10a2d89e22/content/common/service_worker/service_worker_types.h
[modify] https://crrev.com/2ab4ee36ec9392134e83f60f72b29f10a2d89e22/content/public/DEPS
[modify] https://crrev.com/2ab4ee36ec9392134e83f60f72b29f10a2d89e22/content/public/common/BUILD.gn
[modify] https://crrev.com/2ab4ee36ec9392134e83f60f72b29f10a2d89e22/content/public/common/resource_response_info.cc
[modify] https://crrev.com/2ab4ee36ec9392134e83f60f72b29f10a2d89e22/content/public/common/resource_response_info.h
[modify] https://crrev.com/2ab4ee36ec9392134e83f60f72b29f10a2d89e22/content/test/BUILD.gn
[add] https://crrev.com/2ab4ee36ec9392134e83f60f72b29f10a2d89e22/services/network/OWNERS
[add] https://crrev.com/2ab4ee36ec9392134e83f60f72b29f10a2d89e22/services/network/README.md
[add] https://crrev.com/2ab4ee36ec9392134e83f60f72b29f10a2d89e22/services/network/public/interfaces/BUILD.gn
[add] https://crrev.com/2ab4ee36ec9392134e83f60f72b29f10a2d89e22/services/network/public/interfaces/OWNERS
[add] https://crrev.com/2ab4ee36ec9392134e83f60f72b29f10a2d89e22/services/network/public/interfaces/fetch_api.mojom
[modify] https://crrev.com/2ab4ee36ec9392134e83f60f72b29f10a2d89e22/third_party/WebKit/Source/core/DEPS
[modify] https://crrev.com/2ab4ee36ec9392134e83f60f72b29f10a2d89e22/third_party/WebKit/Source/core/loader/BUILD.gn
[modify] https://crrev.com/2ab4ee36ec9392134e83f60f72b29f10a2d89e22/third_party/WebKit/Source/core/loader/DocumentThreadableLoader.cpp
[modify] https://crrev.com/2ab4ee36ec9392134e83f60f72b29f10a2d89e22/third_party/WebKit/Source/modules/BUILD.gn
[modify] https://crrev.com/2ab4ee36ec9392134e83f60f72b29f10a2d89e22/third_party/WebKit/Source/modules/cachestorage/CacheTest.cpp
[modify] https://crrev.com/2ab4ee36ec9392134e83f60f72b29f10a2d89e22/third_party/WebKit/Source/modules/cachestorage/DEPS
[modify] https://crrev.com/2ab4ee36ec9392134e83f60f72b29f10a2d89e22/third_party/WebKit/Source/modules/fetch/BUILD.gn
[modify] https://crrev.com/2ab4ee36ec9392134e83f60f72b29f10a2d89e22/third_party/WebKit/Source/modules/fetch/DEPS
[modify] https://crrev.com/2ab4ee36ec9392134e83f60f72b29f10a2d89e22/third_party/WebKit/Source/modules/fetch/FetchManager.cpp
[modify] https://crrev.com/2ab4ee36ec9392134e83f60f72b29f10a2d89e22/third_party/WebKit/Source/modules/fetch/FetchResponseData.cpp
[modify] https://crrev.com/2ab4ee36ec9392134e83f60f72b29f10a2d89e22/third_party/WebKit/Source/modules/fetch/FetchResponseDataTest.cpp
[modify] https://crrev.com/2ab4ee36ec9392134e83f60f72b29f10a2d89e22/third_party/WebKit/Source/modules/fetch/Response.cpp
[modify] https://crrev.com/2ab4ee36ec9392134e83f60f72b29f10a2d89e22/third_party/WebKit/Source/modules/fetch/ResponseTest.cpp
[modify] https://crrev.com/2ab4ee36ec9392134e83f60f72b29f10a2d89e22/third_party/WebKit/Source/platform/exported/WebServiceWorkerResponse.cpp
[modify] https://crrev.com/2ab4ee36ec9392134e83f60f72b29f10a2d89e22/third_party/WebKit/Source/platform/exported/WebURLResponse.cpp
[modify] https://crrev.com/2ab4ee36ec9392134e83f60f72b29f10a2d89e22/third_party/WebKit/Source/platform/loader/BUILD.gn
[modify] https://crrev.com/2ab4ee36ec9392134e83f60f72b29f10a2d89e22/third_party/WebKit/Source/platform/loader/DEPS
[modify] https://crrev.com/2ab4ee36ec9392134e83f60f72b29f10a2d89e22/third_party/WebKit/Source/platform/loader/SubresourceIntegrityTest.cpp
[modify] https://crrev.com/2ab4ee36ec9392134e83f60f72b29f10a2d89e22/third_party/WebKit/Source/platform/loader/fetch/Resource.cpp
[modify] https://crrev.com/2ab4ee36ec9392134e83f60f72b29f10a2d89e22/third_party/WebKit/Source/platform/loader/fetch/ResourceLoader.cpp
[modify] https://crrev.com/2ab4ee36ec9392134e83f60f72b29f10a2d89e22/third_party/WebKit/Source/platform/loader/fetch/ResourceLoaderTest.cpp
[modify] https://crrev.com/2ab4ee36ec9392134e83f60f72b29f10a2d89e22/third_party/WebKit/Source/platform/loader/fetch/ResourceResponse.cpp
[modify] https://crrev.com/2ab4ee36ec9392134e83f60f72b29f10a2d89e22/third_party/WebKit/Source/platform/loader/fetch/ResourceResponse.h
[modify] https://crrev.com/2ab4ee36ec9392134e83f60f72b29f10a2d89e22/third_party/WebKit/common/README.md
[modify] https://crrev.com/2ab4ee36ec9392134e83f60f72b29f10a2d89e22/third_party/WebKit/public/BUILD.gn
[modify] https://crrev.com/2ab4ee36ec9392134e83f60f72b29f10a2d89e22/third_party/WebKit/public/platform/DEPS
[modify] https://crrev.com/2ab4ee36ec9392134e83f60f72b29f10a2d89e22/third_party/WebKit/public/platform/WebURLResponse.h
[modify] https://crrev.com/2ab4ee36ec9392134e83f60f72b29f10a2d89e22/third_party/WebKit/public/platform/modules/fetch/fetch_api_request.mojom
[modify] https://crrev.com/2ab4ee36ec9392134e83f60f72b29f10a2d89e22/third_party/WebKit/public/platform/modules/serviceworker/WebServiceWorkerResponse.h

Project Member

Comment 3 by bugdroid1@chromium.org, Aug 15 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8003f1f1683d85beee5b5e755838eff42f5a33d6

commit 8003f1f1683d85beee5b5e755838eff42f5a33d6
Author: Matt Falkenhagen <falken@chromium.org>
Date: Tue Aug 15 08:32:16 2017

Remove unnecessary includes of fetch_api_request.mojom.h

These were obsoleted by https://crrev.com/2ab4ee36ec9392134

Bug: 750883, 746197, 753658
Change-Id: I35da60e985253f46cc027388c6bf2a5476264e06
TBR: kinuko
Reviewed-on: https://chromium-review.googlesource.com/614938
Reviewed-by: Matt Falkenhagen <falken@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Yutaka Hirano <yhirano@chromium.org>
Commit-Queue: Matt Falkenhagen <falken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#494345}
[modify] https://crrev.com/8003f1f1683d85beee5b5e755838eff42f5a33d6/content/browser/DEPS
[modify] https://crrev.com/8003f1f1683d85beee5b5e755838eff42f5a33d6/content/browser/background_fetch/background_fetch_data_manager.cc
[modify] https://crrev.com/8003f1f1683d85beee5b5e755838eff42f5a33d6/content/browser/cache_storage/cache_storage_cache.cc
[modify] https://crrev.com/8003f1f1683d85beee5b5e755838eff42f5a33d6/content/browser/service_worker/service_worker_response_info.h
[modify] https://crrev.com/8003f1f1683d85beee5b5e755838eff42f5a33d6/content/browser/service_worker/service_worker_url_loader_job_unittest.cc
[modify] https://crrev.com/8003f1f1683d85beee5b5e755838eff42f5a33d6/content/browser/service_worker/service_worker_url_request_job.h
[modify] https://crrev.com/8003f1f1683d85beee5b5e755838eff42f5a33d6/content/common/service_worker/service_worker_types.h
[modify] https://crrev.com/8003f1f1683d85beee5b5e755838eff42f5a33d6/content/public/common/resource_response_info.h
[modify] https://crrev.com/8003f1f1683d85beee5b5e755838eff42f5a33d6/third_party/WebKit/Source/platform/loader/SubresourceIntegrityTest.cpp
[modify] https://crrev.com/8003f1f1683d85beee5b5e755838eff42f5a33d6/third_party/WebKit/Source/platform/loader/fetch/ResourceResponse.h

Comment 4 by laforge@google.com, Nov 7 2017

Components: -Internals>Network>Service Internals>Services>Network
Apologies, applied the wrong component in bulk.

Comment 5 by jam@chromium.org, Dec 13 2017

Blocking: 598073
Owner: jam@chromium.org
Status: Started (was: Available)
Project Member

Comment 6 by bugdroid1@chromium.org, Dec 22 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b77d22fb769642c041f18ba368d0208d0a10d62b

commit b77d22fb769642c041f18ba368d0208d0a10d62b
Author: John Abd-El-Malek <jam@chromium.org>
Date: Fri Dec 22 20:41:22 2017

Drop content::ResourceRequest dependency on blink::WebReferrerPolicy.

Instead, use net::URLRequest::ReferrerPolicy. This is in preparation for moving the struct to
services/network.

In a follow-up, I'll switch content::Referrer to use the net enum as well.

Bug: 753658
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo
Change-Id: I622cba8d8c8f828f3961b9cb3a524b8cf487a3c1
Reviewed-on: https://chromium-review.googlesource.com/842249
Commit-Queue: John Abd-El-Malek <jam@chromium.org>
Reviewed-by: Yuzhu Shen <yzshen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#526053}
[modify] https://crrev.com/b77d22fb769642c041f18ba368d0208d0a10d62b/chrome/browser/bitmap_fetcher/bitmap_fetcher.cc
[modify] https://crrev.com/b77d22fb769642c041f18ba368d0208d0a10d62b/content/browser/download/download_utils.cc
[modify] https://crrev.com/b77d22fb769642c041f18ba368d0208d0a10d62b/content/browser/loader/navigation_url_loader_network_service.cc
[modify] https://crrev.com/b77d22fb769642c041f18ba368d0208d0a10d62b/content/browser/loader/resource_dispatcher_host_impl.cc
[modify] https://crrev.com/b77d22fb769642c041f18ba368d0208d0a10d62b/content/browser/loader/resource_dispatcher_host_unittest.cc
[modify] https://crrev.com/b77d22fb769642c041f18ba368d0208d0a10d62b/content/browser/security_exploit_browsertest.cc
[modify] https://crrev.com/b77d22fb769642c041f18ba368d0208d0a10d62b/content/browser/service_worker/service_worker_fetch_dispatcher.cc
[modify] https://crrev.com/b77d22fb769642c041f18ba368d0208d0a10d62b/content/common/service_worker/service_worker_loader_helpers.cc
[modify] https://crrev.com/b77d22fb769642c041f18ba368d0208d0a10d62b/content/network/url_loader.cc
[modify] https://crrev.com/b77d22fb769642c041f18ba368d0208d0a10d62b/content/network/url_loader_unittest.cc
[modify] https://crrev.com/b77d22fb769642c041f18ba368d0208d0a10d62b/content/public/common/referrer.cc
[modify] https://crrev.com/b77d22fb769642c041f18ba368d0208d0a10d62b/content/public/common/referrer.h
[modify] https://crrev.com/b77d22fb769642c041f18ba368d0208d0a10d62b/content/public/common/resource_request.h
[modify] https://crrev.com/b77d22fb769642c041f18ba368d0208d0a10d62b/content/public/test/navigation_simulator.cc
[modify] https://crrev.com/b77d22fb769642c041f18ba368d0208d0a10d62b/content/public/test/referrer_unittest.cc
[modify] https://crrev.com/b77d22fb769642c041f18ba368d0208d0a10d62b/content/renderer/fetchers/resource_fetcher_impl.cc
[modify] https://crrev.com/b77d22fb769642c041f18ba368d0208d0a10d62b/content/renderer/loader/resource_dispatcher.cc
[modify] https://crrev.com/b77d22fb769642c041f18ba368d0208d0a10d62b/content/renderer/loader/resource_dispatcher_unittest.cc
[modify] https://crrev.com/b77d22fb769642c041f18ba368d0208d0a10d62b/content/renderer/loader/web_url_loader_impl.cc
[modify] https://crrev.com/b77d22fb769642c041f18ba368d0208d0a10d62b/content/renderer/service_worker/service_worker_context_client.cc
[modify] https://crrev.com/b77d22fb769642c041f18ba368d0208d0a10d62b/content/renderer/service_worker/service_worker_subresource_loader.cc

Project Member

Comment 8 by bugdroid1@chromium.org, Dec 28 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/005ef206ba5ce817d2fcf820da033cc0ec507c1a

commit 005ef206ba5ce817d2fcf820da033cc0ec507c1a
Author: John Abd-El-Malek <jam@chromium.org>
Date: Thu Dec 28 15:54:38 2017

Replace ResourceRequest::visibility_state with a boolean indicating whether the request is from a prerendered frame.

This is all the state that the browser needs.

TBR=tsepez

Bug: 753658
Change-Id: I0fe30fc2894c7f88e6c8b68e8b38af757e00b809
Reviewed-on: https://chromium-review.googlesource.com/844895
Reviewed-by: Yuzhu Shen <yzshen@chromium.org>
Commit-Queue: John Abd-El-Malek <jam@chromium.org>
Cr-Commit-Position: refs/heads/master@{#526298}
[modify] https://crrev.com/005ef206ba5ce817d2fcf820da033cc0ec507c1a/chrome/browser/loader/chrome_resource_dispatcher_host_delegate.cc
[modify] https://crrev.com/005ef206ba5ce817d2fcf820da033cc0ec507c1a/content/browser/devtools/devtools_url_interceptor_request_job.cc
[modify] https://crrev.com/005ef206ba5ce817d2fcf820da033cc0ec507c1a/content/browser/frame_host/navigation_request.cc
[modify] https://crrev.com/005ef206ba5ce817d2fcf820da033cc0ec507c1a/content/browser/frame_host/navigation_request_info.cc
[modify] https://crrev.com/005ef206ba5ce817d2fcf820da033cc0ec507c1a/content/browser/frame_host/navigation_request_info.h
[modify] https://crrev.com/005ef206ba5ce817d2fcf820da033cc0ec507c1a/content/browser/loader/navigation_url_loader_network_service_unittest.cc
[modify] https://crrev.com/005ef206ba5ce817d2fcf820da033cc0ec507c1a/content/browser/loader/navigation_url_loader_unittest.cc
[modify] https://crrev.com/005ef206ba5ce817d2fcf820da033cc0ec507c1a/content/browser/loader/resource_dispatcher_host_impl.cc
[modify] https://crrev.com/005ef206ba5ce817d2fcf820da033cc0ec507c1a/content/browser/loader/resource_dispatcher_host_unittest.cc
[modify] https://crrev.com/005ef206ba5ce817d2fcf820da033cc0ec507c1a/content/browser/loader/resource_request_info_impl.cc
[modify] https://crrev.com/005ef206ba5ce817d2fcf820da033cc0ec507c1a/content/browser/loader/resource_request_info_impl.h
[modify] https://crrev.com/005ef206ba5ce817d2fcf820da033cc0ec507c1a/content/browser/service_worker/service_worker_fetch_dispatcher.cc
[modify] https://crrev.com/005ef206ba5ce817d2fcf820da033cc0ec507c1a/content/common/resource_messages.h
[modify] https://crrev.com/005ef206ba5ce817d2fcf820da033cc0ec507c1a/content/public/browser/resource_request_info.h
[modify] https://crrev.com/005ef206ba5ce817d2fcf820da033cc0ec507c1a/content/public/common/resource_request.h
[modify] https://crrev.com/005ef206ba5ce817d2fcf820da033cc0ec507c1a/content/renderer/loader/request_extra_data.cc

Project Member

Comment 9 by bugdroid1@chromium.org, Dec 28 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4f7cfdfbeb75981159796514c1105d2a03605a5e

commit 4f7cfdfbeb75981159796514c1105d2a03605a5e
Author: Randy Smith <rdsmith@chromium.org>
Date: Thu Dec 28 18:09:50 2017

Move serialization for various types to //services/network.

This CL includes moving the serialization for CORSErrorStatus,
HttpResponseHeaders, and URLLoaderCompletionStatus to //services/network.

Bug: 753658
Change-Id: If3160cf6e1285616fc3db202fd5d459d5d4e0274
Reviewed-on: https://chromium-review.googlesource.com/844100
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Commit-Queue: Randy Smith <rdsmith@chromium.org>
Cr-Commit-Position: refs/heads/master@{#526306}
[modify] https://crrev.com/4f7cfdfbeb75981159796514c1105d2a03605a5e/content/common/resource_messages.cc
[modify] https://crrev.com/4f7cfdfbeb75981159796514c1105d2a03605a5e/content/common/resource_messages.h
[modify] https://crrev.com/4f7cfdfbeb75981159796514c1105d2a03605a5e/content/public/common/cors_error_status.typemap
[modify] https://crrev.com/4f7cfdfbeb75981159796514c1105d2a03605a5e/content/public/common/url_loader_completion_status.typemap
[modify] https://crrev.com/4f7cfdfbeb75981159796514c1105d2a03605a5e/content/test/BUILD.gn
[modify] https://crrev.com/4f7cfdfbeb75981159796514c1105d2a03605a5e/services/network/public/cpp/network_param_ipc_traits.cc
[modify] https://crrev.com/4f7cfdfbeb75981159796514c1105d2a03605a5e/services/network/public/cpp/network_param_ipc_traits.h

Project Member

Comment 10 by bugdroid1@chromium.org, Dec 29 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8c3760024b4387044391cc750307d98cfcbe1da0

commit 8c3760024b4387044391cc750307d98cfcbe1da0
Author: Randy Smith <rdsmith@chromium.org>
Date: Fri Dec 29 03:57:01 2017

Renamed ResourceDevToolsInfo and move it to //services/network.

This is part of moving all things that url_loader.mojom is dependent on
to //services/network.

Bug: 753658
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo
Change-Id: I1cf0411ac15a39b09d18a2c0c3ff04d7fac64787
Reviewed-on: https://chromium-review.googlesource.com/844116
Commit-Queue: Randy Smith <rdsmith@chromium.org>
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#526357}
[modify] https://crrev.com/8c3760024b4387044391cc750307d98cfcbe1da0/content/browser/devtools/protocol/network_handler.cc
[modify] https://crrev.com/8c3760024b4387044391cc750307d98cfcbe1da0/content/browser/loader/resource_loader.cc
[modify] https://crrev.com/8c3760024b4387044391cc750307d98cfcbe1da0/content/common/loader_util.cc
[modify] https://crrev.com/8c3760024b4387044391cc750307d98cfcbe1da0/content/common/loader_util.h
[modify] https://crrev.com/8c3760024b4387044391cc750307d98cfcbe1da0/content/common/resource_messages.cc
[modify] https://crrev.com/8c3760024b4387044391cc750307d98cfcbe1da0/content/common/resource_messages.h
[modify] https://crrev.com/8c3760024b4387044391cc750307d98cfcbe1da0/content/network/network_service_unittest.cc
[modify] https://crrev.com/8c3760024b4387044391cc750307d98cfcbe1da0/content/network/url_loader.cc
[modify] https://crrev.com/8c3760024b4387044391cc750307d98cfcbe1da0/content/public/common/BUILD.gn
[modify] https://crrev.com/8c3760024b4387044391cc750307d98cfcbe1da0/content/public/common/DEPS
[delete] https://crrev.com/59388664eb816df4b0757190da4e2d20d5989770/content/public/common/resource_devtools_info.cc
[delete] https://crrev.com/59388664eb816df4b0757190da4e2d20d5989770/content/public/common/resource_devtools_info.h
[modify] https://crrev.com/8c3760024b4387044391cc750307d98cfcbe1da0/content/public/common/resource_response.cc
[modify] https://crrev.com/8c3760024b4387044391cc750307d98cfcbe1da0/content/public/common/resource_response_info.h
[modify] https://crrev.com/8c3760024b4387044391cc750307d98cfcbe1da0/content/renderer/loader/sync_load_context.cc
[modify] https://crrev.com/8c3760024b4387044391cc750307d98cfcbe1da0/content/renderer/loader/web_url_loader_impl.cc
[modify] https://crrev.com/8c3760024b4387044391cc750307d98cfcbe1da0/services/network/public/cpp/BUILD.gn
[add] https://crrev.com/8c3760024b4387044391cc750307d98cfcbe1da0/services/network/public/cpp/http_raw_request_response_info.cc
[add] https://crrev.com/8c3760024b4387044391cc750307d98cfcbe1da0/services/network/public/cpp/http_raw_request_response_info.h
[modify] https://crrev.com/8c3760024b4387044391cc750307d98cfcbe1da0/services/network/public/cpp/network_param_ipc_traits.cc
[modify] https://crrev.com/8c3760024b4387044391cc750307d98cfcbe1da0/services/network/public/cpp/network_param_ipc_traits.h

Project Member

Comment 12 by bugdroid1@chromium.org, Jan 5 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c5ecdd96996d2012437cc10314df54d3a740e8ba

commit c5ecdd96996d2012437cc10314df54d3a740e8ba
Author: Randy Smith <rdsmith@chromium.org>
Date: Fri Jan 05 00:16:42 2018

Shift PreviewsState usage in ResourceResponseInfo to an int.

This breaks the dependency of ResourceResponseInfo on PreviewsState and allows
a (future) move into //services/network.

Bug: 753658
Change-Id: Ia07e7a5a6d587a7c484d3525211224d4b6cdeb9a
Reviewed-on: https://chromium-review.googlesource.com/846227
Commit-Queue: Randy Smith <rdsmith@chromium.org>
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Reviewed-by: Reilly Grant <reillyg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#527159}
[modify] https://crrev.com/c5ecdd96996d2012437cc10314df54d3a740e8ba/chrome/browser/loader/chrome_resource_dispatcher_host_delegate.cc
[modify] https://crrev.com/c5ecdd96996d2012437cc10314df54d3a740e8ba/chrome/renderer/security_filter_peer.h
[modify] https://crrev.com/c5ecdd96996d2012437cc10314df54d3a740e8ba/content/browser/frame_host/navigation_request.cc
[modify] https://crrev.com/c5ecdd96996d2012437cc10314df54d3a740e8ba/content/browser/loader/resource_loader.cc
[modify] https://crrev.com/c5ecdd96996d2012437cc10314df54d3a740e8ba/content/public/common/resource_response_info.cc
[modify] https://crrev.com/c5ecdd96996d2012437cc10314df54d3a740e8ba/content/public/common/resource_response_info.h
[modify] https://crrev.com/c5ecdd96996d2012437cc10314df54d3a740e8ba/content/renderer/loader/web_url_loader_impl.cc

Project Member

Comment 13 by bugdroid1@chromium.org, Jan 5 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e88e8e34c1fc653416df4fa559b6561e55177d73

commit e88e8e34c1fc653416df4fa559b6561e55177d73
Author: Randy Smith <rdsmith@chromium.org>
Date: Fri Jan 05 04:25:52 2018

Removed header dependence of resource_response_info.cc on AppCache.

Bug: 753658
Change-Id: I3f31262decb7d4953a11df4913b535398736de07
Reviewed-on: https://chromium-review.googlesource.com/850918
Commit-Queue: Randy Smith <rdsmith@chromium.org>
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Cr-Commit-Position: refs/heads/master@{#527197}
[modify] https://crrev.com/e88e8e34c1fc653416df4fa559b6561e55177d73/content/browser/loader/resource_loader.cc
[modify] https://crrev.com/e88e8e34c1fc653416df4fa559b6561e55177d73/content/public/common/resource_response_info.cc
[modify] https://crrev.com/e88e8e34c1fc653416df4fa559b6561e55177d73/content/public/common/resource_response_info.h

Project Member

Comment 14 by bugdroid1@chromium.org, Jan 8 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2791e09be30571f56475fd16373061dd8288c8c5

commit 2791e09be30571f56475fd16373061dd8288c8c5
Author: John Abd-El-Malek <jam@chromium.org>
Date: Mon Jan 08 17:43:16 2018

Replace content enums in ResourceRequest with ints.

We need to extract these web platform specific enums from the struct as the network service doesn't
know or care about them. Until that's done, remove the dependency so that we can move the struct to
services/network since that blocks making URLLoader work on iOS. That way we can parallelize
converting shared layered components to use content::URLLoader instead of net::URLFetcher.

Bug: 753658
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo
Change-Id: I2553f442a8b7be9ee7d34c7991573838ac2d75a3
Reviewed-on: https://chromium-review.googlesource.com/845861
Commit-Queue: John Abd-El-Malek <jam@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#527664}
[modify] https://crrev.com/2791e09be30571f56475fd16373061dd8288c8c5/chrome/browser/android/compositor/scene_layer/contextual_search_scene_layer.cc
[modify] https://crrev.com/2791e09be30571f56475fd16373061dd8288c8c5/chrome/browser/bitmap_fetcher/bitmap_fetcher.cc
[modify] https://crrev.com/2791e09be30571f56475fd16373061dd8288c8c5/chrome/browser/bitmap_fetcher/bitmap_fetcher.h
[modify] https://crrev.com/2791e09be30571f56475fd16373061dd8288c8c5/chrome/browser/bitmap_fetcher/bitmap_fetcher_browsertest.cc
[modify] https://crrev.com/2791e09be30571f56475fd16373061dd8288c8c5/chrome/browser/bitmap_fetcher/bitmap_fetcher_service.cc
[modify] https://crrev.com/2791e09be30571f56475fd16373061dd8288c8c5/chrome/browser/extensions/webstore_install_helper.cc
[modify] https://crrev.com/2791e09be30571f56475fd16373061dd8288c8c5/chrome/browser/profiles/profile_avatar_downloader.cc
[modify] https://crrev.com/2791e09be30571f56475fd16373061dd8288c8c5/chrome/browser/task_manager/task_manager_interface.cc
[modify] https://crrev.com/2791e09be30571f56475fd16373061dd8288c8c5/chrome/browser/ui/passwords/account_avatar_fetcher.cc
[modify] https://crrev.com/2791e09be30571f56475fd16373061dd8288c8c5/components/safe_browsing/browser/browser_url_loader_throttle.cc
[modify] https://crrev.com/2791e09be30571f56475fd16373061dd8288c8c5/components/safe_browsing/renderer/renderer_url_loader_throttle.cc
[modify] https://crrev.com/2791e09be30571f56475fd16373061dd8288c8c5/content/browser/appcache/appcache_request_handler.cc
[modify] https://crrev.com/2791e09be30571f56475fd16373061dd8288c8c5/content/browser/appcache/appcache_subresource_url_factory.cc
[modify] https://crrev.com/2791e09be30571f56475fd16373061dd8288c8c5/content/browser/appcache/appcache_url_loader_job.cc
[modify] https://crrev.com/2791e09be30571f56475fd16373061dd8288c8c5/content/browser/loader/navigation_url_loader_network_service.cc
[modify] https://crrev.com/2791e09be30571f56475fd16373061dd8288c8c5/content/browser/loader/resource_dispatcher_host_impl.cc
[modify] https://crrev.com/2791e09be30571f56475fd16373061dd8288c8c5/content/browser/service_worker/service_worker_fetch_dispatcher.cc
[modify] https://crrev.com/2791e09be30571f56475fd16373061dd8288c8c5/content/browser/service_worker/service_worker_script_url_loader.cc
[modify] https://crrev.com/2791e09be30571f56475fd16373061dd8288c8c5/content/browser/service_worker/service_worker_url_loader_job.cc
[modify] https://crrev.com/2791e09be30571f56475fd16373061dd8288c8c5/content/browser/service_worker/service_worker_url_loader_job_unittest.cc
[modify] https://crrev.com/2791e09be30571f56475fd16373061dd8288c8c5/content/common/service_worker/service_worker_loader_helpers.cc
[modify] https://crrev.com/2791e09be30571f56475fd16373061dd8288c8c5/content/network/DEPS
[modify] https://crrev.com/2791e09be30571f56475fd16373061dd8288c8c5/content/network/url_loader.cc
[modify] https://crrev.com/2791e09be30571f56475fd16373061dd8288c8c5/content/network/url_loader.h
[modify] https://crrev.com/2791e09be30571f56475fd16373061dd8288c8c5/content/network/url_loader_unittest.cc
[modify] https://crrev.com/2791e09be30571f56475fd16373061dd8288c8c5/content/public/common/resource_request.h
[modify] https://crrev.com/2791e09be30571f56475fd16373061dd8288c8c5/content/renderer/loader/cors_url_loader.cc
[modify] https://crrev.com/2791e09be30571f56475fd16373061dd8288c8c5/content/renderer/loader/cors_url_loader_unittest.cc
[modify] https://crrev.com/2791e09be30571f56475fd16373061dd8288c8c5/content/renderer/loader/resource_dispatcher.cc
[modify] https://crrev.com/2791e09be30571f56475fd16373061dd8288c8c5/content/renderer/loader/web_url_loader_impl.cc
[modify] https://crrev.com/2791e09be30571f56475fd16373061dd8288c8c5/content/renderer/service_worker/service_worker_context_client.cc
[modify] https://crrev.com/2791e09be30571f56475fd16373061dd8288c8c5/content/renderer/service_worker/service_worker_subresource_loader.cc
[modify] https://crrev.com/2791e09be30571f56475fd16373061dd8288c8c5/content/renderer/service_worker/service_worker_subresource_loader_unittest.cc
[modify] https://crrev.com/2791e09be30571f56475fd16373061dd8288c8c5/extensions/browser/extension_protocols.cc

Project Member

Comment 15 by bugdroid1@chromium.org, Jan 10 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a5941163576c3a46927b90b034734d997345753e

commit a5941163576c3a46927b90b034734d997345753e
Author: John Abd-El-Malek <jam@chromium.org>
Date: Wed Jan 10 20:08:28 2018

Remove dependencies from content::ResourceRequest in preparation for its move to services/network.

Bug: 753658
Change-Id: I656d2b49a7995d57db4514104165056300861c77
Reviewed-on: https://chromium-review.googlesource.com/859096
Reviewed-by: Ken Rockot <rockot@chromium.org>
Commit-Queue: John Abd-El-Malek <jam@chromium.org>
Cr-Commit-Position: refs/heads/master@{#528402}
[modify] https://crrev.com/a5941163576c3a46927b90b034734d997345753e/chrome/browser/android/tab_android.cc
[modify] https://crrev.com/a5941163576c3a46927b90b034734d997345753e/chrome/browser/android/vr_shell/vr_shell.h
[modify] https://crrev.com/a5941163576c3a46927b90b034734d997345753e/components/web_contents_delegate_android/web_contents_delegate_android.cc
[modify] https://crrev.com/a5941163576c3a46927b90b034734d997345753e/content/browser/frame_host/navigation_controller_android.cc
[modify] https://crrev.com/a5941163576c3a46927b90b034734d997345753e/content/common/BUILD.gn
[modify] https://crrev.com/a5941163576c3a46927b90b034734d997345753e/content/public/common/BUILD.gn
[modify] https://crrev.com/a5941163576c3a46927b90b034734d997345753e/content/public/common/resource_request.cc
[modify] https://crrev.com/a5941163576c3a46927b90b034734d997345753e/content/public/common/resource_request.h
[modify] https://crrev.com/a5941163576c3a46927b90b034734d997345753e/content/public/common/resource_request_body.cc
[modify] https://crrev.com/a5941163576c3a46927b90b034734d997345753e/content/public/common/resource_request_body.h
[rename] https://crrev.com/a5941163576c3a46927b90b034734d997345753e/content/public/common/resource_request_body_android.cc
[rename] https://crrev.com/a5941163576c3a46927b90b034734d997345753e/content/public/common/resource_request_body_android.h

Project Member

Comment 16 by bugdroid1@chromium.org, Jan 11 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/105b3747c5eab20245f2e13834d33701f4ec2e50

commit 105b3747c5eab20245f2e13834d33701f4ec2e50
Author: John Abd-El-Malek <jam@chromium.org>
Date: Thu Jan 11 22:39:25 2018

Move storage::DataElement to services/network as it's part of ResourceRequestBody which is moving.

Bug: 753658
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo
Change-Id: If28cc24abc31c65aacd51d4b1b2e51b50ace128d
Reviewed-on: https://chromium-review.googlesource.com/861334
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Commit-Queue: John Abd-El-Malek <jam@chromium.org>
Cr-Commit-Position: refs/heads/master@{#528787}
[modify] https://crrev.com/105b3747c5eab20245f2e13834d33701f4ec2e50/content/browser/blob_storage/blob_dispatcher_host.cc
[modify] https://crrev.com/105b3747c5eab20245f2e13834d33701f4ec2e50/content/browser/blob_storage/blob_dispatcher_host.h
[modify] https://crrev.com/105b3747c5eab20245f2e13834d33701f4ec2e50/content/browser/blob_storage/blob_dispatcher_host_unittest.cc
[modify] https://crrev.com/105b3747c5eab20245f2e13834d33701f4ec2e50/content/browser/blob_storage/blob_transport_host_unittest.cc
[modify] https://crrev.com/105b3747c5eab20245f2e13834d33701f4ec2e50/content/browser/cache_storage/cache_storage_cache_unittest.cc
[modify] https://crrev.com/105b3747c5eab20245f2e13834d33701f4ec2e50/content/browser/fileapi/fileapi_message_filter.cc
[modify] https://crrev.com/105b3747c5eab20245f2e13834d33701f4ec2e50/content/browser/fileapi/fileapi_message_filter_unittest.cc
[modify] https://crrev.com/105b3747c5eab20245f2e13834d33701f4ec2e50/content/common/fileapi/webblob_messages.h
[modify] https://crrev.com/105b3747c5eab20245f2e13834d33701f4ec2e50/content/common/resource_messages.cc
[modify] https://crrev.com/105b3747c5eab20245f2e13834d33701f4ec2e50/content/common/resource_messages.h
[modify] https://crrev.com/105b3747c5eab20245f2e13834d33701f4ec2e50/content/network/url_loader.cc
[modify] https://crrev.com/105b3747c5eab20245f2e13834d33701f4ec2e50/content/public/common/DEPS
[modify] https://crrev.com/105b3747c5eab20245f2e13834d33701f4ec2e50/content/public/common/resource_request_body.h
[modify] https://crrev.com/105b3747c5eab20245f2e13834d33701f4ec2e50/content/public/common/simple_url_loader.cc
[modify] https://crrev.com/105b3747c5eab20245f2e13834d33701f4ec2e50/content/public/common/simple_url_loader_unittest.cc
[modify] https://crrev.com/105b3747c5eab20245f2e13834d33701f4ec2e50/content/renderer/BUILD.gn
[modify] https://crrev.com/105b3747c5eab20245f2e13834d33701f4ec2e50/content/renderer/blob_storage/blob_consolidation.cc
[modify] https://crrev.com/105b3747c5eab20245f2e13834d33701f4ec2e50/content/renderer/blob_storage/blob_consolidation.h
[modify] https://crrev.com/105b3747c5eab20245f2e13834d33701f4ec2e50/content/renderer/blob_storage/blob_consolidation_unittest.cc
[modify] https://crrev.com/105b3747c5eab20245f2e13834d33701f4ec2e50/content/renderer/blob_storage/blob_transport_controller.cc
[modify] https://crrev.com/105b3747c5eab20245f2e13834d33701f4ec2e50/content/renderer/blob_storage/blob_transport_controller.h
[modify] https://crrev.com/105b3747c5eab20245f2e13834d33701f4ec2e50/content/renderer/blob_storage/blob_transport_controller_unittest.cc
[modify] https://crrev.com/105b3747c5eab20245f2e13834d33701f4ec2e50/content/renderer/blob_storage/webblobregistry_impl.cc
[modify] https://crrev.com/105b3747c5eab20245f2e13834d33701f4ec2e50/content/renderer/blob_storage/webblobregistry_impl.h
[modify] https://crrev.com/105b3747c5eab20245f2e13834d33701f4ec2e50/content/renderer/render_frame_impl.cc
[modify] https://crrev.com/105b3747c5eab20245f2e13834d33701f4ec2e50/services/network/public/cpp/BUILD.gn
[rename] https://crrev.com/105b3747c5eab20245f2e13834d33701f4ec2e50/services/network/public/cpp/data_element.cc
[rename] https://crrev.com/105b3747c5eab20245f2e13834d33701f4ec2e50/services/network/public/cpp/data_element.h
[modify] https://crrev.com/105b3747c5eab20245f2e13834d33701f4ec2e50/storage/browser/BUILD.gn
[modify] https://crrev.com/105b3747c5eab20245f2e13834d33701f4ec2e50/storage/browser/blob/blob_data_builder.cc
[modify] https://crrev.com/105b3747c5eab20245f2e13834d33701f4ec2e50/storage/browser/blob/blob_data_builder.h
[modify] https://crrev.com/105b3747c5eab20245f2e13834d33701f4ec2e50/storage/browser/blob/blob_data_builder_unittest.cc
[modify] https://crrev.com/105b3747c5eab20245f2e13834d33701f4ec2e50/storage/browser/blob/blob_data_item.cc
[modify] https://crrev.com/105b3747c5eab20245f2e13834d33701f4ec2e50/storage/browser/blob/blob_data_item.h
[modify] https://crrev.com/105b3747c5eab20245f2e13834d33701f4ec2e50/storage/browser/blob/blob_data_snapshot.cc
[modify] https://crrev.com/105b3747c5eab20245f2e13834d33701f4ec2e50/storage/browser/blob/blob_entry.cc
[modify] https://crrev.com/105b3747c5eab20245f2e13834d33701f4ec2e50/storage/browser/blob/blob_flattener_unittest.cc
[modify] https://crrev.com/105b3747c5eab20245f2e13834d33701f4ec2e50/storage/browser/blob/blob_memory_controller.cc
[modify] https://crrev.com/105b3747c5eab20245f2e13834d33701f4ec2e50/storage/browser/blob/blob_memory_controller_unittest.cc
[modify] https://crrev.com/105b3747c5eab20245f2e13834d33701f4ec2e50/storage/browser/blob/blob_reader.cc
[modify] https://crrev.com/105b3747c5eab20245f2e13834d33701f4ec2e50/storage/browser/blob/blob_registry_impl_unittest.cc
[modify] https://crrev.com/105b3747c5eab20245f2e13834d33701f4ec2e50/storage/browser/blob/blob_slice_unittest.cc
[modify] https://crrev.com/105b3747c5eab20245f2e13834d33701f4ec2e50/storage/browser/blob/blob_storage_context.cc
[modify] https://crrev.com/105b3747c5eab20245f2e13834d33701f4ec2e50/storage/browser/blob/blob_storage_context.h
[modify] https://crrev.com/105b3747c5eab20245f2e13834d33701f4ec2e50/storage/browser/blob/blob_transport_host.cc
[modify] https://crrev.com/105b3747c5eab20245f2e13834d33701f4ec2e50/storage/browser/blob/blob_transport_host.h
[modify] https://crrev.com/105b3747c5eab20245f2e13834d33701f4ec2e50/storage/browser/blob/blob_transport_request_builder.cc
[modify] https://crrev.com/105b3747c5eab20245f2e13834d33701f4ec2e50/storage/browser/blob/blob_transport_request_builder.h
[modify] https://crrev.com/105b3747c5eab20245f2e13834d33701f4ec2e50/storage/browser/blob/blob_transport_request_builder_unittest.cc
[modify] https://crrev.com/105b3747c5eab20245f2e13834d33701f4ec2e50/storage/browser/blob/blob_url_request_job.cc
[modify] https://crrev.com/105b3747c5eab20245f2e13834d33701f4ec2e50/storage/browser/blob/shareable_blob_data_item.cc
[modify] https://crrev.com/105b3747c5eab20245f2e13834d33701f4ec2e50/storage/browser/blob/shareable_blob_data_item.h
[modify] https://crrev.com/105b3747c5eab20245f2e13834d33701f4ec2e50/storage/browser/blob/view_blob_internals_job.cc
[modify] https://crrev.com/105b3747c5eab20245f2e13834d33701f4ec2e50/storage/common/BUILD.gn
[modify] https://crrev.com/105b3747c5eab20245f2e13834d33701f4ec2e50/tools/ipc_fuzzer/fuzzer/fuzzer.cc

Project Member

Comment 17 by bugdroid1@chromium.org, Jan 12 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b49606cff1405d428ee028979f28f082f1abde3d

commit b49606cff1405d428ee028979f28f082f1abde3d
Author: John Abd-El-Malek <jam@chromium.org>
Date: Fri Jan 12 17:23:34 2018

Move ResourceRequestBody to services/network in preparation of moving content/network.

TBR=nasko

Bug: 753658
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo
Change-Id: Ib8622bcdd6566b3ab5bff02c31be5f54854fe967
Reviewed-on: https://chromium-review.googlesource.com/864422
Reviewed-by: Ken Rockot <rockot@chromium.org>
Cr-Commit-Position: refs/heads/master@{#528982}
[modify] https://crrev.com/b49606cff1405d428ee028979f28f082f1abde3d/chrome/browser/extensions/bookmark_app_navigation_throttle_browsertest.cc
[modify] https://crrev.com/b49606cff1405d428ee028979f28f082f1abde3d/chrome/browser/prerender/prerender_browsertest.cc
[modify] https://crrev.com/b49606cff1405d428ee028979f28f082f1abde3d/chrome/browser/sessions/better_session_restore_browsertest.cc
[modify] https://crrev.com/b49606cff1405d428ee028979f28f082f1abde3d/chrome/browser/ui/browser_navigator_browsertest.cc
[modify] https://crrev.com/b49606cff1405d428ee028979f28f082f1abde3d/chrome/browser/ui/browser_navigator_params.h
[modify] https://crrev.com/b49606cff1405d428ee028979f28f082f1abde3d/chrome/browser/ui/tab_contents/core_tab_helper.cc
[modify] https://crrev.com/b49606cff1405d428ee028979f28f082f1abde3d/chrome/test/base/ui_test_utils.cc
[modify] https://crrev.com/b49606cff1405d428ee028979f28f082f1abde3d/content/browser/blob_storage/chrome_blob_storage_context.cc
[modify] https://crrev.com/b49606cff1405d428ee028979f28f082f1abde3d/content/browser/blob_storage/chrome_blob_storage_context.h
[modify] https://crrev.com/b49606cff1405d428ee028979f28f082f1abde3d/content/browser/child_process_security_policy_impl.cc
[modify] https://crrev.com/b49606cff1405d428ee028979f28f082f1abde3d/content/browser/child_process_security_policy_impl.h
[modify] https://crrev.com/b49606cff1405d428ee028979f28f082f1abde3d/content/browser/download/download_utils.cc
[modify] https://crrev.com/b49606cff1405d428ee028979f28f082f1abde3d/content/browser/frame_host/frame_navigation_entry.cc
[modify] https://crrev.com/b49606cff1405d428ee028979f28f082f1abde3d/content/browser/frame_host/frame_navigation_entry.h
[modify] https://crrev.com/b49606cff1405d428ee028979f28f082f1abde3d/content/browser/frame_host/navigation_controller_android.cc
[modify] https://crrev.com/b49606cff1405d428ee028979f28f082f1abde3d/content/browser/frame_host/navigation_controller_impl_unittest.cc
[modify] https://crrev.com/b49606cff1405d428ee028979f28f082f1abde3d/content/browser/frame_host/navigation_entry_impl.cc
[modify] https://crrev.com/b49606cff1405d428ee028979f28f082f1abde3d/content/browser/frame_host/navigation_entry_impl.h
[modify] https://crrev.com/b49606cff1405d428ee028979f28f082f1abde3d/content/browser/frame_host/navigation_entry_impl_unittest.cc
[modify] https://crrev.com/b49606cff1405d428ee028979f28f082f1abde3d/content/browser/frame_host/navigation_handle_impl.cc
[modify] https://crrev.com/b49606cff1405d428ee028979f28f082f1abde3d/content/browser/frame_host/navigation_handle_impl.h
[modify] https://crrev.com/b49606cff1405d428ee028979f28f082f1abde3d/content/browser/frame_host/navigation_request.cc
[modify] https://crrev.com/b49606cff1405d428ee028979f28f082f1abde3d/content/browser/frame_host/navigation_request.h
[modify] https://crrev.com/b49606cff1405d428ee028979f28f082f1abde3d/content/browser/frame_host/navigator.h
[modify] https://crrev.com/b49606cff1405d428ee028979f28f082f1abde3d/content/browser/frame_host/navigator_impl.cc
[modify] https://crrev.com/b49606cff1405d428ee028979f28f082f1abde3d/content/browser/frame_host/navigator_impl.h
[modify] https://crrev.com/b49606cff1405d428ee028979f28f082f1abde3d/content/browser/frame_host/render_frame_host_impl.cc
[modify] https://crrev.com/b49606cff1405d428ee028979f28f082f1abde3d/content/browser/frame_host/render_frame_host_impl.h
[modify] https://crrev.com/b49606cff1405d428ee028979f28f082f1abde3d/content/browser/loader/resource_dispatcher_host_impl.cc
[modify] https://crrev.com/b49606cff1405d428ee028979f28f082f1abde3d/content/browser/loader/resource_request_info_impl.cc
[modify] https://crrev.com/b49606cff1405d428ee028979f28f082f1abde3d/content/browser/loader/resource_request_info_impl.h
[modify] https://crrev.com/b49606cff1405d428ee028979f28f082f1abde3d/content/browser/loader/upload_data_stream_builder.cc
[modify] https://crrev.com/b49606cff1405d428ee028979f28f082f1abde3d/content/browser/loader/upload_data_stream_builder.h
[modify] https://crrev.com/b49606cff1405d428ee028979f28f082f1abde3d/content/browser/loader/upload_data_stream_builder_unittest.cc
[modify] https://crrev.com/b49606cff1405d428ee028979f28f082f1abde3d/content/browser/security_exploit_browsertest.cc
[modify] https://crrev.com/b49606cff1405d428ee028979f28f082f1abde3d/content/browser/service_worker/service_worker_controllee_request_handler.cc
[modify] https://crrev.com/b49606cff1405d428ee028979f28f082f1abde3d/content/browser/service_worker/service_worker_controllee_request_handler.h
[modify] https://crrev.com/b49606cff1405d428ee028979f28f082f1abde3d/content/browser/service_worker/service_worker_controllee_request_handler_unittest.cc
[modify] https://crrev.com/b49606cff1405d428ee028979f28f082f1abde3d/content/browser/service_worker/service_worker_data_pipe_reader_unittest.cc
[modify] https://crrev.com/b49606cff1405d428ee028979f28f082f1abde3d/content/browser/service_worker/service_worker_provider_host.cc
[modify] https://crrev.com/b49606cff1405d428ee028979f28f082f1abde3d/content/browser/service_worker/service_worker_provider_host.h
[modify] https://crrev.com/b49606cff1405d428ee028979f28f082f1abde3d/content/browser/service_worker/service_worker_request_handler.cc
[modify] https://crrev.com/b49606cff1405d428ee028979f28f082f1abde3d/content/browser/service_worker/service_worker_request_handler.h
[modify] https://crrev.com/b49606cff1405d428ee028979f28f082f1abde3d/content/browser/service_worker/service_worker_url_loader_job_unittest.cc
[modify] https://crrev.com/b49606cff1405d428ee028979f28f082f1abde3d/content/browser/service_worker/service_worker_url_request_job.cc
[modify] https://crrev.com/b49606cff1405d428ee028979f28f082f1abde3d/content/browser/service_worker/service_worker_url_request_job.h
[modify] https://crrev.com/b49606cff1405d428ee028979f28f082f1abde3d/content/browser/service_worker/service_worker_url_request_job_unittest.cc
[modify] https://crrev.com/b49606cff1405d428ee028979f28f082f1abde3d/content/browser/service_worker/service_worker_write_to_cache_job_unittest.cc
[modify] https://crrev.com/b49606cff1405d428ee028979f28f082f1abde3d/content/common/BUILD.gn
[modify] https://crrev.com/b49606cff1405d428ee028979f28f082f1abde3d/content/common/frame_messages.h
[modify] https://crrev.com/b49606cff1405d428ee028979f28f082f1abde3d/content/common/native_types.typemap
[modify] https://crrev.com/b49606cff1405d428ee028979f28f082f1abde3d/content/common/navigation_params.cc
[modify] https://crrev.com/b49606cff1405d428ee028979f28f082f1abde3d/content/common/navigation_params.h
[modify] https://crrev.com/b49606cff1405d428ee028979f28f082f1abde3d/content/common/page_state_serialization.cc
[modify] https://crrev.com/b49606cff1405d428ee028979f28f082f1abde3d/content/common/page_state_serialization.h
[modify] https://crrev.com/b49606cff1405d428ee028979f28f082f1abde3d/content/common/page_state_serialization_unittest.cc
[modify] https://crrev.com/b49606cff1405d428ee028979f28f082f1abde3d/content/common/resource_messages.cc
[modify] https://crrev.com/b49606cff1405d428ee028979f28f082f1abde3d/content/common/resource_messages.h
[modify] https://crrev.com/b49606cff1405d428ee028979f28f082f1abde3d/content/network/data_pipe_element_reader.cc
[modify] https://crrev.com/b49606cff1405d428ee028979f28f082f1abde3d/content/network/data_pipe_element_reader.h
[modify] https://crrev.com/b49606cff1405d428ee028979f28f082f1abde3d/content/network/url_loader.cc
[modify] https://crrev.com/b49606cff1405d428ee028979f28f082f1abde3d/content/network/url_loader_unittest.cc
[modify] https://crrev.com/b49606cff1405d428ee028979f28f082f1abde3d/content/public/browser/DEPS
[modify] https://crrev.com/b49606cff1405d428ee028979f28f082f1abde3d/content/public/browser/navigation_controller.h
[modify] https://crrev.com/b49606cff1405d428ee028979f28f082f1abde3d/content/public/browser/navigation_entry.h
[modify] https://crrev.com/b49606cff1405d428ee028979f28f082f1abde3d/content/public/browser/navigation_handle.cc
[modify] https://crrev.com/b49606cff1405d428ee028979f28f082f1abde3d/content/public/browser/navigation_handle.h
[modify] https://crrev.com/b49606cff1405d428ee028979f28f082f1abde3d/content/public/browser/page_navigator.h
[modify] https://crrev.com/b49606cff1405d428ee028979f28f082f1abde3d/content/public/common/BUILD.gn
[modify] https://crrev.com/b49606cff1405d428ee028979f28f082f1abde3d/content/public/common/DEPS
[modify] https://crrev.com/b49606cff1405d428ee028979f28f082f1abde3d/content/public/common/page_state.cc
[modify] https://crrev.com/b49606cff1405d428ee028979f28f082f1abde3d/content/public/common/resource_request.h
[modify] https://crrev.com/b49606cff1405d428ee028979f28f082f1abde3d/content/public/common/resource_request_body_android.cc
[modify] https://crrev.com/b49606cff1405d428ee028979f28f082f1abde3d/content/public/common/resource_request_body_android.h
[modify] https://crrev.com/b49606cff1405d428ee028979f28f082f1abde3d/content/public/common/simple_url_loader.cc
[modify] https://crrev.com/b49606cff1405d428ee028979f28f082f1abde3d/content/public/common/simple_url_loader_unittest.cc
[modify] https://crrev.com/b49606cff1405d428ee028979f28f082f1abde3d/content/public/test/navigation_simulator.cc
[modify] https://crrev.com/b49606cff1405d428ee028979f28f082f1abde3d/content/renderer/fetchers/resource_fetcher_impl.cc
[modify] https://crrev.com/b49606cff1405d428ee028979f28f082f1abde3d/content/renderer/loader/resource_dispatcher_unittest.cc
[modify] https://crrev.com/b49606cff1405d428ee028979f28f082f1abde3d/content/renderer/loader/web_url_loader_impl.cc
[modify] https://crrev.com/b49606cff1405d428ee028979f28f082f1abde3d/content/renderer/loader/web_url_request_util.cc
[modify] https://crrev.com/b49606cff1405d428ee028979f28f082f1abde3d/content/renderer/loader/web_url_request_util.h
[modify] https://crrev.com/b49606cff1405d428ee028979f28f082f1abde3d/content/renderer/render_view_browsertest.cc
[modify] https://crrev.com/b49606cff1405d428ee028979f28f082f1abde3d/content/renderer/service_worker/service_worker_subresource_loader_unittest.cc
[modify] https://crrev.com/b49606cff1405d428ee028979f28f082f1abde3d/services/network/public/cpp/BUILD.gn
[rename] https://crrev.com/b49606cff1405d428ee028979f28f082f1abde3d/services/network/public/cpp/resource_request_body.cc
[rename] https://crrev.com/b49606cff1405d428ee028979f28f082f1abde3d/services/network/public/cpp/resource_request_body.h

Project Member

Comment 18 by bugdroid1@chromium.org, Jan 12 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1df61797e36153daa1441a15fab99d9d393c0b14

commit 1df61797e36153daa1441a15fab99d9d393c0b14
Author: John Abd-El-Malek <jam@chromium.org>
Date: Fri Jan 12 20:40:45 2018

Move ResourceRequest to services/network in preparation of moving content/network.

TBR=nasko for ipc changes

Bug: 753658
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo
Change-Id: I26cd2721b1894e81cb4f121ab39ad5e2e0dd735a
Reviewed-on: https://chromium-review.googlesource.com/865102
Commit-Queue: John Abd-El-Malek <jam@chromium.org>
Reviewed-by: Ken Rockot <rockot@chromium.org>
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Cr-Commit-Position: refs/heads/master@{#529053}
[modify] https://crrev.com/1df61797e36153daa1441a15fab99d9d393c0b14/chrome/browser/bitmap_fetcher/bitmap_fetcher.cc
[modify] https://crrev.com/1df61797e36153daa1441a15fab99d9d393c0b14/chrome/browser/bitmap_fetcher/bitmap_fetcher.h
[modify] https://crrev.com/1df61797e36153daa1441a15fab99d9d393c0b14/chrome/browser/chromeos/login/screens/terms_of_service_screen.cc
[modify] https://crrev.com/1df61797e36153daa1441a15fab99d9d393c0b14/chrome/browser/net/network_context_configuration_browsertest.cc
[modify] https://crrev.com/1df61797e36153daa1441a15fab99d9d393c0b14/chrome/browser/net/profile_network_context_service_browsertest.cc
[modify] https://crrev.com/1df61797e36153daa1441a15fab99d9d393c0b14/chrome/browser/ui/app_list/search/common/url_icon_source.cc
[modify] https://crrev.com/1df61797e36153daa1441a15fab99d9d393c0b14/chrome/common/DEPS
[modify] https://crrev.com/1df61797e36153daa1441a15fab99d9d393c0b14/chrome/common/prerender_url_loader_throttle.cc
[modify] https://crrev.com/1df61797e36153daa1441a15fab99d9d393c0b14/chrome/common/prerender_url_loader_throttle.h
[modify] https://crrev.com/1df61797e36153daa1441a15fab99d9d393c0b14/components/safe_browsing/browser/DEPS
[modify] https://crrev.com/1df61797e36153daa1441a15fab99d9d393c0b14/components/safe_browsing/browser/base_parallel_resource_throttle.cc
[modify] https://crrev.com/1df61797e36153daa1441a15fab99d9d393c0b14/components/safe_browsing/browser/browser_url_loader_throttle.cc
[modify] https://crrev.com/1df61797e36153daa1441a15fab99d9d393c0b14/components/safe_browsing/browser/browser_url_loader_throttle.h
[modify] https://crrev.com/1df61797e36153daa1441a15fab99d9d393c0b14/components/safe_browsing/renderer/DEPS
[modify] https://crrev.com/1df61797e36153daa1441a15fab99d9d393c0b14/components/safe_browsing/renderer/renderer_url_loader_throttle.cc
[modify] https://crrev.com/1df61797e36153daa1441a15fab99d9d393c0b14/components/safe_browsing/renderer/renderer_url_loader_throttle.h
[modify] https://crrev.com/1df61797e36153daa1441a15fab99d9d393c0b14/content/browser/appcache/appcache_request.cc
[modify] https://crrev.com/1df61797e36153daa1441a15fab99d9d393c0b14/content/browser/appcache/appcache_request.h
[modify] https://crrev.com/1df61797e36153daa1441a15fab99d9d393c0b14/content/browser/appcache/appcache_request_handler.cc
[modify] https://crrev.com/1df61797e36153daa1441a15fab99d9d393c0b14/content/browser/appcache/appcache_request_handler.h
[modify] https://crrev.com/1df61797e36153daa1441a15fab99d9d393c0b14/content/browser/appcache/appcache_request_handler_unittest.cc
[modify] https://crrev.com/1df61797e36153daa1441a15fab99d9d393c0b14/content/browser/appcache/appcache_subresource_url_factory.cc
[modify] https://crrev.com/1df61797e36153daa1441a15fab99d9d393c0b14/content/browser/appcache/appcache_subresource_url_factory.h
[modify] https://crrev.com/1df61797e36153daa1441a15fab99d9d393c0b14/content/browser/appcache/appcache_update_job_unittest.cc
[modify] https://crrev.com/1df61797e36153daa1441a15fab99d9d393c0b14/content/browser/appcache/appcache_update_url_loader_request.h
[modify] https://crrev.com/1df61797e36153daa1441a15fab99d9d393c0b14/content/browser/appcache/appcache_url_loader_job.h
[modify] https://crrev.com/1df61797e36153daa1441a15fab99d9d393c0b14/content/browser/appcache/appcache_url_loader_request.cc
[modify] https://crrev.com/1df61797e36153daa1441a15fab99d9d393c0b14/content/browser/appcache/appcache_url_loader_request.h
[modify] https://crrev.com/1df61797e36153daa1441a15fab99d9d393c0b14/content/browser/blob_storage/blob_internals_url_loader.cc
[modify] https://crrev.com/1df61797e36153daa1441a15fab99d9d393c0b14/content/browser/blob_storage/blob_internals_url_loader.h
[modify] https://crrev.com/1df61797e36153daa1441a15fab99d9d393c0b14/content/browser/blob_storage/blob_url_loader_factory.cc
[modify] https://crrev.com/1df61797e36153daa1441a15fab99d9d393c0b14/content/browser/blob_storage/blob_url_loader_factory.h
[modify] https://crrev.com/1df61797e36153daa1441a15fab99d9d393c0b14/content/browser/blob_storage/blob_url_unittest.cc
[modify] https://crrev.com/1df61797e36153daa1441a15fab99d9d393c0b14/content/browser/browsing_data/browsing_data_remover_impl_browsertest.cc
[modify] https://crrev.com/1df61797e36153daa1441a15fab99d9d393c0b14/content/browser/devtools/protocol/network_handler.cc
[modify] https://crrev.com/1df61797e36153daa1441a15fab99d9d393c0b14/content/browser/devtools/protocol/network_handler.h
[modify] https://crrev.com/1df61797e36153daa1441a15fab99d9d393c0b14/content/browser/devtools/service_worker_devtools_manager.cc
[modify] https://crrev.com/1df61797e36153daa1441a15fab99d9d393c0b14/content/browser/devtools/service_worker_devtools_manager.h
[modify] https://crrev.com/1df61797e36153daa1441a15fab99d9d393c0b14/content/browser/download/download_manager_impl.cc
[modify] https://crrev.com/1df61797e36153daa1441a15fab99d9d393c0b14/content/browser/download/download_manager_impl.h
[modify] https://crrev.com/1df61797e36153daa1441a15fab99d9d393c0b14/content/browser/download/download_response_handler.cc
[modify] https://crrev.com/1df61797e36153daa1441a15fab99d9d393c0b14/content/browser/download/download_response_handler.h
[modify] https://crrev.com/1df61797e36153daa1441a15fab99d9d393c0b14/content/browser/download/download_utils.cc
[modify] https://crrev.com/1df61797e36153daa1441a15fab99d9d393c0b14/content/browser/download/download_utils.h
[modify] https://crrev.com/1df61797e36153daa1441a15fab99d9d393c0b14/content/browser/download/resource_downloader.cc
[modify] https://crrev.com/1df61797e36153daa1441a15fab99d9d393c0b14/content/browser/download/resource_downloader.h
[modify] https://crrev.com/1df61797e36153daa1441a15fab99d9d393c0b14/content/browser/file_url_loader_factory.cc
[modify] https://crrev.com/1df61797e36153daa1441a15fab99d9d393c0b14/content/browser/file_url_loader_factory.h
[modify] https://crrev.com/1df61797e36153daa1441a15fab99d9d393c0b14/content/browser/frame_host/navigation_request.cc
[modify] https://crrev.com/1df61797e36153daa1441a15fab99d9d393c0b14/content/browser/histogram_internals_url_loader.cc
[modify] https://crrev.com/1df61797e36153daa1441a15fab99d9d393c0b14/content/browser/histogram_internals_url_loader.h
[modify] https://crrev.com/1df61797e36153daa1441a15fab99d9d393c0b14/content/browser/loader/mojo_async_resource_handler_unittest.cc
[modify] https://crrev.com/1df61797e36153daa1441a15fab99d9d393c0b14/content/browser/loader/navigation_url_loader_network_service.cc
[modify] https://crrev.com/1df61797e36153daa1441a15fab99d9d393c0b14/content/browser/loader/navigation_url_loader_network_service_unittest.cc
[modify] https://crrev.com/1df61797e36153daa1441a15fab99d9d393c0b14/content/browser/loader/resource_dispatcher_host_impl.cc
[modify] https://crrev.com/1df61797e36153daa1441a15fab99d9d393c0b14/content/browser/loader/resource_dispatcher_host_impl.h
[modify] https://crrev.com/1df61797e36153daa1441a15fab99d9d393c0b14/content/browser/loader/resource_dispatcher_host_unittest.cc
[modify] https://crrev.com/1df61797e36153daa1441a15fab99d9d393c0b14/content/browser/loader/resource_message_filter.cc
[modify] https://crrev.com/1df61797e36153daa1441a15fab99d9d393c0b14/content/browser/loader/resource_message_filter.h
[modify] https://crrev.com/1df61797e36153daa1441a15fab99d9d393c0b14/content/browser/loader/url_loader_factory_impl.cc
[modify] https://crrev.com/1df61797e36153daa1441a15fab99d9d393c0b14/content/browser/loader/url_loader_factory_impl.h
[modify] https://crrev.com/1df61797e36153daa1441a15fab99d9d393c0b14/content/browser/loader/url_loader_factory_impl_unittest.cc
[modify] https://crrev.com/1df61797e36153daa1441a15fab99d9d393c0b14/content/browser/loader/url_loader_request_handler.h
[modify] https://crrev.com/1df61797e36153daa1441a15fab99d9d393c0b14/content/browser/network_service_restart_browsertest.cc
[modify] https://crrev.com/1df61797e36153daa1441a15fab99d9d393c0b14/content/browser/security_exploit_browsertest.cc
[modify] https://crrev.com/1df61797e36153daa1441a15fab99d9d393c0b14/content/browser/service_worker/embedded_worker_test_helper.cc
[modify] https://crrev.com/1df61797e36153daa1441a15fab99d9d393c0b14/content/browser/service_worker/embedded_worker_test_helper.h
[modify] https://crrev.com/1df61797e36153daa1441a15fab99d9d393c0b14/content/browser/service_worker/service_worker_browsertest.cc
[modify] https://crrev.com/1df61797e36153daa1441a15fab99d9d393c0b14/content/browser/service_worker/service_worker_controllee_request_handler.cc
[modify] https://crrev.com/1df61797e36153daa1441a15fab99d9d393c0b14/content/browser/service_worker/service_worker_controllee_request_handler.h
[modify] https://crrev.com/1df61797e36153daa1441a15fab99d9d393c0b14/content/browser/service_worker/service_worker_fetch_dispatcher.cc
[modify] https://crrev.com/1df61797e36153daa1441a15fab99d9d393c0b14/content/browser/service_worker/service_worker_fetch_dispatcher.h
[modify] https://crrev.com/1df61797e36153daa1441a15fab99d9d393c0b14/content/browser/service_worker/service_worker_provider_host.cc
[modify] https://crrev.com/1df61797e36153daa1441a15fab99d9d393c0b14/content/browser/service_worker/service_worker_request_handler.cc
[modify] https://crrev.com/1df61797e36153daa1441a15fab99d9d393c0b14/content/browser/service_worker/service_worker_request_handler.h
[modify] https://crrev.com/1df61797e36153daa1441a15fab99d9d393c0b14/content/browser/service_worker/service_worker_script_url_loader.cc
[modify] https://crrev.com/1df61797e36153daa1441a15fab99d9d393c0b14/content/browser/service_worker/service_worker_script_url_loader.h
[modify] https://crrev.com/1df61797e36153daa1441a15fab99d9d393c0b14/content/browser/service_worker/service_worker_script_url_loader_factory.cc
[modify] https://crrev.com/1df61797e36153daa1441a15fab99d9d393c0b14/content/browser/service_worker/service_worker_script_url_loader_factory.h
[modify] https://crrev.com/1df61797e36153daa1441a15fab99d9d393c0b14/content/browser/service_worker/service_worker_script_url_loader_unittest.cc
[modify] https://crrev.com/1df61797e36153daa1441a15fab99d9d393c0b14/content/browser/service_worker/service_worker_url_loader_job.cc
[modify] https://crrev.com/1df61797e36153daa1441a15fab99d9d393c0b14/content/browser/service_worker/service_worker_url_loader_job.h
[modify] https://crrev.com/1df61797e36153daa1441a15fab99d9d393c0b14/content/browser/service_worker/service_worker_url_loader_job_unittest.cc
[modify] https://crrev.com/1df61797e36153daa1441a15fab99d9d393c0b14/content/browser/storage_partition_impl_browsertest.cc
[modify] https://crrev.com/1df61797e36153daa1441a15fab99d9d393c0b14/content/browser/webui/network_error_url_loader.cc
[modify] https://crrev.com/1df61797e36153daa1441a15fab99d9d393c0b14/content/browser/webui/network_error_url_loader.h
[modify] https://crrev.com/1df61797e36153daa1441a15fab99d9d393c0b14/content/browser/webui/web_ui_url_loader_factory.cc
[modify] https://crrev.com/1df61797e36153daa1441a15fab99d9d393c0b14/content/common/loader_util.cc
[modify] https://crrev.com/1df61797e36153daa1441a15fab99d9d393c0b14/content/common/loader_util.h
[modify] https://crrev.com/1df61797e36153daa1441a15fab99d9d393c0b14/content/common/resource_messages.h
[modify] https://crrev.com/1df61797e36153daa1441a15fab99d9d393c0b14/content/common/service_worker/service_worker_loader_helpers.cc
[modify] https://crrev.com/1df61797e36153daa1441a15fab99d9d393c0b14/content/common/service_worker/service_worker_loader_helpers.h
[modify] https://crrev.com/1df61797e36153daa1441a15fab99d9d393c0b14/content/common/throttling_url_loader.cc
[modify] https://crrev.com/1df61797e36153daa1441a15fab99d9d393c0b14/content/common/throttling_url_loader.h
[modify] https://crrev.com/1df61797e36153daa1441a15fab99d9d393c0b14/content/common/throttling_url_loader_unittest.cc
[modify] https://crrev.com/1df61797e36153daa1441a15fab99d9d393c0b14/content/network/network_service_unittest.cc
[modify] https://crrev.com/1df61797e36153daa1441a15fab99d9d393c0b14/content/network/network_service_url_loader_factory.cc
[modify] https://crrev.com/1df61797e36153daa1441a15fab99d9d393c0b14/content/network/network_service_url_loader_factory.h
[modify] https://crrev.com/1df61797e36153daa1441a15fab99d9d393c0b14/content/network/url_loader.cc
[modify] https://crrev.com/1df61797e36153daa1441a15fab99d9d393c0b14/content/network/url_loader.h
[modify] https://crrev.com/1df61797e36153daa1441a15fab99d9d393c0b14/content/network/url_loader_unittest.cc
[modify] https://crrev.com/1df61797e36153daa1441a15fab99d9d393c0b14/content/public/browser/file_url_loader.h
[modify] https://crrev.com/1df61797e36153daa1441a15fab99d9d393c0b14/content/public/common/BUILD.gn
[modify] https://crrev.com/1df61797e36153daa1441a15fab99d9d393c0b14/content/public/common/simple_url_loader.cc
[modify] https://crrev.com/1df61797e36153daa1441a15fab99d9d393c0b14/content/public/common/simple_url_loader.h
[modify] https://crrev.com/1df61797e36153daa1441a15fab99d9d393c0b14/content/public/common/simple_url_loader_unittest.cc
[modify] https://crrev.com/1df61797e36153daa1441a15fab99d9d393c0b14/content/public/common/url_loader_throttle.cc
[modify] https://crrev.com/1df61797e36153daa1441a15fab99d9d393c0b14/content/public/common/url_loader_throttle.h
[modify] https://crrev.com/1df61797e36153daa1441a15fab99d9d393c0b14/content/public/common/url_request.typemap
[modify] https://crrev.com/1df61797e36153daa1441a15fab99d9d393c0b14/content/public/test/browser_test_utils.cc
[modify] https://crrev.com/1df61797e36153daa1441a15fab99d9d393c0b14/content/public/test/url_loader_interceptor.cc
[modify] https://crrev.com/1df61797e36153daa1441a15fab99d9d393c0b14/content/public/test/url_loader_interceptor.h
[modify] https://crrev.com/1df61797e36153daa1441a15fab99d9d393c0b14/content/renderer/fetchers/resource_fetcher_impl.cc
[modify] https://crrev.com/1df61797e36153daa1441a15fab99d9d393c0b14/content/renderer/fetchers/resource_fetcher_impl.h
[modify] https://crrev.com/1df61797e36153daa1441a15fab99d9d393c0b14/content/renderer/loader/cors_url_loader.cc
[modify] https://crrev.com/1df61797e36153daa1441a15fab99d9d393c0b14/content/renderer/loader/cors_url_loader.h
[modify] https://crrev.com/1df61797e36153daa1441a15fab99d9d393c0b14/content/renderer/loader/cors_url_loader_factory.cc
[modify] https://crrev.com/1df61797e36153daa1441a15fab99d9d393c0b14/content/renderer/loader/cors_url_loader_factory.h
[modify] https://crrev.com/1df61797e36153daa1441a15fab99d9d393c0b14/content/renderer/loader/cors_url_loader_unittest.cc
[modify] https://crrev.com/1df61797e36153daa1441a15fab99d9d393c0b14/content/renderer/loader/request_extra_data.cc
[modify] https://crrev.com/1df61797e36153daa1441a15fab99d9d393c0b14/content/renderer/loader/request_extra_data.h
[modify] https://crrev.com/1df61797e36153daa1441a15fab99d9d393c0b14/content/renderer/loader/resource_dispatcher.cc
[modify] https://crrev.com/1df61797e36153daa1441a15fab99d9d393c0b14/content/renderer/loader/resource_dispatcher.h
[modify] https://crrev.com/1df61797e36153daa1441a15fab99d9d393c0b14/content/renderer/loader/resource_dispatcher_unittest.cc
[modify] https://crrev.com/1df61797e36153daa1441a15fab99d9d393c0b14/content/renderer/loader/sync_load_context.cc
[modify] https://crrev.com/1df61797e36153daa1441a15fab99d9d393c0b14/content/renderer/loader/sync_load_context.h
[modify] https://crrev.com/1df61797e36153daa1441a15fab99d9d393c0b14/content/renderer/loader/url_loader_client_impl_unittest.cc
[modify] https://crrev.com/1df61797e36153daa1441a15fab99d9d393c0b14/content/renderer/loader/url_response_body_consumer_unittest.cc
[modify] https://crrev.com/1df61797e36153daa1441a15fab99d9d393c0b14/content/renderer/loader/web_url_loader_impl.cc
[modify] https://crrev.com/1df61797e36153daa1441a15fab99d9d393c0b14/content/renderer/loader/web_url_loader_impl_unittest.cc
[modify] https://crrev.com/1df61797e36153daa1441a15fab99d9d393c0b14/content/renderer/service_worker/controller_service_worker_impl.cc
[modify] https://crrev.com/1df61797e36153daa1441a15fab99d9d393c0b14/content/renderer/service_worker/controller_service_worker_impl.h
[modify] https://crrev.com/1df61797e36153daa1441a15fab99d9d393c0b14/content/renderer/service_worker/service_worker_context_client.cc
[modify] https://crrev.com/1df61797e36153daa1441a15fab99d9d393c0b14/content/renderer/service_worker/service_worker_context_client.h
[modify] https://crrev.com/1df61797e36153daa1441a15fab99d9d393c0b14/content/renderer/service_worker/service_worker_context_client_unittest.cc
[modify] https://crrev.com/1df61797e36153daa1441a15fab99d9d393c0b14/content/renderer/service_worker/service_worker_provider_context_unittest.cc
[modify] https://crrev.com/1df61797e36153daa1441a15fab99d9d393c0b14/content/renderer/service_worker/service_worker_subresource_loader.cc
[modify] https://crrev.com/1df61797e36153daa1441a15fab99d9d393c0b14/content/renderer/service_worker/service_worker_subresource_loader.h
[modify] https://crrev.com/1df61797e36153daa1441a15fab99d9d393c0b14/content/renderer/service_worker/service_worker_subresource_loader_unittest.cc
[modify] https://crrev.com/1df61797e36153daa1441a15fab99d9d393c0b14/extensions/browser/extension_protocols.cc
[modify] https://crrev.com/1df61797e36153daa1441a15fab99d9d393c0b14/extensions/browser/url_request_util.cc
[modify] https://crrev.com/1df61797e36153daa1441a15fab99d9d393c0b14/services/network/public/cpp/BUILD.gn
[modify] https://crrev.com/1df61797e36153daa1441a15fab99d9d393c0b14/services/network/public/cpp/DEPS
[rename] https://crrev.com/1df61797e36153daa1441a15fab99d9d393c0b14/services/network/public/cpp/resource_request.cc
[rename] https://crrev.com/1df61797e36153daa1441a15fab99d9d393c0b14/services/network/public/cpp/resource_request.h

Comment 19 by jam@chromium.org, Jan 17 2018

Summary: Move content/network to services/network (was: Move content::Resource{Request,Response} into /services/network)
(generalizing the bug)
Issue 785420 has been merged into this issue.
Project Member

Comment 21 by bugdroid1@chromium.org, Jan 17 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7305ed16a2fdfa81ffdaffa557128e7699fdc856

commit 7305ed16a2fdfa81ffdaffa557128e7699fdc856
Author: John Abd-El-Malek <jam@chromium.org>
Date: Wed Jan 17 18:08:41 2018

Remove the usage of Referrer in content/network in preparation for moving it to services/network.

As part of this, remove 3 instances that were converting from net to blink and back to net enum.

Bug: 753658
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo
Change-Id: I77082e91d9e817c3c9e8434f4b2e67834b2a5f31
Reviewed-on: https://chromium-review.googlesource.com/869790
Reviewed-by: Yuzhu Shen <yzshen@chromium.org>
Commit-Queue: John Abd-El-Malek <jam@chromium.org>
Cr-Commit-Position: refs/heads/master@{#529804}
[modify] https://crrev.com/7305ed16a2fdfa81ffdaffa557128e7699fdc856/content/browser/loader/resource_dispatcher_host_impl.cc
[modify] https://crrev.com/7305ed16a2fdfa81ffdaffa557128e7699fdc856/content/common/loader_util.cc
[modify] https://crrev.com/7305ed16a2fdfa81ffdaffa557128e7699fdc856/content/common/loader_util.h
[modify] https://crrev.com/7305ed16a2fdfa81ffdaffa557128e7699fdc856/content/common/service_worker/service_worker_loader_helpers.cc
[modify] https://crrev.com/7305ed16a2fdfa81ffdaffa557128e7699fdc856/content/network/DEPS
[modify] https://crrev.com/7305ed16a2fdfa81ffdaffa557128e7699fdc856/content/network/url_loader.cc
[modify] https://crrev.com/7305ed16a2fdfa81ffdaffa557128e7699fdc856/content/network/url_loader_unittest.cc
[modify] https://crrev.com/7305ed16a2fdfa81ffdaffa557128e7699fdc856/content/public/common/referrer.cc
[modify] https://crrev.com/7305ed16a2fdfa81ffdaffa557128e7699fdc856/content/public/common/referrer.h

Project Member

Comment 22 by bugdroid1@chromium.org, Jan 17 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ff094aa1ff9e127c69dd2ccac13e18fd02730ab4

commit ff094aa1ff9e127c69dd2ccac13e18fd02730ab4
Author: Randy Smith <rdsmith@chromium.org>
Date: Wed Jan 17 18:21:27 2018

Move ResourceResponseInfo to //services/network.

Bug: 753658
Change-Id: If4f9a3f05aee311ec614e98e1c72aaf8dc6c87ad
Reviewed-on: https://chromium-review.googlesource.com/860263
Commit-Queue: Randy Smith <rdsmith@chromium.org>
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Cr-Commit-Position: refs/heads/master@{#529811}
[modify] https://crrev.com/ff094aa1ff9e127c69dd2ccac13e18fd02730ab4/chrome/browser/net/network_context_configuration_browsertest.cc
[modify] https://crrev.com/ff094aa1ff9e127c69dd2ccac13e18fd02730ab4/chrome/renderer/extensions/extension_localization_peer.cc
[modify] https://crrev.com/ff094aa1ff9e127c69dd2ccac13e18fd02730ab4/chrome/renderer/extensions/extension_localization_peer.h
[modify] https://crrev.com/ff094aa1ff9e127c69dd2ccac13e18fd02730ab4/chrome/renderer/extensions/extension_localization_peer_unittest.cc
[modify] https://crrev.com/ff094aa1ff9e127c69dd2ccac13e18fd02730ab4/chrome/renderer/security_filter_peer.cc
[modify] https://crrev.com/ff094aa1ff9e127c69dd2ccac13e18fd02730ab4/chrome/renderer/security_filter_peer.h
[modify] https://crrev.com/ff094aa1ff9e127c69dd2ccac13e18fd02730ab4/content/browser/browsing_data/clear_site_data_throttle.cc
[modify] https://crrev.com/ff094aa1ff9e127c69dd2ccac13e18fd02730ab4/content/browser/service_worker/service_worker_context_request_handler.cc
[modify] https://crrev.com/ff094aa1ff9e127c69dd2ccac13e18fd02730ab4/content/browser/service_worker/service_worker_controllee_request_handler.cc
[modify] https://crrev.com/ff094aa1ff9e127c69dd2ccac13e18fd02730ab4/content/browser/service_worker/service_worker_response_info.cc
[modify] https://crrev.com/ff094aa1ff9e127c69dd2ccac13e18fd02730ab4/content/browser/service_worker/service_worker_response_info.h
[modify] https://crrev.com/ff094aa1ff9e127c69dd2ccac13e18fd02730ab4/content/browser/storage_partition_impl_browsertest.cc
[modify] https://crrev.com/ff094aa1ff9e127c69dd2ccac13e18fd02730ab4/content/common/cross_site_document_classifier.cc
[modify] https://crrev.com/ff094aa1ff9e127c69dd2ccac13e18fd02730ab4/content/common/navigation_params.h
[modify] https://crrev.com/ff094aa1ff9e127c69dd2ccac13e18fd02730ab4/content/common/resource_messages.cc
[modify] https://crrev.com/ff094aa1ff9e127c69dd2ccac13e18fd02730ab4/content/common/resource_messages.h
[modify] https://crrev.com/ff094aa1ff9e127c69dd2ccac13e18fd02730ab4/content/common/service_worker/service_worker_messages.h
[modify] https://crrev.com/ff094aa1ff9e127c69dd2ccac13e18fd02730ab4/content/public/android/BUILD.gn
[modify] https://crrev.com/ff094aa1ff9e127c69dd2ccac13e18fd02730ab4/content/public/common/BUILD.gn
[modify] https://crrev.com/ff094aa1ff9e127c69dd2ccac13e18fd02730ab4/content/public/common/resource_response.h
[modify] https://crrev.com/ff094aa1ff9e127c69dd2ccac13e18fd02730ab4/content/public/renderer/request_peer.h
[modify] https://crrev.com/ff094aa1ff9e127c69dd2ccac13e18fd02730ab4/content/renderer/loader/resource_dispatcher.cc
[modify] https://crrev.com/ff094aa1ff9e127c69dd2ccac13e18fd02730ab4/content/renderer/loader/resource_dispatcher.h
[modify] https://crrev.com/ff094aa1ff9e127c69dd2ccac13e18fd02730ab4/content/renderer/loader/resource_dispatcher_unittest.cc
[modify] https://crrev.com/ff094aa1ff9e127c69dd2ccac13e18fd02730ab4/content/renderer/loader/site_isolation_stats_gatherer.cc
[modify] https://crrev.com/ff094aa1ff9e127c69dd2ccac13e18fd02730ab4/content/renderer/loader/site_isolation_stats_gatherer.h
[modify] https://crrev.com/ff094aa1ff9e127c69dd2ccac13e18fd02730ab4/content/renderer/loader/sync_load_context.cc
[modify] https://crrev.com/ff094aa1ff9e127c69dd2ccac13e18fd02730ab4/content/renderer/loader/sync_load_context.h
[modify] https://crrev.com/ff094aa1ff9e127c69dd2ccac13e18fd02730ab4/content/renderer/loader/sync_load_response.h
[modify] https://crrev.com/ff094aa1ff9e127c69dd2ccac13e18fd02730ab4/content/renderer/loader/test_request_peer.cc
[modify] https://crrev.com/ff094aa1ff9e127c69dd2ccac13e18fd02730ab4/content/renderer/loader/test_request_peer.h
[modify] https://crrev.com/ff094aa1ff9e127c69dd2ccac13e18fd02730ab4/content/renderer/loader/url_response_body_consumer_unittest.cc
[modify] https://crrev.com/ff094aa1ff9e127c69dd2ccac13e18fd02730ab4/content/renderer/loader/web_url_loader_impl.cc
[modify] https://crrev.com/ff094aa1ff9e127c69dd2ccac13e18fd02730ab4/content/renderer/loader/web_url_loader_impl.h
[modify] https://crrev.com/ff094aa1ff9e127c69dd2ccac13e18fd02730ab4/content/renderer/loader/web_url_loader_impl_unittest.cc
[modify] https://crrev.com/ff094aa1ff9e127c69dd2ccac13e18fd02730ab4/mojo/public/tools/bindings/chromium_bindings_configuration.gni
[modify] https://crrev.com/ff094aa1ff9e127c69dd2ccac13e18fd02730ab4/services/network/public/cpp/BUILD.gn
[modify] https://crrev.com/ff094aa1ff9e127c69dd2ccac13e18fd02730ab4/services/network/public/cpp/network_param_ipc_traits.cc
[modify] https://crrev.com/ff094aa1ff9e127c69dd2ccac13e18fd02730ab4/services/network/public/cpp/network_param_ipc_traits.h
[rename] https://crrev.com/ff094aa1ff9e127c69dd2ccac13e18fd02730ab4/services/network/public/cpp/resource_response_info.cc
[rename] https://crrev.com/ff094aa1ff9e127c69dd2ccac13e18fd02730ab4/services/network/public/cpp/resource_response_info.h

Comment 23 by jam@chromium.org, Jan 17 2018

Blocking: 803149
Project Member

Comment 24 by bugdroid1@chromium.org, Jan 17 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/462480368214f523f93f9e4a1a99a272a3159061

commit 462480368214f523f93f9e4a1a99a272a3159061
Author: John Abd-El-Malek <jam@chromium.org>
Date: Wed Jan 17 19:11:23 2018

Move resource_response.h to //services/network/public/cpp.

Bug: 753658
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo
Change-Id: Iae4c394b7c33b17746f7cb17c65446ccf49cffcd
Reviewed-on: https://chromium-review.googlesource.com/865664
Commit-Queue: John Abd-El-Malek <jam@chromium.org>
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Cr-Commit-Position: refs/heads/master@{#529839}
[modify] https://crrev.com/462480368214f523f93f9e4a1a99a272a3159061/android_webview/browser/renderer_host/aw_resource_dispatcher_host_delegate.cc
[modify] https://crrev.com/462480368214f523f93f9e4a1a99a272a3159061/android_webview/browser/renderer_host/aw_resource_dispatcher_host_delegate.h
[modify] https://crrev.com/462480368214f523f93f9e4a1a99a272a3159061/chrome/browser/loader/chrome_resource_dispatcher_host_delegate.cc
[modify] https://crrev.com/462480368214f523f93f9e4a1a99a272a3159061/chrome/browser/loader/chrome_resource_dispatcher_host_delegate.h
[modify] https://crrev.com/462480368214f523f93f9e4a1a99a272a3159061/chrome/browser/loader/chrome_resource_dispatcher_host_delegate_browsertest.cc
[modify] https://crrev.com/462480368214f523f93f9e4a1a99a272a3159061/chrome/browser/net/network_context_configuration_browsertest.cc
[modify] https://crrev.com/462480368214f523f93f9e4a1a99a272a3159061/chrome/common/prerender_url_loader_throttle.cc
[modify] https://crrev.com/462480368214f523f93f9e4a1a99a272a3159061/chrome/common/prerender_url_loader_throttle.h
[modify] https://crrev.com/462480368214f523f93f9e4a1a99a272a3159061/components/safe_browsing/browser/base_parallel_resource_throttle.cc
[modify] https://crrev.com/462480368214f523f93f9e4a1a99a272a3159061/components/safe_browsing/browser/browser_url_loader_throttle.cc
[modify] https://crrev.com/462480368214f523f93f9e4a1a99a272a3159061/components/safe_browsing/browser/browser_url_loader_throttle.h
[modify] https://crrev.com/462480368214f523f93f9e4a1a99a272a3159061/components/safe_browsing/renderer/renderer_url_loader_throttle.cc
[modify] https://crrev.com/462480368214f523f93f9e4a1a99a272a3159061/components/safe_browsing/renderer/renderer_url_loader_throttle.h
[modify] https://crrev.com/462480368214f523f93f9e4a1a99a272a3159061/content/browser/appcache/appcache_request_handler.cc
[modify] https://crrev.com/462480368214f523f93f9e4a1a99a272a3159061/content/browser/appcache/appcache_request_handler.h
[modify] https://crrev.com/462480368214f523f93f9e4a1a99a272a3159061/content/browser/appcache/appcache_request_handler_unittest.cc
[modify] https://crrev.com/462480368214f523f93f9e4a1a99a272a3159061/content/browser/appcache/appcache_subresource_url_factory.cc
[modify] https://crrev.com/462480368214f523f93f9e4a1a99a272a3159061/content/browser/appcache/appcache_update_job_unittest.cc
[modify] https://crrev.com/462480368214f523f93f9e4a1a99a272a3159061/content/browser/appcache/appcache_update_url_loader_request.cc
[modify] https://crrev.com/462480368214f523f93f9e4a1a99a272a3159061/content/browser/appcache/appcache_update_url_loader_request.h
[modify] https://crrev.com/462480368214f523f93f9e4a1a99a272a3159061/content/browser/appcache/appcache_url_loader_job.cc
[modify] https://crrev.com/462480368214f523f93f9e4a1a99a272a3159061/content/browser/appcache/appcache_url_loader_request.h
[modify] https://crrev.com/462480368214f523f93f9e4a1a99a272a3159061/content/browser/blob_storage/blob_internals_url_loader.cc
[modify] https://crrev.com/462480368214f523f93f9e4a1a99a272a3159061/content/browser/blob_storage/blob_url_loader_factory.cc
[modify] https://crrev.com/462480368214f523f93f9e4a1a99a272a3159061/content/browser/devtools/protocol/network_handler.cc
[modify] https://crrev.com/462480368214f523f93f9e4a1a99a272a3159061/content/browser/devtools/protocol/network_handler.h
[modify] https://crrev.com/462480368214f523f93f9e4a1a99a272a3159061/content/browser/devtools/service_worker_devtools_manager.cc
[modify] https://crrev.com/462480368214f523f93f9e4a1a99a272a3159061/content/browser/devtools/service_worker_devtools_manager.h
[modify] https://crrev.com/462480368214f523f93f9e4a1a99a272a3159061/content/browser/download/download_manager_impl.cc
[modify] https://crrev.com/462480368214f523f93f9e4a1a99a272a3159061/content/browser/download/download_manager_impl.h
[modify] https://crrev.com/462480368214f523f93f9e4a1a99a272a3159061/content/browser/download/download_resource_handler.cc
[modify] https://crrev.com/462480368214f523f93f9e4a1a99a272a3159061/content/browser/download/download_resource_handler.h
[modify] https://crrev.com/462480368214f523f93f9e4a1a99a272a3159061/content/browser/download/download_response_handler.cc
[modify] https://crrev.com/462480368214f523f93f9e4a1a99a272a3159061/content/browser/download/download_response_handler.h
[modify] https://crrev.com/462480368214f523f93f9e4a1a99a272a3159061/content/browser/download/resource_downloader.cc
[modify] https://crrev.com/462480368214f523f93f9e4a1a99a272a3159061/content/browser/download/resource_downloader.h
[modify] https://crrev.com/462480368214f523f93f9e4a1a99a272a3159061/content/browser/download/save_file_resource_handler.cc
[modify] https://crrev.com/462480368214f523f93f9e4a1a99a272a3159061/content/browser/download/save_file_resource_handler.h
[modify] https://crrev.com/462480368214f523f93f9e4a1a99a272a3159061/content/browser/file_url_loader_factory.cc
[modify] https://crrev.com/462480368214f523f93f9e4a1a99a272a3159061/content/browser/frame_host/navigation_request.cc
[modify] https://crrev.com/462480368214f523f93f9e4a1a99a272a3159061/content/browser/frame_host/navigation_request.h
[modify] https://crrev.com/462480368214f523f93f9e4a1a99a272a3159061/content/browser/frame_host/navigator_impl.cc
[modify] https://crrev.com/462480368214f523f93f9e4a1a99a272a3159061/content/browser/frame_host/navigator_impl_unittest.cc
[modify] https://crrev.com/462480368214f523f93f9e4a1a99a272a3159061/content/browser/frame_host/render_frame_host_impl.cc
[modify] https://crrev.com/462480368214f523f93f9e4a1a99a272a3159061/content/browser/frame_host/render_frame_host_impl.h
[modify] https://crrev.com/462480368214f523f93f9e4a1a99a272a3159061/content/browser/histogram_internals_url_loader.cc
[modify] https://crrev.com/462480368214f523f93f9e4a1a99a272a3159061/content/browser/loader/cross_site_document_resource_handler.cc
[modify] https://crrev.com/462480368214f523f93f9e4a1a99a272a3159061/content/browser/loader/cross_site_document_resource_handler.h
[modify] https://crrev.com/462480368214f523f93f9e4a1a99a272a3159061/content/browser/loader/cross_site_document_resource_handler_unittest.cc
[modify] https://crrev.com/462480368214f523f93f9e4a1a99a272a3159061/content/browser/loader/detachable_resource_handler.cc
[modify] https://crrev.com/462480368214f523f93f9e4a1a99a272a3159061/content/browser/loader/detachable_resource_handler.h
[modify] https://crrev.com/462480368214f523f93f9e4a1a99a272a3159061/content/browser/loader/detachable_resource_handler_unittest.cc
[modify] https://crrev.com/462480368214f523f93f9e4a1a99a272a3159061/content/browser/loader/intercepting_resource_handler.cc
[modify] https://crrev.com/462480368214f523f93f9e4a1a99a272a3159061/content/browser/loader/intercepting_resource_handler.h
[modify] https://crrev.com/462480368214f523f93f9e4a1a99a272a3159061/content/browser/loader/intercepting_resource_handler_unittest.cc
[modify] https://crrev.com/462480368214f523f93f9e4a1a99a272a3159061/content/browser/loader/layered_resource_handler.cc
[modify] https://crrev.com/462480368214f523f93f9e4a1a99a272a3159061/content/browser/loader/layered_resource_handler.h
[modify] https://crrev.com/462480368214f523f93f9e4a1a99a272a3159061/content/browser/loader/mime_sniffing_resource_handler.cc
[modify] https://crrev.com/462480368214f523f93f9e4a1a99a272a3159061/content/browser/loader/mime_sniffing_resource_handler.h
[modify] https://crrev.com/462480368214f523f93f9e4a1a99a272a3159061/content/browser/loader/mime_sniffing_resource_handler_unittest.cc
[modify] https://crrev.com/462480368214f523f93f9e4a1a99a272a3159061/content/browser/loader/mock_resource_loader.cc
[modify] https://crrev.com/462480368214f523f93f9e4a1a99a272a3159061/content/browser/loader/mock_resource_loader.h
[modify] https://crrev.com/462480368214f523f93f9e4a1a99a272a3159061/content/browser/loader/mojo_async_resource_handler.cc
[modify] https://crrev.com/462480368214f523f93f9e4a1a99a272a3159061/content/browser/loader/mojo_async_resource_handler.h
[modify] https://crrev.com/462480368214f523f93f9e4a1a99a272a3159061/content/browser/loader/mojo_async_resource_handler_unittest.cc
[modify] https://crrev.com/462480368214f523f93f9e4a1a99a272a3159061/content/browser/loader/navigation_resource_handler.cc
[modify] https://crrev.com/462480368214f523f93f9e4a1a99a272a3159061/content/browser/loader/navigation_resource_handler.h
[modify] https://crrev.com/462480368214f523f93f9e4a1a99a272a3159061/content/browser/loader/navigation_url_loader_delegate.h
[modify] https://crrev.com/462480368214f523f93f9e4a1a99a272a3159061/content/browser/loader/navigation_url_loader_impl.cc
[modify] https://crrev.com/462480368214f523f93f9e4a1a99a272a3159061/content/browser/loader/navigation_url_loader_impl.h
[modify] https://crrev.com/462480368214f523f93f9e4a1a99a272a3159061/content/browser/loader/navigation_url_loader_impl_core.cc
[modify] https://crrev.com/462480368214f523f93f9e4a1a99a272a3159061/content/browser/loader/navigation_url_loader_impl_core.h
[modify] https://crrev.com/462480368214f523f93f9e4a1a99a272a3159061/content/browser/loader/navigation_url_loader_network_service.cc
[modify] https://crrev.com/462480368214f523f93f9e4a1a99a272a3159061/content/browser/loader/navigation_url_loader_network_service.h
[modify] https://crrev.com/462480368214f523f93f9e4a1a99a272a3159061/content/browser/loader/navigation_url_loader_network_service_unittest.cc
[modify] https://crrev.com/462480368214f523f93f9e4a1a99a272a3159061/content/browser/loader/navigation_url_loader_unittest.cc
[modify] https://crrev.com/462480368214f523f93f9e4a1a99a272a3159061/content/browser/loader/redirect_to_file_resource_handler.cc
[modify] https://crrev.com/462480368214f523f93f9e4a1a99a272a3159061/content/browser/loader/redirect_to_file_resource_handler.h
[modify] https://crrev.com/462480368214f523f93f9e4a1a99a272a3159061/content/browser/loader/redirect_to_file_resource_handler_unittest.cc
[modify] https://crrev.com/462480368214f523f93f9e4a1a99a272a3159061/content/browser/loader/resource_dispatcher_host_impl.cc
[modify] https://crrev.com/462480368214f523f93f9e4a1a99a272a3159061/content/browser/loader/resource_dispatcher_host_impl.h
[modify] https://crrev.com/462480368214f523f93f9e4a1a99a272a3159061/content/browser/loader/resource_dispatcher_host_unittest.cc
[modify] https://crrev.com/462480368214f523f93f9e4a1a99a272a3159061/content/browser/loader/resource_handler.h
[modify] https://crrev.com/462480368214f523f93f9e4a1a99a272a3159061/content/browser/loader/resource_loader.cc
[modify] https://crrev.com/462480368214f523f93f9e4a1a99a272a3159061/content/browser/loader/resource_loader_delegate.h
[modify] https://crrev.com/462480368214f523f93f9e4a1a99a272a3159061/content/browser/loader/resource_loader_unittest.cc
[modify] https://crrev.com/462480368214f523f93f9e4a1a99a272a3159061/content/browser/loader/stream_resource_handler.cc
[modify] https://crrev.com/462480368214f523f93f9e4a1a99a272a3159061/content/browser/loader/stream_resource_handler.h
[modify] https://crrev.com/462480368214f523f93f9e4a1a99a272a3159061/content/browser/loader/test_resource_handler.cc
[modify] https://crrev.com/462480368214f523f93f9e4a1a99a272a3159061/content/browser/loader/test_resource_handler.h
[modify] https://crrev.com/462480368214f523f93f9e4a1a99a272a3159061/content/browser/loader/throttling_resource_handler.cc
[modify] https://crrev.com/462480368214f523f93f9e4a1a99a272a3159061/content/browser/loader/throttling_resource_handler.h
[modify] https://crrev.com/462480368214f523f93f9e4a1a99a272a3159061/content/browser/loader/throttling_resource_handler_unittest.cc
[modify] https://crrev.com/462480368214f523f93f9e4a1a99a272a3159061/content/browser/loader/url_loader_request_handler.cc
[modify] https://crrev.com/462480368214f523f93f9e4a1a99a272a3159061/content/browser/loader/url_loader_request_handler.h
[modify] https://crrev.com/462480368214f523f93f9e4a1a99a272a3159061/content/browser/service_worker/service_worker_fetch_dispatcher.cc
[modify] https://crrev.com/462480368214f523f93f9e4a1a99a272a3159061/content/browser/service_worker/service_worker_script_url_loader.cc
[modify] https://crrev.com/462480368214f523f93f9e4a1a99a272a3159061/content/browser/service_worker/service_worker_script_url_loader.h
[modify] https://crrev.com/462480368214f523f93f9e4a1a99a272a3159061/content/browser/service_worker/service_worker_script_url_loader_factory.cc
[modify] https://crrev.com/462480368214f523f93f9e4a1a99a272a3159061/content/browser/service_worker/service_worker_script_url_loader_unittest.cc
[modify] https://crrev.com/462480368214f523f93f9e4a1a99a272a3159061/content/browser/service_worker/service_worker_url_loader_job.h
[modify] https://crrev.com/462480368214f523f93f9e4a1a99a272a3159061/content/browser/service_worker/service_worker_url_loader_job_unittest.cc
[modify] https://crrev.com/462480368214f523f93f9e4a1a99a272a3159061/content/browser/storage_partition_impl_browsertest.cc
[modify] https://crrev.com/462480368214f523f93f9e4a1a99a272a3159061/content/browser/webui/web_ui_url_loader_factory.cc
[modify] https://crrev.com/462480368214f523f93f9e4a1a99a272a3159061/content/common/frame_messages.h
[modify] https://crrev.com/462480368214f523f93f9e4a1a99a272a3159061/content/common/loader_util.cc
[modify] https://crrev.com/462480368214f523f93f9e4a1a99a272a3159061/content/common/loader_util.h
[modify] https://crrev.com/462480368214f523f93f9e4a1a99a272a3159061/content/common/navigation_params.h
[modify] https://crrev.com/462480368214f523f93f9e4a1a99a272a3159061/content/common/resource_messages.h
[modify] https://crrev.com/462480368214f523f93f9e4a1a99a272a3159061/content/common/service_worker/service_worker_loader_helpers.cc
[modify] https://crrev.com/462480368214f523f93f9e4a1a99a272a3159061/content/common/service_worker/service_worker_loader_helpers.h
[modify] https://crrev.com/462480368214f523f93f9e4a1a99a272a3159061/content/common/throttling_url_loader.cc
[modify] https://crrev.com/462480368214f523f93f9e4a1a99a272a3159061/content/common/throttling_url_loader.h
[modify] https://crrev.com/462480368214f523f93f9e4a1a99a272a3159061/content/common/throttling_url_loader_unittest.cc
[modify] https://crrev.com/462480368214f523f93f9e4a1a99a272a3159061/content/network/DEPS
[modify] https://crrev.com/462480368214f523f93f9e4a1a99a272a3159061/content/network/cache_url_loader.cc
[modify] https://crrev.com/462480368214f523f93f9e4a1a99a272a3159061/content/network/url_loader.cc
[modify] https://crrev.com/462480368214f523f93f9e4a1a99a272a3159061/content/network/url_loader.h
[modify] https://crrev.com/462480368214f523f93f9e4a1a99a272a3159061/content/public/browser/resource_dispatcher_host_delegate.cc
[modify] https://crrev.com/462480368214f523f93f9e4a1a99a272a3159061/content/public/browser/resource_dispatcher_host_delegate.h
[modify] https://crrev.com/462480368214f523f93f9e4a1a99a272a3159061/content/public/common/BUILD.gn
[modify] https://crrev.com/462480368214f523f93f9e4a1a99a272a3159061/content/public/common/simple_url_loader.cc
[modify] https://crrev.com/462480368214f523f93f9e4a1a99a272a3159061/content/public/common/simple_url_loader.h
[modify] https://crrev.com/462480368214f523f93f9e4a1a99a272a3159061/content/public/common/simple_url_loader_unittest.cc
[modify] https://crrev.com/462480368214f523f93f9e4a1a99a272a3159061/content/public/common/url_loader_throttle.cc
[modify] https://crrev.com/462480368214f523f93f9e4a1a99a272a3159061/content/public/common/url_loader_throttle.h
[modify] https://crrev.com/462480368214f523f93f9e4a1a99a272a3159061/content/public/common/url_response_head.typemap
[modify] https://crrev.com/462480368214f523f93f9e4a1a99a272a3159061/content/public/test/navigation_simulator.cc
[modify] https://crrev.com/462480368214f523f93f9e4a1a99a272a3159061/content/public/test/test_url_loader_client.cc
[modify] https://crrev.com/462480368214f523f93f9e4a1a99a272a3159061/content/public/test/test_url_loader_client.h
[modify] https://crrev.com/462480368214f523f93f9e4a1a99a272a3159061/content/public/test/url_loader_interceptor.cc
[modify] https://crrev.com/462480368214f523f93f9e4a1a99a272a3159061/content/renderer/fetchers/resource_fetcher_impl.cc
[modify] https://crrev.com/462480368214f523f93f9e4a1a99a272a3159061/content/renderer/loader/cors_url_loader.cc
[modify] https://crrev.com/462480368214f523f93f9e4a1a99a272a3159061/content/renderer/loader/cors_url_loader.h
[modify] https://crrev.com/462480368214f523f93f9e4a1a99a272a3159061/content/renderer/loader/cors_url_loader_unittest.cc
[modify] https://crrev.com/462480368214f523f93f9e4a1a99a272a3159061/content/renderer/loader/resource_dispatcher.cc
[modify] https://crrev.com/462480368214f523f93f9e4a1a99a272a3159061/content/renderer/loader/resource_dispatcher.h
[modify] https://crrev.com/462480368214f523f93f9e4a1a99a272a3159061/content/renderer/loader/resource_dispatcher_unittest.cc
[modify] https://crrev.com/462480368214f523f93f9e4a1a99a272a3159061/content/renderer/loader/url_loader_client_impl.cc
[modify] https://crrev.com/462480368214f523f93f9e4a1a99a272a3159061/content/renderer/loader/url_loader_client_impl.h
[modify] https://crrev.com/462480368214f523f93f9e4a1a99a272a3159061/content/renderer/loader/url_loader_client_impl_unittest.cc
[modify] https://crrev.com/462480368214f523f93f9e4a1a99a272a3159061/content/renderer/loader/web_url_loader_impl.h
[modify] https://crrev.com/462480368214f523f93f9e4a1a99a272a3159061/content/renderer/render_frame_impl.cc
[modify] https://crrev.com/462480368214f523f93f9e4a1a99a272a3159061/content/renderer/render_frame_impl.h
[modify] https://crrev.com/462480368214f523f93f9e4a1a99a272a3159061/content/renderer/service_worker/service_worker_context_client.cc
[modify] https://crrev.com/462480368214f523f93f9e4a1a99a272a3159061/content/renderer/service_worker/service_worker_subresource_loader.cc
[modify] https://crrev.com/462480368214f523f93f9e4a1a99a272a3159061/content/renderer/service_worker/service_worker_subresource_loader.h
[modify] https://crrev.com/462480368214f523f93f9e4a1a99a272a3159061/content/renderer/service_worker/service_worker_subresource_loader_unittest.cc
[modify] https://crrev.com/462480368214f523f93f9e4a1a99a272a3159061/content/test/DEPS
[modify] https://crrev.com/462480368214f523f93f9e4a1a99a272a3159061/content/test/test_navigation_url_loader.cc
[modify] https://crrev.com/462480368214f523f93f9e4a1a99a272a3159061/content/test/test_navigation_url_loader.h
[modify] https://crrev.com/462480368214f523f93f9e4a1a99a272a3159061/content/test/test_navigation_url_loader_delegate.cc
[modify] https://crrev.com/462480368214f523f93f9e4a1a99a272a3159061/content/test/test_navigation_url_loader_delegate.h
[modify] https://crrev.com/462480368214f523f93f9e4a1a99a272a3159061/content/test/test_render_frame.cc
[modify] https://crrev.com/462480368214f523f93f9e4a1a99a272a3159061/content/test/test_render_frame_host.cc
[modify] https://crrev.com/462480368214f523f93f9e4a1a99a272a3159061/extensions/browser/extension_protocols.cc
[modify] https://crrev.com/462480368214f523f93f9e4a1a99a272a3159061/services/network/public/cpp/BUILD.gn
[modify] https://crrev.com/462480368214f523f93f9e4a1a99a272a3159061/services/network/public/cpp/network_param_ipc_traits.h
[rename] https://crrev.com/462480368214f523f93f9e4a1a99a272a3159061/services/network/public/cpp/resource_response.cc
[rename] https://crrev.com/462480368214f523f93f9e4a1a99a272a3159061/services/network/public/cpp/resource_response.h

Project Member

Comment 25 by bugdroid1@chromium.org, Jan 17 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3ea9867e6d9a5965c7481d1eb03719ab47476ecd

commit 3ea9867e6d9a5965c7481d1eb03719ab47476ecd
Author: John Abd-El-Malek <jam@chromium.org>
Date: Wed Jan 17 20:33:06 2018

Move proxy_config.mojom and its related C++ files to services/network.

This is in preparation of moving content/network to services/network.

TBR=nasko

Bug: 753658
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo
Change-Id: Ibcd229b465a8df60333f3aac0421b36a8fafc0b4
Reviewed-on: https://chromium-review.googlesource.com/870731
Commit-Queue: John Abd-El-Malek <jam@chromium.org>
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Reviewed-by: Nasko Oskov <nasko@chromium.org>
Reviewed-by: Ken Rockot <rockot@chromium.org>
Cr-Commit-Position: refs/heads/master@{#529858}
[modify] https://crrev.com/3ea9867e6d9a5965c7481d1eb03719ab47476ecd/chrome/browser/net/proxy_config_monitor.cc
[modify] https://crrev.com/3ea9867e6d9a5965c7481d1eb03719ab47476ecd/chrome/browser/net/proxy_config_monitor.h
[modify] https://crrev.com/3ea9867e6d9a5965c7481d1eb03719ab47476ecd/chrome/browser/profiles/profile_io_data.cc
[modify] https://crrev.com/3ea9867e6d9a5965c7481d1eb03719ab47476ecd/content/network/BUILD.gn
[modify] https://crrev.com/3ea9867e6d9a5965c7481d1eb03719ab47476ecd/content/network/DEPS
[modify] https://crrev.com/3ea9867e6d9a5965c7481d1eb03719ab47476ecd/content/network/network_context.cc
[modify] https://crrev.com/3ea9867e6d9a5965c7481d1eb03719ab47476ecd/content/network/network_context_unittest.cc
[modify] https://crrev.com/3ea9867e6d9a5965c7481d1eb03719ab47476ecd/content/public/common/BUILD.gn
[modify] https://crrev.com/3ea9867e6d9a5965c7481d1eb03719ab47476ecd/content/public/common/network_service.mojom
[delete] https://crrev.com/696ed9bc2fb815a5d32014dbb98d7337c3703065/content/public/common/proxy_config.typemap
[modify] https://crrev.com/3ea9867e6d9a5965c7481d1eb03719ab47476ecd/content/public/common/typemaps.gni
[modify] https://crrev.com/3ea9867e6d9a5965c7481d1eb03719ab47476ecd/content/test/BUILD.gn
[modify] https://crrev.com/3ea9867e6d9a5965c7481d1eb03719ab47476ecd/services/BUILD.gn
[modify] https://crrev.com/3ea9867e6d9a5965c7481d1eb03719ab47476ecd/services/network/BUILD.gn
[rename] https://crrev.com/3ea9867e6d9a5965c7481d1eb03719ab47476ecd/services/network/proxy_config_service_mojo.cc
[rename] https://crrev.com/3ea9867e6d9a5965c7481d1eb03719ab47476ecd/services/network/proxy_config_service_mojo.h
[rename] https://crrev.com/3ea9867e6d9a5965c7481d1eb03719ab47476ecd/services/network/proxy_config_service_mojo_unittest.cc
[modify] https://crrev.com/3ea9867e6d9a5965c7481d1eb03719ab47476ecd/services/network/public/cpp/BUILD.gn
[add] https://crrev.com/3ea9867e6d9a5965c7481d1eb03719ab47476ecd/services/network/public/cpp/proxy_config.typemap
[rename] https://crrev.com/3ea9867e6d9a5965c7481d1eb03719ab47476ecd/services/network/public/cpp/proxy_config_traits.cc
[rename] https://crrev.com/3ea9867e6d9a5965c7481d1eb03719ab47476ecd/services/network/public/cpp/proxy_config_traits.h
[rename] https://crrev.com/3ea9867e6d9a5965c7481d1eb03719ab47476ecd/services/network/public/cpp/proxy_config_traits_unittest.cc
[modify] https://crrev.com/3ea9867e6d9a5965c7481d1eb03719ab47476ecd/services/network/public/cpp/typemaps.gni
[modify] https://crrev.com/3ea9867e6d9a5965c7481d1eb03719ab47476ecd/services/network/public/interfaces/BUILD.gn
[rename] https://crrev.com/3ea9867e6d9a5965c7481d1eb03719ab47476ecd/services/network/public/interfaces/proxy_config.mojom

Project Member

Comment 26 by bugdroid1@chromium.org, Jan 17 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/baf611e16997ded33cae4f4b8aa691fcef8fabec

commit baf611e16997ded33cae4f4b8aa691fcef8fabec
Author: John Abd-El-Malek <jam@chromium.org>
Date: Wed Jan 17 23:10:13 2018

Remove the usage of ResourceType in content/network in preparation for moving it to
services/network.

In general, the network service shouldn't know about different behavior depending on the resource
type. It's up to the caller to configure various options, headers, etc...

This change:
1) Moves setting the "Accept" header to the caller. The renderer is the only place that makes
favicon/image/stylesheet requests, so it sets those special Accept headers there. The browser sets
the Accept header for frame requests since it's the only one that makes them now with PlzNavigate.
2) The update_first_party_url_on_redirect option is set in the browser for frame requests.

Bug: 753658
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo
Change-Id: Ide1426b834140a2b9b6488c8c201ec5eacf9817a
Reviewed-on: https://chromium-review.googlesource.com/865561
Commit-Queue: John Abd-El-Malek <jam@chromium.org>
Reviewed-by: Ken Rockot <rockot@chromium.org>
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Cr-Commit-Position: refs/heads/master@{#529944}
[add] https://crrev.com/baf611e16997ded33cae4f4b8aa691fcef8fabec/chrome/browser/net/chrome_accept_header_browsertest.cc
[modify] https://crrev.com/baf611e16997ded33cae4f4b8aa691fcef8fabec/chrome/test/BUILD.gn
[modify] https://crrev.com/baf611e16997ded33cae4f4b8aa691fcef8fabec/content/browser/loader/mime_sniffing_resource_handler.cc
[modify] https://crrev.com/baf611e16997ded33cae4f4b8aa691fcef8fabec/content/browser/loader/mime_sniffing_resource_handler_unittest.cc
[modify] https://crrev.com/baf611e16997ded33cae4f4b8aa691fcef8fabec/content/browser/loader/navigation_url_loader_network_service.cc
[modify] https://crrev.com/baf611e16997ded33cae4f4b8aa691fcef8fabec/content/browser/loader/resource_dispatcher_host_impl.cc
[add] https://crrev.com/baf611e16997ded33cae4f4b8aa691fcef8fabec/content/browser/net/accept_header_browsertest.cc
[modify] https://crrev.com/baf611e16997ded33cae4f4b8aa691fcef8fabec/content/browser/network_service_client.cc
[modify] https://crrev.com/baf611e16997ded33cae4f4b8aa691fcef8fabec/content/browser/network_service_client.h
[modify] https://crrev.com/baf611e16997ded33cae4f4b8aa691fcef8fabec/content/common/loader_util.cc
[modify] https://crrev.com/baf611e16997ded33cae4f4b8aa691fcef8fabec/content/common/loader_util.h
[modify] https://crrev.com/baf611e16997ded33cae4f4b8aa691fcef8fabec/content/common/resource_messages.h
[modify] https://crrev.com/baf611e16997ded33cae4f4b8aa691fcef8fabec/content/network/DEPS
[modify] https://crrev.com/baf611e16997ded33cae4f4b8aa691fcef8fabec/content/network/url_loader.cc
[modify] https://crrev.com/baf611e16997ded33cae4f4b8aa691fcef8fabec/content/network/url_loader.h
[modify] https://crrev.com/baf611e16997ded33cae4f4b8aa691fcef8fabec/content/network/url_loader_unittest.cc
[modify] https://crrev.com/baf611e16997ded33cae4f4b8aa691fcef8fabec/content/public/common/network_service.mojom
[modify] https://crrev.com/baf611e16997ded33cae4f4b8aa691fcef8fabec/content/renderer/loader/web_url_loader_impl.cc
[modify] https://crrev.com/baf611e16997ded33cae4f4b8aa691fcef8fabec/content/test/BUILD.gn
[add] https://crrev.com/baf611e16997ded33cae4f4b8aa691fcef8fabec/content/test/data/accept-header-iframe.html
[add] https://crrev.com/baf611e16997ded33cae4f4b8aa691fcef8fabec/content/test/data/accept-header-iframe.html.mock-http-headers
[add] https://crrev.com/baf611e16997ded33cae4f4b8aa691fcef8fabec/content/test/data/accept-header.html
[modify] https://crrev.com/baf611e16997ded33cae4f4b8aa691fcef8fabec/services/network/public/cpp/resource_request.h
[modify] https://crrev.com/baf611e16997ded33cae4f4b8aa691fcef8fabec/testing/buildbot/filters/mojo.fyi.network_browser_tests.filter

Project Member

Comment 27 by bugdroid1@chromium.org, Jan 18 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b165dc5211edda5957d621643749d22d71152afe

commit b165dc5211edda5957d621643749d22d71152afe
Author: John Abd-El-Malek <jam@chromium.org>
Date: Thu Jan 18 17:12:18 2018

Move url_loader.mojom and url_loader_factory.mojom to services/network.

TBR=nasko

Bug: 753658
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo
Change-Id: I275cafb2676007dc49d90435dd0be525601089de
Reviewed-on: https://chromium-review.googlesource.com/871663
Commit-Queue: John Abd-El-Malek <jam@chromium.org>
Reviewed-by: Ken Rockot <rockot@chromium.org>
Cr-Commit-Position: refs/heads/master@{#530175}
[modify] https://crrev.com/b165dc5211edda5957d621643749d22d71152afe/chrome/browser/android/compositor/scene_layer/contextual_search_scene_layer.cc
[modify] https://crrev.com/b165dc5211edda5957d621643749d22d71152afe/chrome/browser/bitmap_fetcher/bitmap_fetcher.cc
[modify] https://crrev.com/b165dc5211edda5957d621643749d22d71152afe/chrome/browser/bitmap_fetcher/bitmap_fetcher.h
[modify] https://crrev.com/b165dc5211edda5957d621643749d22d71152afe/chrome/browser/chromeos/app_mode/kiosk_app_data.cc
[modify] https://crrev.com/b165dc5211edda5957d621643749d22d71152afe/chrome/browser/chromeos/app_mode/kiosk_app_data.h
[modify] https://crrev.com/b165dc5211edda5957d621643749d22d71152afe/chrome/browser/chromeos/login/screens/terms_of_service_screen.cc
[modify] https://crrev.com/b165dc5211edda5957d621643749d22d71152afe/chrome/browser/extensions/api/dashboard_private/dashboard_private_api.cc
[modify] https://crrev.com/b165dc5211edda5957d621643749d22d71152afe/chrome/browser/extensions/api/webstore_private/webstore_private_api.cc
[modify] https://crrev.com/b165dc5211edda5957d621643749d22d71152afe/chrome/browser/extensions/chrome_url_request_util.h
[modify] https://crrev.com/b165dc5211edda5957d621643749d22d71152afe/chrome/browser/extensions/webstore_install_helper.cc
[modify] https://crrev.com/b165dc5211edda5957d621643749d22d71152afe/chrome/browser/extensions/webstore_install_helper.h
[modify] https://crrev.com/b165dc5211edda5957d621643749d22d71152afe/chrome/browser/net/errorpage_browsertest.cc
[modify] https://crrev.com/b165dc5211edda5957d621643749d22d71152afe/chrome/browser/net/network_context_configuration_browsertest.cc
[modify] https://crrev.com/b165dc5211edda5957d621643749d22d71152afe/chrome/browser/net/profile_network_context_service_browsertest.cc
[modify] https://crrev.com/b165dc5211edda5957d621643749d22d71152afe/chrome/browser/net/system_network_context_manager.cc
[modify] https://crrev.com/b165dc5211edda5957d621643749d22d71152afe/chrome/browser/net/system_network_context_manager.h
[modify] https://crrev.com/b165dc5211edda5957d621643749d22d71152afe/chrome/browser/password_manager/account_chooser_dialog_android.cc
[modify] https://crrev.com/b165dc5211edda5957d621643749d22d71152afe/chrome/browser/prerender/prerender_browsertest.cc
[modify] https://crrev.com/b165dc5211edda5957d621643749d22d71152afe/chrome/browser/profiles/profile_avatar_downloader.cc
[modify] https://crrev.com/b165dc5211edda5957d621643749d22d71152afe/chrome/browser/ui/app_list/search/common/url_icon_source.cc
[modify] https://crrev.com/b165dc5211edda5957d621643749d22d71152afe/chrome/browser/ui/app_list/search/webstore/webstore_result.cc
[modify] https://crrev.com/b165dc5211edda5957d621643749d22d71152afe/chrome/browser/ui/cocoa/passwords/account_avatar_fetcher_manager.h
[modify] https://crrev.com/b165dc5211edda5957d621643749d22d71152afe/chrome/browser/ui/cocoa/passwords/account_avatar_fetcher_manager.mm
[modify] https://crrev.com/b165dc5211edda5957d621643749d22d71152afe/chrome/browser/ui/cocoa/passwords/account_chooser_view_controller_unittest.mm
[modify] https://crrev.com/b165dc5211edda5957d621643749d22d71152afe/chrome/browser/ui/cocoa/passwords/auto_signin_view_controller.mm
[modify] https://crrev.com/b165dc5211edda5957d621643749d22d71152afe/chrome/browser/ui/cocoa/passwords/autosignin_prompt_view_controller_unittest.mm
[modify] https://crrev.com/b165dc5211edda5957d621643749d22d71152afe/chrome/browser/ui/cocoa/passwords/password_prompt_bridge_interface.h
[modify] https://crrev.com/b165dc5211edda5957d621643749d22d71152afe/chrome/browser/ui/cocoa/passwords/password_prompt_view_bridge.h
[modify] https://crrev.com/b165dc5211edda5957d621643749d22d71152afe/chrome/browser/ui/cocoa/passwords/password_prompt_view_bridge.mm
[modify] https://crrev.com/b165dc5211edda5957d621643749d22d71152afe/chrome/browser/ui/passwords/account_avatar_fetcher.cc
[modify] https://crrev.com/b165dc5211edda5957d621643749d22d71152afe/chrome/browser/ui/passwords/account_avatar_fetcher.h
[modify] https://crrev.com/b165dc5211edda5957d621643749d22d71152afe/chrome/browser/ui/views/passwords/account_chooser_dialog_view.cc
[modify] https://crrev.com/b165dc5211edda5957d621643749d22d71152afe/chrome/browser/ui/views/passwords/credentials_item_view.cc
[modify] https://crrev.com/b165dc5211edda5957d621643749d22d71152afe/chrome/browser/ui/views/passwords/credentials_item_view.h
[modify] https://crrev.com/b165dc5211edda5957d621643749d22d71152afe/content/browser/appcache/appcache_frontend_proxy.cc
[modify] https://crrev.com/b165dc5211edda5957d621643749d22d71152afe/content/browser/appcache/appcache_frontend_proxy.h
[modify] https://crrev.com/b165dc5211edda5957d621643749d22d71152afe/content/browser/appcache/appcache_group_unittest.cc
[modify] https://crrev.com/b165dc5211edda5957d621643749d22d71152afe/content/browser/appcache/appcache_host.cc
[modify] https://crrev.com/b165dc5211edda5957d621643749d22d71152afe/content/browser/appcache/appcache_host_unittest.cc
[modify] https://crrev.com/b165dc5211edda5957d621643749d22d71152afe/content/browser/appcache/appcache_navigation_handle_core.cc
[modify] https://crrev.com/b165dc5211edda5957d621643749d22d71152afe/content/browser/appcache/appcache_navigation_handle_core.h
[modify] https://crrev.com/b165dc5211edda5957d621643749d22d71152afe/content/browser/appcache/appcache_request_handler.cc
[modify] https://crrev.com/b165dc5211edda5957d621643749d22d71152afe/content/browser/appcache/appcache_request_handler.h
[modify] https://crrev.com/b165dc5211edda5957d621643749d22d71152afe/content/browser/appcache/appcache_request_handler_unittest.cc
[modify] https://crrev.com/b165dc5211edda5957d621643749d22d71152afe/content/browser/appcache/appcache_storage_impl_unittest.cc
[modify] https://crrev.com/b165dc5211edda5957d621643749d22d71152afe/content/browser/appcache/appcache_subresource_url_factory.cc
[modify] https://crrev.com/b165dc5211edda5957d621643749d22d71152afe/content/browser/appcache/appcache_subresource_url_factory.h
[modify] https://crrev.com/b165dc5211edda5957d621643749d22d71152afe/content/browser/appcache/appcache_unittest.cc
[modify] https://crrev.com/b165dc5211edda5957d621643749d22d71152afe/content/browser/appcache/appcache_update_job_unittest.cc
[modify] https://crrev.com/b165dc5211edda5957d621643749d22d71152afe/content/browser/appcache/appcache_update_url_loader_request.cc
[modify] https://crrev.com/b165dc5211edda5957d621643749d22d71152afe/content/browser/appcache/appcache_update_url_loader_request.h
[modify] https://crrev.com/b165dc5211edda5957d621643749d22d71152afe/content/browser/appcache/appcache_url_loader_job.cc
[modify] https://crrev.com/b165dc5211edda5957d621643749d22d71152afe/content/browser/appcache/appcache_url_loader_job.h
[modify] https://crrev.com/b165dc5211edda5957d621643749d22d71152afe/content/browser/blob_storage/blob_internals_url_loader.cc
[modify] https://crrev.com/b165dc5211edda5957d621643749d22d71152afe/content/browser/blob_storage/blob_internals_url_loader.h
[modify] https://crrev.com/b165dc5211edda5957d621643749d22d71152afe/content/browser/blob_storage/blob_url_loader_factory.cc
[modify] https://crrev.com/b165dc5211edda5957d621643749d22d71152afe/content/browser/blob_storage/blob_url_loader_factory.h
[modify] https://crrev.com/b165dc5211edda5957d621643749d22d71152afe/content/browser/blob_storage/blob_url_unittest.cc
[modify] https://crrev.com/b165dc5211edda5957d621643749d22d71152afe/content/browser/browsing_data/browsing_data_remover_impl_browsertest.cc
[modify] https://crrev.com/b165dc5211edda5957d621643749d22d71152afe/content/browser/download/download_manager_impl.cc
[modify] https://crrev.com/b165dc5211edda5957d621643749d22d71152afe/content/browser/download/download_manager_impl.h
[modify] https://crrev.com/b165dc5211edda5957d621643749d22d71152afe/content/browser/download/download_response_handler.cc
[modify] https://crrev.com/b165dc5211edda5957d621643749d22d71152afe/content/browser/download/download_response_handler.h
[modify] https://crrev.com/b165dc5211edda5957d621643749d22d71152afe/content/browser/download/resource_downloader.cc
[modify] https://crrev.com/b165dc5211edda5957d621643749d22d71152afe/content/browser/download/resource_downloader.h
[modify] https://crrev.com/b165dc5211edda5957d621643749d22d71152afe/content/browser/file_url_loader_factory.cc
[modify] https://crrev.com/b165dc5211edda5957d621643749d22d71152afe/content/browser/file_url_loader_factory.h
[modify] https://crrev.com/b165dc5211edda5957d621643749d22d71152afe/content/browser/frame_host/navigation_request.cc
[modify] https://crrev.com/b165dc5211edda5957d621643749d22d71152afe/content/browser/frame_host/navigation_request.h
[modify] https://crrev.com/b165dc5211edda5957d621643749d22d71152afe/content/browser/frame_host/navigator_impl.cc
[modify] https://crrev.com/b165dc5211edda5957d621643749d22d71152afe/content/browser/frame_host/render_frame_host_impl.cc
[modify] https://crrev.com/b165dc5211edda5957d621643749d22d71152afe/content/browser/frame_host/render_frame_host_impl.h
[modify] https://crrev.com/b165dc5211edda5957d621643749d22d71152afe/content/browser/histogram_internals_url_loader.cc
[modify] https://crrev.com/b165dc5211edda5957d621643749d22d71152afe/content/browser/histogram_internals_url_loader.h
[modify] https://crrev.com/b165dc5211edda5957d621643749d22d71152afe/content/browser/loader/downloaded_temp_file_impl.cc
[modify] https://crrev.com/b165dc5211edda5957d621643749d22d71152afe/content/browser/loader/downloaded_temp_file_impl.h
[modify] https://crrev.com/b165dc5211edda5957d621643749d22d71152afe/content/browser/loader/mojo_async_resource_handler.cc
[modify] https://crrev.com/b165dc5211edda5957d621643749d22d71152afe/content/browser/loader/mojo_async_resource_handler.h
[modify] https://crrev.com/b165dc5211edda5957d621643749d22d71152afe/content/browser/loader/mojo_async_resource_handler_unittest.cc
[modify] https://crrev.com/b165dc5211edda5957d621643749d22d71152afe/content/browser/loader/navigation_url_loader_delegate.h
[modify] https://crrev.com/b165dc5211edda5957d621643749d22d71152afe/content/browser/loader/navigation_url_loader_impl.cc
[modify] https://crrev.com/b165dc5211edda5957d621643749d22d71152afe/content/browser/loader/navigation_url_loader_impl_core.cc
[modify] https://crrev.com/b165dc5211edda5957d621643749d22d71152afe/content/browser/loader/navigation_url_loader_network_service.cc
[modify] https://crrev.com/b165dc5211edda5957d621643749d22d71152afe/content/browser/loader/navigation_url_loader_network_service.h
[modify] https://crrev.com/b165dc5211edda5957d621643749d22d71152afe/content/browser/loader/navigation_url_loader_network_service_unittest.cc
[modify] https://crrev.com/b165dc5211edda5957d621643749d22d71152afe/content/browser/loader/resource_dispatcher_host_impl.cc
[modify] https://crrev.com/b165dc5211edda5957d621643749d22d71152afe/content/browser/loader/resource_dispatcher_host_impl.h
[modify] https://crrev.com/b165dc5211edda5957d621643749d22d71152afe/content/browser/loader/resource_dispatcher_host_unittest.cc
[modify] https://crrev.com/b165dc5211edda5957d621643749d22d71152afe/content/browser/loader/resource_message_filter.cc
[modify] https://crrev.com/b165dc5211edda5957d621643749d22d71152afe/content/browser/loader/resource_message_filter.h
[modify] https://crrev.com/b165dc5211edda5957d621643749d22d71152afe/content/browser/loader/resource_request_info_impl.cc
[modify] https://crrev.com/b165dc5211edda5957d621643749d22d71152afe/content/browser/loader/resource_request_info_impl.h
[modify] https://crrev.com/b165dc5211edda5957d621643749d22d71152afe/content/browser/loader/url_loader_factory_impl.cc
[modify] https://crrev.com/b165dc5211edda5957d621643749d22d71152afe/content/browser/loader/url_loader_factory_impl.h
[modify] https://crrev.com/b165dc5211edda5957d621643749d22d71152afe/content/browser/loader/url_loader_factory_impl_unittest.cc
[modify] https://crrev.com/b165dc5211edda5957d621643749d22d71152afe/content/browser/loader/url_loader_request_handler.cc
[modify] https://crrev.com/b165dc5211edda5957d621643749d22d71152afe/content/browser/loader/url_loader_request_handler.h
[modify] https://crrev.com/b165dc5211edda5957d621643749d22d71152afe/content/browser/renderer_host/render_process_host_impl.cc
[modify] https://crrev.com/b165dc5211edda5957d621643749d22d71152afe/content/browser/renderer_host/render_process_host_impl.h
[modify] https://crrev.com/b165dc5211edda5957d621643749d22d71152afe/content/browser/security_exploit_browsertest.cc
[modify] https://crrev.com/b165dc5211edda5957d621643749d22d71152afe/content/browser/service_worker/service_worker_browsertest.cc
[modify] https://crrev.com/b165dc5211edda5957d621643749d22d71152afe/content/browser/service_worker/service_worker_fetch_dispatcher.cc
[modify] https://crrev.com/b165dc5211edda5957d621643749d22d71152afe/content/browser/service_worker/service_worker_fetch_dispatcher.h
[modify] https://crrev.com/b165dc5211edda5957d621643749d22d71152afe/content/browser/service_worker/service_worker_provider_host.cc
[modify] https://crrev.com/b165dc5211edda5957d621643749d22d71152afe/content/browser/service_worker/service_worker_script_url_loader.cc
[modify] https://crrev.com/b165dc5211edda5957d621643749d22d71152afe/content/browser/service_worker/service_worker_script_url_loader.h
[modify] https://crrev.com/b165dc5211edda5957d621643749d22d71152afe/content/browser/service_worker/service_worker_script_url_loader_factory.cc
[modify] https://crrev.com/b165dc5211edda5957d621643749d22d71152afe/content/browser/service_worker/service_worker_script_url_loader_factory.h
[modify] https://crrev.com/b165dc5211edda5957d621643749d22d71152afe/content/browser/service_worker/service_worker_script_url_loader_unittest.cc
[modify] https://crrev.com/b165dc5211edda5957d621643749d22d71152afe/content/browser/service_worker/service_worker_url_job_wrapper.h
[modify] https://crrev.com/b165dc5211edda5957d621643749d22d71152afe/content/browser/service_worker/service_worker_url_loader_job.cc
[modify] https://crrev.com/b165dc5211edda5957d621643749d22d71152afe/content/browser/service_worker/service_worker_url_loader_job.h
[modify] https://crrev.com/b165dc5211edda5957d621643749d22d71152afe/content/browser/service_worker/service_worker_url_loader_job_unittest.cc
[modify] https://crrev.com/b165dc5211edda5957d621643749d22d71152afe/content/browser/service_worker/service_worker_url_request_job.cc
[modify] https://crrev.com/b165dc5211edda5957d621643749d22d71152afe/content/browser/storage_partition_impl.cc
[modify] https://crrev.com/b165dc5211edda5957d621643749d22d71152afe/content/browser/storage_partition_impl.h
[modify] https://crrev.com/b165dc5211edda5957d621643749d22d71152afe/content/browser/storage_partition_impl_browsertest.cc
[modify] https://crrev.com/b165dc5211edda5957d621643749d22d71152afe/content/browser/url_loader_factory_getter.cc
[modify] https://crrev.com/b165dc5211edda5957d621643749d22d71152afe/content/browser/url_loader_factory_getter.h
[modify] https://crrev.com/b165dc5211edda5957d621643749d22d71152afe/content/browser/webui/network_error_url_loader.cc
[modify] https://crrev.com/b165dc5211edda5957d621643749d22d71152afe/content/browser/webui/network_error_url_loader.h
[modify] https://crrev.com/b165dc5211edda5957d621643749d22d71152afe/content/browser/webui/web_ui_url_loader_factory.cc
[modify] https://crrev.com/b165dc5211edda5957d621643749d22d71152afe/content/browser/webui/web_ui_url_loader_factory.h
[modify] https://crrev.com/b165dc5211edda5957d621643749d22d71152afe/content/common/BUILD.gn
[modify] https://crrev.com/b165dc5211edda5957d621643749d22d71152afe/content/common/appcache.mojom
[modify] https://crrev.com/b165dc5211edda5957d621643749d22d71152afe/content/common/appcache_interfaces.h
[modify] https://crrev.com/b165dc5211edda5957d621643749d22d71152afe/content/common/content_param_traits_macros.h
[modify] https://crrev.com/b165dc5211edda5957d621643749d22d71152afe/content/common/frame.mojom
[modify] https://crrev.com/b165dc5211edda5957d621643749d22d71152afe/content/common/navigation_subresource_loader_params.h
[modify] https://crrev.com/b165dc5211edda5957d621643749d22d71152afe/content/common/renderer_host.mojom
[delete] https://crrev.com/87cb413ea5addcc68d78be5e3b8c8ed9b45d0ec9/content/common/resource_messages.cc
[modify] https://crrev.com/b165dc5211edda5957d621643749d22d71152afe/content/common/resource_messages.h
[modify] https://crrev.com/b165dc5211edda5957d621643749d22d71152afe/content/common/service_worker/controller_service_worker.mojom
[modify] https://crrev.com/b165dc5211edda5957d621643749d22d71152afe/content/common/service_worker/service_worker.mojom
[modify] https://crrev.com/b165dc5211edda5957d621643749d22d71152afe/content/common/service_worker/service_worker_event_dispatcher.mojom
[modify] https://crrev.com/b165dc5211edda5957d621643749d22d71152afe/content/common/service_worker/service_worker_provider.mojom
[modify] https://crrev.com/b165dc5211edda5957d621643749d22d71152afe/content/common/throttling_url_loader.cc
[modify] https://crrev.com/b165dc5211edda5957d621643749d22d71152afe/content/common/throttling_url_loader.h
[modify] https://crrev.com/b165dc5211edda5957d621643749d22d71152afe/content/common/throttling_url_loader_unittest.cc
[modify] https://crrev.com/b165dc5211edda5957d621643749d22d71152afe/content/common/url_loader_factory_bundle.cc
[modify] https://crrev.com/b165dc5211edda5957d621643749d22d71152afe/content/common/url_loader_factory_bundle.h
[modify] https://crrev.com/b165dc5211edda5957d621643749d22d71152afe/content/common/url_loader_factory_bundle.mojom
[modify] https://crrev.com/b165dc5211edda5957d621643749d22d71152afe/content/common/url_loader_factory_bundle_struct_traits.cc
[modify] https://crrev.com/b165dc5211edda5957d621643749d22d71152afe/content/common/url_loader_factory_bundle_struct_traits.h
[delete] https://crrev.com/87cb413ea5addcc68d78be5e3b8c8ed9b45d0ec9/content/common/url_request_struct_traits.cc
[delete] https://crrev.com/87cb413ea5addcc68d78be5e3b8c8ed9b45d0ec9/content/common/url_request_struct_traits.h
[modify] https://crrev.com/b165dc5211edda5957d621643749d22d71152afe/content/common/weak_wrapper_shared_url_loader_factory.cc
[modify] https://crrev.com/b165dc5211edda5957d621643749d22d71152afe/content/common/weak_wrapper_shared_url_loader_factory.h
[modify] https://crrev.com/b165dc5211edda5957d621643749d22d71152afe/content/common/wrapper_shared_url_loader_factory.cc
[modify] https://crrev.com/b165dc5211edda5957d621643749d22d71152afe/content/common/wrapper_shared_url_loader_factory.h
[modify] https://crrev.com/b165dc5211edda5957d621643749d22d71152afe/content/network/DEPS
[modify] https://crrev.com/b165dc5211edda5957d621643749d22d71152afe/content/network/cache_url_loader.cc
[modify] https://crrev.com/b165dc5211edda5957d621643749d22d71152afe/content/network/cache_url_loader.h
[modify] https://crrev.com/b165dc5211edda5957d621643749d22d71152afe/content/network/manifest.json
[modify] https://crrev.com/b165dc5211edda5957d621643749d22d71152afe/content/network/network_context.cc
[modify] https://crrev.com/b165dc5211edda5957d621643749d22d71152afe/content/network/network_context.h
[modify] https://crrev.com/b165dc5211edda5957d621643749d22d71152afe/content/network/network_service_unittest.cc
[modify] https://crrev.com/b165dc5211edda5957d621643749d22d71152afe/content/network/network_service_url_loader_factory.cc
[modify] https://crrev.com/b165dc5211edda5957d621643749d22d71152afe/content/network/network_service_url_loader_factory.h
[modify] https://crrev.com/b165dc5211edda5957d621643749d22d71152afe/content/network/url_loader.cc
[modify] https://crrev.com/b165dc5211edda5957d621643749d22d71152afe/content/network/url_loader.h
[modify] https://crrev.com/b165dc5211edda5957d621643749d22d71152afe/content/network/url_loader_unittest.cc
[modify] https://crrev.com/b165dc5211edda5957d621643749d22d71152afe/content/public/app/mojo/content_browser_manifest.json
[modify] https://crrev.com/b165dc5211edda5957d621643749d22d71152afe/content/public/browser/content_browser_client.h
[modify] https://crrev.com/b165dc5211edda5957d621643749d22d71152afe/content/public/browser/download_manager.h
[modify] https://crrev.com/b165dc5211edda5957d621643749d22d71152afe/content/public/browser/file_url_loader.h
[modify] https://crrev.com/b165dc5211edda5957d621643749d22d71152afe/content/public/browser/storage_partition.h
[modify] https://crrev.com/b165dc5211edda5957d621643749d22d71152afe/content/public/common/BUILD.gn
[modify] https://crrev.com/b165dc5211edda5957d621643749d22d71152afe/content/public/common/common_param_traits.cc
[modify] https://crrev.com/b165dc5211edda5957d621643749d22d71152afe/content/public/common/common_param_traits.h
[modify] https://crrev.com/b165dc5211edda5957d621643749d22d71152afe/content/public/common/common_param_traits_macros.h
[delete] https://crrev.com/87cb413ea5addcc68d78be5e3b8c8ed9b45d0ec9/content/public/common/network_param.typemap
[modify] https://crrev.com/b165dc5211edda5957d621643749d22d71152afe/content/public/common/network_service.mojom
[modify] https://crrev.com/b165dc5211edda5957d621643749d22d71152afe/content/public/common/network_service_test.mojom
[modify] https://crrev.com/b165dc5211edda5957d621643749d22d71152afe/content/public/common/shared_url_loader_factory.h
[modify] https://crrev.com/b165dc5211edda5957d621643749d22d71152afe/content/public/common/simple_url_loader.cc
[modify] https://crrev.com/b165dc5211edda5957d621643749d22d71152afe/content/public/common/simple_url_loader.h
[modify] https://crrev.com/b165dc5211edda5957d621643749d22d71152afe/content/public/common/simple_url_loader_unittest.cc
[modify] https://crrev.com/b165dc5211edda5957d621643749d22d71152afe/content/public/common/typemaps.gni
[delete] https://crrev.com/87cb413ea5addcc68d78be5e3b8c8ed9b45d0ec9/content/public/common/url_request.typemap
[delete] https://crrev.com/87cb413ea5addcc68d78be5e3b8c8ed9b45d0ec9/content/public/common/url_response_head.typemap
[modify] https://crrev.com/b165dc5211edda5957d621643749d22d71152afe/content/public/renderer/child_url_loader_factory_getter.h
[modify] https://crrev.com/b165dc5211edda5957d621643749d22d71152afe/content/public/renderer/render_frame.h
[modify] https://crrev.com/b165dc5211edda5957d621643749d22d71152afe/content/public/renderer/resource_fetcher.h
[modify] https://crrev.com/b165dc5211edda5957d621643749d22d71152afe/content/public/test/browser_test_utils.cc
[modify] https://crrev.com/b165dc5211edda5957d621643749d22d71152afe/content/public/test/test_storage_partition.cc
[modify] https://crrev.com/b165dc5211edda5957d621643749d22d71152afe/content/public/test/test_storage_partition.h
[modify] https://crrev.com/b165dc5211edda5957d621643749d22d71152afe/content/public/test/test_url_loader_client.cc
[modify] https://crrev.com/b165dc5211edda5957d621643749d22d71152afe/content/public/test/test_url_loader_client.h
[modify] https://crrev.com/b165dc5211edda5957d621643749d22d71152afe/content/public/test/url_loader_interceptor.cc
[modify] https://crrev.com/b165dc5211edda5957d621643749d22d71152afe/content/public/test/url_loader_interceptor.h
[modify] https://crrev.com/b165dc5211edda5957d621643749d22d71152afe/content/renderer/appcache/appcache_dispatcher.cc
[modify] https://crrev.com/b165dc5211edda5957d621643749d22d71152afe/content/renderer/appcache/appcache_dispatcher.h
[modify] https://crrev.com/b165dc5211edda5957d621643749d22d71152afe/content/renderer/appcache/appcache_frontend_impl.cc
[modify] https://crrev.com/b165dc5211edda5957d621643749d22d71152afe/content/renderer/appcache/appcache_frontend_impl.h
[modify] https://crrev.com/b165dc5211edda5957d621643749d22d71152afe/content/renderer/appcache/web_application_cache_host_impl.h
[modify] https://crrev.com/b165dc5211edda5957d621643749d22d71152afe/content/renderer/fetchers/resource_fetcher_impl.cc
[modify] https://crrev.com/b165dc5211edda5957d621643749d22d71152afe/content/renderer/fetchers/resource_fetcher_impl.h
[modify] https://crrev.com/b165dc5211edda5957d621643749d22d71152afe/content/renderer/loader
Project Member

Comment 28 by bugdroid1@chromium.org, Jan 18 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/53670ddf8ac21864abe0f3ad5f0a7c6769943374

commit 53670ddf8ac21864abe0f3ad5f0a7c6769943374
Author: John Abd-El-Malek <jam@chromium.org>
Date: Thu Jan 18 22:07:21 2018

Move network_service.mojom and network_service_test.mojom to services/network.

Bug: 753658
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo
Change-Id: Ida11d6dc98e31a6a09f8ea260dd2e5da2507ac81
Reviewed-on: https://chromium-review.googlesource.com/874551
Reviewed-by: Yuzhu Shen <yzshen@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Commit-Queue: John Abd-El-Malek <jam@chromium.org>
Cr-Commit-Position: refs/heads/master@{#530291}
[modify] https://crrev.com/53670ddf8ac21864abe0f3ad5f0a7c6769943374/chrome/browser/browser_process_impl.h
[modify] https://crrev.com/53670ddf8ac21864abe0f3ad5f0a7c6769943374/chrome/browser/chrome_content_browser_client.cc
[modify] https://crrev.com/53670ddf8ac21864abe0f3ad5f0a7c6769943374/chrome/browser/chrome_content_browser_client.h
[modify] https://crrev.com/53670ddf8ac21864abe0f3ad5f0a7c6769943374/chrome/browser/chrome_network_service_restart_browsertest.cc
[modify] https://crrev.com/53670ddf8ac21864abe0f3ad5f0a7c6769943374/chrome/browser/extensions/api/cookies/cookies_api.cc
[modify] https://crrev.com/53670ddf8ac21864abe0f3ad5f0a7c6769943374/chrome/browser/extensions/extension_service_unittest.cc
[modify] https://crrev.com/53670ddf8ac21864abe0f3ad5f0a7c6769943374/chrome/browser/io_thread.h
[modify] https://crrev.com/53670ddf8ac21864abe0f3ad5f0a7c6769943374/chrome/browser/net/default_network_context_params.cc
[modify] https://crrev.com/53670ddf8ac21864abe0f3ad5f0a7c6769943374/chrome/browser/net/default_network_context_params.h
[modify] https://crrev.com/53670ddf8ac21864abe0f3ad5f0a7c6769943374/chrome/browser/net/network_connection_tracker_browsertest.cc
[modify] https://crrev.com/53670ddf8ac21864abe0f3ad5f0a7c6769943374/chrome/browser/net/network_context_configuration_browsertest.cc
[modify] https://crrev.com/53670ddf8ac21864abe0f3ad5f0a7c6769943374/chrome/browser/net/profile_network_context_service.cc
[modify] https://crrev.com/53670ddf8ac21864abe0f3ad5f0a7c6769943374/chrome/browser/net/profile_network_context_service.h
[modify] https://crrev.com/53670ddf8ac21864abe0f3ad5f0a7c6769943374/chrome/browser/net/proxy_config_monitor.cc
[modify] https://crrev.com/53670ddf8ac21864abe0f3ad5f0a7c6769943374/chrome/browser/net/proxy_config_monitor.h
[modify] https://crrev.com/53670ddf8ac21864abe0f3ad5f0a7c6769943374/chrome/browser/net/system_network_context_manager.cc
[modify] https://crrev.com/53670ddf8ac21864abe0f3ad5f0a7c6769943374/chrome/browser/net/system_network_context_manager.h
[modify] https://crrev.com/53670ddf8ac21864abe0f3ad5f0a7c6769943374/chrome/browser/net/variations_http_headers_browsertest.cc
[modify] https://crrev.com/53670ddf8ac21864abe0f3ad5f0a7c6769943374/chrome/browser/policy/policy_network_browsertest.cc
[modify] https://crrev.com/53670ddf8ac21864abe0f3ad5f0a7c6769943374/chrome/browser/profile_resetter/profile_resetter_browsertest.cc
[modify] https://crrev.com/53670ddf8ac21864abe0f3ad5f0a7c6769943374/chrome/browser/profiles/profile.cc
[modify] https://crrev.com/53670ddf8ac21864abe0f3ad5f0a7c6769943374/chrome/browser/profiles/profile.h
[modify] https://crrev.com/53670ddf8ac21864abe0f3ad5f0a7c6769943374/chrome/browser/profiles/profile_impl_io_data.cc
[modify] https://crrev.com/53670ddf8ac21864abe0f3ad5f0a7c6769943374/chrome/browser/profiles/profile_io_data.h
[modify] https://crrev.com/53670ddf8ac21864abe0f3ad5f0a7c6769943374/chrome/browser/ssl/cert_verifier_browser_test.h
[modify] https://crrev.com/53670ddf8ac21864abe0f3ad5f0a7c6769943374/chrome/test/base/testing_profile.cc
[modify] https://crrev.com/53670ddf8ac21864abe0f3ad5f0a7c6769943374/chrome/test/base/testing_profile.h
[modify] https://crrev.com/53670ddf8ac21864abe0f3ad5f0a7c6769943374/content/browser/browsing_data/browsing_data_remover_impl_browsertest.cc
[modify] https://crrev.com/53670ddf8ac21864abe0f3ad5f0a7c6769943374/content/browser/devtools/protocol/network_handler.cc
[modify] https://crrev.com/53670ddf8ac21864abe0f3ad5f0a7c6769943374/content/browser/devtools/protocol/network_handler.h
[modify] https://crrev.com/53670ddf8ac21864abe0f3ad5f0a7c6769943374/content/browser/frame_host/render_frame_host_impl.cc
[modify] https://crrev.com/53670ddf8ac21864abe0f3ad5f0a7c6769943374/content/browser/frame_host/render_frame_message_filter.h
[modify] https://crrev.com/53670ddf8ac21864abe0f3ad5f0a7c6769943374/content/browser/network_service_client.cc
[modify] https://crrev.com/53670ddf8ac21864abe0f3ad5f0a7c6769943374/content/browser/network_service_client.h
[modify] https://crrev.com/53670ddf8ac21864abe0f3ad5f0a7c6769943374/content/browser/network_service_instance.cc
[modify] https://crrev.com/53670ddf8ac21864abe0f3ad5f0a7c6769943374/content/browser/network_service_restart_browsertest.cc
[modify] https://crrev.com/53670ddf8ac21864abe0f3ad5f0a7c6769943374/content/browser/renderer_host/render_process_host_impl.cc
[modify] https://crrev.com/53670ddf8ac21864abe0f3ad5f0a7c6769943374/content/browser/renderer_interface_binders.cc
[modify] https://crrev.com/53670ddf8ac21864abe0f3ad5f0a7c6769943374/content/browser/service_manager/service_manager_context.cc
[modify] https://crrev.com/53670ddf8ac21864abe0f3ad5f0a7c6769943374/content/browser/storage_partition_impl.cc
[modify] https://crrev.com/53670ddf8ac21864abe0f3ad5f0a7c6769943374/content/browser/storage_partition_impl.h
[modify] https://crrev.com/53670ddf8ac21864abe0f3ad5f0a7c6769943374/content/browser/storage_partition_impl_browsertest.cc
[modify] https://crrev.com/53670ddf8ac21864abe0f3ad5f0a7c6769943374/content/browser/url_loader_factory_getter.cc
[modify] https://crrev.com/53670ddf8ac21864abe0f3ad5f0a7c6769943374/content/browser/webui/web_ui_url_loader_factory.cc
[modify] https://crrev.com/53670ddf8ac21864abe0f3ad5f0a7c6769943374/content/network/manifest.json
[modify] https://crrev.com/53670ddf8ac21864abe0f3ad5f0a7c6769943374/content/network/network_context.cc
[modify] https://crrev.com/53670ddf8ac21864abe0f3ad5f0a7c6769943374/content/network/network_context.h
[modify] https://crrev.com/53670ddf8ac21864abe0f3ad5f0a7c6769943374/content/network/network_context_unittest.cc
[modify] https://crrev.com/53670ddf8ac21864abe0f3ad5f0a7c6769943374/content/network/network_service_impl.cc
[modify] https://crrev.com/53670ddf8ac21864abe0f3ad5f0a7c6769943374/content/network/network_service_impl.h
[modify] https://crrev.com/53670ddf8ac21864abe0f3ad5f0a7c6769943374/content/network/network_service_unittest.cc
[modify] https://crrev.com/53670ddf8ac21864abe0f3ad5f0a7c6769943374/content/network/url_request_context_builder_mojo.cc
[modify] https://crrev.com/53670ddf8ac21864abe0f3ad5f0a7c6769943374/content/public/browser/BUILD.gn
[modify] https://crrev.com/53670ddf8ac21864abe0f3ad5f0a7c6769943374/content/public/browser/content_browser_client.cc
[modify] https://crrev.com/53670ddf8ac21864abe0f3ad5f0a7c6769943374/content/public/browser/content_browser_client.h
[modify] https://crrev.com/53670ddf8ac21864abe0f3ad5f0a7c6769943374/content/public/browser/network_service_instance.h
[modify] https://crrev.com/53670ddf8ac21864abe0f3ad5f0a7c6769943374/content/public/browser/storage_partition.h
[modify] https://crrev.com/53670ddf8ac21864abe0f3ad5f0a7c6769943374/content/public/common/BUILD.gn
[modify] https://crrev.com/53670ddf8ac21864abe0f3ad5f0a7c6769943374/content/public/common/network_connection_tracker.cc
[modify] https://crrev.com/53670ddf8ac21864abe0f3ad5f0a7c6769943374/content/public/common/network_connection_tracker.h
[modify] https://crrev.com/53670ddf8ac21864abe0f3ad5f0a7c6769943374/content/public/common/network_connection_tracker_unittest.cc
[modify] https://crrev.com/53670ddf8ac21864abe0f3ad5f0a7c6769943374/content/public/common/simple_url_loader_unittest.cc
[modify] https://crrev.com/53670ddf8ac21864abe0f3ad5f0a7c6769943374/content/public/network/network_service.h
[modify] https://crrev.com/53670ddf8ac21864abe0f3ad5f0a7c6769943374/content/public/network/url_request_context_builder_mojo.h
[modify] https://crrev.com/53670ddf8ac21864abe0f3ad5f0a7c6769943374/content/public/test/browser_test_base.cc
[modify] https://crrev.com/53670ddf8ac21864abe0f3ad5f0a7c6769943374/content/public/test/browser_test_utils.cc
[modify] https://crrev.com/53670ddf8ac21864abe0f3ad5f0a7c6769943374/content/public/test/browser_test_utils.h
[modify] https://crrev.com/53670ddf8ac21864abe0f3ad5f0a7c6769943374/content/public/test/network_service_test_helper.cc
[modify] https://crrev.com/53670ddf8ac21864abe0f3ad5f0a7c6769943374/content/public/test/network_service_test_helper.h
[modify] https://crrev.com/53670ddf8ac21864abe0f3ad5f0a7c6769943374/content/public/test/test_storage_partition.cc
[modify] https://crrev.com/53670ddf8ac21864abe0f3ad5f0a7c6769943374/content/public/test/test_storage_partition.h
[modify] https://crrev.com/53670ddf8ac21864abe0f3ad5f0a7c6769943374/content/shell/gpu/DEPS
[modify] https://crrev.com/53670ddf8ac21864abe0f3ad5f0a7c6769943374/content/shell/gpu/shell_content_gpu_client.h
[modify] https://crrev.com/53670ddf8ac21864abe0f3ad5f0a7c6769943374/services/network/public/interfaces/BUILD.gn
[rename] https://crrev.com/53670ddf8ac21864abe0f3ad5f0a7c6769943374/services/network/public/interfaces/network_service.mojom
[rename] https://crrev.com/53670ddf8ac21864abe0f3ad5f0a7c6769943374/services/network/public/interfaces/network_service_test.mojom
[modify] https://crrev.com/53670ddf8ac21864abe0f3ad5f0a7c6769943374/services/network/public/interfaces/url_loader.mojom
[modify] https://crrev.com/53670ddf8ac21864abe0f3ad5f0a7c6769943374/services/proxy_resolver/public/interfaces/BUILD.gn

Project Member

Comment 29 by bugdroid1@chromium.org, Jan 18 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a255e00eccc9cd91105f543e3fca1c02237665e0

commit a255e00eccc9cd91105f543e3fca1c02237665e0
Author: John Abd-El-Malek <jam@chromium.org>
Date: Thu Jan 18 22:27:58 2018

Move loader_util from content to services/network.

Bug: 753658
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo
Change-Id: I7dd4b23a8f9006845b73966591d7f410a5979d91
Reviewed-on: https://chromium-review.googlesource.com/875005
Commit-Queue: John Abd-El-Malek <jam@chromium.org>
Reviewed-by: Ken Rockot <rockot@chromium.org>
Cr-Commit-Position: refs/heads/master@{#530302}
[modify] https://crrev.com/a255e00eccc9cd91105f543e3fca1c02237665e0/chrome/browser/prefs/chrome_command_line_pref_store.cc
[modify] https://crrev.com/a255e00eccc9cd91105f543e3fca1c02237665e0/content/browser/loader/mime_sniffing_resource_handler.cc
[modify] https://crrev.com/a255e00eccc9cd91105f543e3fca1c02237665e0/content/browser/loader/navigation_url_loader_network_service.cc
[modify] https://crrev.com/a255e00eccc9cd91105f543e3fca1c02237665e0/content/browser/loader/resource_dispatcher_host_impl.cc
[modify] https://crrev.com/a255e00eccc9cd91105f543e3fca1c02237665e0/content/browser/loader/resource_loader.cc
[modify] https://crrev.com/a255e00eccc9cd91105f543e3fca1c02237665e0/content/browser/renderer_host/render_process_host_impl.cc
[modify] https://crrev.com/a255e00eccc9cd91105f543e3fca1c02237665e0/content/browser/utility_process_host_impl.cc
[modify] https://crrev.com/a255e00eccc9cd91105f543e3fca1c02237665e0/content/common/BUILD.gn
[modify] https://crrev.com/a255e00eccc9cd91105f543e3fca1c02237665e0/content/common/service_worker/service_worker_loader_helpers.cc
[modify] https://crrev.com/a255e00eccc9cd91105f543e3fca1c02237665e0/content/network/url_loader.cc
[modify] https://crrev.com/a255e00eccc9cd91105f543e3fca1c02237665e0/content/public/common/content_switches.cc
[modify] https://crrev.com/a255e00eccc9cd91105f543e3fca1c02237665e0/content/public/common/content_switches.h
[modify] https://crrev.com/a255e00eccc9cd91105f543e3fca1c02237665e0/content/public/common/referrer.cc
[modify] https://crrev.com/a255e00eccc9cd91105f543e3fca1c02237665e0/content/renderer/loader/web_url_loader_impl.cc
[modify] https://crrev.com/a255e00eccc9cd91105f543e3fca1c02237665e0/content/renderer/loader/web_url_request_util.cc
[modify] https://crrev.com/a255e00eccc9cd91105f543e3fca1c02237665e0/services/network/public/cpp/BUILD.gn
[rename] https://crrev.com/a255e00eccc9cd91105f543e3fca1c02237665e0/services/network/public/cpp/loader_util.cc
[rename] https://crrev.com/a255e00eccc9cd91105f543e3fca1c02237665e0/services/network/public/cpp/loader_util.h
[add] https://crrev.com/a255e00eccc9cd91105f543e3fca1c02237665e0/services/network/public/cpp/network_switches.cc
[add] https://crrev.com/a255e00eccc9cd91105f543e3fca1c02237665e0/services/network/public/cpp/network_switches.h

Project Member

Comment 30 by bugdroid1@chromium.org, Jan 19 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/91243b3fec157170f49a58dee21d98dd08646ef7

commit 91243b3fec157170f49a58dee21d98dd08646ef7
Author: John Abd-El-Malek <jam@chromium.org>
Date: Fri Jan 19 06:08:33 2018

Remove usage of content/common from content/network in preparation of moving that code to services/network.

Bug: 753658
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo
Change-Id: Ifcde5a90551d5abec39ff96fccf665aae3183391
Reviewed-on: https://chromium-review.googlesource.com/875298
Commit-Queue: John Abd-El-Malek <jam@chromium.org>
Reviewed-by: Nasko Oskov <nasko@chromium.org>
Reviewed-by: Yuzhu Shen <yzshen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#530433}
[modify] https://crrev.com/91243b3fec157170f49a58dee21d98dd08646ef7/android_webview/browser/DEPS
[modify] https://crrev.com/91243b3fec157170f49a58dee21d98dd08646ef7/android_webview/browser/net/aw_url_request_context_getter.cc
[modify] https://crrev.com/91243b3fec157170f49a58dee21d98dd08646ef7/chrome/browser/about_flags.cc
[modify] https://crrev.com/91243b3fec157170f49a58dee21d98dd08646ef7/chrome/browser/browser_process_impl.cc
[modify] https://crrev.com/91243b3fec157170f49a58dee21d98dd08646ef7/chrome/browser/io_thread.cc
[modify] https://crrev.com/91243b3fec157170f49a58dee21d98dd08646ef7/chrome/browser/net/default_network_context_params.cc
[modify] https://crrev.com/91243b3fec157170f49a58dee21d98dd08646ef7/chrome/browser/supervised_user/supervised_user_browsertest.cc
[modify] https://crrev.com/91243b3fec157170f49a58dee21d98dd08646ef7/chromecast/browser/DEPS
[modify] https://crrev.com/91243b3fec157170f49a58dee21d98dd08646ef7/chromecast/browser/cast_net_log.cc
[modify] https://crrev.com/91243b3fec157170f49a58dee21d98dd08646ef7/content/browser/loader/cross_site_document_blocking_browsertest.cc
[modify] https://crrev.com/91243b3fec157170f49a58dee21d98dd08646ef7/content/browser/security_exploit_browsertest.cc
[modify] https://crrev.com/91243b3fec157170f49a58dee21d98dd08646ef7/content/browser/utility_process_host_impl.cc
[modify] https://crrev.com/91243b3fec157170f49a58dee21d98dd08646ef7/content/network/DEPS
[modify] https://crrev.com/91243b3fec157170f49a58dee21d98dd08646ef7/content/network/cache_url_loader.cc
[modify] https://crrev.com/91243b3fec157170f49a58dee21d98dd08646ef7/content/network/network_context.cc
[modify] https://crrev.com/91243b3fec157170f49a58dee21d98dd08646ef7/content/network/network_service_impl.cc
[modify] https://crrev.com/91243b3fec157170f49a58dee21d98dd08646ef7/content/public/browser/content_browser_client.cc
[modify] https://crrev.com/91243b3fec157170f49a58dee21d98dd08646ef7/content/public/common/content_switches.cc
[modify] https://crrev.com/91243b3fec157170f49a58dee21d98dd08646ef7/content/public/common/content_switches.h
[modify] https://crrev.com/91243b3fec157170f49a58dee21d98dd08646ef7/content/renderer/loader/site_isolation_stats_gatherer_browsertest.cc
[modify] https://crrev.com/91243b3fec157170f49a58dee21d98dd08646ef7/content/shell/DEPS
[modify] https://crrev.com/91243b3fec157170f49a58dee21d98dd08646ef7/content/shell/app/shell_main_delegate.cc
[modify] https://crrev.com/91243b3fec157170f49a58dee21d98dd08646ef7/content/shell/browser/shell_net_log.cc
[modify] https://crrev.com/91243b3fec157170f49a58dee21d98dd08646ef7/content/shell/browser/shell_url_request_context_getter.cc
[modify] https://crrev.com/91243b3fec157170f49a58dee21d98dd08646ef7/headless/DEPS
[modify] https://crrev.com/91243b3fec157170f49a58dee21d98dd08646ef7/headless/app/headless_shell.cc
[modify] https://crrev.com/91243b3fec157170f49a58dee21d98dd08646ef7/headless/app/headless_shell_switches.h
[modify] https://crrev.com/91243b3fec157170f49a58dee21d98dd08646ef7/headless/lib/browser/headless_browser_impl.cc
[modify] https://crrev.com/91243b3fec157170f49a58dee21d98dd08646ef7/services/network/public/cpp/network_switches.cc
[modify] https://crrev.com/91243b3fec157170f49a58dee21d98dd08646ef7/services/network/public/cpp/network_switches.h
[modify] https://crrev.com/91243b3fec157170f49a58dee21d98dd08646ef7/services/network/public/interfaces/network_service.mojom

Project Member

Comment 31 by bugdroid1@chromium.org, Jan 30 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3bbbdf9432a8cca307f1e8ee0c7f265393428853

commit 3bbbdf9432a8cca307f1e8ee0c7f265393428853
Author: John Abd-El-Malek <jam@chromium.org>
Date: Tue Jan 30 03:27:35 2018

Move content/network to services/network.

ResourceScheduler and CORS code are left behind until the content/ dependencies are removed.

Bug: 753658
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo
Change-Id: Ife204640886541376354e3fcbe0fef631326822e
Reviewed-on: https://chromium-review.googlesource.com/891646
Commit-Queue: John Abd-El-Malek <jam@chromium.org>
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Reviewed-by: Ken Rockot <rockot@chromium.org>
Cr-Commit-Position: refs/heads/master@{#532742}
[modify] https://crrev.com/3bbbdf9432a8cca307f1e8ee0c7f265393428853/chrome/browser/BUILD.gn
[modify] https://crrev.com/3bbbdf9432a8cca307f1e8ee0c7f265393428853/chrome/browser/io_thread.cc
[modify] https://crrev.com/3bbbdf9432a8cca307f1e8ee0c7f265393428853/chrome/browser/io_thread.h
[modify] https://crrev.com/3bbbdf9432a8cca307f1e8ee0c7f265393428853/chrome/browser/net/system_network_context_manager.cc
[modify] https://crrev.com/3bbbdf9432a8cca307f1e8ee0c7f265393428853/chrome/browser/profiles/profile_io_data.cc
[modify] https://crrev.com/3bbbdf9432a8cca307f1e8ee0c7f265393428853/chrome/browser/profiles/profile_io_data.h
[modify] https://crrev.com/3bbbdf9432a8cca307f1e8ee0c7f265393428853/chrome/browser/ssl/DEPS
[modify] https://crrev.com/3bbbdf9432a8cca307f1e8ee0c7f265393428853/chrome/browser/ssl/cert_verifier_browser_test.cc
[modify] https://crrev.com/3bbbdf9432a8cca307f1e8ee0c7f265393428853/chrome/browser/ssl/ssl_browsertest.cc
[modify] https://crrev.com/3bbbdf9432a8cca307f1e8ee0c7f265393428853/chrome/browser/ui/startup/bad_flags_prompt.cc
[modify] https://crrev.com/3bbbdf9432a8cca307f1e8ee0c7f265393428853/chrome/utility/BUILD.gn
[modify] https://crrev.com/3bbbdf9432a8cca307f1e8ee0c7f265393428853/chrome/utility/DEPS
[modify] https://crrev.com/3bbbdf9432a8cca307f1e8ee0c7f265393428853/chrome/utility/chrome_content_utility_client.cc
[modify] https://crrev.com/3bbbdf9432a8cca307f1e8ee0c7f265393428853/content/BUILD.gn
[modify] https://crrev.com/3bbbdf9432a8cca307f1e8ee0c7f265393428853/content/browser/BUILD.gn
[modify] https://crrev.com/3bbbdf9432a8cca307f1e8ee0c7f265393428853/content/browser/devtools/devtools_network_transaction_factory.cc
[modify] https://crrev.com/3bbbdf9432a8cca307f1e8ee0c7f265393428853/content/browser/frame_host/render_frame_host_impl.cc
[modify] https://crrev.com/3bbbdf9432a8cca307f1e8ee0c7f265393428853/content/browser/loader/mojo_async_resource_handler.cc
[modify] https://crrev.com/3bbbdf9432a8cca307f1e8ee0c7f265393428853/content/browser/loader/mojo_async_resource_handler.h
[modify] https://crrev.com/3bbbdf9432a8cca307f1e8ee0c7f265393428853/content/browser/loader/mojo_async_resource_handler_unittest.cc
[modify] https://crrev.com/3bbbdf9432a8cca307f1e8ee0c7f265393428853/content/browser/loader/navigation_url_loader_network_service_unittest.cc
[modify] https://crrev.com/3bbbdf9432a8cca307f1e8ee0c7f265393428853/content/browser/network_service_instance.cc
[modify] https://crrev.com/3bbbdf9432a8cca307f1e8ee0c7f265393428853/content/browser/renderer_interface_binders.cc
[modify] https://crrev.com/3bbbdf9432a8cca307f1e8ee0c7f265393428853/content/browser/service_manager/service_manager_context.cc
[modify] https://crrev.com/3bbbdf9432a8cca307f1e8ee0c7f265393428853/content/browser/storage_partition_impl.cc
[modify] https://crrev.com/3bbbdf9432a8cca307f1e8ee0c7f265393428853/content/browser/utility_process_host_impl.cc
[modify] https://crrev.com/3bbbdf9432a8cca307f1e8ee0c7f265393428853/content/network/BUILD.gn
[modify] https://crrev.com/3bbbdf9432a8cca307f1e8ee0c7f265393428853/content/network/DEPS
[modify] https://crrev.com/3bbbdf9432a8cca307f1e8ee0c7f265393428853/content/network/OWNERS
[delete] https://crrev.com/0e0e6d654fcdae192825324c811798a63dff0ae9/content/network/README.md
[delete] https://crrev.com/0e0e6d654fcdae192825324c811798a63dff0ae9/content/network/network_sandbox_hook_linux.h
[modify] https://crrev.com/3bbbdf9432a8cca307f1e8ee0c7f265393428853/content/network/network_service_unittest.cc
[delete] https://crrev.com/0e0e6d654fcdae192825324c811798a63dff0ae9/content/network/network_service_url_loader_factory.h
[modify] https://crrev.com/3bbbdf9432a8cca307f1e8ee0c7f265393428853/content/network/url_loader_unittest.cc
[modify] https://crrev.com/3bbbdf9432a8cca307f1e8ee0c7f265393428853/content/public/app/BUILD.gn
[modify] https://crrev.com/3bbbdf9432a8cca307f1e8ee0c7f265393428853/content/public/browser/network_service_instance.h
[modify] https://crrev.com/3bbbdf9432a8cca307f1e8ee0c7f265393428853/content/public/common/content_switches.cc
[modify] https://crrev.com/3bbbdf9432a8cca307f1e8ee0c7f265393428853/content/public/common/content_switches.h
[modify] https://crrev.com/3bbbdf9432a8cca307f1e8ee0c7f265393428853/content/public/common/network_connection_tracker_unittest.cc
[modify] https://crrev.com/3bbbdf9432a8cca307f1e8ee0c7f265393428853/content/public/common/simple_url_loader_unittest.cc
[delete] https://crrev.com/0e0e6d654fcdae192825324c811798a63dff0ae9/content/public/network/BUILD.gn
[delete] https://crrev.com/0e0e6d654fcdae192825324c811798a63dff0ae9/content/public/network/DEPS
[modify] https://crrev.com/3bbbdf9432a8cca307f1e8ee0c7f265393428853/content/public/test/DEPS
[modify] https://crrev.com/3bbbdf9432a8cca307f1e8ee0c7f265393428853/content/public/test/network_service_test_helper.cc
[modify] https://crrev.com/3bbbdf9432a8cca307f1e8ee0c7f265393428853/content/shell/BUILD.gn
[modify] https://crrev.com/3bbbdf9432a8cca307f1e8ee0c7f265393428853/content/shell/browser/layout_test/layout_test_url_request_context_getter.cc
[modify] https://crrev.com/3bbbdf9432a8cca307f1e8ee0c7f265393428853/content/test/BUILD.gn
[modify] https://crrev.com/3bbbdf9432a8cca307f1e8ee0c7f265393428853/content/test/DEPS
[modify] https://crrev.com/3bbbdf9432a8cca307f1e8ee0c7f265393428853/content/test/proxy_service_mojo_unittest.cc
[modify] https://crrev.com/3bbbdf9432a8cca307f1e8ee0c7f265393428853/content/test/url_request_context_builder_mojo_unittest.cc
[modify] https://crrev.com/3bbbdf9432a8cca307f1e8ee0c7f265393428853/content/utility/BUILD.gn
[modify] https://crrev.com/3bbbdf9432a8cca307f1e8ee0c7f265393428853/content/utility/DEPS
[modify] https://crrev.com/3bbbdf9432a8cca307f1e8ee0c7f265393428853/content/utility/utility_main.cc
[modify] https://crrev.com/3bbbdf9432a8cca307f1e8ee0c7f265393428853/content/utility/utility_service_factory.cc
[modify] https://crrev.com/3bbbdf9432a8cca307f1e8ee0c7f265393428853/services/network/BUILD.gn
[modify] https://crrev.com/3bbbdf9432a8cca307f1e8ee0c7f265393428853/services/network/DEPS
[modify] https://crrev.com/3bbbdf9432a8cca307f1e8ee0c7f265393428853/services/network/OWNERS
[rename] https://crrev.com/3bbbdf9432a8cca307f1e8ee0c7f265393428853/services/network/PRESUBMIT.py
[rename] https://crrev.com/3bbbdf9432a8cca307f1e8ee0c7f265393428853/services/network/cache_url_loader.cc
[rename] https://crrev.com/3bbbdf9432a8cca307f1e8ee0c7f265393428853/services/network/cache_url_loader.h
[rename] https://crrev.com/3bbbdf9432a8cca307f1e8ee0c7f265393428853/services/network/data_pipe_element_reader.cc
[rename] https://crrev.com/3bbbdf9432a8cca307f1e8ee0c7f265393428853/services/network/data_pipe_element_reader.h
[rename] https://crrev.com/3bbbdf9432a8cca307f1e8ee0c7f265393428853/services/network/data_pipe_element_reader_unittest.cc
[rename] https://crrev.com/3bbbdf9432a8cca307f1e8ee0c7f265393428853/services/network/http_server_properties_pref_delegate.cc
[rename] https://crrev.com/3bbbdf9432a8cca307f1e8ee0c7f265393428853/services/network/http_server_properties_pref_delegate.h
[rename] https://crrev.com/3bbbdf9432a8cca307f1e8ee0c7f265393428853/services/network/manifest.json
[rename] https://crrev.com/3bbbdf9432a8cca307f1e8ee0c7f265393428853/services/network/network_change_manager.cc
[rename] https://crrev.com/3bbbdf9432a8cca307f1e8ee0c7f265393428853/services/network/network_change_manager.h
[rename] https://crrev.com/3bbbdf9432a8cca307f1e8ee0c7f265393428853/services/network/network_change_manager_unittest.cc
[rename] https://crrev.com/3bbbdf9432a8cca307f1e8ee0c7f265393428853/services/network/network_context.cc
[rename] https://crrev.com/3bbbdf9432a8cca307f1e8ee0c7f265393428853/services/network/network_context.h
[rename] https://crrev.com/3bbbdf9432a8cca307f1e8ee0c7f265393428853/services/network/network_context_unittest.cc
[rename] https://crrev.com/3bbbdf9432a8cca307f1e8ee0c7f265393428853/services/network/network_sandbox_hook_linux.cc
[add] https://crrev.com/3bbbdf9432a8cca307f1e8ee0c7f265393428853/services/network/network_sandbox_hook_linux.h
[rename] https://crrev.com/3bbbdf9432a8cca307f1e8ee0c7f265393428853/services/network/network_service_impl.cc
[rename] https://crrev.com/3bbbdf9432a8cca307f1e8ee0c7f265393428853/services/network/network_service_impl.h
[rename] https://crrev.com/3bbbdf9432a8cca307f1e8ee0c7f265393428853/services/network/network_service_url_loader_factory.cc
[add] https://crrev.com/3bbbdf9432a8cca307f1e8ee0c7f265393428853/services/network/network_service_url_loader_factory.h
[rename] https://crrev.com/3bbbdf9432a8cca307f1e8ee0c7f265393428853/services/network/proxy_resolver_factory_mojo.cc
[rename] https://crrev.com/3bbbdf9432a8cca307f1e8ee0c7f265393428853/services/network/proxy_resolver_factory_mojo.h
[rename] https://crrev.com/3bbbdf9432a8cca307f1e8ee0c7f265393428853/services/network/proxy_resolver_factory_mojo_unittest.cc
[rename] https://crrev.com/3bbbdf9432a8cca307f1e8ee0c7f265393428853/services/network/proxy_service_mojo.cc
[rename] https://crrev.com/3bbbdf9432a8cca307f1e8ee0c7f265393428853/services/network/proxy_service_mojo.h
[modify] https://crrev.com/3bbbdf9432a8cca307f1e8ee0c7f265393428853/services/network/public/cpp/BUILD.gn
[modify] https://crrev.com/3bbbdf9432a8cca307f1e8ee0c7f265393428853/services/network/public/cpp/DEPS
[rename] https://crrev.com/3bbbdf9432a8cca307f1e8ee0c7f265393428853/services/network/public/cpp/ignore_errors_cert_verifier.cc
[rename] https://crrev.com/3bbbdf9432a8cca307f1e8ee0c7f265393428853/services/network/public/cpp/ignore_errors_cert_verifier.h
[rename] https://crrev.com/3bbbdf9432a8cca307f1e8ee0c7f265393428853/services/network/public/cpp/ignore_errors_cert_verifier_unittest.cc
[rename] https://crrev.com/3bbbdf9432a8cca307f1e8ee0c7f265393428853/services/network/public/cpp/network_service.h
[modify] https://crrev.com/3bbbdf9432a8cca307f1e8ee0c7f265393428853/services/network/public/cpp/network_switches.cc
[modify] https://crrev.com/3bbbdf9432a8cca307f1e8ee0c7f265393428853/services/network/public/cpp/network_switches.h
[rename] https://crrev.com/3bbbdf9432a8cca307f1e8ee0c7f265393428853/services/network/public/cpp/url_request_context_builder_mojo.h
[rename] https://crrev.com/3bbbdf9432a8cca307f1e8ee0c7f265393428853/services/network/public/cpp/url_request_context_owner.cc
[rename] https://crrev.com/3bbbdf9432a8cca307f1e8ee0c7f265393428853/services/network/public/cpp/url_request_context_owner.h
[rename] https://crrev.com/3bbbdf9432a8cca307f1e8ee0c7f265393428853/services/network/restricted_cookie_manager.cc
[rename] https://crrev.com/3bbbdf9432a8cca307f1e8ee0c7f265393428853/services/network/restricted_cookie_manager.h
[rename] https://crrev.com/3bbbdf9432a8cca307f1e8ee0c7f265393428853/services/network/restricted_cookie_manager_unittest.cc
[rename] https://crrev.com/3bbbdf9432a8cca307f1e8ee0c7f265393428853/services/network/throttling/network_conditions.cc
[rename] https://crrev.com/3bbbdf9432a8cca307f1e8ee0c7f265393428853/services/network/throttling/network_conditions.h
[rename] https://crrev.com/3bbbdf9432a8cca307f1e8ee0c7f265393428853/services/network/throttling/throttling_controller.cc
[rename] https://crrev.com/3bbbdf9432a8cca307f1e8ee0c7f265393428853/services/network/throttling/throttling_controller.h
[rename] https://crrev.com/3bbbdf9432a8cca307f1e8ee0c7f265393428853/services/network/throttling/throttling_controller_unittest.cc
[rename] https://crrev.com/3bbbdf9432a8cca307f1e8ee0c7f265393428853/services/network/throttling/throttling_network_interceptor.cc
[rename] https://crrev.com/3bbbdf9432a8cca307f1e8ee0c7f265393428853/services/network/throttling/throttling_network_interceptor.h
[rename] https://crrev.com/3bbbdf9432a8cca307f1e8ee0c7f265393428853/services/network/throttling/throttling_network_transaction.cc
[rename] https://crrev.com/3bbbdf9432a8cca307f1e8ee0c7f265393428853/services/network/throttling/throttling_network_transaction.h
[rename] https://crrev.com/3bbbdf9432a8cca307f1e8ee0c7f265393428853/services/network/throttling/throttling_network_transaction_factory.cc
[rename] https://crrev.com/3bbbdf9432a8cca307f1e8ee0c7f265393428853/services/network/throttling/throttling_network_transaction_factory.h
[rename] https://crrev.com/3bbbdf9432a8cca307f1e8ee0c7f265393428853/services/network/throttling/throttling_upload_data_stream.cc
[rename] https://crrev.com/3bbbdf9432a8cca307f1e8ee0c7f265393428853/services/network/throttling/throttling_upload_data_stream.h
[rename] https://crrev.com/3bbbdf9432a8cca307f1e8ee0c7f265393428853/services/network/upload_progress_tracker.cc
[rename] https://crrev.com/3bbbdf9432a8cca307f1e8ee0c7f265393428853/services/network/upload_progress_tracker.h
[rename] https://crrev.com/3bbbdf9432a8cca307f1e8ee0c7f265393428853/services/network/upload_progress_tracker_unittest.cc
[rename] https://crrev.com/3bbbdf9432a8cca307f1e8ee0c7f265393428853/services/network/url_loader.cc
[rename] https://crrev.com/3bbbdf9432a8cca307f1e8ee0c7f265393428853/services/network/url_loader.h
[rename] https://crrev.com/3bbbdf9432a8cca307f1e8ee0c7f265393428853/services/network/url_request_context_builder_mojo.cc
[modify] https://crrev.com/3bbbdf9432a8cca307f1e8ee0c7f265393428853/storage/browser/blob/blob_url_loader.cc

Project Member

Comment 32 by bugdroid1@chromium.org, Jan 30 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/87565daf3b2d46e178b58cbcc13b71c1924a70a9

commit 87565daf3b2d46e178b58cbcc13b71c1924a70a9
Author: John Abd-El-Malek <jam@chromium.org>
Date: Tue Jan 30 05:53:47 2018

Temporary disable of browser tests that use CertVerifier with network service until services/network uses a component.

Until then, the test method isn't exported and the tests fail.

TBR=rockot@chromium.org
NOTRY=true

Bug: 753658
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo
Change-Id: Ifd5c4bf4e8e92aa8a87c439eb053ec08105724e4
Reviewed-on: https://chromium-review.googlesource.com/892496
Commit-Queue: John Abd-El-Malek <jam@chromium.org>
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Cr-Commit-Position: refs/heads/master@{#532778}
[modify] https://crrev.com/87565daf3b2d46e178b58cbcc13b71c1924a70a9/testing/buildbot/filters/mojo.fyi.network_browser_tests.filter

Project Member

Comment 33 by bugdroid1@chromium.org, Jan 30 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d0cd7c5ceb8cc8ed1b7f22d7f220e2e1b9c1c7e2

commit d0cd7c5ceb8cc8ed1b7f22d7f220e2e1b9c1c7e2
Author: John Abd-El-Malek <jam@chromium.org>
Date: Tue Jan 30 07:20:02 2018

Move TestURLLoaderClient to services/network/test.

This, together with cl 892292, unblocks moving url_loader_test.cc to services/network.

Bug: 753658
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo
Change-Id: Iba9cc4f07e2f8a4d2c6617c4c69bd1c74e03ab65
Reviewed-on: https://chromium-review.googlesource.com/892698
Reviewed-by: Yutaka Hirano <yhirano@chromium.org>
Commit-Queue: John Abd-El-Malek <jam@chromium.org>
Cr-Commit-Position: refs/heads/master@{#532801}
[modify] https://crrev.com/d0cd7c5ceb8cc8ed1b7f22d7f220e2e1b9c1c7e2/chrome/browser/net/DEPS
[modify] https://crrev.com/d0cd7c5ceb8cc8ed1b7f22d7f220e2e1b9c1c7e2/chrome/browser/net/network_context_configuration_browsertest.cc
[modify] https://crrev.com/d0cd7c5ceb8cc8ed1b7f22d7f220e2e1b9c1c7e2/chrome/browser/net/profile_network_context_service_browsertest.cc
[modify] https://crrev.com/d0cd7c5ceb8cc8ed1b7f22d7f220e2e1b9c1c7e2/content/browser/blob_storage/blob_url_unittest.cc
[modify] https://crrev.com/d0cd7c5ceb8cc8ed1b7f22d7f220e2e1b9c1c7e2/content/browser/loader/mojo_async_resource_handler_unittest.cc
[modify] https://crrev.com/d0cd7c5ceb8cc8ed1b7f22d7f220e2e1b9c1c7e2/content/browser/loader/resource_dispatcher_host_unittest.cc
[modify] https://crrev.com/d0cd7c5ceb8cc8ed1b7f22d7f220e2e1b9c1c7e2/content/browser/loader/url_loader_factory_impl_unittest.cc
[modify] https://crrev.com/d0cd7c5ceb8cc8ed1b7f22d7f220e2e1b9c1c7e2/content/browser/security_exploit_browsertest.cc
[modify] https://crrev.com/d0cd7c5ceb8cc8ed1b7f22d7f220e2e1b9c1c7e2/content/browser/service_worker/service_worker_script_url_loader_unittest.cc
[modify] https://crrev.com/d0cd7c5ceb8cc8ed1b7f22d7f220e2e1b9c1c7e2/content/browser/service_worker/service_worker_url_loader_job_unittest.cc
[modify] https://crrev.com/d0cd7c5ceb8cc8ed1b7f22d7f220e2e1b9c1c7e2/content/browser/storage_partition_impl_browsertest.cc
[modify] https://crrev.com/d0cd7c5ceb8cc8ed1b7f22d7f220e2e1b9c1c7e2/content/network/cors/cors_url_loader_unittest.cc
[modify] https://crrev.com/d0cd7c5ceb8cc8ed1b7f22d7f220e2e1b9c1c7e2/content/network/network_service_unittest.cc
[modify] https://crrev.com/d0cd7c5ceb8cc8ed1b7f22d7f220e2e1b9c1c7e2/content/network/url_loader_unittest.cc
[modify] https://crrev.com/d0cd7c5ceb8cc8ed1b7f22d7f220e2e1b9c1c7e2/content/renderer/service_worker/service_worker_provider_context_unittest.cc
[modify] https://crrev.com/d0cd7c5ceb8cc8ed1b7f22d7f220e2e1b9c1c7e2/content/renderer/service_worker/service_worker_subresource_loader_unittest.cc
[modify] https://crrev.com/d0cd7c5ceb8cc8ed1b7f22d7f220e2e1b9c1c7e2/content/test/BUILD.gn
[modify] https://crrev.com/d0cd7c5ceb8cc8ed1b7f22d7f220e2e1b9c1c7e2/services/network/BUILD.gn
[rename] https://crrev.com/d0cd7c5ceb8cc8ed1b7f22d7f220e2e1b9c1c7e2/services/network/test/test_url_loader_client.cc
[rename] https://crrev.com/d0cd7c5ceb8cc8ed1b7f22d7f220e2e1b9c1c7e2/services/network/test/test_url_loader_client.h

Project Member

Comment 34 by bugdroid1@chromium.org, Jan 30 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f071bebc8f1401e4225ca4ef56fd3b2c2d7b1d47

commit f071bebc8f1401e4225ca4ef56fd3b2c2d7b1d47
Author: John Abd-El-Malek <jam@chromium.org>
Date: Tue Jan 30 18:03:24 2018

Move ControllableHttpResponse to net/base/test_server as it'll be used outside of content & chrome.

services/network/ needs that helper class, and it can't depend on content/. While content/ can depend on services/network, this helper isn't related to the network service so it's moved to live beside the test server code.

Bug: 753658
Change-Id: Ied49b9e5dd45549d00e5684a9cb696155edacf13
Reviewed-on: https://chromium-review.googlesource.com/892292
Reviewed-by: Matt Menke <mmenke@chromium.org>
Commit-Queue: John Abd-El-Malek <jam@chromium.org>
Cr-Commit-Position: refs/heads/master@{#532942}
[modify] https://crrev.com/f071bebc8f1401e4225ca4ef56fd3b2c2d7b1d47/chrome/browser/extensions/api/downloads/downloads_api_browsertest.cc
[modify] https://crrev.com/f071bebc8f1401e4225ca4ef56fd3b2c2d7b1d47/chrome/browser/thumbnails/thumbnail_browsertest.cc
[modify] https://crrev.com/f071bebc8f1401e4225ca4ef56fd3b2c2d7b1d47/content/browser/browser_side_navigation_browsertest.cc
[modify] https://crrev.com/f071bebc8f1401e4225ca4ef56fd3b2c2d7b1d47/content/browser/devtools/render_frame_devtools_agent_host_browsertest.cc
[modify] https://crrev.com/f071bebc8f1401e4225ca4ef56fd3b2c2d7b1d47/content/browser/frame_host/navigation_controller_impl_browsertest.cc
[modify] https://crrev.com/f071bebc8f1401e4225ca4ef56fd3b2c2d7b1d47/content/browser/frame_host/render_frame_host_impl_browsertest.cc
[modify] https://crrev.com/f071bebc8f1401e4225ca4ef56fd3b2c2d7b1d47/content/browser/frame_host/render_frame_host_manager_browsertest.cc
[modify] https://crrev.com/f071bebc8f1401e4225ca4ef56fd3b2c2d7b1d47/content/network/DEPS
[modify] https://crrev.com/f071bebc8f1401e4225ca4ef56fd3b2c2d7b1d47/content/network/url_loader_unittest.cc
[modify] https://crrev.com/f071bebc8f1401e4225ca4ef56fd3b2c2d7b1d47/content/test/BUILD.gn
[modify] https://crrev.com/f071bebc8f1401e4225ca4ef56fd3b2c2d7b1d47/net/BUILD.gn
[rename] https://crrev.com/f071bebc8f1401e4225ca4ef56fd3b2c2d7b1d47/net/test/embedded_test_server/controllable_http_response.cc
[rename] https://crrev.com/f071bebc8f1401e4225ca4ef56fd3b2c2d7b1d47/net/test/embedded_test_server/controllable_http_response.h

Project Member

Comment 35 by bugdroid1@chromium.org, Jan 31 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e1c22cc3b5dc2a4276839d053bdf12ddee14dbea

commit e1c22cc3b5dc2a4276839d053bdf12ddee14dbea
Author: John Abd-El-Malek <jam@chromium.org>
Date: Wed Jan 31 00:41:07 2018

Move url_loader_unittest.cc and network_service_unittest.cc to services/network.

Their content dependencies have been removed in previous changes.

Bug: 753658
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo
Change-Id: Ic632759ef35cfef4e707d29acdc361ae836e9b62
Reviewed-on: https://chromium-review.googlesource.com/893651
Commit-Queue: John Abd-El-Malek <jam@chromium.org>
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Reviewed-by: Ken Rockot <rockot@chromium.org>
Cr-Commit-Position: refs/heads/master@{#533113}
[modify] https://crrev.com/e1c22cc3b5dc2a4276839d053bdf12ddee14dbea/content/network/BUILD.gn
[modify] https://crrev.com/e1c22cc3b5dc2a4276839d053bdf12ddee14dbea/content/network/DEPS
[modify] https://crrev.com/e1c22cc3b5dc2a4276839d053bdf12ddee14dbea/content/test/BUILD.gn
[modify] https://crrev.com/e1c22cc3b5dc2a4276839d053bdf12ddee14dbea/content/test/unittests_manifest.json
[modify] https://crrev.com/e1c22cc3b5dc2a4276839d053bdf12ddee14dbea/content/utility/BUILD.gn
[modify] https://crrev.com/e1c22cc3b5dc2a4276839d053bdf12ddee14dbea/services/BUILD.gn
[modify] https://crrev.com/e1c22cc3b5dc2a4276839d053bdf12ddee14dbea/services/network/BUILD.gn
[rename] https://crrev.com/e1c22cc3b5dc2a4276839d053bdf12ddee14dbea/services/network/network_service_unittest.cc
[add] https://crrev.com/e1c22cc3b5dc2a4276839d053bdf12ddee14dbea/services/network/test/OWNERS
[add] https://crrev.com/e1c22cc3b5dc2a4276839d053bdf12ddee14dbea/services/network/test/service_unittest_manifest.json
[rename] https://crrev.com/e1c22cc3b5dc2a4276839d053bdf12ddee14dbea/services/network/url_loader_unittest.cc
[modify] https://crrev.com/e1c22cc3b5dc2a4276839d053bdf12ddee14dbea/services/test/BUILD.gn
[add] https://crrev.com/e1c22cc3b5dc2a4276839d053bdf12ddee14dbea/services/test/data/content-sniffer-test0.html
[copy] https://crrev.com/e1c22cc3b5dc2a4276839d053bdf12ddee14dbea/services/test/data/content-sniffer-test0.html.mock-http-headers
[add] https://crrev.com/e1c22cc3b5dc2a4276839d053bdf12ddee14dbea/services/test/data/content-sniffer-test1.html
[add] https://crrev.com/e1c22cc3b5dc2a4276839d053bdf12ddee14dbea/services/test/data/content-sniffer-test1.html.mock-http-headers
[add] https://crrev.com/e1c22cc3b5dc2a4276839d053bdf12ddee14dbea/services/test/data/content-sniffer-test2.html
[add] https://crrev.com/e1c22cc3b5dc2a4276839d053bdf12ddee14dbea/services/test/data/content-sniffer-test2.html.mock-http-headers
[rename] https://crrev.com/e1c22cc3b5dc2a4276839d053bdf12ddee14dbea/services/test/data/content-sniffer-test4.html
[rename] https://crrev.com/e1c22cc3b5dc2a4276839d053bdf12ddee14dbea/services/test/data/content-sniffer-test4.html.mock-http-headers
[copy] https://crrev.com/e1c22cc3b5dc2a4276839d053bdf12ddee14dbea/services/test/data/empty.html
[add] https://crrev.com/e1c22cc3b5dc2a4276839d053bdf12ddee14dbea/services/test/data/hello.html
[add] https://crrev.com/e1c22cc3b5dc2a4276839d053bdf12ddee14dbea/services/test/data/hello.html.mock-http-headers
[rename] https://crrev.com/e1c22cc3b5dc2a4276839d053bdf12ddee14dbea/services/test/data/nocache.html
[rename] https://crrev.com/e1c22cc3b5dc2a4276839d053bdf12ddee14dbea/services/test/data/nocache.html.mock-http-headers
[add] https://crrev.com/e1c22cc3b5dc2a4276839d053bdf12ddee14dbea/services/test/data/nosniff-test.html
[add] https://crrev.com/e1c22cc3b5dc2a4276839d053bdf12ddee14dbea/services/test/data/nosniff-test.html.mock-http-headers
[add] https://crrev.com/e1c22cc3b5dc2a4276839d053bdf12ddee14dbea/services/test/data/redirect307-to-echo
[add] https://crrev.com/e1c22cc3b5dc2a4276839d053bdf12ddee14dbea/services/test/data/redirect307-to-echo.mock-http-headers
[add] https://crrev.com/e1c22cc3b5dc2a4276839d053bdf12ddee14dbea/services/test/data/simple_page.html

Project Member

Comment 36 by bugdroid1@chromium.org, Jan 31 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c395966e3d8815f24c768539cb2c187282766af6

commit c395966e3d8815f24c768539cb2c187282766af6
Author: Bret Sepulveda <bsep@chromium.org>
Date: Wed Jan 31 01:24:46 2018

Revert "Move url_loader_unittest.cc and network_service_unittest.cc to services/network."

This reverts commit e1c22cc3b5dc2a4276839d053bdf12ddee14dbea.

Reason for revert:
Compile failure on Windows https://ci.chromium.org/buildbot/chromium/Win%20x64/18699

Original change's description:
> Move url_loader_unittest.cc and network_service_unittest.cc to services/network.
> 
> Their content dependencies have been removed in previous changes.
> 
> Bug: 753658
> Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo
> Change-Id: Ic632759ef35cfef4e707d29acdc361ae836e9b62
> Reviewed-on: https://chromium-review.googlesource.com/893651
> Commit-Queue: John Abd-El-Malek <jam@chromium.org>
> Reviewed-by: Tom Sepez <tsepez@chromium.org>
> Reviewed-by: Ken Rockot <rockot@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#533113}

TBR=jam@chromium.org,rockot@chromium.org,tsepez@chromium.org

Change-Id: Id179d007751f72c0813162ed0995232b033e74a0
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 753658
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo
Reviewed-on: https://chromium-review.googlesource.com/894710
Reviewed-by: Bret Sepulveda <bsep@chromium.org>
Commit-Queue: Bret Sepulveda <bsep@chromium.org>
Cr-Commit-Position: refs/heads/master@{#533140}
[modify] https://crrev.com/c395966e3d8815f24c768539cb2c187282766af6/content/network/BUILD.gn
[modify] https://crrev.com/c395966e3d8815f24c768539cb2c187282766af6/content/network/DEPS
[rename] https://crrev.com/c395966e3d8815f24c768539cb2c187282766af6/content/network/network_service_unittest.cc
[rename] https://crrev.com/c395966e3d8815f24c768539cb2c187282766af6/content/network/url_loader_unittest.cc
[modify] https://crrev.com/c395966e3d8815f24c768539cb2c187282766af6/content/test/BUILD.gn
[rename] https://crrev.com/c395966e3d8815f24c768539cb2c187282766af6/content/test/data/content-sniffer-test4.html
[rename] https://crrev.com/c395966e3d8815f24c768539cb2c187282766af6/content/test/data/content-sniffer-test4.html.mock-http-headers
[rename] https://crrev.com/c395966e3d8815f24c768539cb2c187282766af6/content/test/data/nocache.html
[rename] https://crrev.com/c395966e3d8815f24c768539cb2c187282766af6/content/test/data/nocache.html.mock-http-headers
[modify] https://crrev.com/c395966e3d8815f24c768539cb2c187282766af6/content/test/unittests_manifest.json
[modify] https://crrev.com/c395966e3d8815f24c768539cb2c187282766af6/content/utility/BUILD.gn
[modify] https://crrev.com/c395966e3d8815f24c768539cb2c187282766af6/services/BUILD.gn
[modify] https://crrev.com/c395966e3d8815f24c768539cb2c187282766af6/services/network/BUILD.gn
[delete] https://crrev.com/ffe3c1da26430bb842db30d618ae349f37b02725/services/network/test/OWNERS
[delete] https://crrev.com/ffe3c1da26430bb842db30d618ae349f37b02725/services/network/test/service_unittest_manifest.json
[modify] https://crrev.com/c395966e3d8815f24c768539cb2c187282766af6/services/test/BUILD.gn
[delete] https://crrev.com/ffe3c1da26430bb842db30d618ae349f37b02725/services/test/data/content-sniffer-test0.html
[delete] https://crrev.com/ffe3c1da26430bb842db30d618ae349f37b02725/services/test/data/content-sniffer-test0.html.mock-http-headers
[delete] https://crrev.com/ffe3c1da26430bb842db30d618ae349f37b02725/services/test/data/content-sniffer-test1.html
[delete] https://crrev.com/ffe3c1da26430bb842db30d618ae349f37b02725/services/test/data/content-sniffer-test1.html.mock-http-headers
[delete] https://crrev.com/ffe3c1da26430bb842db30d618ae349f37b02725/services/test/data/content-sniffer-test2.html
[delete] https://crrev.com/ffe3c1da26430bb842db30d618ae349f37b02725/services/test/data/content-sniffer-test2.html.mock-http-headers
[delete] https://crrev.com/ffe3c1da26430bb842db30d618ae349f37b02725/services/test/data/empty.html
[delete] https://crrev.com/ffe3c1da26430bb842db30d618ae349f37b02725/services/test/data/hello.html
[delete] https://crrev.com/ffe3c1da26430bb842db30d618ae349f37b02725/services/test/data/hello.html.mock-http-headers
[delete] https://crrev.com/ffe3c1da26430bb842db30d618ae349f37b02725/services/test/data/nosniff-test.html
[delete] https://crrev.com/ffe3c1da26430bb842db30d618ae349f37b02725/services/test/data/nosniff-test.html.mock-http-headers
[delete] https://crrev.com/ffe3c1da26430bb842db30d618ae349f37b02725/services/test/data/redirect307-to-echo
[delete] https://crrev.com/ffe3c1da26430bb842db30d618ae349f37b02725/services/test/data/redirect307-to-echo.mock-http-headers
[delete] https://crrev.com/ffe3c1da26430bb842db30d618ae349f37b02725/services/test/data/simple_page.html

Project Member

Comment 37 by bugdroid1@chromium.org, Jan 31 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ba4ede2f67fa09c512ea6063411618acad6516f7

commit ba4ede2f67fa09c512ea6063411618acad6516f7
Author: John Abd-El-Malek <jam@chromium.org>
Date: Wed Jan 31 02:42:42 2018

Reland "Move url_loader_unittest.cc and network_service_unittest.cc to services/network."

This is a reland of e1c22cc3b5dc2a4276839d053bdf12ddee14dbea. The change didn't actually break the build, it was http://crbug.com/644525

Bug: 644525

Original change's description:
> Move url_loader_unittest.cc and network_service_unittest.cc to services/network.
>
> Their content dependencies have been removed in previous changes.
>
> Bug: 753658
> Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo
> Change-Id: Ic632759ef35cfef4e707d29acdc361ae836e9b62
> Reviewed-on: https://chromium-review.googlesource.com/893651
> Commit-Queue: John Abd-El-Malek <jam@chromium.org>
> Reviewed-by: Tom Sepez <tsepez@chromium.org>
> Reviewed-by: Ken Rockot <rockot@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#533113}

Bug: 753658
Change-Id: If780785790fb2b56aff1d91ddeb781bab2e127a3
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo
Reviewed-on: https://chromium-review.googlesource.com/894895
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Cr-Commit-Position: refs/heads/master@{#533175}
[modify] https://crrev.com/ba4ede2f67fa09c512ea6063411618acad6516f7/content/network/BUILD.gn
[modify] https://crrev.com/ba4ede2f67fa09c512ea6063411618acad6516f7/content/network/DEPS
[modify] https://crrev.com/ba4ede2f67fa09c512ea6063411618acad6516f7/content/test/BUILD.gn
[modify] https://crrev.com/ba4ede2f67fa09c512ea6063411618acad6516f7/content/test/unittests_manifest.json
[modify] https://crrev.com/ba4ede2f67fa09c512ea6063411618acad6516f7/content/utility/BUILD.gn
[modify] https://crrev.com/ba4ede2f67fa09c512ea6063411618acad6516f7/services/BUILD.gn
[modify] https://crrev.com/ba4ede2f67fa09c512ea6063411618acad6516f7/services/network/BUILD.gn
[rename] https://crrev.com/ba4ede2f67fa09c512ea6063411618acad6516f7/services/network/network_service_unittest.cc
[add] https://crrev.com/ba4ede2f67fa09c512ea6063411618acad6516f7/services/network/test/OWNERS
[add] https://crrev.com/ba4ede2f67fa09c512ea6063411618acad6516f7/services/network/test/service_unittest_manifest.json
[rename] https://crrev.com/ba4ede2f67fa09c512ea6063411618acad6516f7/services/network/url_loader_unittest.cc
[modify] https://crrev.com/ba4ede2f67fa09c512ea6063411618acad6516f7/services/test/BUILD.gn
[add] https://crrev.com/ba4ede2f67fa09c512ea6063411618acad6516f7/services/test/data/content-sniffer-test0.html
[copy] https://crrev.com/ba4ede2f67fa09c512ea6063411618acad6516f7/services/test/data/content-sniffer-test0.html.mock-http-headers
[add] https://crrev.com/ba4ede2f67fa09c512ea6063411618acad6516f7/services/test/data/content-sniffer-test1.html
[add] https://crrev.com/ba4ede2f67fa09c512ea6063411618acad6516f7/services/test/data/content-sniffer-test1.html.mock-http-headers
[add] https://crrev.com/ba4ede2f67fa09c512ea6063411618acad6516f7/services/test/data/content-sniffer-test2.html
[add] https://crrev.com/ba4ede2f67fa09c512ea6063411618acad6516f7/services/test/data/content-sniffer-test2.html.mock-http-headers
[rename] https://crrev.com/ba4ede2f67fa09c512ea6063411618acad6516f7/services/test/data/content-sniffer-test4.html
[rename] https://crrev.com/ba4ede2f67fa09c512ea6063411618acad6516f7/services/test/data/content-sniffer-test4.html.mock-http-headers
[copy] https://crrev.com/ba4ede2f67fa09c512ea6063411618acad6516f7/services/test/data/empty.html
[add] https://crrev.com/ba4ede2f67fa09c512ea6063411618acad6516f7/services/test/data/hello.html
[add] https://crrev.com/ba4ede2f67fa09c512ea6063411618acad6516f7/services/test/data/hello.html.mock-http-headers
[rename] https://crrev.com/ba4ede2f67fa09c512ea6063411618acad6516f7/services/test/data/nocache.html
[rename] https://crrev.com/ba4ede2f67fa09c512ea6063411618acad6516f7/services/test/data/nocache.html.mock-http-headers
[add] https://crrev.com/ba4ede2f67fa09c512ea6063411618acad6516f7/services/test/data/nosniff-test.html
[add] https://crrev.com/ba4ede2f67fa09c512ea6063411618acad6516f7/services/test/data/nosniff-test.html.mock-http-headers
[add] https://crrev.com/ba4ede2f67fa09c512ea6063411618acad6516f7/services/test/data/redirect307-to-echo
[add] https://crrev.com/ba4ede2f67fa09c512ea6063411618acad6516f7/services/test/data/redirect307-to-echo.mock-http-headers
[add] https://crrev.com/ba4ede2f67fa09c512ea6063411618acad6516f7/services/test/data/simple_page.html

Project Member

Comment 38 by bugdroid1@chromium.org, Jan 31 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3d915b21722c6a8cfac748dd748195adc4691297

commit 3d915b21722c6a8cfac748dd748195adc4691297
Author: John Abd-El-Malek <jam@chromium.org>
Date: Wed Jan 31 18:58:00 2018

Run url_loader_unittest.cc on iOS as it already passes.

Bug: 753658
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo
Change-Id: I4fa031a0044307c56351a4d5072d7fcee1b8f053
Reviewed-on: https://chromium-review.googlesource.com/895262
Reviewed-by: Sylvain Defresne <sdefresne@chromium.org>
Commit-Queue: John Abd-El-Malek <jam@chromium.org>
Cr-Commit-Position: refs/heads/master@{#533344}
[modify] https://crrev.com/3d915b21722c6a8cfac748dd748195adc4691297/services/network/BUILD.gn
[modify] https://crrev.com/3d915b21722c6a8cfac748dd748195adc4691297/services/test/BUILD.gn

Project Member

Comment 39 by bugdroid1@chromium.org, Jan 31 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8e82a32d4ce2c283e9e2007cdeb00b848af325db

commit 8e82a32d4ce2c283e9e2007cdeb00b848af325db
Author: John Abd-El-Malek <jam@chromium.org>
Date: Wed Jan 31 20:30:47 2018

Make services/network a component.

This is needed to fix the cert verifier tests that were temporarily disabled in r532778.

Also remove the public headers in services/network/public/cpp that are implemented in services/network. As Ken pointed out, public/cpp is just client library and isn't a public interface.

Bug: 753658
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo
Change-Id: Ie4f721a781cb8c1c345749ea9e1f30cbf67e5fd7
Reviewed-on: https://chromium-review.googlesource.com/894298
Reviewed-by: Ken Rockot <rockot@chromium.org>
Commit-Queue: John Abd-El-Malek <jam@chromium.org>
Cr-Commit-Position: refs/heads/master@{#533385}
[modify] https://crrev.com/8e82a32d4ce2c283e9e2007cdeb00b848af325db/chrome/browser/DEPS
[modify] https://crrev.com/8e82a32d4ce2c283e9e2007cdeb00b848af325db/chrome/browser/io_thread.cc
[modify] https://crrev.com/8e82a32d4ce2c283e9e2007cdeb00b848af325db/chrome/browser/net/system_network_context_manager.cc
[modify] https://crrev.com/8e82a32d4ce2c283e9e2007cdeb00b848af325db/chrome/browser/profiles/profile_io_data.cc
[modify] https://crrev.com/8e82a32d4ce2c283e9e2007cdeb00b848af325db/chrome/utility/BUILD.gn
[modify] https://crrev.com/8e82a32d4ce2c283e9e2007cdeb00b848af325db/chrome/utility/DEPS
[modify] https://crrev.com/8e82a32d4ce2c283e9e2007cdeb00b848af325db/chrome/utility/chrome_content_utility_client.cc
[modify] https://crrev.com/8e82a32d4ce2c283e9e2007cdeb00b848af325db/content/browser/network_service_instance.cc
[modify] https://crrev.com/8e82a32d4ce2c283e9e2007cdeb00b848af325db/content/browser/service_manager/service_manager_context.cc
[modify] https://crrev.com/8e82a32d4ce2c283e9e2007cdeb00b848af325db/content/browser/storage_partition_impl.cc
[modify] https://crrev.com/8e82a32d4ce2c283e9e2007cdeb00b848af325db/content/public/common/DEPS
[modify] https://crrev.com/8e82a32d4ce2c283e9e2007cdeb00b848af325db/content/public/common/network_connection_tracker_unittest.cc
[modify] https://crrev.com/8e82a32d4ce2c283e9e2007cdeb00b848af325db/content/public/common/simple_url_loader_unittest.cc
[modify] https://crrev.com/8e82a32d4ce2c283e9e2007cdeb00b848af325db/content/test/DEPS
[modify] https://crrev.com/8e82a32d4ce2c283e9e2007cdeb00b848af325db/content/test/url_request_context_builder_mojo_unittest.cc
[modify] https://crrev.com/8e82a32d4ce2c283e9e2007cdeb00b848af325db/content/utility/utility_service_factory.cc
[modify] https://crrev.com/8e82a32d4ce2c283e9e2007cdeb00b848af325db/services/network/BUILD.gn
[modify] https://crrev.com/8e82a32d4ce2c283e9e2007cdeb00b848af325db/services/network/cookie_manager.h
[modify] https://crrev.com/8e82a32d4ce2c283e9e2007cdeb00b848af325db/services/network/data_pipe_element_reader.h
[modify] https://crrev.com/8e82a32d4ce2c283e9e2007cdeb00b848af325db/services/network/network_change_manager.h
[modify] https://crrev.com/8e82a32d4ce2c283e9e2007cdeb00b848af325db/services/network/network_context.cc
[modify] https://crrev.com/8e82a32d4ce2c283e9e2007cdeb00b848af325db/services/network/network_context.h
[modify] https://crrev.com/8e82a32d4ce2c283e9e2007cdeb00b848af325db/services/network/network_context_unittest.cc
[modify] https://crrev.com/8e82a32d4ce2c283e9e2007cdeb00b848af325db/services/network/network_sandbox_hook_linux.h
[rename] https://crrev.com/8e82a32d4ce2c283e9e2007cdeb00b848af325db/services/network/network_service.cc
[rename] https://crrev.com/8e82a32d4ce2c283e9e2007cdeb00b848af325db/services/network/network_service.h
[modify] https://crrev.com/8e82a32d4ce2c283e9e2007cdeb00b848af325db/services/network/network_service_unittest.cc
[modify] https://crrev.com/8e82a32d4ce2c283e9e2007cdeb00b848af325db/services/network/network_service_url_loader_factory.cc
[modify] https://crrev.com/8e82a32d4ce2c283e9e2007cdeb00b848af325db/services/network/proxy_config_service_mojo.h
[modify] https://crrev.com/8e82a32d4ce2c283e9e2007cdeb00b848af325db/services/network/proxy_resolver_factory_mojo.h
[modify] https://crrev.com/8e82a32d4ce2c283e9e2007cdeb00b848af325db/services/network/proxy_service_mojo.h
[modify] https://crrev.com/8e82a32d4ce2c283e9e2007cdeb00b848af325db/services/network/public/cpp/BUILD.gn
[delete] https://crrev.com/f2f3b1c3b5117c20f313a135059723366a6e488c/services/network/public/cpp/network_service.h
[modify] https://crrev.com/8e82a32d4ce2c283e9e2007cdeb00b848af325db/services/network/restricted_cookie_manager.h
[modify] https://crrev.com/8e82a32d4ce2c283e9e2007cdeb00b848af325db/services/network/throttling/network_conditions.h
[modify] https://crrev.com/8e82a32d4ce2c283e9e2007cdeb00b848af325db/services/network/throttling/throttling_controller.h
[modify] https://crrev.com/8e82a32d4ce2c283e9e2007cdeb00b848af325db/services/network/throttling/throttling_network_interceptor.h
[modify] https://crrev.com/8e82a32d4ce2c283e9e2007cdeb00b848af325db/services/network/throttling/throttling_network_transaction.h
[modify] https://crrev.com/8e82a32d4ce2c283e9e2007cdeb00b848af325db/services/network/throttling/throttling_network_transaction_factory.h
[modify] https://crrev.com/8e82a32d4ce2c283e9e2007cdeb00b848af325db/services/network/udp_socket.h
[modify] https://crrev.com/8e82a32d4ce2c283e9e2007cdeb00b848af325db/services/network/udp_socket_factory.h
[modify] https://crrev.com/8e82a32d4ce2c283e9e2007cdeb00b848af325db/services/network/upload_progress_tracker.h
[modify] https://crrev.com/8e82a32d4ce2c283e9e2007cdeb00b848af325db/services/network/url_loader.cc
[modify] https://crrev.com/8e82a32d4ce2c283e9e2007cdeb00b848af325db/services/network/url_loader.h
[modify] https://crrev.com/8e82a32d4ce2c283e9e2007cdeb00b848af325db/services/network/url_request_context_builder_mojo.cc
[rename] https://crrev.com/8e82a32d4ce2c283e9e2007cdeb00b848af325db/services/network/url_request_context_builder_mojo.h

Comment 40 by jam@chromium.org, Jan 31 2018

Status: Fixed (was: Started)
Project Member

Comment 41 by bugdroid1@chromium.org, Jan 31 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/104e65a2081a3d37b0c872e6d9515014eaf85a12

commit 104e65a2081a3d37b0c872e6d9515014eaf85a12
Author: John Abd-El-Malek <jam@chromium.org>
Date: Wed Jan 31 20:53:02 2018

Revert "Temporary disable of browser tests that use CertVerifier with network service until services/network uses a component."

This reverts commit 87565daf3b2d46e178b58cbcc13b71c1924a70a9.

Reason for revert: r533385 now fixes this.
NOTRY=true

Original change's description:
> Temporary disable of browser tests that use CertVerifier with network service until services/network uses a component.
> 
> Until then, the test method isn't exported and the tests fail.
> 
> TBR=rockot@chromium.org
> NOTRY=true
> 
> Bug: 753658
> Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo
> Change-Id: Ifd5c4bf4e8e92aa8a87c439eb053ec08105724e4
> Reviewed-on: https://chromium-review.googlesource.com/892496
> Commit-Queue: John Abd-El-Malek <jam@chromium.org>
> Reviewed-by: John Abd-El-Malek <jam@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#532778}

TBR=jam@chromium.org,rockot@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 753658
Change-Id: I319b2e7263847fe76673192077d2bea55a470b7d
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo
Reviewed-on: https://chromium-review.googlesource.com/896032
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Cr-Commit-Position: refs/heads/master@{#533397}
[modify] https://crrev.com/104e65a2081a3d37b0c872e6d9515014eaf85a12/testing/buildbot/filters/mojo.fyi.network_browser_tests.filter

Project Member

Comment 42 by bugdroid1@chromium.org, Feb 1 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/89c02aea795ae75eab45419574d7c5db092a4a17

commit 89c02aea795ae75eab45419574d7c5db092a4a17
Author: John Abd-El-Malek <jam@chromium.org>
Date: Thu Feb 01 01:56:19 2018

Move non client-library code from services/network/public/cpp out of the public directory.

Context: https://groups.google.com/a/chromium.org/d/msg/network-service-dev/OtU2gBvN_EE/TUIl4j9cAAAJ

Bug: 753658
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo
Change-Id: Ib40dc4625ead75f0e612bf719e7dba428cbeed35
Reviewed-on: https://chromium-review.googlesource.com/896204
Commit-Queue: John Abd-El-Malek <jam@chromium.org>
Reviewed-by: Ken Rockot <rockot@chromium.org>
Cr-Commit-Position: refs/heads/master@{#533522}
[modify] https://crrev.com/89c02aea795ae75eab45419574d7c5db092a4a17/chrome/browser/DEPS
[modify] https://crrev.com/89c02aea795ae75eab45419574d7c5db092a4a17/chrome/browser/io_thread.cc
[modify] https://crrev.com/89c02aea795ae75eab45419574d7c5db092a4a17/chrome/browser/profiles/profile_io_data.cc
[modify] https://crrev.com/89c02aea795ae75eab45419574d7c5db092a4a17/content/browser/loader/mime_sniffing_resource_handler.cc
[modify] https://crrev.com/89c02aea795ae75eab45419574d7c5db092a4a17/content/browser/loader/navigation_url_loader_network_service.cc
[modify] https://crrev.com/89c02aea795ae75eab45419574d7c5db092a4a17/content/browser/loader/resource_dispatcher_host_impl.cc
[modify] https://crrev.com/89c02aea795ae75eab45419574d7c5db092a4a17/content/browser/loader/resource_loader.cc
[modify] https://crrev.com/89c02aea795ae75eab45419574d7c5db092a4a17/content/browser/renderer_host/p2p/socket_dispatcher_host.cc
[modify] https://crrev.com/89c02aea795ae75eab45419574d7c5db092a4a17/content/browser/renderer_host/p2p/socket_host.cc
[modify] https://crrev.com/89c02aea795ae75eab45419574d7c5db092a4a17/content/browser/renderer_host/p2p/socket_host_tcp.cc
[modify] https://crrev.com/89c02aea795ae75eab45419574d7c5db092a4a17/content/common/BUILD.gn
[modify] https://crrev.com/89c02aea795ae75eab45419574d7c5db092a4a17/content/common/DEPS
[modify] https://crrev.com/89c02aea795ae75eab45419574d7c5db092a4a17/content/common/service_worker/service_worker_loader_helpers.cc
[modify] https://crrev.com/89c02aea795ae75eab45419574d7c5db092a4a17/content/public/common/BUILD.gn
[modify] https://crrev.com/89c02aea795ae75eab45419574d7c5db092a4a17/content/public/common/DEPS
[modify] https://crrev.com/89c02aea795ae75eab45419574d7c5db092a4a17/content/public/common/referrer.cc
[modify] https://crrev.com/89c02aea795ae75eab45419574d7c5db092a4a17/content/renderer/BUILD.gn
[modify] https://crrev.com/89c02aea795ae75eab45419574d7c5db092a4a17/content/renderer/loader/web_url_loader_impl.cc
[modify] https://crrev.com/89c02aea795ae75eab45419574d7c5db092a4a17/content/shell/BUILD.gn
[modify] https://crrev.com/89c02aea795ae75eab45419574d7c5db092a4a17/content/shell/DEPS
[modify] https://crrev.com/89c02aea795ae75eab45419574d7c5db092a4a17/content/shell/browser/layout_test/layout_test_url_request_context_getter.cc
[modify] https://crrev.com/89c02aea795ae75eab45419574d7c5db092a4a17/jingle/BUILD.gn
[modify] https://crrev.com/89c02aea795ae75eab45419574d7c5db092a4a17/jingle/glue/DEPS
[modify] https://crrev.com/89c02aea795ae75eab45419574d7c5db092a4a17/jingle/glue/xmpp_client_socket_factory.cc
[modify] https://crrev.com/89c02aea795ae75eab45419574d7c5db092a4a17/jingle/glue/xmpp_client_socket_factory.h
[modify] https://crrev.com/89c02aea795ae75eab45419574d7c5db092a4a17/remoting/signaling/DEPS
[modify] https://crrev.com/89c02aea795ae75eab45419574d7c5db092a4a17/remoting/signaling/xmpp_signal_strategy.cc
[modify] https://crrev.com/89c02aea795ae75eab45419574d7c5db092a4a17/services/network/BUILD.gn
[rename] https://crrev.com/89c02aea795ae75eab45419574d7c5db092a4a17/services/network/ignore_errors_cert_verifier.cc
[rename] https://crrev.com/89c02aea795ae75eab45419574d7c5db092a4a17/services/network/ignore_errors_cert_verifier.h
[rename] https://crrev.com/89c02aea795ae75eab45419574d7c5db092a4a17/services/network/ignore_errors_cert_verifier_unittest.cc
[rename] https://crrev.com/89c02aea795ae75eab45419574d7c5db092a4a17/services/network/loader_util.cc
[rename] https://crrev.com/89c02aea795ae75eab45419574d7c5db092a4a17/services/network/loader_util.h
[modify] https://crrev.com/89c02aea795ae75eab45419574d7c5db092a4a17/services/network/network_context.cc
[rename] https://crrev.com/89c02aea795ae75eab45419574d7c5db092a4a17/services/network/proxy_resolving_client_socket.cc
[rename] https://crrev.com/89c02aea795ae75eab45419574d7c5db092a4a17/services/network/proxy_resolving_client_socket.h
[rename] https://crrev.com/89c02aea795ae75eab45419574d7c5db092a4a17/services/network/proxy_resolving_client_socket_factory.cc
[rename] https://crrev.com/89c02aea795ae75eab45419574d7c5db092a4a17/services/network/proxy_resolving_client_socket_factory.h
[rename] https://crrev.com/89c02aea795ae75eab45419574d7c5db092a4a17/services/network/proxy_resolving_client_socket_unittest.cc
[modify] https://crrev.com/89c02aea795ae75eab45419574d7c5db092a4a17/services/network/public/cpp/BUILD.gn
[modify] https://crrev.com/89c02aea795ae75eab45419574d7c5db092a4a17/services/network/url_loader.cc

Project Member

Comment 43 by bugdroid1@chromium.org, Feb 1 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4cd4e305eccb7bd08615664a3629cc3fc16c7deb

commit 4cd4e305eccb7bd08615664a3629cc3fc16c7deb
Author: Yutaka Hirano <yhirano@chromium.org>
Date: Thu Feb 01 17:38:00 2018

Move ResourceScheduler to /services/network

Bug: 753658, 754918
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo
Change-Id: Id9206b68b1b85b0db20919763e45aede88d565cc
Reviewed-on: https://chromium-review.googlesource.com/892938
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Commit-Queue: John Abd-El-Malek <jam@chromium.org>
Cr-Commit-Position: refs/heads/master@{#533718}
[modify] https://crrev.com/4cd4e305eccb7bd08615664a3629cc3fc16c7deb/content/browser/loader/mojo_async_resource_handler.cc
[modify] https://crrev.com/4cd4e305eccb7bd08615664a3629cc3fc16c7deb/content/browser/loader/mojo_async_resource_handler_unittest.cc
[modify] https://crrev.com/4cd4e305eccb7bd08615664a3629cc3fc16c7deb/content/browser/loader/resource_dispatcher_host_impl.cc
[modify] https://crrev.com/4cd4e305eccb7bd08615664a3629cc3fc16c7deb/content/browser/loader/resource_dispatcher_host_impl.h
[modify] https://crrev.com/4cd4e305eccb7bd08615664a3629cc3fc16c7deb/content/browser/loader/resource_scheduler_filter.cc
[modify] https://crrev.com/4cd4e305eccb7bd08615664a3629cc3fc16c7deb/content/network/BUILD.gn
[modify] https://crrev.com/4cd4e305eccb7bd08615664a3629cc3fc16c7deb/content/test/BUILD.gn
[modify] https://crrev.com/4cd4e305eccb7bd08615664a3629cc3fc16c7deb/services/network/BUILD.gn
[rename] https://crrev.com/4cd4e305eccb7bd08615664a3629cc3fc16c7deb/services/network/resource_scheduler.cc
[rename] https://crrev.com/4cd4e305eccb7bd08615664a3629cc3fc16c7deb/services/network/resource_scheduler.h
[rename] https://crrev.com/4cd4e305eccb7bd08615664a3629cc3fc16c7deb/services/network/resource_scheduler_unittest.cc

Project Member

Comment 44 by bugdroid1@chromium.org, Feb 5 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/cfb3fae9e51e6a587c77d009222525e526c03701

commit cfb3fae9e51e6a587c77d009222525e526c03701
Author: John Abd-El-Malek <jam@chromium.org>
Date: Mon Feb 05 19:29:45 2018

Run network_service_unittest tests on iOS.

Only the network change tests fail there.

Bug: 753658
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo
Change-Id: Ie2ff9ae496b63c8461bc0be6c3d0edfe4855f567
Reviewed-on: https://chromium-review.googlesource.com/896394
Reviewed-by: Sylvain Defresne <sdefresne@chromium.org>
Commit-Queue: John Abd-El-Malek <jam@chromium.org>
Cr-Commit-Position: refs/heads/master@{#534458}
[modify] https://crrev.com/cfb3fae9e51e6a587c77d009222525e526c03701/services/network/BUILD.gn
[modify] https://crrev.com/cfb3fae9e51e6a587c77d009222525e526c03701/services/network/network_service_unittest.cc

Project Member

Comment 45 by bugdroid1@chromium.org, Feb 6 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/bdafede504a38e747c3431d8ccc06edd33c4c859

commit bdafede504a38e747c3431d8ccc06edd33c4c859
Author: John Abd-El-Malek <jam@chromium.org>
Date: Tue Feb 06 15:10:36 2018

Move SimpleURLLoader to services/network/public/cpp.

Bug: 753658
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo
Change-Id: I4187878bfb627fb0983dca3a218c65f86d889f7c
Reviewed-on: https://chromium-review.googlesource.com/902624
Reviewed-by: Ken Rockot <rockot@chromium.org>
Commit-Queue: John Abd-El-Malek <jam@chromium.org>
Cr-Commit-Position: refs/heads/master@{#534687}
[modify] https://crrev.com/bdafede504a38e747c3431d8ccc06edd33c4c859/chrome/browser/bitmap_fetcher/bitmap_fetcher.cc
[modify] https://crrev.com/bdafede504a38e747c3431d8ccc06edd33c4c859/chrome/browser/bitmap_fetcher/bitmap_fetcher.h
[modify] https://crrev.com/bdafede504a38e747c3431d8ccc06edd33c4c859/chrome/browser/chromeos/login/screens/terms_of_service_screen.cc
[modify] https://crrev.com/bdafede504a38e747c3431d8ccc06edd33c4c859/chrome/browser/chromeos/login/screens/terms_of_service_screen.h
[modify] https://crrev.com/bdafede504a38e747c3431d8ccc06edd33c4c859/chrome/browser/net/network_context_configuration_browsertest.cc
[modify] https://crrev.com/bdafede504a38e747c3431d8ccc06edd33c4c859/chrome/browser/net/profile_network_context_service_browsertest.cc
[modify] https://crrev.com/bdafede504a38e747c3431d8ccc06edd33c4c859/chrome/browser/ui/app_list/search/common/url_icon_source.cc
[modify] https://crrev.com/bdafede504a38e747c3431d8ccc06edd33c4c859/chrome/browser/ui/app_list/search/common/url_icon_source.h
[modify] https://crrev.com/bdafede504a38e747c3431d8ccc06edd33c4c859/content/browser/browsing_data/browsing_data_remover_impl_browsertest.cc
[modify] https://crrev.com/bdafede504a38e747c3431d8ccc06edd33c4c859/content/browser/network_service_restart_browsertest.cc
[modify] https://crrev.com/bdafede504a38e747c3431d8ccc06edd33c4c859/content/public/common/BUILD.gn
[modify] https://crrev.com/bdafede504a38e747c3431d8ccc06edd33c4c859/content/public/test/browser_test_utils.cc
[modify] https://crrev.com/bdafede504a38e747c3431d8ccc06edd33c4c859/content/public/test/simple_url_loader_test_helper.cc
[modify] https://crrev.com/bdafede504a38e747c3431d8ccc06edd33c4c859/content/public/test/simple_url_loader_test_helper.h
[modify] https://crrev.com/bdafede504a38e747c3431d8ccc06edd33c4c859/content/test/BUILD.gn
[modify] https://crrev.com/bdafede504a38e747c3431d8ccc06edd33c4c859/services/network/public/cpp/BUILD.gn
[rename] https://crrev.com/bdafede504a38e747c3431d8ccc06edd33c4c859/services/network/public/cpp/simple_url_loader.cc
[rename] https://crrev.com/bdafede504a38e747c3431d8ccc06edd33c4c859/services/network/public/cpp/simple_url_loader.h
[rename] https://crrev.com/bdafede504a38e747c3431d8ccc06edd33c4c859/services/network/public/cpp/simple_url_loader_stream_consumer.h
[rename] https://crrev.com/bdafede504a38e747c3431d8ccc06edd33c4c859/services/network/public/cpp/simple_url_loader_unittest.cc
[modify] https://crrev.com/bdafede504a38e747c3431d8ccc06edd33c4c859/services/test/BUILD.gn
[add] https://crrev.com/bdafede504a38e747c3431d8ccc06edd33c4c859/services/test/data/title1.html

Cc: -rdsmith@chromium.org

Sign in to add a comment