Convert text-iterator layout test to gtest |
|||||||
Issue descriptionThere are no good reasons using layout test for verifying TextIterator. We should convert below to gtest: LayoutTests/editing/text-iterator/ backward-textiterator-first-letter-crash.html basic-iteration-shadowdom.html basic-iteration.html find-after-mutation.html findString-restarts-at-last-position.html findString-selection-disabled.html findString-shadow-roots.html findString-start-search-after-selection.html findString.html first-letter-rtl-crash.html first-letter-word-boundary.html range-to-from-location-and-length.html read-past-cloned-first-letter.html rtl-first-letter-text-iterator-crash.html rtl-selection-crash.html selection-to-string-with-auto-fill.html thai-cursor-movement.html
,
Aug 9 2017
,
Aug 9 2017
The text dumps in layout tests also form a test suite for TextIterator, which, however, shouldn't be relied on. During the development of TextIterator NG, some existing bugs in TextIterator are found, and a number of layout tests are rebaselined. We should also convert the rebaselined layout tests (somehow) to unit tests, so that the correct behavior of TextIterator NG is coverted by some tests dedicated to it. The list of rebaselined tests can be found in https://chromium-review.googlesource.com/c/580371
,
Aug 23 2017
,
Aug 29 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/2266a8ad92bf914bb090d036a2619c41a953c3a9 commit 2266a8ad92bf914bb090d036a2619c41a953c3a9 Author: Akari Asai <akariasai@google.com> Date: Tue Aug 29 07:34:24 2017 Converts basic-iteration.js to gtest. Converted WebKit/LayoutTests/editing/text-iterator/script-tests/basic-iteration.js to gtest and added the corresponding tests to WebKit/Source/core/editing/iterators/ TextIteratorTest.cpp, since there are no good reasons using layout test for verifying TextIterator. Bug: 753657 Change-Id: I392b13da25829ab312d82eb7c0dcb6404a5de300 Reviewed-on: https://chromium-review.googlesource.com/628398 Reviewed-by: Xiaocheng Hu <xiaochengh@chromium.org> Commit-Queue: Akari Asai <akariasai@google.com> Cr-Commit-Position: refs/heads/master@{#498041} [modify] https://crrev.com/2266a8ad92bf914bb090d036a2619c41a953c3a9/third_party/WebKit/LayoutTests/FlagExpectations/enable-blink-features=LayoutNG [delete] https://crrev.com/a6df92167f0eabd6496a84877ba80f66a928ecbd/third_party/WebKit/LayoutTests/editing/text-iterator/basic-iteration-expected.txt [delete] https://crrev.com/a6df92167f0eabd6496a84877ba80f66a928ecbd/third_party/WebKit/LayoutTests/editing/text-iterator/basic-iteration.html [delete] https://crrev.com/a6df92167f0eabd6496a84877ba80f66a928ecbd/third_party/WebKit/LayoutTests/editing/text-iterator/script-tests/basic-iteration.js [modify] https://crrev.com/2266a8ad92bf914bb090d036a2619c41a953c3a9/third_party/WebKit/Source/core/editing/iterators/TextIteratorTest.cpp
,
Oct 2 2017
The assigned owner "akariasai@google.com" is not able to receive e-mails, please re-triage. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Oct 3 2017
,
Oct 3
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue. Sorry for the inconvenience if the bug really should have been left as Available. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Oct 5
|
|||||||
►
Sign in to add a comment |
|||||||
Comment 1 by xiaoche...@chromium.org
, Aug 9 2017