New issue
Advanced search Search tips

Issue 753655 link

Starred by 1 user

Issue metadata

Status: Duplicate
Merged: issue 750923
Owner: ----
Closed: Aug 2017
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug-Regression



Sign in to add a comment

5.5%-30.1% regression in thread_times.tough_scrolling_cases at 490326:490497

Project Member Reported by kouhei@chromium.org, Aug 9 2017

Issue description

See the link to graphs below.
 
All graphs for this bug:
  https://chromeperf.appspot.com/group_report?bug_id=753655

(For debugging:) Original alerts at time of bug-filing:
  https://chromeperf.appspot.com/group_report?sid=d93bcdb6591a217723cb2c630a6d3d7fb84196acfdbba1fbab8225fab5968039


Bot(s) for this bug's original alert(s):

chromium-rel-win7-dual
chromium-rel-win7-gpu-intel
chromium-rel-win8-dual
Cc: bsalo...@google.com
Owner: bsalo...@google.com

=== Auto-CCing suspected CL author bsalomon@google.com ===

Hi bsalomon@google.com, the bisect results pointed to your CL, please take a look at the
results.


=== BISECT JOB RESULTS ===
Perf regression found with culprit

Suspected Commit
  Author : Brian Salomon
  Commit : 3f6f965a5a65415c65fe9e64eb41896c66da771d
  Date   : Fri Jul 28 11:54:47 2017
  Subject: Implement clone for 6 additional GrFragmentProcessor subclasses.

Bisect Details
  Configuration: win_8_perf_bisect
  Benchmark    : thread_times.tough_scrolling_cases
  Metric       : thread_raster_cpu_time_per_frame/text_constant_full_page_raster_05000_pixels_per_second
  Change       : 4.58% | 2.22152990422 -> 2.32325803437

Revision                             Result                    N
chromium@490325                      2.22153 +- 0.0865254      6      good
chromium@490386                      2.22963 +- 0.10652        6      good
chromium@490402                      2.1054 +- 0.110027        6      good
chromium@490403                      2.04348 +- 0.149106       6      good
chromium@490403,skia@3f6f965a5a      2.4005 +- 0.228113        6      bad       <--
chromium@490403,skia@f7928b4f33      2.26155 +- 0.157417       6      bad
chromium@490404                      2.42815 +- 0.0915047      6      bad
chromium@490406                      2.36538 +- 0.124803       6      bad
chromium@490410                      2.4448 +- 0.135008        6      bad
chromium@490417                      2.3316 +- 0.134282        9      bad
chromium@490447                      2.32326 +- 0.0605982      6      bad

To Run This Test
  src/tools/perf/run_benchmark -v --browser=release --output-format=chartjson --upload-results --pageset-repeat=1 --also-run-disabled-tests --story-filter=text.constant.full.page.raster.05000.pixels.per.second thread_times.tough_scrolling_cases

More information on addressing performance regressions:
  http://g.co/ChromePerformanceRegressions

Debug information about this bisect:
  https://chromeperf.appspot.com/buildbucket_job_status/8971770012245628704


For feedback, file a bug with component Speed>Bisection
This change added code that is not called by Chrome. The numbers in the bisect look noisy. I think it is fairly unlikely that change is the cause. I'm unassigning myself and kicking off another bisect per  http://g.co/ChromePerformanceRegressions.
Owner: ----
Mergedinto: 750923
Status: Duplicate (was: Untriaged)

=== BISECT JOB RESULTS ===
Perf regression found with culprit

Suspected Commit
  Author : Hans Wennborg
  Commit : d2c91228a51bdf37ae3b2e501fb53c0528f1629c
  Date   : Fri Jul 28 20:11:05 2017
  Subject: win: Set is_clang=true by default

Bisect Details
  Configuration: winx64intel_perf_bisect
  Benchmark    : thread_times.tough_scrolling_cases
  Metric       : thread_raster_cpu_time_per_frame/text_constant_full_page_raster_10000_pixels_per_second
  Change       : 6.49% | 3.29969203059 -> 3.53608217209

Revision             Result                    N
chromium@490421      3.29969 +- 0.0807876      6       good
chromium@490459      3.24536 +- 0.0511973      6       good
chromium@490478      3.36787 +- 0.286998       6       good
chromium@490488      3.31094 +- 0.13888        9       good
chromium@490493      3.38068 +- 0.352356       14      good
chromium@490494      3.63034 +- 0.121354       6       bad       <--
chromium@490495      3.62859 +- 0.21004        6       bad
chromium@490497      3.53608 +- 0.157891       9       bad

To Run This Test
  src/tools/perf/run_benchmark -v --browser=release_x64 --output-format=chartjson --upload-results --pageset-repeat=1 --also-run-disabled-tests --story-filter=text.constant.full.page.raster.10000.pixels.per.second thread_times.tough_scrolling_cases

More information on addressing performance regressions:
  http://g.co/ChromePerformanceRegressions

Debug information about this bisect:
  https://chromeperf.appspot.com/buildbucket_job_status/8971733363853157600


For feedback, file a bug with component Speed>Bisection

Sign in to add a comment