New issue
Advanced search Search tips

Issue 753619 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Sep 11
Components:
EstimatedDays: ----
NextAction: ----
OS: Fuchsia
Pri: 3
Type: Bug



Sign in to add a comment

Enable crash reporting under Fuchsia

Project Member Reported by kmarshall@chromium.org, Aug 9 2017

Issue description

Tracking bug for porting Breakpad or using OS native crash reporting facilities in Fuchsia.
 
Owner: scottmg@chromium.org
Status: Assigned (was: Untriaged)
Meeting with Fuchsia and Crashpad today to figure out what to do for OS-level crash reporting. Hopefully this can be sorted out in a way that means limited integration work for Chromium (and other applications).
Project Member

Comment 2 by bugdroid1@chromium.org, Aug 10 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/bc4dfe0ca814e360aad00be4ab41011884df051c

commit bc4dfe0ca814e360aad00be4ab41011884df051c
Author: Kevin Marshall <kmarshall@chromium.org>
Date: Thu Aug 10 05:43:06 2017

Fuchsia: disable crash reporting in headless client

Breakpad/crash reporting aren't available yet in Fuchsia.


Bug:  753619 
Change-Id: I0453ce91cf06a01c5a38ede1f927d27ecd21e121
Reviewed-on: https://chromium-review.googlesource.com/606562
Reviewed-by: Sami Kyöstilä <skyostil@chromium.org>
Commit-Queue: Kevin Marshall <kmarshall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#493296}
[modify] https://crrev.com/bc4dfe0ca814e360aad00be4ab41011884df051c/headless/BUILD.gn
[modify] https://crrev.com/bc4dfe0ca814e360aad00be4ab41011884df051c/headless/lib/headless_content_main_delegate.cc
[modify] https://crrev.com/bc4dfe0ca814e360aad00be4ab41011884df051c/headless/lib/headless_content_main_delegate.h
[modify] https://crrev.com/bc4dfe0ca814e360aad00be4ab41011884df051c/headless/lib/headless_macros.h

Project Member

Comment 3 by bugdroid1@chromium.org, Aug 11 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f24e3740ea0a4f4371cb631308e4d8e759ae4adb

commit f24e3740ea0a4f4371cb631308e4d8e759ae4adb
Author: Scott Graham <scottmg@chromium.org>
Date: Fri Aug 11 17:50:22 2017

fuchsia: Add dependency on //headless to get headless_shell target

This lets gn generate build files that contain headless_shell as a
target, but there's still lots of porting to be done to get it to
actually build.

Dependencies on crash reporting are excluded, as it is expected
that a shipping product would rely on the Fuchsia system crash
reporter, so Chrome itself does not need a separate one.

Bug:  746674 ,  753619 
Change-Id: Id63ebeb1ed8e3a927e6ac8b368f89c9c010d440f
Reviewed-on: https://chromium-review.googlesource.com/608810
Reviewed-by: Sami Kyöstilä <skyostil@chromium.org>
Cr-Commit-Position: refs/heads/master@{#493794}
[modify] https://crrev.com/f24e3740ea0a4f4371cb631308e4d8e759ae4adb/BUILD.gn
[modify] https://crrev.com/f24e3740ea0a4f4371cb631308e4d8e759ae4adb/headless/BUILD.gn

Project Member

Comment 4 by bugdroid1@chromium.org, Oct 9 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7b98909890c716667ef542d1d215cd2b0d1cf14f

commit 7b98909890c716667ef542d1d215cd2b0d1cf14f
Author: Sergey Ulanov <sergeyu@chromium.org>
Date: Mon Oct 09 23:20:45 2017

Make cast_shell buildable for Fuchsia

1. Added ifdefs around crash-reporting,  bug 753619 .
2. Added CastContentWindowFuchsia.
4. Disabled NetworkChangeNotifierFactoryCast - will need to add a
   Fuchsia-specific implementation once we have an API

Bug:  772488 ,  753619 
Change-Id: Id48af74ccdb003230233a6061bbf49412a571ce6
Reviewed-on: https://chromium-review.googlesource.com/705399
Commit-Queue: Sergey Ulanov <sergeyu@chromium.org>
Reviewed-by: Luke Halliwell <halliwell@chromium.org>
Reviewed-by: Wez <wez@chromium.org>
Cr-Commit-Position: refs/heads/master@{#507529}
[modify] https://crrev.com/7b98909890c716667ef542d1d215cd2b0d1cf14f/chromecast/BUILD.gn
[modify] https://crrev.com/7b98909890c716667ef542d1d215cd2b0d1cf14f/chromecast/app/cast_main_delegate.cc
[modify] https://crrev.com/7b98909890c716667ef542d1d215cd2b0d1cf14f/chromecast/app/cast_main_delegate.h
[modify] https://crrev.com/7b98909890c716667ef542d1d215cd2b0d1cf14f/chromecast/base/file_utils.cc
[modify] https://crrev.com/7b98909890c716667ef542d1d215cd2b0d1cf14f/chromecast/browser/BUILD.gn
[modify] https://crrev.com/7b98909890c716667ef542d1d215cd2b0d1cf14f/chromecast/browser/cast_browser_main_parts.cc
[modify] https://crrev.com/7b98909890c716667ef542d1d215cd2b0d1cf14f/chromecast/browser/cast_content_browser_client.cc
[add] https://crrev.com/7b98909890c716667ef542d1d215cd2b0d1cf14f/chromecast/browser/cast_content_window_aura.cc
[rename] https://crrev.com/7b98909890c716667ef542d1d215cd2b0d1cf14f/chromecast/browser/cast_content_window_aura.h
[delete] https://crrev.com/b81f263e6f4535b7b311d180976078d9274dbc89/chromecast/browser/cast_content_window_linux.cc
[modify] https://crrev.com/7b98909890c716667ef542d1d215cd2b0d1cf14f/chromecast/browser/metrics/cast_metrics_service_client.cc
[modify] https://crrev.com/7b98909890c716667ef542d1d215cd2b0d1cf14f/chromecast/renderer/cast_content_renderer_client.cc

Status: Fixed (was: Assigned)
There's no crash integration in Chrome-on-Fuchsia, but Crashpad is the system crash reporter on Fuchsia, and it sends data to the (chrome) crash server, so we're pretty close to what we'd need.

Some follow up (possibly server-side?) might be required to be able to cross-reference crashes between platforms, or otherwise slice data to see it in the way we want, as well as on additional features in Crashpad to get more data into dumps.

Sign in to add a comment