Move VideoFrameCompositor off media thread. |
|||||
Issue descriptionCurrently the VideoFrameCompositor in the SurfaceLayer use case runs on the media thread. We may encounter smoothness issues with this. We should instead use a different thread for it and VideoFrameSubmitter.
,
May 25 2018
Do we still want to do this?
,
May 25 2018
Definitely want to do some testing to see if it makes a difference.
,
Aug 9
,
Aug 14
Do y'all have traces where the media thread is overloaded and smoothness ends up being impacted? I'm just trying to understand what the underlying data motivating this change is.
,
Aug 14
I support any request for data to verify my suggestion. Probably that means implementing this and checking the AV-Analysis + YouTube metrics. The reason I suggested this though: It's not necessary for it to be overloaded, just for there to be long blocking tasks on it -- of which software video decode may definitely block 10s to 100s of ms (audio decode is also on this thread, but is generally very fast). The media thread does not run with the same thread priorities as the previous compositor thread either.
,
Aug 14
Ok, software video decode as a use case makes sense here. If you're adding more work to a thread, then maybe that would push work past some threshold of making the cutoff for a particular frame and hurt smoothness.
,
Aug 31
Fixed by https://chromium-review.googlesource.com/c/chromium/src/+/1176879
,
Aug 31
|
|||||
►
Sign in to add a comment |
|||||
Comment 1 by lethalantidote@chromium.org
, Aug 9 2017