New issue
Advanced search Search tips

Issue 753605 link

Starred by 5 users

Issue metadata

Status: Fixed
Owner:
Closed: Aug 31
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 2
Type: Feature

Blocking:
issue 746182
issue 866508



Sign in to add a comment

Move VideoFrameCompositor off media thread.

Project Member Reported by lethalantidote@chromium.org, Aug 8 2017

Issue description

Currently the VideoFrameCompositor in the SurfaceLayer use case runs on the media thread. We may encounter smoothness issues with this. We should instead use a different thread for it and VideoFrameSubmitter.


 
Blocking: 746182
Do we still want to do this?
Definitely want to do some testing to see if it makes a difference. 
Cc: mlamouri@chromium.org
Do y'all have traces where the media thread is overloaded and smoothness ends up being impacted? I'm just trying to understand what the underlying data motivating this change is.
I support any request for data to verify my suggestion. Probably that means implementing this and checking the AV-Analysis + YouTube metrics.

The reason I suggested this though: It's not necessary for it to be overloaded, just for there to be long blocking tasks on it -- of which software video decode may definitely block 10s to 100s of ms (audio decode is also on this thread, but is generally very fast). The media thread does not run with the same thread priorities as the previous compositor thread either.
Cc: enne@chromium.org
Ok, software video decode as a use case makes sense here.  If you're adding more work to a thread, then maybe that would push work past some threshold of making the cutoff for a particular frame and hurt smoothness.
Blocking: 866508

Sign in to add a comment