New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 753599 link

Starred by 2 users
Status: Fixed
Owner:
█ martiw@chromium.org
Last visit > 30 days ago
Closed: Jan 2018
Cc:
█ ramyasharma@chromium.org
█ noyau@chromium.org
gracec@chromium.org
ios-bugs@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 3
Type: Bug

Blocked on:
issue 695749
Blocking:
issue 768817
issue 796483



Sign in to add a comment

Cleanup after the new UI is launched for Bookmarks on iOS

Project Member Reported by ramyasharma@chromium.org, Aug 8 2017 
Cleanup after the new UI is launched for Bookmarks on iOS:

Remove BookmarkNavigation bar
Remove BookmarkCollectionView
Delete BookmarkHomeTabletViewController
Merge BookmarkHomeHandsetViewController into BookmarkHomeViewController

After the launch, there will be no two view controllers for handset and tablet. We will have a single implementation.

Comment 1 by ramyasharma@chromium.org, Aug 8 2017

Blockedon: 695749

Comment 2 by gracec@chromium.org, Sep 8 2017

Cc: gracec@chromium.org

Comment 3 by martiw@chromium.org, Dec 20 2017

Status: Started (was: Assigned)

Comment 4 by gambard@chromium.org, Dec 20 2017

Blocking: 768817

Comment 5 by gambard@chromium.org, Dec 20 2017

Blocking: 796483
Project Member

Comment 6 by bugdroid1@chromium.org, Jan 15 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c5d360fb8895d3653a21c0556de77b61bac7ada1

commit c5d360fb8895d3653a21c0556de77b61bac7ada1
Author: Marti Wong <martiw@chromium.org>
Date: Mon Jan 15 12:47:11 2018

Remove the new iOS bookmarks flag and cleanup old bookmarks code.

- Removed the bookmark new generation feature flag.
- Removed the files which are used by the old bookmarks only:
    bookmark_editing_bar
    bookmark_navigation_bar
    bookmark_top_bar
    bookmark_collection_view
    bookmark_collection_cells
    bookmark_home_primary_view
    bookmark_home_tablet_ntp_controller
    bookmark_menu_cell
    bookmark_menu_item
    bookmark_menu_view
    bookmark_panel_view
    bookmark_position_cache
    bookmark_signin_promo_cell
    bookmarks_egtest
    modal_ntp
- Removed kChromeUIBookmarksURL and kChromeUIBookmarksHost which
  are disabled in the new bookmarks.
- Disable a failing egtest (which failed before this CL).
- Some unittests are modified accordingly.
- Added some TODOs for follow-up CLs.

Bug:  753599 
Change-Id: I6c3c30d7b256194f19d3419ea623752d1f8f0f8e
Reviewed-on: https://chromium-review.googlesource.com/858977
Reviewed-by: Gauthier Ambard <gambard@chromium.org>
Reviewed-by: Sylvain Defresne <sdefresne@chromium.org>
Commit-Queue: Marti Wong <martiw@chromium.org>
Cr-Commit-Position: refs/heads/master@{#529260}
[modify] https://crrev.com/c5d360fb8895d3653a21c0556de77b61bac7ada1/ios/chrome/browser/about_flags.mm
[modify] https://crrev.com/c5d360fb8895d3653a21c0556de77b61bac7ada1/ios/chrome/browser/bookmarks/bookmark_new_generation_features.cc
[modify] https://crrev.com/c5d360fb8895d3653a21c0556de77b61bac7ada1/ios/chrome/browser/bookmarks/bookmark_new_generation_features.h
[modify] https://crrev.com/c5d360fb8895d3653a21c0556de77b61bac7ada1/ios/chrome/browser/chrome_url_constants.cc
[modify] https://crrev.com/c5d360fb8895d3653a21c0556de77b61bac7ada1/ios/chrome/browser/chrome_url_constants.h
[modify] https://crrev.com/c5d360fb8895d3653a21c0556de77b61bac7ada1/ios/chrome/browser/ios_chrome_flag_descriptions.cc
[modify] https://crrev.com/c5d360fb8895d3653a21c0556de77b61bac7ada1/ios/chrome/browser/ios_chrome_flag_descriptions.h
[modify] https://crrev.com/c5d360fb8895d3653a21c0556de77b61bac7ada1/ios/chrome/browser/prefs/BUILD.gn
[modify] https://crrev.com/c5d360fb8895d3653a21c0556de77b61bac7ada1/ios/chrome/browser/tabs/tab_model_closing_web_state_observer.mm
[modify] https://crrev.com/c5d360fb8895d3653a21c0556de77b61bac7ada1/ios/chrome/browser/ui/BUILD.gn
[modify] https://crrev.com/c5d360fb8895d3653a21c0556de77b61bac7ada1/ios/chrome/browser/ui/bookmarks/BUILD.gn
[modify] https://crrev.com/c5d360fb8895d3653a21c0556de77b61bac7ada1/ios/chrome/browser/ui/bookmarks/bars/BUILD.gn
[delete] https://crrev.com/27fa925301116517028cfe2fd332a338508e8437/ios/chrome/browser/ui/bookmarks/bars/bookmark_editing_bar.h
[delete] https://crrev.com/27fa925301116517028cfe2fd332a338508e8437/ios/chrome/browser/ui/bookmarks/bars/bookmark_editing_bar.mm
[delete] https://crrev.com/27fa925301116517028cfe2fd332a338508e8437/ios/chrome/browser/ui/bookmarks/bars/bookmark_navigation_bar.h
[delete] https://crrev.com/27fa925301116517028cfe2fd332a338508e8437/ios/chrome/browser/ui/bookmarks/bars/bookmark_navigation_bar.mm
[delete] https://crrev.com/27fa925301116517028cfe2fd332a338508e8437/ios/chrome/browser/ui/bookmarks/bars/bookmark_top_bar.h
[delete] https://crrev.com/27fa925301116517028cfe2fd332a338508e8437/ios/chrome/browser/ui/bookmarks/bars/bookmark_top_bar.mm
[delete] https://crrev.com/27fa925301116517028cfe2fd332a338508e8437/ios/chrome/browser/ui/bookmarks/bookmark_collection_cells.h
[delete] https://crrev.com/27fa925301116517028cfe2fd332a338508e8437/ios/chrome/browser/ui/bookmarks/bookmark_collection_cells.mm
[delete] https://crrev.com/27fa925301116517028cfe2fd332a338508e8437/ios/chrome/browser/ui/bookmarks/bookmark_collection_view.h
[delete] https://crrev.com/27fa925301116517028cfe2fd332a338508e8437/ios/chrome/browser/ui/bookmarks/bookmark_collection_view.mm
[modify] https://crrev.com/c5d360fb8895d3653a21c0556de77b61bac7ada1/ios/chrome/browser/ui/bookmarks/bookmark_collection_view_background.mm
[modify] https://crrev.com/c5d360fb8895d3653a21c0556de77b61bac7ada1/ios/chrome/browser/ui/bookmarks/bookmark_controller_factory.h
[modify] https://crrev.com/c5d360fb8895d3653a21c0556de77b61bac7ada1/ios/chrome/browser/ui/bookmarks/bookmark_controller_factory.mm
[modify] https://crrev.com/c5d360fb8895d3653a21c0556de77b61bac7ada1/ios/chrome/browser/ui/bookmarks/bookmark_extended_button.h
[modify] https://crrev.com/c5d360fb8895d3653a21c0556de77b61bac7ada1/ios/chrome/browser/ui/bookmarks/bookmark_folder_table_view_cell.mm
[modify] https://crrev.com/c5d360fb8895d3653a21c0556de77b61bac7ada1/ios/chrome/browser/ui/bookmarks/bookmark_home_handset_view_controller.h
[modify] https://crrev.com/c5d360fb8895d3653a21c0556de77b61bac7ada1/ios/chrome/browser/ui/bookmarks/bookmark_home_handset_view_controller.mm
[delete] https://crrev.com/27fa925301116517028cfe2fd332a338508e8437/ios/chrome/browser/ui/bookmarks/bookmark_home_handset_view_controller_unittest.mm
[delete] https://crrev.com/27fa925301116517028cfe2fd332a338508e8437/ios/chrome/browser/ui/bookmarks/bookmark_home_primary_view.h
[delete] https://crrev.com/27fa925301116517028cfe2fd332a338508e8437/ios/chrome/browser/ui/bookmarks/bookmark_home_tablet_ntp_controller.h
[delete] https://crrev.com/27fa925301116517028cfe2fd332a338508e8437/ios/chrome/browser/ui/bookmarks/bookmark_home_tablet_ntp_controller.mm
[modify] https://crrev.com/c5d360fb8895d3653a21c0556de77b61bac7ada1/ios/chrome/browser/ui/bookmarks/bookmark_home_view_controller.h
[modify] https://crrev.com/c5d360fb8895d3653a21c0556de77b61bac7ada1/ios/chrome/browser/ui/bookmarks/bookmark_home_view_controller.mm
[modify] https://crrev.com/c5d360fb8895d3653a21c0556de77b61bac7ada1/ios/chrome/browser/ui/bookmarks/bookmark_home_view_controller_protected.h
[modify] https://crrev.com/c5d360fb8895d3653a21c0556de77b61bac7ada1/ios/chrome/browser/ui/bookmarks/bookmark_home_view_controller_unittest.mm
[modify] https://crrev.com/c5d360fb8895d3653a21c0556de77b61bac7ada1/ios/chrome/browser/ui/bookmarks/bookmark_home_waiting_view.h
[modify] https://crrev.com/c5d360fb8895d3653a21c0556de77b61bac7ada1/ios/chrome/browser/ui/bookmarks/bookmark_interaction_controller.mm
[modify] https://crrev.com/c5d360fb8895d3653a21c0556de77b61bac7ada1/ios/chrome/browser/ui/bookmarks/bookmark_mediator.h
[delete] https://crrev.com/27fa925301116517028cfe2fd332a338508e8437/ios/chrome/browser/ui/bookmarks/bookmark_menu_cell.h
[delete] https://crrev.com/27fa925301116517028cfe2fd332a338508e8437/ios/chrome/browser/ui/bookmarks/bookmark_menu_cell.mm
[delete] https://crrev.com/27fa925301116517028cfe2fd332a338508e8437/ios/chrome/browser/ui/bookmarks/bookmark_menu_item.h
[delete] https://crrev.com/27fa925301116517028cfe2fd332a338508e8437/ios/chrome/browser/ui/bookmarks/bookmark_menu_item.mm
[delete] https://crrev.com/27fa925301116517028cfe2fd332a338508e8437/ios/chrome/browser/ui/bookmarks/bookmark_menu_view.h
[delete] https://crrev.com/27fa925301116517028cfe2fd332a338508e8437/ios/chrome/browser/ui/bookmarks/bookmark_menu_view.mm
[modify] https://crrev.com/c5d360fb8895d3653a21c0556de77b61bac7ada1/ios/chrome/browser/ui/bookmarks/bookmark_navigation_controller.h
[delete] https://crrev.com/27fa925301116517028cfe2fd332a338508e8437/ios/chrome/browser/ui/bookmarks/bookmark_panel_view.h
[delete] https://crrev.com/27fa925301116517028cfe2fd332a338508e8437/ios/chrome/browser/ui/bookmarks/bookmark_panel_view.mm
[delete] https://crrev.com/27fa925301116517028cfe2fd332a338508e8437/ios/chrome/browser/ui/bookmarks/bookmark_position_cache.h
[delete] https://crrev.com/27fa925301116517028cfe2fd332a338508e8437/ios/chrome/browser/ui/bookmarks/bookmark_position_cache.mm
[delete] https://crrev.com/27fa925301116517028cfe2fd332a338508e8437/ios/chrome/browser/ui/bookmarks/bookmark_position_cache_unittest.mm
[delete] https://crrev.com/27fa925301116517028cfe2fd332a338508e8437/ios/chrome/browser/ui/bookmarks/bookmark_signin_promo_cell.h
[delete] https://crrev.com/27fa925301116517028cfe2fd332a338508e8437/ios/chrome/browser/ui/bookmarks/bookmark_signin_promo_cell.mm
[modify] https://crrev.com/c5d360fb8895d3653a21c0556de77b61bac7ada1/ios/chrome/browser/ui/bookmarks/bookmark_utils_ios.h
[modify] https://crrev.com/c5d360fb8895d3653a21c0556de77b61bac7ada1/ios/chrome/browser/ui/bookmarks/bookmark_utils_ios.mm
[modify] https://crrev.com/c5d360fb8895d3653a21c0556de77b61bac7ada1/ios/chrome/browser/ui/bookmarks/bookmark_utils_ios_unittest.mm
[delete] https://crrev.com/27fa925301116517028cfe2fd332a338508e8437/ios/chrome/browser/ui/bookmarks/bookmarks_egtest.mm
[modify] https://crrev.com/c5d360fb8895d3653a21c0556de77b61bac7ada1/ios/chrome/browser/ui/bookmarks/bookmarks_new_generation_egtest.mm
[modify] https://crrev.com/c5d360fb8895d3653a21c0556de77b61bac7ada1/ios/chrome/browser/ui/browser_view_controller.mm
[modify] https://crrev.com/c5d360fb8895d3653a21c0556de77b61bac7ada1/ios/chrome/browser/ui/browser_view_controller_unittest.mm
[modify] https://crrev.com/c5d360fb8895d3653a21c0556de77b61bac7ada1/ios/chrome/browser/ui/content_suggestions/BUILD.gn
[modify] https://crrev.com/c5d360fb8895d3653a21c0556de77b61bac7ada1/ios/chrome/browser/ui/content_suggestions/content_suggestions_egtest.mm
[modify] https://crrev.com/c5d360fb8895d3653a21c0556de77b61bac7ada1/ios/chrome/browser/ui/content_suggestions/ntp_home_egtest.mm
[modify] https://crrev.com/c5d360fb8895d3653a21c0556de77b61bac7ada1/ios/chrome/browser/ui/keyboard_commands_egtest.mm
[modify] https://crrev.com/c5d360fb8895d3653a21c0556de77b61bac7ada1/ios/chrome/browser/ui/ntp/BUILD.gn
[modify] https://crrev.com/c5d360fb8895d3653a21c0556de77b61bac7ada1/ios/chrome/browser/ui/ntp/incognito_view_controller.mm
[delete] https://crrev.com/27fa925301116517028cfe2fd332a338508e8437/ios/chrome/browser/ui/ntp/modal_ntp.h
[delete] https://crrev.com/27fa925301116517028cfe2fd332a338508e8437/ios/chrome/browser/ui/ntp/modal_ntp.mm
[modify] https://crrev.com/c5d360fb8895d3653a21c0556de77b61bac7ada1/ios/chrome/browser/ui/ntp/new_tab_page_bar.h
[modify] https://crrev.com/c5d360fb8895d3653a21c0556de77b61bac7ada1/ios/chrome/browser/ui/ntp/new_tab_page_bar.mm
[modify] https://crrev.com/c5d360fb8895d3653a21c0556de77b61bac7ada1/ios/chrome/browser/ui/ntp/new_tab_page_bar_unittest.mm
[modify] https://crrev.com/c5d360fb8895d3653a21c0556de77b61bac7ada1/ios/chrome/browser/ui/ntp/new_tab_page_controller.h
[modify] https://crrev.com/c5d360fb8895d3653a21c0556de77b61bac7ada1/ios/chrome/browser/ui/ntp/new_tab_page_controller.mm
[modify] https://crrev.com/c5d360fb8895d3653a21c0556de77b61bac7ada1/ios/chrome/browser/ui/ntp/new_tab_page_controller_unittest.mm
[modify] https://crrev.com/c5d360fb8895d3653a21c0556de77b61bac7ada1/ios/chrome/browser/ui/ntp/new_tab_page_egtest.mm
[modify] https://crrev.com/c5d360fb8895d3653a21c0556de77b61bac7ada1/ios/chrome/browser/ui/ntp/new_tab_page_view.mm
[modify] https://crrev.com/c5d360fb8895d3653a21c0556de77b61bac7ada1/ios/chrome/browser/ui/ntp/recent_tabs/BUILD.gn
[modify] https://crrev.com/c5d360fb8895d3653a21c0556de77b61bac7ada1/ios/chrome/browser/ui/ntp/recent_tabs/recent_tabs_table_egtest.mm
[modify] https://crrev.com/c5d360fb8895d3653a21c0556de77b61bac7ada1/ios/chrome/browser/ui/signin_interaction/BUILD.gn
[modify] https://crrev.com/c5d360fb8895d3653a21c0556de77b61bac7ada1/ios/chrome/browser/ui/signin_interaction/signin_interaction_controller_egtest.mm
[modify] https://crrev.com/c5d360fb8895d3653a21c0556de77b61bac7ada1/ios/chrome/browser/ui/toolbar/BUILD.gn
[modify] https://crrev.com/c5d360fb8895d3653a21c0556de77b61bac7ada1/ios/chrome/browser/ui/toolbar/toolbar_egtest.mm
[modify] https://crrev.com/c5d360fb8895d3653a21c0556de77b61bac7ada1/ios/chrome/browser/ui/toolbar/toolbar_model_delegate_ios.mm
[modify] https://crrev.com/c5d360fb8895d3653a21c0556de77b61bac7ada1/ios/chrome/browser/ui/webui/BUILD.gn
[modify] https://crrev.com/c5d360fb8895d3653a21c0556de77b61bac7ada1/ios/chrome/browser/ui/webui/about_ui.cc
[modify] https://crrev.com/c5d360fb8895d3653a21c0556de77b61bac7ada1/ios/chrome/browser/ui/webui/web_ui_egtest.mm
Project Member

Comment 7 by bugdroid1@chromium.org, Jan 18 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/90e3fedcee875e8f40ea3d207f5256da3d123b2b

commit 90e3fedcee875e8f40ea3d207f5256da3d123b2b
Author: Marti Wong <martiw@chromium.org>
Date: Thu Jan 18 01:08:55 2018

Cleanup old iOS bookmarks code, remove unnecessary subclasses.

- Merge the following to bookmark_home_view_controller:
  1. bookmark_home_handset_view_controller
  2. bookmark_home_view_controller_protected
- Remove bookmark_controller_factory.
- Remove bookmark_extended_button which is no longer used.
- Rename bookmark_collection_view_background to
  bookmark_empty_background.
- Rename bookmarks_new_generation_egtest to bookmarks_egtest.

Bug:  753599 
Change-Id: I85522d0882c32cb5f252d15abdc53c0bf918656f
Reviewed-on: https://chromium-review.googlesource.com/867827
Commit-Queue: Marti Wong <martiw@chromium.org>
Reviewed-by: Sylvain Defresne <sdefresne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#529991}
[modify] https://crrev.com/90e3fedcee875e8f40ea3d207f5256da3d123b2b/ios/chrome/browser/ui/bookmarks/BUILD.gn
[delete] https://crrev.com/dd3ee9b39e5918f048f5879cdd419013db8437b2/ios/chrome/browser/ui/bookmarks/bookmark_collection_view_background.h
[delete] https://crrev.com/dd3ee9b39e5918f048f5879cdd419013db8437b2/ios/chrome/browser/ui/bookmarks/bookmark_controller_factory.h
[delete] https://crrev.com/dd3ee9b39e5918f048f5879cdd419013db8437b2/ios/chrome/browser/ui/bookmarks/bookmark_controller_factory.mm
[modify] https://crrev.com/90e3fedcee875e8f40ea3d207f5256da3d123b2b/ios/chrome/browser/ui/bookmarks/bookmark_edit_view_controller.mm
[add] https://crrev.com/90e3fedcee875e8f40ea3d207f5256da3d123b2b/ios/chrome/browser/ui/bookmarks/bookmark_empty_background.h
[rename] https://crrev.com/90e3fedcee875e8f40ea3d207f5256da3d123b2b/ios/chrome/browser/ui/bookmarks/bookmark_empty_background.mm
[delete] https://crrev.com/dd3ee9b39e5918f048f5879cdd419013db8437b2/ios/chrome/browser/ui/bookmarks/bookmark_extended_button.h
[delete] https://crrev.com/dd3ee9b39e5918f048f5879cdd419013db8437b2/ios/chrome/browser/ui/bookmarks/bookmark_extended_button.mm
[modify] https://crrev.com/90e3fedcee875e8f40ea3d207f5256da3d123b2b/ios/chrome/browser/ui/bookmarks/bookmark_folder_table_view_cell.mm
[delete] https://crrev.com/dd3ee9b39e5918f048f5879cdd419013db8437b2/ios/chrome/browser/ui/bookmarks/bookmark_home_handset_view_controller.h
[delete] https://crrev.com/dd3ee9b39e5918f048f5879cdd419013db8437b2/ios/chrome/browser/ui/bookmarks/bookmark_home_handset_view_controller.mm
[modify] https://crrev.com/90e3fedcee875e8f40ea3d207f5256da3d123b2b/ios/chrome/browser/ui/bookmarks/bookmark_home_view_controller.h
[modify] https://crrev.com/90e3fedcee875e8f40ea3d207f5256da3d123b2b/ios/chrome/browser/ui/bookmarks/bookmark_home_view_controller.mm
[delete] https://crrev.com/dd3ee9b39e5918f048f5879cdd419013db8437b2/ios/chrome/browser/ui/bookmarks/bookmark_home_view_controller_protected.h
[modify] https://crrev.com/90e3fedcee875e8f40ea3d207f5256da3d123b2b/ios/chrome/browser/ui/bookmarks/bookmark_home_view_controller_unittest.mm
[modify] https://crrev.com/90e3fedcee875e8f40ea3d207f5256da3d123b2b/ios/chrome/browser/ui/bookmarks/bookmark_interaction_controller.mm
[modify] https://crrev.com/90e3fedcee875e8f40ea3d207f5256da3d123b2b/ios/chrome/browser/ui/bookmarks/bookmark_table_view.mm
[rename] https://crrev.com/90e3fedcee875e8f40ea3d207f5256da3d123b2b/ios/chrome/browser/ui/bookmarks/bookmarks_egtest.mm

Comment 8 by martiw@chromium.org, Jan 18 2018

Status: Fixed (was: Started)

Comment 9 by martiw@chromium.org, Jan 22 2018

Cc: noyau@chromium.org
Status: Assigned (was: Fixed)
Reopen this bug because bookmark_folder_view_controller needs to be removed too.

Comment 10 by martiw@chromium.org, Jan 22 2018

Status: Fixed (was: Assigned)
Actually we could keep bookmark_folder_view_controller.
bookmark_folder_view_controller is for bookmark_folder_editor_view and nothing to do with the deleted property folderView.
Marked as fixed again.
►

Sign in to add a comment