New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 753598 link

Starred by 1 user
Status: Fixed
Owner:
█ nxia@chromium.org
Last visit > 30 days ago
Closed: Aug 2017
Cc:
dgarr...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

CQCompletion failed due to KeyError

Project Member Reported by akes...@chromium.org, Aug 8 2017 
https://luci-milo.appspot.com/buildbot/chromeos/master-paladin/15661

not sure if related to sentry-paladin being broken at the time. Regardless, this KeyError is probably not the right behavior.

@@@STEP_FAILURE@@@
08:53:49: ERROR: Traceback (most recent call last):
  File "/b/c/cbuild/repository/chromite/cbuildbot/stages/generic_stages.py", line 693, in Run
    self.PerformStage()
  File "/b/c/cbuild/repository/chromite/cbuildbot/stages/completion_stages.py", line 919, in PerformStage
    super(CommitQueueCompletionStage, self).PerformStage()
  File "/b/c/cbuild/repository/chromite/cbuildbot/stages/completion_stages.py", line 246, in PerformStage
    statuses = self._FetchSlaveStatuses()
  File "/b/c/cbuild/repository/chromite/cbuildbot/stages/completion_stages.py", line 169, in _FetchSlaveStatuses
    manager, build_id, db, builder_names, timeout))
  File "/b/c/cbuild/repository/chromite/cbuildbot/stages/completion_stages.py", line 915, in _GetSlaveBuildStatus
    timeout=timeout)
  File "/b/c/cbuild/repository/chromite/cbuildbot/manifest_version.py", line 639, in GetBuildersStatus
    return self._GetSlaveBuilderStatus(master_build_id, db, builders_array)
  File "/b/c/cbuild/repository/chromite/cbuildbot/manifest_version.py", line 660, in _GetSlaveBuilderStatus
    builder_status = slave_builder_statuses.GetBuilderStatusForBuild(builder)
  File "/b/c/cbuild/repository/chromite/lib/builder_status_lib.py", line 357, in GetBuilderStatusForBuild
    build_config, self.cidb_info_dict, self.buildbucket_info_dict)
  File "/b/c/cbuild/repository/chromite/lib/builder_status_lib.py", line 321, in _GetDashboardUrl
    return buildbucket_info_dict[build_config].url
KeyError: u'sentry-paladin'

Comment 1 by nxia@chromium.org, Aug 9 2017 

Tue, 08 Aug 08:27	Tree is open (EXPERIMENTAL=guado_moblab-paladin,sentry-paladin  crbug.com/751895   crbug.com/753221  )

should be related to the tree_status. somehow the build was not fetched.

Comment 2 by nxia@chromium.org, Aug 9 2017 

07:29:28 completion stage started

08:27 tree status was changed, sentry-paladin was added to experimental list.

08:53:49 key error

sent out a fix at https://chromium-review.googlesource.com/c/607577
Project Member

Comment 3 by bugdroid1@chromium.org, Aug 9 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/chromite/+/1d6c62c0bf217a9bf693b0c7023aea0744ba4b13

commit 1d6c62c0bf217a9bf693b0c7023aea0744ba4b13
Author: Ningning Xia <nxia@chromium.org>
Date: Wed Aug 09 18:48:08 2017

manifest_version: Refetch builders_array after the completion loop.

Important build config list may be changed in the metadata while the
master waiting for the slaves to complete. Refetch the builders_array
before creating BuildersStatus for slave builds.

BUG= chromium:753598 
TEST=unit_tests

Change-Id: Icadce204aa4454c025af827ec1519ba0d8352228
Reviewed-on: https://chromium-review.googlesource.com/607577
Commit-Ready: Ningning Xia <nxia@chromium.org>
Tested-by: Ningning Xia <nxia@chromium.org>
Reviewed-by: Don Garrett <dgarrett@chromium.org>

[modify] https://crrev.com/1d6c62c0bf217a9bf693b0c7023aea0744ba4b13/cbuildbot/manifest_version.py

Comment 4 by nxia@chromium.org, Aug 9 2017

Status: Fixed (was: Assigned)
►

Sign in to add a comment