We're seeking to make actions in OfflinePageModelImpl, it has several tasks (and maybe more): Save Page Task Get Pages Task Delete Pages Task Consistency Check Task Update Pages Task Clear Storage Task Initialize Store Task.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ec3e7a8a5f6974f7ee3081583b215b4eee994d69 commit ec3e7a8a5f6974f7ee3081583b215b4eee994d69 Author: Yafei Duan <romax@chromium.org> Date: Mon Sep 11 23:04:39 2017 [Offline Pages] Implementing add page task. Implementing AddPageTask which will insert a page into metedata store, then invoke the callback with an AddPageResult. This is part of the OfflinePageModel taskification. Also OfflineStoreUtils is introduced, containing the utility methods used in tasks. The unit test will be in another patch, in order to adopt the testing framework which will be landed with GetPageTask. Bug: 753595 Change-Id: I4ef848c24d40217e0e071a72aae49c3fdd9a3f70 Reviewed-on: https://chromium-review.googlesource.com/636725 Commit-Queue: Yafei Duan <romax@chromium.org> Reviewed-by: Filip Gorski <fgorski@chromium.org> Cr-Commit-Position: refs/heads/master@{#501078} [modify] https://crrev.com/ec3e7a8a5f6974f7ee3081583b215b4eee994d69/components/offline_pages/core/BUILD.gn [add] https://crrev.com/ec3e7a8a5f6974f7ee3081583b215b4eee994d69/components/offline_pages/core/model/add_page_task.cc [add] https://crrev.com/ec3e7a8a5f6974f7ee3081583b215b4eee994d69/components/offline_pages/core/model/add_page_task.h [add] https://crrev.com/ec3e7a8a5f6974f7ee3081583b215b4eee994d69/components/offline_pages/core/model/offline_store_utils.cc [add] https://crrev.com/ec3e7a8a5f6974f7ee3081583b215b4eee994d69/components/offline_pages/core/model/offline_store_utils.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b64cacea1de67539cadc74f731d216a409101890 commit b64cacea1de67539cadc74f731d216a409101890 Author: Yafei Duan <romax@chromium.org> Date: Wed Sep 13 00:13:28 2017 [Offline Pages] Implementing create archive task. Implementing CreateArchiveTask, which is a task for starting the archive creation but will not wait for the completion of the process, in order to support multiple archivers working in parallel. The creator of the task has to provide a CreateArchiveTaskCallback, which will be processing the arguments and decide whether the creation is successful, so that it can create AddPageTask for next steps. Also duplicating most of the tests related with archive creation from the OfflinePageModelImpl unit tests. Bug: 753595 Change-Id: I915daab56a260ccaa9c028c0ea95c2ff0646d461 Reviewed-on: https://chromium-review.googlesource.com/634084 Commit-Queue: Yafei Duan <romax@chromium.org> Reviewed-by: Filip Gorski <fgorski@chromium.org> Cr-Commit-Position: refs/heads/master@{#501468} [modify] https://crrev.com/b64cacea1de67539cadc74f731d216a409101890/components/offline_pages/core/BUILD.gn [add] https://crrev.com/b64cacea1de67539cadc74f731d216a409101890/components/offline_pages/core/model/create_archive_task.cc [add] https://crrev.com/b64cacea1de67539cadc74f731d216a409101890/components/offline_pages/core/model/create_archive_task.h [add] https://crrev.com/b64cacea1de67539cadc74f731d216a409101890/components/offline_pages/core/model/create_archive_task_unittest.cc [modify] https://crrev.com/b64cacea1de67539cadc74f731d216a409101890/components/offline_pages/core/model/offline_store_utils.cc [modify] https://crrev.com/b64cacea1de67539cadc74f731d216a409101890/components/offline_pages/core/model/offline_store_utils.h [modify] https://crrev.com/b64cacea1de67539cadc74f731d216a409101890/components/offline_pages/core/offline_page_archiver.h [modify] https://crrev.com/b64cacea1de67539cadc74f731d216a409101890/components/offline_pages/core/offline_page_item.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b571009f4b0ef6048fd925940f0d10f54b4f2bd4 commit b571009f4b0ef6048fd925940f0d10f54b4f2bd4 Author: Filip Gorski <fgorski@chromium.org> Date: Fri Sep 15 23:50:02 2017 [Offline pages] GetPagesTask with testing infra Provides a GetPagesTask with the following capabilities: * Getting all pages * Getting pages by client IDs * Getting pages by URL (matching both original and final without fragments) * Getting pages by request origin * Getting a single page by Offline ID * All off above come with tests and factory methods properly initializing the task. In addition to that this patch adds basic test infrastructure simplifying testing offline page model related tasks: * Offline page item generator * Offline page metadata store test util * Test task runner (allowing for task execution to completion) Bug: 753595 Change-Id: I825cf2b8cd8874fb39218019f5e33c576e2e9225 Reviewed-on: https://chromium-review.googlesource.com/658202 Reviewed-by: Justin DeWitt <dewittj@chromium.org> Reviewed-by: Yafei Duan <romax@chromium.org> Commit-Queue: Filip Gorski <fgorski@chromium.org> Cr-Commit-Position: refs/heads/master@{#502444} [modify] https://crrev.com/b571009f4b0ef6048fd925940f0d10f54b4f2bd4/components/offline_pages/core/BUILD.gn [add] https://crrev.com/b571009f4b0ef6048fd925940f0d10f54b4f2bd4/components/offline_pages/core/model/get_pages_task.cc [add] https://crrev.com/b571009f4b0ef6048fd925940f0d10f54b4f2bd4/components/offline_pages/core/model/get_pages_task.h [add] https://crrev.com/b571009f4b0ef6048fd925940f0d10f54b4f2bd4/components/offline_pages/core/model/get_pages_task_unittest.cc [add] https://crrev.com/b571009f4b0ef6048fd925940f0d10f54b4f2bd4/components/offline_pages/core/model/offline_page_item_generator.cc [add] https://crrev.com/b571009f4b0ef6048fd925940f0d10f54b4f2bd4/components/offline_pages/core/model/offline_page_item_generator.h [modify] https://crrev.com/b571009f4b0ef6048fd925940f0d10f54b4f2bd4/components/offline_pages/core/model/offline_store_utils.cc [modify] https://crrev.com/b571009f4b0ef6048fd925940f0d10f54b4f2bd4/components/offline_pages/core/offline_page_item.cc [modify] https://crrev.com/b571009f4b0ef6048fd925940f0d10f54b4f2bd4/components/offline_pages/core/offline_page_item.h [modify] https://crrev.com/b571009f4b0ef6048fd925940f0d10f54b4f2bd4/components/offline_pages/core/offline_page_metadata_store_sql.cc [modify] https://crrev.com/b571009f4b0ef6048fd925940f0d10f54b4f2bd4/components/offline_pages/core/offline_page_metadata_store_sql.h [add] https://crrev.com/b571009f4b0ef6048fd925940f0d10f54b4f2bd4/components/offline_pages/core/offline_page_metadata_store_test_util.cc [add] https://crrev.com/b571009f4b0ef6048fd925940f0d10f54b4f2bd4/components/offline_pages/core/offline_page_metadata_store_test_util.h [add] https://crrev.com/b571009f4b0ef6048fd925940f0d10f54b4f2bd4/components/offline_pages/core/test_task_runner.cc [add] https://crrev.com/b571009f4b0ef6048fd925940f0d10f54b4f2bd4/components/offline_pages/core/test_task_runner.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/7cd6c29f01923913d17adcc84ee7ff92cd374142 commit 7cd6c29f01923913d17adcc84ee7ff92cd374142 Author: Yafei Duan <romax@chromium.org> Date: Mon Sep 18 23:36:56 2017 [Offline Pages] Implementing DeletePageTask. Implemented the DeletePageTask which is responsible to delete offline pages along with their metadata entries in the database. This is part of the taskifying Offline Page Model effort and it depends on the AddPageTask for testing. Bug: 753595 Change-Id: I344f1da54f2c67dc72078351b8590766ae98476a Reviewed-on: https://chromium-review.googlesource.com/651390 Commit-Queue: Yafei Duan <romax@chromium.org> Reviewed-by: Filip Gorski <fgorski@chromium.org> Cr-Commit-Position: refs/heads/master@{#502713} [modify] https://crrev.com/7cd6c29f01923913d17adcc84ee7ff92cd374142/components/offline_pages/core/BUILD.gn [modify] https://crrev.com/7cd6c29f01923913d17adcc84ee7ff92cd374142/components/offline_pages/core/model/add_page_task.cc [add] https://crrev.com/7cd6c29f01923913d17adcc84ee7ff92cd374142/components/offline_pages/core/model/delete_page_task.cc [add] https://crrev.com/7cd6c29f01923913d17adcc84ee7ff92cd374142/components/offline_pages/core/model/delete_page_task.h [add] https://crrev.com/7cd6c29f01923913d17adcc84ee7ff92cd374142/components/offline_pages/core/model/delete_page_task_unittest.cc [modify] https://crrev.com/7cd6c29f01923913d17adcc84ee7ff92cd374142/components/offline_pages/core/model/offline_store_utils.cc [modify] https://crrev.com/7cd6c29f01923913d17adcc84ee7ff92cd374142/components/offline_pages/core/model/offline_store_utils.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/fea9e53538f62fa6a5b080e42098051eb72c3f71 commit fea9e53538f62fa6a5b080e42098051eb72c3f71 Author: Filip Gorski <fgorski@chromium.org> Date: Fri Sep 22 06:07:44 2017 [Offline pages] Removing GetPagesMatchingQuery for OPM interface * Removing all calls to GetPagesMatchingQuery and replacing them with more specific methods: * GetPagesByNamespace * GetPagesRemovedOnCacheReset * GetPagesSupportedByDownloads Bug: 753595 Change-Id: Ic400b0e9c58d008a376da1ece6d5134752539e06 Reviewed-on: https://chromium-review.googlesource.com/671928 Commit-Queue: Filip Gorski <fgorski@chromium.org> Reviewed-by: Justin DeWitt <dewittj@chromium.org> Reviewed-by: Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#503668} [modify] https://crrev.com/fea9e53538f62fa6a5b080e42098051eb72c3f71/chrome/browser/ntp_snippets/download_suggestions_provider.cc [modify] https://crrev.com/fea9e53538f62fa6a5b080e42098051eb72c3f71/chrome/browser/offline_pages/android/offline_page_bridge.cc [modify] https://crrev.com/fea9e53538f62fa6a5b080e42098051eb72c3f71/chrome/browser/offline_pages/offline_page_utils.cc [modify] https://crrev.com/fea9e53538f62fa6a5b080e42098051eb72c3f71/components/ntp_snippets/offline_pages/offline_pages_test_utils.cc [modify] https://crrev.com/fea9e53538f62fa6a5b080e42098051eb72c3f71/components/ntp_snippets/offline_pages/offline_pages_test_utils.h [modify] https://crrev.com/fea9e53538f62fa6a5b080e42098051eb72c3f71/components/ntp_snippets/remote/prefetched_pages_tracker_impl.cc [modify] https://crrev.com/fea9e53538f62fa6a5b080e42098051eb72c3f71/components/ntp_snippets/remote/prefetched_pages_tracker_impl_unittest.cc [modify] https://crrev.com/fea9e53538f62fa6a5b080e42098051eb72c3f71/components/offline_pages/core/offline_page_model.h [modify] https://crrev.com/fea9e53538f62fa6a5b080e42098051eb72c3f71/components/offline_pages/core/offline_page_model_impl.cc [modify] https://crrev.com/fea9e53538f62fa6a5b080e42098051eb72c3f71/components/offline_pages/core/offline_page_model_impl.h [modify] https://crrev.com/fea9e53538f62fa6a5b080e42098051eb72c3f71/components/offline_pages/core/offline_page_model_impl_unittest.cc [modify] https://crrev.com/fea9e53538f62fa6a5b080e42098051eb72c3f71/components/offline_pages/core/stub_offline_page_model.cc [modify] https://crrev.com/fea9e53538f62fa6a5b080e42098051eb72c3f71/components/offline_pages/core/stub_offline_page_model.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/48db2f3cd02f9b45d19df495f60afe2b4a9788f3 commit 48db2f3cd02f9b45d19df495f60afe2b4a9788f3 Author: Filip Gorski <fgorski@chromium.org> Date: Fri Sep 22 18:51:31 2017 [Offline pages] Rename OfflinePageBridge#getPagesForNamespace (step 1) Renames the method on the C++ side, and then adds a method with correct name on Java side. Bug: 753595 Change-Id: I1b65f04f94eeca41656f8ae92892d78431b03545 Reviewed-on: https://chromium-review.googlesource.com/678451 Commit-Queue: Filip Gorski <fgorski@chromium.org> Reviewed-by: Justin DeWitt <dewittj@chromium.org> Cr-Commit-Position: refs/heads/master@{#503808} [modify] https://crrev.com/48db2f3cd02f9b45d19df495f60afe2b4a9788f3/chrome/android/java/src/org/chromium/chrome/browser/offlinepages/OfflinePageBridge.java [modify] https://crrev.com/48db2f3cd02f9b45d19df495f60afe2b4a9788f3/chrome/browser/offline_pages/android/offline_page_bridge.cc [modify] https://crrev.com/48db2f3cd02f9b45d19df495f60afe2b4a9788f3/chrome/browser/offline_pages/android/offline_page_bridge.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/0da94d96c133a17aefee61ae35c826a69d1f1ddc commit 0da94d96c133a17aefee61ae35c826a69d1f1ddc Author: Filip Gorski <fgorski@chromium.org> Date: Fri Sep 22 23:31:10 2017 [Offline pages] Implement additional get pages functionality To GetPagesTask: * Adds capability to get pages by namespace * Adds capability to get pages supported by downloads * Adds capability to get pages removed on cache reset To ClientPolicyController: * Adds capability to list namespaces removed on cache reset Provides tests for all added functionality. Bug: 753595 Change-Id: I4c7e1cc8c99468884321c9d8643356854cbf67c1 Reviewed-on: https://chromium-review.googlesource.com/677744 Commit-Queue: Filip Gorski <fgorski@chromium.org> Reviewed-by: Yafei Duan <romax@chromium.org> Reviewed-by: Justin DeWitt <dewittj@chromium.org> Cr-Commit-Position: refs/heads/master@{#503902} [modify] https://crrev.com/0da94d96c133a17aefee61ae35c826a69d1f1ddc/components/offline_pages/core/client_policy_controller.cc [modify] https://crrev.com/0da94d96c133a17aefee61ae35c826a69d1f1ddc/components/offline_pages/core/client_policy_controller.h [modify] https://crrev.com/0da94d96c133a17aefee61ae35c826a69d1f1ddc/components/offline_pages/core/client_policy_controller_unittest.cc [modify] https://crrev.com/0da94d96c133a17aefee61ae35c826a69d1f1ddc/components/offline_pages/core/model/get_pages_task.cc [modify] https://crrev.com/0da94d96c133a17aefee61ae35c826a69d1f1ddc/components/offline_pages/core/model/get_pages_task.h [modify] https://crrev.com/0da94d96c133a17aefee61ae35c826a69d1f1ddc/components/offline_pages/core/model/get_pages_task_unittest.cc
The following revision refers to this bug: https://chrome-internal.googlesource.com/clank/internal/apps/+/6eaa3f47f773d53fb76fd3742f789114db167ad9 commit 6eaa3f47f773d53fb76fd3742f789114db167ad9 Author: Filip Gorski <fgorski@google.com> Date: Mon Sep 25 22:44:24 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/bfcf3bb0e4ce938feac3fb2951488b8355c37e0f commit bfcf3bb0e4ce938feac3fb2951488b8355c37e0f Author: Yafei Duan <romax@chromium.org> Date: Tue Sep 26 00:41:18 2017 [Offline Pages] Implement ClearStorageTask. Implemented ClearStorageTask, which is responsible for clearing expired temporary pages from metadata store, and their associated archive files. This is replacing the functionality of the OfflinePageStorageManager. Bug: 753595 Change-Id: I037923a1293950998446e9992e247155063d0b5a Reviewed-on: https://chromium-review.googlesource.com/674057 Commit-Queue: Yafei Duan <romax@chromium.org> Reviewed-by: Filip Gorski <fgorski@chromium.org> Cr-Commit-Position: refs/heads/master@{#504237} [modify] https://crrev.com/bfcf3bb0e4ce938feac3fb2951488b8355c37e0f/components/offline_pages/core/BUILD.gn [add] https://crrev.com/bfcf3bb0e4ce938feac3fb2951488b8355c37e0f/components/offline_pages/core/model/clear_storage_task.cc [add] https://crrev.com/bfcf3bb0e4ce938feac3fb2951488b8355c37e0f/components/offline_pages/core/model/clear_storage_task.h [add] https://crrev.com/bfcf3bb0e4ce938feac3fb2951488b8355c37e0f/components/offline_pages/core/model/clear_storage_task_unittest.cc [modify] https://crrev.com/bfcf3bb0e4ce938feac3fb2951488b8355c37e0f/components/offline_pages/core/model/delete_page_task.cc [modify] https://crrev.com/bfcf3bb0e4ce938feac3fb2951488b8355c37e0f/components/offline_pages/core/model/offline_page_item_generator.cc [modify] https://crrev.com/bfcf3bb0e4ce938feac3fb2951488b8355c37e0f/components/offline_pages/core/model/offline_page_item_generator.h [modify] https://crrev.com/bfcf3bb0e4ce938feac3fb2951488b8355c37e0f/components/offline_pages/core/model/offline_store_utils.h [modify] https://crrev.com/bfcf3bb0e4ce938feac3fb2951488b8355c37e0f/components/offline_pages/core/offline_page_metadata_store_test_util.cc [modify] https://crrev.com/bfcf3bb0e4ce938feac3fb2951488b8355c37e0f/components/offline_pages/core/offline_page_metadata_store_test_util.h [modify] https://crrev.com/bfcf3bb0e4ce938feac3fb2951488b8355c37e0f/components/offline_pages/core/offline_page_storage_manager_unittest.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/fdae685f45172338d672a874a0eb9352d2321422 commit fdae685f45172338d672a874a0eb9352d2321422 Author: Yafei Duan <romax@chromium.org> Date: Tue Sep 26 03:50:10 2017 [Offline Pages] Implementing MarkPageAccessedTask. Implementing the MarkPageAccessedTask which is responsible for updating the database entry when a page is loaded. Also added a utility method to get all pages for testing. Bug: 753595 Change-Id: I0f0ba0f150928b7e245eb357893067c6863d420f Reviewed-on: https://chromium-review.googlesource.com/677026 Commit-Queue: Yafei Duan <romax@chromium.org> Reviewed-by: Filip Gorski <fgorski@chromium.org> Cr-Commit-Position: refs/heads/master@{#504278} [modify] https://crrev.com/fdae685f45172338d672a874a0eb9352d2321422/components/offline_pages/core/BUILD.gn [add] https://crrev.com/fdae685f45172338d672a874a0eb9352d2321422/components/offline_pages/core/model/mark_page_accessed_task.cc [add] https://crrev.com/fdae685f45172338d672a874a0eb9352d2321422/components/offline_pages/core/model/mark_page_accessed_task.h [add] https://crrev.com/fdae685f45172338d672a874a0eb9352d2321422/components/offline_pages/core/model/mark_page_accessed_task_unittest.cc [modify] https://crrev.com/fdae685f45172338d672a874a0eb9352d2321422/components/offline_pages/core/offline_page_metadata_store_test_util.cc [modify] https://crrev.com/fdae685f45172338d672a874a0eb9352d2321422/components/offline_pages/core/offline_page_metadata_store_test_util.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/37ec185932ca2c92553e96338d9fc8892ccb92ea commit 37ec185932ca2c92553e96338d9fc8892ccb92ea Author: Filip Gorski <fgorski@chromium.org> Date: Wed Sep 27 19:50:59 2017 [Offline pages] Renaming GetPagesForNamespace to ...ByNamespace (step 3) This patch removes a duplicate method and renames its uses. Bug: 753595 Change-Id: I8c101b726418f457e4d0feadfb6f042c6558e02f Reviewed-on: https://chromium-review.googlesource.com/687822 Reviewed-by: Justin DeWitt <dewittj@chromium.org> Commit-Queue: Filip Gorski <fgorski@chromium.org> Cr-Commit-Position: refs/heads/master@{#504756} [modify] https://crrev.com/37ec185932ca2c92553e96338d9fc8892ccb92ea/chrome/android/java/src/org/chromium/chrome/browser/offlinepages/OfflinePageBridge.java [modify] https://crrev.com/37ec185932ca2c92553e96338d9fc8892ccb92ea/chrome/android/javatests/src/org/chromium/chrome/browser/offlinepages/OfflinePageBridgeTest.java
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e963492af903b8f75faf42ded46d802d4a15b082 commit e963492af903b8f75faf42ded46d802d4a15b082 Author: Yafei Duan <romax@chromium.org> Date: Tue Oct 03 19:41:13 2017 [Offline Pages] Adding tests for AddPageTask, and related refactoring. Added missing unit tests for AddPageTask, and also refactored unit tests for DeletePageTask to use OfflinePageMetadataStoreTestUtil. Refactored the ability to create associated files with page entries in OfflinePageItemGenerator. Refactored the StoreTestUtil to use AddPageTask to add pages. Bug: 753595 Change-Id: Ic5f2a93d6072b072ec8ac79a2c16ee5f20545219 Reviewed-on: https://chromium-review.googlesource.com/691051 Commit-Queue: Yafei Duan <romax@chromium.org> Reviewed-by: Filip Gorski <fgorski@chromium.org> Cr-Commit-Position: refs/heads/master@{#506143} [modify] https://crrev.com/e963492af903b8f75faf42ded46d802d4a15b082/components/offline_pages/core/BUILD.gn [modify] https://crrev.com/e963492af903b8f75faf42ded46d802d4a15b082/components/offline_pages/core/model/add_page_task.cc [modify] https://crrev.com/e963492af903b8f75faf42ded46d802d4a15b082/components/offline_pages/core/model/add_page_task.h [add] https://crrev.com/e963492af903b8f75faf42ded46d802d4a15b082/components/offline_pages/core/model/add_page_task_unittest.cc [modify] https://crrev.com/e963492af903b8f75faf42ded46d802d4a15b082/components/offline_pages/core/model/clear_storage_task_unittest.cc [modify] https://crrev.com/e963492af903b8f75faf42ded46d802d4a15b082/components/offline_pages/core/model/delete_page_task_unittest.cc [modify] https://crrev.com/e963492af903b8f75faf42ded46d802d4a15b082/components/offline_pages/core/model/mark_page_accessed_task_unittest.cc [modify] https://crrev.com/e963492af903b8f75faf42ded46d802d4a15b082/components/offline_pages/core/model/offline_page_item_generator.cc [modify] https://crrev.com/e963492af903b8f75faf42ded46d802d4a15b082/components/offline_pages/core/model/offline_page_item_generator.h [modify] https://crrev.com/e963492af903b8f75faf42ded46d802d4a15b082/components/offline_pages/core/offline_page_metadata_store_test_util.cc [modify] https://crrev.com/e963492af903b8f75faf42ded46d802d4a15b082/components/offline_pages/core/offline_page_metadata_store_test_util.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/fd71dbbe1a1531f9b21859b6c29a2babf62136c4 commit fd71dbbe1a1531f9b21859b6c29a2babf62136c4 Author: Yafei Duan <romax@chromium.org> Date: Thu Oct 05 02:16:27 2017 [Offline Pages] Implementing ClearDigestTask. Implemented ClearDigestTask which is responsible for cleaning the digest field of an offline page in the metadata store. Also had minor fix for MarkPageAccessedTask and AddPageTask. Bug: 753595 Change-Id: I74757781d50d93faa14590892dd7eecdec8ec7b5 Reviewed-on: https://chromium-review.googlesource.com/699157 Commit-Queue: Yafei Duan <romax@chromium.org> Reviewed-by: Filip Gorski <fgorski@chromium.org> Cr-Commit-Position: refs/heads/master@{#506625} [modify] https://crrev.com/fd71dbbe1a1531f9b21859b6c29a2babf62136c4/components/offline_pages/core/BUILD.gn [modify] https://crrev.com/fd71dbbe1a1531f9b21859b6c29a2babf62136c4/components/offline_pages/core/model/add_page_task.h [add] https://crrev.com/fd71dbbe1a1531f9b21859b6c29a2babf62136c4/components/offline_pages/core/model/clear_digest_task.cc [add] https://crrev.com/fd71dbbe1a1531f9b21859b6c29a2babf62136c4/components/offline_pages/core/model/clear_digest_task.h [add] https://crrev.com/fd71dbbe1a1531f9b21859b6c29a2babf62136c4/components/offline_pages/core/model/clear_digest_task_unittest.cc [modify] https://crrev.com/fd71dbbe1a1531f9b21859b6c29a2babf62136c4/components/offline_pages/core/model/mark_page_accessed_task.cc [modify] https://crrev.com/fd71dbbe1a1531f9b21859b6c29a2babf62136c4/components/offline_pages/core/model/mark_page_accessed_task.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d456c60a82d4ed9535e1aa201b8cefe468a7832e commit d456c60a82d4ed9535e1aa201b8cefe468a7832e Author: Yafei Duan <romax@chromium.org> Date: Mon Oct 09 23:22:27 2017 [Offline Pages] Implementing TemporaryPagesConsistencyCheckTask. Implementing TemporaryPagesConsistencyCheckTask, which is responsible for metadata consistency check of temporary Offline Pages. The task will clean temporary pages which are saved in abandoned directory or missing archive files, as well as the files in temporary archive directory but has no associated DB entries. This is part of the taskifying OfflinePageModel effort. Also Added new unit tests. Bug: 753595 Change-Id: I12d45e55813ef40a20209859047367b042525dea Reviewed-on: https://chromium-review.googlesource.com/691094 Commit-Queue: Yafei Duan <romax@chromium.org> Reviewed-by: Filip Gorski <fgorski@chromium.org> Cr-Commit-Position: refs/heads/master@{#507530} [modify] https://crrev.com/d456c60a82d4ed9535e1aa201b8cefe468a7832e/components/offline_pages/core/BUILD.gn [modify] https://crrev.com/d456c60a82d4ed9535e1aa201b8cefe468a7832e/components/offline_pages/core/model/clear_storage_task.h [modify] https://crrev.com/d456c60a82d4ed9535e1aa201b8cefe468a7832e/components/offline_pages/core/model/mark_page_accessed_task.cc [modify] https://crrev.com/d456c60a82d4ed9535e1aa201b8cefe468a7832e/components/offline_pages/core/model/mark_page_accessed_task.h [modify] https://crrev.com/d456c60a82d4ed9535e1aa201b8cefe468a7832e/components/offline_pages/core/model/mark_page_accessed_task_unittest.cc [modify] https://crrev.com/d456c60a82d4ed9535e1aa201b8cefe468a7832e/components/offline_pages/core/model/offline_page_item_generator.cc [add] https://crrev.com/d456c60a82d4ed9535e1aa201b8cefe468a7832e/components/offline_pages/core/model/temporary_pages_consistency_check_task.cc [add] https://crrev.com/d456c60a82d4ed9535e1aa201b8cefe468a7832e/components/offline_pages/core/model/temporary_pages_consistency_check_task.h [add] https://crrev.com/d456c60a82d4ed9535e1aa201b8cefe468a7832e/components/offline_pages/core/model/temporary_pages_consistency_check_task_unittest.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d76d86f287294577346eb6224ffa73d1bfb2f6f9 commit d76d86f287294577346eb6224ffa73d1bfb2f6f9 Author: Yafei Duan <romax@chromium.org> Date: Tue Oct 24 21:09:28 2017 [Offline Pages] Header and dummy implementation of new model. Adding a header and dummy implementation of OfflinePageModelTaskified, which is another implmentation of OfflinePageModel interface, and will be using tasks and TaskQueue to manage interactions with database. Bug: 753595 Change-Id: Id9b27a3f1a1a5a08f56dcaded8241365c54dfe27 Reviewed-on: https://chromium-review.googlesource.com/734330 Reviewed-by: Filip Gorski <fgorski@chromium.org> Reviewed-by: Dmitry Titov <dimich@chromium.org> Commit-Queue: Yafei Duan <romax@chromium.org> Cr-Commit-Position: refs/heads/master@{#511259} [modify] https://crrev.com/d76d86f287294577346eb6224ffa73d1bfb2f6f9/components/offline_pages/core/BUILD.gn [add] https://crrev.com/d76d86f287294577346eb6224ffa73d1bfb2f6f9/components/offline_pages/core/model/offline_page_model_taskified.cc [add] https://crrev.com/d76d86f287294577346eb6224ffa73d1bfb2f6f9/components/offline_pages/core/model/offline_page_model_taskified.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/37bb9a813806c59242bc29e580807912c3cae40f commit 37bb9a813806c59242bc29e580807912c3cae40f Author: Yafei Duan <romax@chromium.org> Date: Tue Oct 24 23:02:24 2017 [Offline Pages] A few prerequisites for OfflinePageModelTaskified - Changed the order of arguments in DeletePageTask. - Removed start time from the callback of ClearStorageTask. - Fixed a bug that leads to histogram DCHECK failure in CreateArchiveTask, by returning the proposed OfflinePageItem instead of one created by default constructor which has an empty namespace in client id. This also makes more sense on the semantic perspective, keeping the consistency of the value returned in that field across callbacks with various results. - Added a new way for deletion in DeletePageTask for removing duplicate pages in order to keep the number of pages per url below limits. It's used after saving pages. Bug: 753595 Change-Id: I9dcd3f596af9445a1f449792e57428e72a579d63 Reviewed-on: https://chromium-review.googlesource.com/727186 Commit-Queue: Yafei Duan <romax@chromium.org> Reviewed-by: Filip Gorski <fgorski@chromium.org> Cr-Commit-Position: refs/heads/master@{#511294} [modify] https://crrev.com/37bb9a813806c59242bc29e580807912c3cae40f/components/offline_pages/core/model/clear_storage_task.cc [modify] https://crrev.com/37bb9a813806c59242bc29e580807912c3cae40f/components/offline_pages/core/model/clear_storage_task.h [modify] https://crrev.com/37bb9a813806c59242bc29e580807912c3cae40f/components/offline_pages/core/model/clear_storage_task_unittest.cc [modify] https://crrev.com/37bb9a813806c59242bc29e580807912c3cae40f/components/offline_pages/core/model/create_archive_task.cc [modify] https://crrev.com/37bb9a813806c59242bc29e580807912c3cae40f/components/offline_pages/core/model/create_archive_task.h [modify] https://crrev.com/37bb9a813806c59242bc29e580807912c3cae40f/components/offline_pages/core/model/create_archive_task_unittest.cc [modify] https://crrev.com/37bb9a813806c59242bc29e580807912c3cae40f/components/offline_pages/core/model/delete_page_task.cc [modify] https://crrev.com/37bb9a813806c59242bc29e580807912c3cae40f/components/offline_pages/core/model/delete_page_task.h [modify] https://crrev.com/37bb9a813806c59242bc29e580807912c3cae40f/components/offline_pages/core/model/delete_page_task_unittest.cc [modify] https://crrev.com/37bb9a813806c59242bc29e580807912c3cae40f/components/offline_pages/core/model/get_pages_task.cc [modify] https://crrev.com/37bb9a813806c59242bc29e580807912c3cae40f/components/offline_pages/core/model/get_pages_task.h [modify] https://crrev.com/37bb9a813806c59242bc29e580807912c3cae40f/components/offline_pages/core/model/get_pages_task_unittest.cc [modify] https://crrev.com/37bb9a813806c59242bc29e580807912c3cae40f/components/offline_pages/core/model/offline_page_item_generator.cc [modify] https://crrev.com/37bb9a813806c59242bc29e580807912c3cae40f/components/offline_pages/core/model/offline_page_item_generator.h [modify] https://crrev.com/37bb9a813806c59242bc29e580807912c3cae40f/components/offline_pages/core/offline_page_metadata_store_test_util.cc [modify] https://crrev.com/37bb9a813806c59242bc29e580807912c3cae40f/components/offline_pages/core/offline_page_metadata_store_test_util.h [modify] https://crrev.com/37bb9a813806c59242bc29e580807912c3cae40f/components/offline_pages/core/offline_page_model.cc [modify] https://crrev.com/37bb9a813806c59242bc29e580807912c3cae40f/components/offline_pages/core/offline_page_model.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/85420f94db8a38bb776a65fbda8259755de66d1d commit 85420f94db8a38bb776a65fbda8259755de66d1d Author: Yafei Duan <romax@chromium.org> Date: Wed Oct 25 01:15:11 2017 Revert "[Offline Pages] A few prerequisites for OfflinePageModelTaskified" This reverts commit 37bb9a813806c59242bc29e580807912c3cae40f. Reason for revert: Findit (https://goo.gl/kROfz5) identified this CL at revision 511294 as the culprit Original change's description: > [Offline Pages] A few prerequisites for OfflinePageModelTaskified > > - Changed the order of arguments in DeletePageTask. > - Removed start time from the callback of ClearStorageTask. > - Fixed a bug that leads to histogram DCHECK failure in > CreateArchiveTask, by returning the proposed OfflinePageItem instead > of one created by default constructor which has an empty namespace in > client id. This also makes more sense on the semantic perspective, > keeping the consistency of the value returned in that field across > callbacks with various results. > - Added a new way for deletion in DeletePageTask for removing duplicate > pages in order to keep the number of pages per url below limits. It's > used after saving pages. > > Bug: 753595 > Change-Id: I9dcd3f596af9445a1f449792e57428e72a579d63 > Reviewed-on: https://chromium-review.googlesource.com/727186 > Commit-Queue: Yafei Duan <romax@chromium.org> > Reviewed-by: Filip Gorski <fgorski@chromium.org> > Cr-Commit-Position: refs/heads/master@{#511294} TBR=fgorski@chromium.org,romax@chromium.org Change-Id: Ibdc6b30a6db7d62b53bbf1391fe8ba66cd2e3de2 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 753595 Reviewed-on: https://chromium-review.googlesource.com/737142 Reviewed-by: Yafei Duan <romax@chromium.org> Commit-Queue: Yafei Duan <romax@chromium.org> Cr-Commit-Position: refs/heads/master@{#511327} [modify] https://crrev.com/85420f94db8a38bb776a65fbda8259755de66d1d/components/offline_pages/core/model/clear_storage_task.cc [modify] https://crrev.com/85420f94db8a38bb776a65fbda8259755de66d1d/components/offline_pages/core/model/clear_storage_task.h [modify] https://crrev.com/85420f94db8a38bb776a65fbda8259755de66d1d/components/offline_pages/core/model/clear_storage_task_unittest.cc [modify] https://crrev.com/85420f94db8a38bb776a65fbda8259755de66d1d/components/offline_pages/core/model/create_archive_task.cc [modify] https://crrev.com/85420f94db8a38bb776a65fbda8259755de66d1d/components/offline_pages/core/model/create_archive_task.h [modify] https://crrev.com/85420f94db8a38bb776a65fbda8259755de66d1d/components/offline_pages/core/model/create_archive_task_unittest.cc [modify] https://crrev.com/85420f94db8a38bb776a65fbda8259755de66d1d/components/offline_pages/core/model/delete_page_task.cc [modify] https://crrev.com/85420f94db8a38bb776a65fbda8259755de66d1d/components/offline_pages/core/model/delete_page_task.h [modify] https://crrev.com/85420f94db8a38bb776a65fbda8259755de66d1d/components/offline_pages/core/model/delete_page_task_unittest.cc [modify] https://crrev.com/85420f94db8a38bb776a65fbda8259755de66d1d/components/offline_pages/core/model/get_pages_task.cc [modify] https://crrev.com/85420f94db8a38bb776a65fbda8259755de66d1d/components/offline_pages/core/model/get_pages_task.h [modify] https://crrev.com/85420f94db8a38bb776a65fbda8259755de66d1d/components/offline_pages/core/model/get_pages_task_unittest.cc [modify] https://crrev.com/85420f94db8a38bb776a65fbda8259755de66d1d/components/offline_pages/core/model/offline_page_item_generator.cc [modify] https://crrev.com/85420f94db8a38bb776a65fbda8259755de66d1d/components/offline_pages/core/model/offline_page_item_generator.h [modify] https://crrev.com/85420f94db8a38bb776a65fbda8259755de66d1d/components/offline_pages/core/offline_page_metadata_store_test_util.cc [modify] https://crrev.com/85420f94db8a38bb776a65fbda8259755de66d1d/components/offline_pages/core/offline_page_metadata_store_test_util.h [modify] https://crrev.com/85420f94db8a38bb776a65fbda8259755de66d1d/components/offline_pages/core/offline_page_model.cc [modify] https://crrev.com/85420f94db8a38bb776a65fbda8259755de66d1d/components/offline_pages/core/offline_page_model.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/33a78c76b8cec48bab6047a175f591ff6ffdca13 commit 33a78c76b8cec48bab6047a175f591ff6ffdca13 Author: Yafei Duan <romax@chromium.org> Date: Fri Nov 03 20:27:05 2017 [Offline Pages] Step 2 of implementing OfflinePageModelTaskfied. This CL is the second CL of implementing OfflinePageModelTaskified. It contains: - SavePage workflow, with clearing storage and removing pages with the same url and in the same namespace. - AddPage workflow. - MarkPageAccessed workflow. - Ensure archive directory get created during construction. - Related tests for above items. Bug: 753595 Change-Id: Ia3ff750c2e615fb2f58e12feef4de2558d7e0da6 Reviewed-on: https://chromium-review.googlesource.com/737956 Commit-Queue: Yafei Duan <romax@chromium.org> Reviewed-by: Filip Gorski <fgorski@chromium.org> Cr-Commit-Position: refs/heads/master@{#513895} [modify] https://crrev.com/33a78c76b8cec48bab6047a175f591ff6ffdca13/components/offline_pages/core/BUILD.gn [modify] https://crrev.com/33a78c76b8cec48bab6047a175f591ff6ffdca13/components/offline_pages/core/model/clear_storage_task.cc [modify] https://crrev.com/33a78c76b8cec48bab6047a175f591ff6ffdca13/components/offline_pages/core/model/clear_storage_task.h [modify] https://crrev.com/33a78c76b8cec48bab6047a175f591ff6ffdca13/components/offline_pages/core/model/clear_storage_task_unittest.cc [modify] https://crrev.com/33a78c76b8cec48bab6047a175f591ff6ffdca13/components/offline_pages/core/model/create_archive_task.cc [modify] https://crrev.com/33a78c76b8cec48bab6047a175f591ff6ffdca13/components/offline_pages/core/model/delete_page_task.cc [modify] https://crrev.com/33a78c76b8cec48bab6047a175f591ff6ffdca13/components/offline_pages/core/model/delete_page_task_unittest.cc [modify] https://crrev.com/33a78c76b8cec48bab6047a175f591ff6ffdca13/components/offline_pages/core/model/offline_page_model_taskified.cc [modify] https://crrev.com/33a78c76b8cec48bab6047a175f591ff6ffdca13/components/offline_pages/core/model/offline_page_model_taskified.h [add] https://crrev.com/33a78c76b8cec48bab6047a175f591ff6ffdca13/components/offline_pages/core/model/offline_page_model_taskified_unittest.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b129e85f23d020498c6181e48f8cfe97639e9590 commit b129e85f23d020498c6181e48f8cfe97639e9590 Author: Yafei Duan <romax@chromium.org> Date: Thu Nov 09 01:25:44 2017 [Offline Pages] Step 3 of implementing OfflinePageModelTaskified. This CL is the third CL of implementing OfflinePageModelTaskfied. It contains: - GetPages* workflow, with GetOfflineIdByClientId. - Related tests for GetPages* workflow. More details: go/offline-page-model-migration Bug: 753595 Change-Id: Ie95389fdb7ac6bfa61fb1ed663f0aa3583c3d11d Reviewed-on: https://chromium-review.googlesource.com/752688 Reviewed-by: Peter Williamson <petewil@chromium.org> Reviewed-by: Filip Gorski <fgorski@chromium.org> Reviewed-by: Dmitry Titov <dimich@chromium.org> Commit-Queue: Yafei Duan <romax@chromium.org> Cr-Commit-Position: refs/heads/master@{#515049} [modify] https://crrev.com/b129e85f23d020498c6181e48f8cfe97639e9590/components/offline_pages/core/model/offline_page_model_taskified.cc [modify] https://crrev.com/b129e85f23d020498c6181e48f8cfe97639e9590/components/offline_pages/core/model/offline_page_model_taskified.h [modify] https://crrev.com/b129e85f23d020498c6181e48f8cfe97639e9590/components/offline_pages/core/model/offline_page_model_taskified_unittest.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/fc4d1d7853cfbef6ab2b7f31b46e42eba9a66cc4 commit fc4d1d7853cfbef6ab2b7f31b46e42eba9a66cc4 Author: Yafei Duan <romax@chromium.org> Date: Fri Nov 10 02:49:09 2017 [Offline Pages] Step 4 of implementing OfflinePageModelTaskified. This CL is the fourth CL of implementing OfflinePageModelTaskified. It contains: - DeletePages* workflow. - Related tests for DeletePages* workflow. Bug: 753595 Change-Id: If1993639be0986ede3aab2e4b9868cfe0b773a84 Reviewed-on: https://chromium-review.googlesource.com/756094 Commit-Queue: Yafei Duan <romax@chromium.org> Reviewed-by: Carlos Knippschild <carlosk@chromium.org> Reviewed-by: Filip Gorski <fgorski@chromium.org> Cr-Commit-Position: refs/heads/master@{#515430} [modify] https://crrev.com/fc4d1d7853cfbef6ab2b7f31b46e42eba9a66cc4/components/offline_pages/core/model/delete_page_task.cc [modify] https://crrev.com/fc4d1d7853cfbef6ab2b7f31b46e42eba9a66cc4/components/offline_pages/core/model/delete_page_task_unittest.cc [modify] https://crrev.com/fc4d1d7853cfbef6ab2b7f31b46e42eba9a66cc4/components/offline_pages/core/model/offline_page_model_taskified.cc [modify] https://crrev.com/fc4d1d7853cfbef6ab2b7f31b46e42eba9a66cc4/components/offline_pages/core/model/offline_page_model_taskified_unittest.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/acec635cba391a5a4aa21b440bce2f75599782bb commit acec635cba391a5a4aa21b440bce2f75599782bb Author: Yafei Duan <romax@chromium.org> Date: Tue Nov 21 03:28:38 2017 [Offline Pages] Implement task for persistent page consistency check. Implementing consistency check for persistent pages. Persistent pages are going to be moved into external directory in near future, but current task implementation only contains the consistency check for temporary pages. This CL covers the consistency check for persistent pages, in order to to complete the consistency check process with the temporary task. It does the following: - Delete pages which have no associated files on disk. - Delete archive files which have no page entries. This is almost the mirror of the current temporary pages consistency check task. Bug: 753595 Change-Id: I87f9f68f6bb8261d5924ff8070aa574426e0f746 Reviewed-on: https://chromium-review.googlesource.com/770430 Commit-Queue: Yafei Duan <romax@chromium.org> Reviewed-by: Peter Williamson <petewil@chromium.org> Cr-Commit-Position: refs/heads/master@{#518082} [modify] https://crrev.com/acec635cba391a5a4aa21b440bce2f75599782bb/components/offline_pages/core/BUILD.gn [modify] https://crrev.com/acec635cba391a5a4aa21b440bce2f75599782bb/components/offline_pages/core/model/offline_page_item_generator.cc [add] https://crrev.com/acec635cba391a5a4aa21b440bce2f75599782bb/components/offline_pages/core/model/persistent_pages_consistency_check_task.cc [add] https://crrev.com/acec635cba391a5a4aa21b440bce2f75599782bb/components/offline_pages/core/model/persistent_pages_consistency_check_task.h [add] https://crrev.com/acec635cba391a5a4aa21b440bce2f75599782bb/components/offline_pages/core/model/persistent_pages_consistency_check_task_unittest.cc [modify] https://crrev.com/acec635cba391a5a4aa21b440bce2f75599782bb/components/offline_pages/core/model/temporary_pages_consistency_check_task.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/189ecd158107ce6046ecec77e541534e820a413c commit 189ecd158107ce6046ecec77e541534e820a413c Author: Takeshi Yoshino <tyoshino@chromium.org> Date: Tue Nov 21 04:59:53 2017 Revert "[Offline Pages] Implement task for persistent page consistency check." This reverts commit acec635cba391a5a4aa21b440bce2f75599782bb. Reason for revert: The newly added unit test is failing on multiple bots Original change's description: > [Offline Pages] Implement task for persistent page consistency check. > > Implementing consistency check for persistent pages. > Persistent pages are going to be moved into external directory in near > future, but current task implementation only contains the consistency > check for temporary pages. > This CL covers the consistency check for persistent pages, in order to > to complete the consistency check process with the temporary task. > It does the following: > - Delete pages which have no associated files on disk. > - Delete archive files which have no page entries. > This is almost the mirror of the current temporary pages consistency > check task. > > Bug: 753595 > Change-Id: I87f9f68f6bb8261d5924ff8070aa574426e0f746 > Reviewed-on: https://chromium-review.googlesource.com/770430 > Commit-Queue: Yafei Duan <romax@chromium.org> > Reviewed-by: Peter Williamson <petewil@chromium.org> > Cr-Commit-Position: refs/heads/master@{#518082} TBR=petewil@chromium.org,romax@chromium.org Change-Id: I7f2d1f45309efd4a5020fadc8d9ff40286cdfb85 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 753595 Reviewed-on: https://chromium-review.googlesource.com/780980 Reviewed-by: Takeshi Yoshino <tyoshino@chromium.org> Commit-Queue: Takeshi Yoshino <tyoshino@chromium.org> Cr-Commit-Position: refs/heads/master@{#518124} [modify] https://crrev.com/189ecd158107ce6046ecec77e541534e820a413c/components/offline_pages/core/BUILD.gn [modify] https://crrev.com/189ecd158107ce6046ecec77e541534e820a413c/components/offline_pages/core/model/offline_page_item_generator.cc [delete] https://crrev.com/12aa0c6679bd58808cd87106e2bd41cba9912858/components/offline_pages/core/model/persistent_pages_consistency_check_task.cc [delete] https://crrev.com/12aa0c6679bd58808cd87106e2bd41cba9912858/components/offline_pages/core/model/persistent_pages_consistency_check_task.h [delete] https://crrev.com/12aa0c6679bd58808cd87106e2bd41cba9912858/components/offline_pages/core/model/persistent_pages_consistency_check_task_unittest.cc [modify] https://crrev.com/189ecd158107ce6046ecec77e541534e820a413c/components/offline_pages/core/model/temporary_pages_consistency_check_task.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c33278869ed6eea98da3bc2593791f96ad5860ea commit c33278869ed6eea98da3bc2593791f96ad5860ea Author: Yafei Duan <romax@chromium.org> Date: Wed Nov 22 00:05:07 2017 Reland: [Offline Pages] Implement task for persistent page consistency check. Relanding 770430 which introduced failing tests and was reverted by 780980, this CL include the fix for failing tests. Original CL: https://chromium-review.googlesource.com/c/chromium/src/+/770430 Revert CL: https://chromium-review.googlesource.com/c/chromium/src/+/780980 Bug: 753595 Change-Id: I8cc66e79a236aaca7dadb3eb8429721c861d6547 Reviewed-on: https://chromium-review.googlesource.com/782714 Reviewed-by: Filip Gorski <fgorski@chromium.org> Commit-Queue: Yafei Duan <romax@chromium.org> Cr-Commit-Position: refs/heads/master@{#518466} [modify] https://crrev.com/c33278869ed6eea98da3bc2593791f96ad5860ea/components/offline_pages/core/BUILD.gn [modify] https://crrev.com/c33278869ed6eea98da3bc2593791f96ad5860ea/components/offline_pages/core/model/offline_page_item_generator.cc [add] https://crrev.com/c33278869ed6eea98da3bc2593791f96ad5860ea/components/offline_pages/core/model/persistent_pages_consistency_check_task.cc [add] https://crrev.com/c33278869ed6eea98da3bc2593791f96ad5860ea/components/offline_pages/core/model/persistent_pages_consistency_check_task.h [add] https://crrev.com/c33278869ed6eea98da3bc2593791f96ad5860ea/components/offline_pages/core/model/persistent_pages_consistency_check_task_unittest.cc [modify] https://crrev.com/c33278869ed6eea98da3bc2593791f96ad5860ea/components/offline_pages/core/model/temporary_pages_consistency_check_task.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/70f79fe5a8f4e2d2377101363c39e2d570c851e3 commit 70f79fe5a8f4e2d2377101363c39e2d570c851e3 Author: Yafei Duan <romax@chromium.org> Date: Mon Dec 04 21:42:02 2017 [Offline Pages] Step 5 of implementing OfflinePageModelTaskified. This CL is the fifth CL of implementing OfflinePageModelTaskified. It contains: - Hooking up consistency checks for temporary and persistent pages. - Related tests. - Updating temporary and persistent consistency check tasks to make them more similar in implementation. Bug: 753595 Change-Id: I7200ea8fbdcfb3f6914c494d0bc060504774a67b Reviewed-on: https://chromium-review.googlesource.com/786820 Reviewed-by: Filip Gorski <fgorski@chromium.org> Commit-Queue: Yafei Duan <romax@chromium.org> Cr-Commit-Position: refs/heads/master@{#521467} [modify] https://crrev.com/70f79fe5a8f4e2d2377101363c39e2d570c851e3/components/offline_pages/core/model/offline_page_model_taskified.cc [modify] https://crrev.com/70f79fe5a8f4e2d2377101363c39e2d570c851e3/components/offline_pages/core/model/offline_page_model_taskified.h [modify] https://crrev.com/70f79fe5a8f4e2d2377101363c39e2d570c851e3/components/offline_pages/core/model/offline_page_model_taskified_unittest.cc [modify] https://crrev.com/70f79fe5a8f4e2d2377101363c39e2d570c851e3/components/offline_pages/core/model/persistent_pages_consistency_check_task.cc [modify] https://crrev.com/70f79fe5a8f4e2d2377101363c39e2d570c851e3/components/offline_pages/core/model/persistent_pages_consistency_check_task_unittest.cc [modify] https://crrev.com/70f79fe5a8f4e2d2377101363c39e2d570c851e3/components/offline_pages/core/model/temporary_pages_consistency_check_task.cc [modify] https://crrev.com/70f79fe5a8f4e2d2377101363c39e2d570c851e3/components/offline_pages/core/model/temporary_pages_consistency_check_task_unittest.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/528c084044eb174424f183d0df66e577481e39c3 commit 528c084044eb174424f183d0df66e577481e39c3 Author: Yafei Duan <romax@chromium.org> Date: Thu Dec 21 04:11:20 2017 [Offline Pages] Switching from OPMImpl to OPMTaskified. Switching OfflinePageModelFactory from creating OfflinePageModelImpl to OfflinePageModelTaskified. Also have related changes required in tests. Bug: 753595 Change-Id: I8de03e1e943cf3e8c3040e5b3572643d72b9fca2 Reviewed-on: https://chromium-review.googlesource.com/833495 Commit-Queue: Yafei Duan <romax@chromium.org> Reviewed-by: Dmitry Titov <dimich@chromium.org> Reviewed-by: Filip Gorski <fgorski@chromium.org> Cr-Commit-Position: refs/heads/master@{#525597} [modify] https://crrev.com/528c084044eb174424f183d0df66e577481e39c3/chrome/browser/offline_pages/android/offline_page_model_factory.cc [modify] https://crrev.com/528c084044eb174424f183d0df66e577481e39c3/chrome/browser/offline_pages/offline_page_request_job_unittest.cc [modify] https://crrev.com/528c084044eb174424f183d0df66e577481e39c3/chrome/browser/offline_pages/offline_page_utils.cc [modify] https://crrev.com/528c084044eb174424f183d0df66e577481e39c3/chrome/browser/offline_pages/offline_page_utils_unittest.cc [modify] https://crrev.com/528c084044eb174424f183d0df66e577481e39c3/chrome/browser/offline_pages/test_offline_page_model_builder.cc [modify] https://crrev.com/528c084044eb174424f183d0df66e577481e39c3/components/offline_pages/core/model/create_archive_task.cc [modify] https://crrev.com/528c084044eb174424f183d0df66e577481e39c3/components/offline_pages/core/model/create_archive_task.h [modify] https://crrev.com/528c084044eb174424f183d0df66e577481e39c3/components/offline_pages/core/model/create_archive_task_unittest.cc [modify] https://crrev.com/528c084044eb174424f183d0df66e577481e39c3/components/offline_pages/core/model/delete_page_task.cc [modify] https://crrev.com/528c084044eb174424f183d0df66e577481e39c3/components/offline_pages/core/model/offline_page_model_taskified.cc [modify] https://crrev.com/528c084044eb174424f183d0df66e577481e39c3/components/offline_pages/core/model/offline_page_model_taskified.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/4ef2d88a56d67bf788f6c170d9b924f904e84ba9 commit 4ef2d88a56d67bf788f6c170d9b924f904e84ba9 Author: Carlos Knippschild <carlosk@chromium.org> Date: Sat Dec 23 05:59:54 2017 Revert "[Offline Pages] Switching from OPMImpl to OPMTaskified." This reverts commit 528c084044eb174424f183d0df66e577481e39c3. Reason for revert: primary suspect of performance regression reported at https://crbug.com/797423 . Original change's description: > [Offline Pages] Switching from OPMImpl to OPMTaskified. > > Switching OfflinePageModelFactory from creating OfflinePageModelImpl to > OfflinePageModelTaskified. Also have related changes required in tests. > > > Bug: 753595 > Change-Id: I8de03e1e943cf3e8c3040e5b3572643d72b9fca2 > Reviewed-on: https://chromium-review.googlesource.com/833495 > Commit-Queue: Yafei Duan <romax@chromium.org> > Reviewed-by: Dmitry Titov <dimich@chromium.org> > Reviewed-by: Filip Gorski <fgorski@chromium.org> > Cr-Commit-Position: refs/heads/master@{#525597} TBR=fgorski@chromium.org,dimich@chromium.org,romax@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 753595 , 797423 Change-Id: I3f6b2ddfa2523bd3007a77df2db26bb841729b3e Reviewed-on: https://chromium-review.googlesource.com/843717 Reviewed-by: Carlos Knippschild <carlosk@chromium.org> Commit-Queue: Carlos Knippschild <carlosk@chromium.org> Cr-Commit-Position: refs/heads/master@{#526141} [modify] https://crrev.com/4ef2d88a56d67bf788f6c170d9b924f904e84ba9/chrome/browser/offline_pages/android/offline_page_model_factory.cc [modify] https://crrev.com/4ef2d88a56d67bf788f6c170d9b924f904e84ba9/chrome/browser/offline_pages/offline_page_request_job_unittest.cc [modify] https://crrev.com/4ef2d88a56d67bf788f6c170d9b924f904e84ba9/chrome/browser/offline_pages/offline_page_utils.cc [modify] https://crrev.com/4ef2d88a56d67bf788f6c170d9b924f904e84ba9/chrome/browser/offline_pages/offline_page_utils_unittest.cc [modify] https://crrev.com/4ef2d88a56d67bf788f6c170d9b924f904e84ba9/chrome/browser/offline_pages/test_offline_page_model_builder.cc [modify] https://crrev.com/4ef2d88a56d67bf788f6c170d9b924f904e84ba9/components/offline_pages/core/model/create_archive_task.cc [modify] https://crrev.com/4ef2d88a56d67bf788f6c170d9b924f904e84ba9/components/offline_pages/core/model/create_archive_task.h [modify] https://crrev.com/4ef2d88a56d67bf788f6c170d9b924f904e84ba9/components/offline_pages/core/model/create_archive_task_unittest.cc [modify] https://crrev.com/4ef2d88a56d67bf788f6c170d9b924f904e84ba9/components/offline_pages/core/model/delete_page_task.cc [modify] https://crrev.com/4ef2d88a56d67bf788f6c170d9b924f904e84ba9/components/offline_pages/core/model/offline_page_model_taskified.cc [modify] https://crrev.com/4ef2d88a56d67bf788f6c170d9b924f904e84ba9/components/offline_pages/core/model/offline_page_model_taskified.h
Comment 1 by romax@chromium.org
, Aug 24 2017