Issue metadata
Sign in to add a comment
|
ForceMaximizeOnFirstRunTest.PRE_TwoRuns hits DCHECK in viz::ClientLayerTreeFrameSink::OnMojoConnectionError |
||||||||||||||||||||||
Issue descriptionI'm trying to enable more tests with --mus for ChromeOS. On one run a bot hit a DCHECK in ForceMaximizeOnFirstRunTest.PRE_TwoRuns enough to trigger failure. Here's the stack: 413:413:0808/150336.504013:FATAL:client_layer_tree_frame_sink.cc(170)] Surface invariants violation #0 0x0000034c663c base::debug::StackTrace::StackTrace() #1 0x0000034df12c logging::LogMessage::~LogMessage() #2 0x000001e3fd62 viz::ClientLayerTreeFrameSink::OnMojoConnectionError() #3 0x0000049946b3 mojo::InterfaceEndpointClient::NotifyError() #4 0x00000499cca6 mojo::internal::MultiplexRouter::ProcessNotifyErrorTask() #5 0x00000499a57d mojo::internal::MultiplexRouter::ProcessTasks() #6 0x00000499bc86 mojo::internal::MultiplexRouter::Accept() #7 0x000004992e56 mojo::FilterChain::Accept() #8 0x000004992145 mojo::Connector::ReadSingleMessage() #9 0x000004992a41 mojo::Connector::ReadAllAvailableMessages() #10 0x0000049928f9 mojo::Connector::OnHandleReadyInternal() #11 0x000001625d55 chromeos::file_system_provider::Int64ToIntCompletionCallback() #12 0x0000049aa704 mojo::SimpleWatcher::OnHandleReady() #13 0x0000049aab8f _ZN4base8internal7InvokerINS0_9BindStateIMN4mojo13SimpleWatcherEFvijRKNS3_18HandleSignalsStateEEJNS_7WeakPtrIS4_EEijS5_EEEFvvEE7RunImplIRKS9_RKNSt3__15tupleIJSB_ijS5_EEEJLm0ELm1ELm2ELm3EEEEvOT_OT0_NS_13IndexSequenceIJXspT1_EEEE #14 0x0000034c6dd0 base::debug::TaskAnnotator::RunTask() #15 0x0000034e67c9 base::MessageLoop::RunTask() #16 0x0000034e6aee base::MessageLoop::DeferOrRunPendingTask() #17 0x0000034e6dc9 base::MessageLoop::DoWork() #18 0x0000034e9319 base::MessagePumpLibevent::Run() #19 0x0000034e6232 base::MessageLoop::Run() #20 0x00000351065a base::RunLoop::Run() #21 0x000003af0356 content::MessageLoopRunner::Run() #22 0x000003af07f6 content::WindowedNotificationObserver::Wait() #23 0x0000012e8285 policy::LoginPolicyTestBase::SkipToLoginScreen() #24 0x0000012e67b2 policy::ForceMaximizeOnFirstRunTest_PRE_TwoRuns_Test::RunTestOnMainThread() #25 0x000003ab95d4 content::BrowserTestBase::ProxyRunTestOnMainThreadLoop() #26 0x0000035f786e ChromeBrowserMainParts::PreMainMessageLoopRunImpl() #27 0x0000035f66fd ChromeBrowserMainParts::PreMainMessageLoopRun() #28 0x0000015c88d2 chromeos::ChromeBrowserMainPartsChromeos::PreMainMessageLoopRun() #29 0x000002059761 content::BrowserMainLoop::PreMainMessageLoopRun() #30 0x00000242e0b7 content::StartupTaskRunner::RunAllTasksNow() #31 0x000002057bef content::BrowserMainLoop::CreateStartupTasks() #32 0x00000205c1e7 content::BrowserMainRunnerImpl::Initialize() #33 0x0000020551e7 content::BrowserMain() #34 0x00000346e758 content::ContentMainRunnerImpl::Run() #35 0x0000053581b2 service_manager::Main() #36 0x00000346d234 content::ContentMain() #37 0x000003ab9291 content::BrowserTestBase::SetUp() #38 0x0000035b6d0b InProcessBrowserTest::SetUp() #39 0x000001270ae1 chromeos::OobeBaseTest::SetUp() #40 0x0000012e7d25 policy::LoginPolicyTestBase::SetUp() #41 0x0000018fe0d1 testing::Test::Run() #42 0x0000018febb0 testing::TestInfo::Run() #43 0x0000018ff097 testing::TestCase::Run() #44 0x0000019055b7 testing::internal::UnitTestImpl::RunAllTests() #45 0x000001905237 testing::UnitTest::Run() #46 0x0000035cb4de base::TestSuite::Run() #47 0x0000034b9859 ChromeTestSuiteRunner::RunTestSuite() #48 0x000003aea35f content::LaunchTests() #49 0x0000034b74c8 RunMashBrowserTests() #50 0x0000034b7147 main #51 0x7faa17492f45 __libc_start_main #52 0x000000586c93 <unknown> Assigning to samans@ as it seems he last touched the line in gpu_compositor_frame_sink that has the failure reason. I couldn't reproduce this locally. I'm going to add this test to the list of tests we don't run.
,
Aug 8 2017
Reassigning to Sadrul as he's looking into this class of bugs now.
,
Aug 10 2017
,
Oct 12 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/73f609d62096e6ba344d71226702ff69cd58da57 commit 73f609d62096e6ba344d71226702ff69cd58da57 Author: Scott Violet <sky@chromium.org> Date: Thu Oct 12 02:04:00 2017 chromeos: enable more browser_tests for mus These tests are passing and no longer need to be disabled. BUG= 754846 , 753593 , 759156 , 755272 Change-Id: I5bc6305d000d515688166575ad8ac7af6c7e8afd Reviewed-on: https://chromium-review.googlesource.com/714118 Reviewed-by: Michael Wasserman <msw@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#508221} [modify] https://crrev.com/73f609d62096e6ba344d71226702ff69cd58da57/testing/buildbot/filters/mus.browser_tests.filter |
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by sadrul@chromium.org
, Aug 8 2017