New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 753590 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Aug 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Make it easier to dedupe UKM reports.

Project Member Reported by holte@chromium.org, Aug 8 2017

Issue description

Add report ids to UKM reports to make it easier to dedupe them when they get sent multiple times.
 

Comment 1 by holte@chromium.org, Aug 8 2017

Components: Internals>Metrics
Project Member

Comment 2 by bugdroid1@chromium.org, Aug 10 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/444575f25f09de657e35515a2fc7ac1a8598c108

commit 444575f25f09de657e35515a2fc7ac1a8598c108
Author: Steven Holte <holte@google.com>
Date: Thu Aug 10 00:28:37 2017

Record report_ids in UKM reports.

Also removes the feature param for controlling session ID recording,
since we have pipeline logic depending on it.

Bug:  753590 
Change-Id: I782f04ef21ab68a4a45b0f50ae416ea0e77e79a9
Reviewed-on: https://chromium-review.googlesource.com/607393
Reviewed-by: Alexei Svitkine (very slow) <asvitkine@chromium.org>
Commit-Queue: Steven Holte <holte@chromium.org>
Cr-Commit-Position: refs/heads/master@{#493188}
[modify] https://crrev.com/444575f25f09de657e35515a2fc7ac1a8598c108/components/metrics/proto/ukm/report.proto
[modify] https://crrev.com/444575f25f09de657e35515a2fc7ac1a8598c108/components/ukm/ukm_service.cc
[modify] https://crrev.com/444575f25f09de657e35515a2fc7ac1a8598c108/components/ukm/ukm_service.h
[modify] https://crrev.com/444575f25f09de657e35515a2fc7ac1a8598c108/components/ukm/ukm_service_unittest.cc

Comment 3 by holte@chromium.org, Aug 11 2017

Status: Fixed (was: Started)

Sign in to add a comment