Disable welcome app triggering for enrolled devices |
|||||||||||||
Issue descriptionFor consumer users, we are disabling syncing of welcome app pref so that users will see it on first sign-in on each new device: crbug/752361. However, for enrolled devices, there's a possibility of a user using many different chromebooks as part of a model. We should disable welcome app triggering for enrolled devices.
,
Aug 9 2017
With bug 752361 going into M61, this change also *must* go into M61. Bumping priority and marking as ReleaseBlock-Stable. Naveen, from M61 on, new users will always see the Chrome OS welcome app pop up. For cart users, this would mean the welcome screen pops up on every single login. The proposed fix is to completely suppress the welcome screen for managed users, including their first login. Routing to Drew to assign an engineer to this.
,
Aug 9 2017
,
Aug 11 2017
My suggestion would be to just revert https://chromium-review.googlesource.com/c/602768 and start syncing that pref - is that welcome screen so valuable that we really need to throw it in front of consumer users on every device? In any case, we also should do something explicit for managed users since they may have sync disabled by their domain admin. Denis, can you take a look? Probably just as easy as changing the code that checks kFirstRunTutorialShown pref to look at ProfilePolicyConnector::IsManaged().
,
Aug 11 2017
,
Aug 11 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d124ec827874e5b88eeabe3b2660214a84031bf5 commit d124ec827874e5b88eeabe3b2660214a84031bf5 Author: Denis Kuznetsov <antrim@google.com> Date: Fri Aug 11 23:43:49 2017 Disable first run for mananged profiles Bug: 753566 Change-Id: I653c6476d219363da8f79a3479180cef0f776556 Reviewed-on: https://chromium-review.googlesource.com/612346 Reviewed-by: Alexander Alekseev <alemate@chromium.org> Commit-Queue: Alexander Alekseev <alemate@chromium.org> Cr-Commit-Position: refs/heads/master@{#493883} [modify] https://crrev.com/d124ec827874e5b88eeabe3b2660214a84031bf5/chrome/browser/chromeos/first_run/first_run.cc
,
Aug 14 2017
,
Aug 14 2017
This bug requires manual review: M61 has already been promoted to the beta branch, so this requires manual review Please contact the milestone owner if you have questions. Owners: amineer@(Android), cmasso@(iOS), ketakid@(ChromeOS), govind@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Aug 14 2017
Approving merge for M61 Chrome OS.
,
Aug 18 2017
This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible! If all merges have been completed, please remove any remaining Merge-Approved labels from this issue. Thanks for your time! To disable nags, add the Disable-Nags label. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Aug 18 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ff6bc321115ca29795b6113cfa062c5974415d0a commit ff6bc321115ca29795b6113cfa062c5974415d0a Author: Denis Kuznetsov <antrim@google.com> Date: Fri Aug 18 15:59:55 2017 Disable first run for mananged profiles TBR=antrim@google.com (cherry picked from commit d124ec827874e5b88eeabe3b2660214a84031bf5) Bug: 753566 Change-Id: I653c6476d219363da8f79a3479180cef0f776556 Reviewed-on: https://chromium-review.googlesource.com/612346 Reviewed-by: Alexander Alekseev <alemate@chromium.org> Commit-Queue: Alexander Alekseev <alemate@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#493883} Reviewed-on: https://chromium-review.googlesource.com/621088 Reviewed-by: Denis Kuznetsov <antrim@chromium.org> Cr-Commit-Position: refs/branch-heads/3163@{#673} Cr-Branched-From: ff259bab28b35d242e10186cd63af7ed404fae0d-refs/heads/master@{#488528} [modify] https://crrev.com/ff6bc321115ca29795b6113cfa062c5974415d0a/chrome/browser/chromeos/first_run/first_run.cc
,
Aug 31 2017
antrim@ can we close this issue since this is already fixed?
,
Sep 5 2017
,
Sep 6 2017
,
Sep 11 2017
Do not see welcome app screen triggering for enrolled device for any users. Verified in Minnie/M61 M ChromeOS Chrome ARC Type Channel 61 9765.61.0 61.0.3163.87 (multiple) release beta |
|||||||||||||
►
Sign in to add a comment |
|||||||||||||
Comment 1 by bartfab@chromium.org
, Aug 9 2017