New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 753564 link

Starred by 1 user

Issue metadata

Status: Archived
Owner:
Last visit > 30 days ago
Closed: Aug 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug



Sign in to add a comment

Filter out Playstore results that have corresponding Web Apps installed

Project Member Reported by vadimt@chromium.org, Aug 8 2017

Issue description

Like:
You have Google Keep Web App installed.
You type Keep in Launcher.
Playstore results shouldn't include Google Keep.
 
Cc: omrilio@chromium.org hejq@chromium.org
Recently used instant apps will be treated as on-device ones, and will never be filtered out, even when where is an equivalent installed extension.
Labels: OS-Chrome
Labels: M-61 Merge-Request-61
Project Member

Comment 5 by sheriffbot@chromium.org, Aug 8 2017

Labels: -Merge-Request-61 Merge-Review-61 Hotlist-Merge-Review
This bug requires manual review: M61 has already been promoted to the beta branch, so this requires manual review
Please contact the milestone owner if you have questions.
Owners: amineer@(Android), cmasso@(iOS), ketakid@(ChromeOS), govind@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 6 by ketakid@google.com, Aug 8 2017

Labels: -Merge-Review-61 Merge-Approved-61
Approving merge to M61 Chrome OS.
LGTM re: #2
Project Member

Comment 8 by bugdroid1@chromium.org, Aug 10 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8faad1ed9e732eff254d2c01315ceb0fd668b415

commit 8faad1ed9e732eff254d2c01315ceb0fd668b415
Author: Vadim Tryshev <vadimt@google.com>
Date: Thu Aug 10 20:26:35 2017

Filtering out Playstore results that have Web Apps.

If a Playstore result has equivalent extension already installed, skip
this result.

Bug:  753564 
Test: Modified ArcPlayStoreSearchProviderTest.Basic test
Change-Id: I30edbf6c6b3c02ca92a11c93e4de08a54ffb01e0
Reviewed-on: https://chromium-review.googlesource.com/607291
Reviewed-by: Yusuke Sato <yusukes@chromium.org>
Reviewed-by: Greg Kerr <kerrnel@chromium.org>
Reviewed-by: Yury Khmel <khmel@chromium.org>
Commit-Queue: Vadim Tryshev <vadimt@chromium.org>
Cr-Commit-Position: refs/heads/master@{#493512}
[modify] https://crrev.com/8faad1ed9e732eff254d2c01315ceb0fd668b415/chrome/browser/ui/app_list/search/arc/arc_playstore_search_provider.cc
[modify] https://crrev.com/8faad1ed9e732eff254d2c01315ceb0fd668b415/chrome/browser/ui/app_list/search/arc/arc_playstore_search_provider_unittest.cc
[modify] https://crrev.com/8faad1ed9e732eff254d2c01315ceb0fd668b415/chrome/browser/ui/app_list/search/search_controller_factory.cc
[modify] https://crrev.com/8faad1ed9e732eff254d2c01315ceb0fd668b415/components/arc/common/app.mojom
[modify] https://crrev.com/8faad1ed9e732eff254d2c01315ceb0fd668b415/components/arc/test/fake_app_instance.cc

Project Member

Comment 9 by bugdroid1@chromium.org, Aug 11 2017

Labels: -merge-approved-61 merge-merged-3163
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3cbfd01de79890a87172dd7be90c2326c4abc9f9

commit 3cbfd01de79890a87172dd7be90c2326c4abc9f9
Author: Vadim Tryshev <vadimt@google.com>
Date: Fri Aug 11 17:47:02 2017

Filtering out Playstore results that have Web Apps.

If a Playstore result has equivalent extension already installed, skip
this result.

TBR=vadimt@google.com

(cherry picked from commit 8faad1ed9e732eff254d2c01315ceb0fd668b415)

Bug:  753564 
Test: Modified ArcPlayStoreSearchProviderTest.Basic test
Change-Id: I30edbf6c6b3c02ca92a11c93e4de08a54ffb01e0
Reviewed-on: https://chromium-review.googlesource.com/607291
Reviewed-by: Yusuke Sato <yusukes@chromium.org>
Reviewed-by: Greg Kerr <kerrnel@chromium.org>
Reviewed-by: Yury Khmel <khmel@chromium.org>
Commit-Queue: Vadim Tryshev <vadimt@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#493512}
Reviewed-on: https://chromium-review.googlesource.com/611672
Reviewed-by: Vadim Tryshev <vadimt@chromium.org>
Cr-Commit-Position: refs/branch-heads/3163@{#492}
Cr-Branched-From: ff259bab28b35d242e10186cd63af7ed404fae0d-refs/heads/master@{#488528}
[modify] https://crrev.com/3cbfd01de79890a87172dd7be90c2326c4abc9f9/chrome/browser/ui/app_list/search/arc/arc_playstore_search_provider.cc
[modify] https://crrev.com/3cbfd01de79890a87172dd7be90c2326c4abc9f9/chrome/browser/ui/app_list/search/arc/arc_playstore_search_provider_unittest.cc
[modify] https://crrev.com/3cbfd01de79890a87172dd7be90c2326c4abc9f9/chrome/browser/ui/app_list/search/search_controller_factory.cc
[modify] https://crrev.com/3cbfd01de79890a87172dd7be90c2326c4abc9f9/components/arc/common/app.mojom
[modify] https://crrev.com/3cbfd01de79890a87172dd7be90c2326c4abc9f9/components/arc/test/fake_app_instance.cc

Status: Fixed (was: Assigned)

Comment 11 by dchan@chromium.org, Jan 22 2018

Status: Archived (was: Fixed)

Sign in to add a comment