New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 753563 link

Starred by 2 users

Issue metadata

Status: Archived
Owner:
Last visit > 30 days ago
Closed: Aug 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug



Sign in to add a comment

Launcher all apps - 48 px spaces between pages when scrolling

Project Member Reported by warx@chromium.org, Aug 8 2017

Issue description

just found new specs require 48px spaces between pages when scrolling
https://screenshot.googleplex.com/9qpQKcRQ3fU

 
Project Member

Comment 1 by bugdroid1@chromium.org, Aug 9 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/19d574af7812d6ea6c61e9284209746458d883c5

commit 19d574af7812d6ea6c61e9284209746458d883c5
Author: Qiang Xu <warx@chromium.org>
Date: Wed Aug 09 22:58:29 2017

app_list: ensure 48px page break space when scrolling

changes:
changes page break space when scrolling from 12px (which visually does
not give page break space) to 48px (which gives extra 36px space).

Test: test with fullscreen app list flag
Bug:  753563 
Change-Id: I746539dd1c833a5d82bb2a0a0b3b623c34e4b94c
Reviewed-on: https://chromium-review.googlesource.com/608965
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Commit-Queue: Qiang(Joe) Xu <warx@chromium.org>
Cr-Commit-Position: refs/heads/master@{#493169}
[modify] https://crrev.com/19d574af7812d6ea6c61e9284209746458d883c5/ui/app_list/views/apps_grid_view.cc

Comment 2 by warx@chromium.org, Aug 10 2017

Labels: M-61 Merge-Request-61

Comment 3 by ketakid@google.com, Aug 10 2017

Labels: -Merge-Request-61 Merge-Approved-61
Approving merge to M61 Chrome OS.
Project Member

Comment 4 by bugdroid1@chromium.org, Aug 11 2017

Labels: -merge-approved-61 merge-merged-3163
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/235e1139d10f6cc8d8b7b9b20cbbe52e25aa9cdb

commit 235e1139d10f6cc8d8b7b9b20cbbe52e25aa9cdb
Author: Maajid <maajid@chromium.org>
Date: Fri Aug 11 01:08:50 2017

app_list: ensure 48px page break space when scrolling

changes:
changes page break space when scrolling from 12px (which visually does
not give page break space) to 48px (which gives extra 36px space).

TBR=warx@chromium.org

(cherry picked from commit 19d574af7812d6ea6c61e9284209746458d883c5)

Test: test with fullscreen app list flag
Bug:  753563 
Change-Id: I746539dd1c833a5d82bb2a0a0b3b623c34e4b94c
Reviewed-on: https://chromium-review.googlesource.com/608965
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Commit-Queue: Qiang(Joe) Xu <warx@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#493169}
Reviewed-on: https://chromium-review.googlesource.com/611484
Reviewed-by: Vadim Tryshev <vadimt@chromium.org>
Cr-Commit-Position: refs/branch-heads/3163@{#481}
Cr-Branched-From: ff259bab28b35d242e10186cd63af7ed404fae0d-refs/heads/master@{#488528}
[modify] https://crrev.com/235e1139d10f6cc8d8b7b9b20cbbe52e25aa9cdb/ui/app_list/views/apps_grid_view.cc

Comment 5 by warx@chromium.org, Aug 11 2017

Status: Fixed (was: Assigned)

Comment 6 by dchan@chromium.org, Jan 22 2018

Status: Archived (was: Fixed)

Sign in to add a comment