Enable data use ascriber for mac os x platform |
|||||||||
Issue descriptionChrome data use ascriber is disabled in mac due to race conditions. https://bugs.chromium.org/p/chromium/issues/detail?id=737558
,
Oct 11 2017
The data use is not being tracked on Mac OS because of this. It shows 0 bytes used, 0 bytes saved, and no savings. See the attached screenshot from my mac machine. A user also filed a user feedback report (http://shortn/_nPyA1dw1wu). Should we increase the priority of this?
,
Oct 11 2017
Ok. There are a couple of memleak bugs that got fixed. Maybe that could have stopped the crash. I will enable data use ascriber for Mac os , and see if there is still crash.
,
Oct 11 2017
Following are the recent bugs fixed. https://bugs.chromium.org/p/chromium/issues/detail?id=752952 https://bugs.chromium.org/p/chromium/issues/detail?id=769627
,
Oct 26 2017
,
Oct 27 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/fc1ca454e77c23fd8f9f22b426c1c80148178055 commit fc1ca454e77c23fd8f9f22b426c1c80148178055 Author: rajendrant <rajendrant@chromium.org> Date: Fri Oct 27 22:29:48 2017 Enable datause ascriber for Mac OS Bug: 753559 Change-Id: I0f085eac342552ab125844993e0ac97634ed2041 Reviewed-on: https://chromium-review.googlesource.com/739845 Commit-Queue: rajendrant <rajendrant@chromium.org> Reviewed-by: Tarun Bansal <tbansal@chromium.org> Cr-Commit-Position: refs/heads/master@{#512328} [modify] https://crrev.com/fc1ca454e77c23fd8f9f22b426c1c80148178055/chrome/browser/data_use_measurement/chrome_data_use_ascriber.cc [modify] https://crrev.com/fc1ca454e77c23fd8f9f22b426c1c80148178055/chrome/browser/data_use_measurement/chrome_data_use_ascriber_unittest.cc
,
Oct 27 2017
Changing status to Fixed. If Mac OS crashes are seen in canary/dev channel, this issue can be reopened.
,
Nov 1 2017
Issue 780350 has been merged into this issue.
,
Nov 1 2017
Is this really fixed? Can it be merged to M63? Why is this P3?
,
Nov 1 2017
,
Nov 3 2017
I'm assuming this is not fixed until you confirm the fix is in M63.
,
Nov 16 2017
Crash bugs specific to Mac is being worked on. crbug.com/781189
,
Dec 5 2017
Raj, if this is blocked on 781189, can you please mark it so?
,
Dec 5 2017
,
Dec 27 2017
Changing the milestone to M-64 since the CL to enable the ascriber (in Comment 5 above) landed in 64.
,
Jan 2 2018
Fixed in M-64. |
|||||||||
►
Sign in to add a comment |
|||||||||
Comment 1 by tbansal@chromium.org
, Aug 8 2017