New issue
Advanced search Search tips

Issue 753559 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Jan 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 1
Type: Bug

Blocked on:
issue 781189



Sign in to add a comment

Enable data use ascriber for mac os x platform

Project Member Reported by rajendrant@chromium.org, Aug 8 2017

Issue description

Chrome data use ascriber is disabled in mac due to race conditions.

https://bugs.chromium.org/p/chromium/issues/detail?id=737558
 
Components: Internals>Network>DataUse
The data use is not being tracked on Mac OS because of this. It shows 0 bytes used, 0 bytes saved, and no savings. See the attached screenshot from my mac machine. A user also filed a user feedback report (http://shortn/_nPyA1dw1wu).

Should we increase the priority of this?

7QtzaH5RN8h.png
130 KB View Download
Ok. There are a couple of memleak bugs that got fixed.
Maybe that could have stopped the crash.

I will enable data use ascriber for Mac os , and see if there is still crash.

Status: Started (was: Assigned)
Project Member

Comment 6 by bugdroid1@chromium.org, Oct 27 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fc1ca454e77c23fd8f9f22b426c1c80148178055

commit fc1ca454e77c23fd8f9f22b426c1c80148178055
Author: rajendrant <rajendrant@chromium.org>
Date: Fri Oct 27 22:29:48 2017

Enable datause ascriber for Mac OS

Bug:  753559 
Change-Id: I0f085eac342552ab125844993e0ac97634ed2041
Reviewed-on: https://chromium-review.googlesource.com/739845
Commit-Queue: rajendrant <rajendrant@chromium.org>
Reviewed-by: Tarun Bansal <tbansal@chromium.org>
Cr-Commit-Position: refs/heads/master@{#512328}
[modify] https://crrev.com/fc1ca454e77c23fd8f9f22b426c1c80148178055/chrome/browser/data_use_measurement/chrome_data_use_ascriber.cc
[modify] https://crrev.com/fc1ca454e77c23fd8f9f22b426c1c80148178055/chrome/browser/data_use_measurement/chrome_data_use_ascriber_unittest.cc

Status: Fixed (was: Started)
Changing status to Fixed.
If Mac OS crashes are seen in canary/dev channel, this issue can be reopened.
Issue 780350 has been merged into this issue.

Comment 9 by bengr@chromium.org, Nov 1 2017

Labels: -Pri-3 Pri-1
Is this really fixed? Can it be merged to M63? Why is this P3?
Labels: M-63
Status: Started (was: Fixed)
I'm assuming this is not fixed until you confirm the fix is in M63.
Crash bugs specific to Mac is being worked on.
crbug.com/781189
Raj, if this is blocked on 781189, can you please mark it so?
Blockedon: 781189
Labels: -M-63 M-64
Changing the milestone to M-64 since the CL to enable the ascriber (in Comment 5 above) landed in 64.
Status: Fixed (was: Started)
Fixed in M-64.

Sign in to add a comment