New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 753554 link

Starred by 1 user
Status: Archived
Owner:
weifangsun@chromium.org
Closed: Aug 2017
Cc:
r...@chromium.org
vapier@chromium.org
█ xiaoyinh@chromium.org
wzang@chromium.org
█ gkihumba@google.com
ketakid@google.com
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: ----
Type: ----

Blocking:
issue 713830
issue 753558



Sign in to add a comment

Get Help: Add offline support for Contact Support button

Project Member Reported by weifangsun@chromium.org, Aug 8 2017 
Currently when a user is offline and clicks on the Contact Support button in the Get Help app, they are directed to a web page with a no network connection error.

We should add the ability to detect if the user is offline prior to clicking on the Contact Support button.

If the user is online, keep the current workflow.
If the user is offline, for EVE only, direct the user to an article under the Your Chromebook section (will follow-up with the article info).
If the user is offline, direct the user to a general Chromebook support article. -- This last requirement is out of scope for M61. I will log a separate bug to track.

Comment 1 by weifangsun@chromium.org, Aug 8 2017

Blocking: 713830

Comment 2 by weifangsun@chromium.org, Aug 8 2017

Blocking: 753558

Comment 3 by wzang@chromium.org, Aug 11 2017

Cc: r...@chromium.org
Project Member

Comment 4 by bugdroid1@chromium.org, Aug 25 2017 

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/chromeos/overlays/overlay-eve-private/+/0f1c2cde91154e152e5f79ade41da657211385ee

commit 0f1c2cde91154e152e5f79ade41da657211385ee
Author: Wenzhao Zang <wzang@chromium.org>
Date: Fri Aug 25 12:34:11 2017
Project Member

Comment 5 by bugdroid1@chromium.org, Aug 25 2017 

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/chromeos/chromeos-assets/+/4b22f278516c760b336d744bf88e13e01a06fbb4

commit 4b22f278516c760b336d744bf88e13e01a06fbb4
Author: Wenzhao Zang <wzang@chromium.org>
Date: Fri Aug 25 21:21:38 2017

Comment 6 by wzang@chromium.org, Aug 25 2017

Labels: Merge-Request-61
Project Member

Comment 7 by sheriffbot@chromium.org, Aug 25 2017

Labels: -Merge-Request-61 Merge-Review-61 Hotlist-Merge-Review
This bug requires manual review: We are only 10 days from stable.
Please contact the milestone owner if you have questions.
Owners: amineer@(Android), cmasso@(iOS), ketakid@(ChromeOS), govind@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 8 by ketakid@google.com, Aug 26 2017

Labels: -Merge-Review-61 Merge-Approved-61
Approving merge to M61 Chrome OS.
Project Member

Comment 9 by bugdroid1@chromium.org, Aug 28 2017

Labels: merge-merged-release-R61-9765.B
The following revision refers to this bug:
  https://chrome-internal.googlesource.com/chromeos/overlays/overlay-eve-private/+/45d0a16802b25fd5a0ac1bab97833fffb1b4991f

commit 45d0a16802b25fd5a0ac1bab97833fffb1b4991f
Author: Wenzhao Zang <wzang@chromium.org>
Date: Mon Aug 28 17:33:07 2017
Project Member

Comment 10 by bugdroid1@chromium.org, Aug 28 2017 

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/chromeos/chromeos-assets/+/76a70dcf50cef9d12fbfa1c4544945733add0c96

commit 76a70dcf50cef9d12fbfa1c4544945733add0c96
Author: Wenzhao Zang <wzang@chromium.org>
Date: Mon Aug 28 17:33:07 2017

Comment 11 by wzang@chromium.org, Aug 28 2017

Labels: -Merge-Approved-61
Status: Fixed (was: Assigned)
Project Member

Comment 12 by bugdroid1@chromium.org, Oct 27 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/board-overlays/+/8486a455c6f84b7857c99197bf1482fbefb8a301

commit 8486a455c6f84b7857c99197bf1482fbefb8a301
Author: Mike Frysinger <vapier@chromium.org>
Date: Fri Oct 27 23:14:15 2017

genius-app-data-eve: move to public overlay

BUG= chromium:753554 
TEST=precq passes

Change-Id: I1a94303e9f72ee308bf04350288b87e1a7be77eb
Reviewed-on: https://chromium-review.googlesource.com/741341
Commit-Ready: Mike Frysinger <vapier@chromium.org>
Tested-by: Mike Frysinger <vapier@chromium.org>
Reviewed-by: Chi-Ngai Wan <cnwan@google.com>
Reviewed-by: Mike Frysinger <vapier@chromium.org>
Reviewed-by: Wenzhao (Colin) Zang <wzang@chromium.org>

[add] https://crrev.com/8486a455c6f84b7857c99197bf1482fbefb8a301/overlay-eve/chromeos-base/genius-app-data-eve/files/warranty/images/image02.png
[add] https://crrev.com/8486a455c6f84b7857c99197bf1482fbefb8a301/overlay-eve/chromeos-base/genius-app-data-eve/files/warranty/images/image00.png
[add] https://crrev.com/8486a455c6f84b7857c99197bf1482fbefb8a301/overlay-eve/chromeos-base/genius-app-data-eve/files/warranty/images/image01.png
[rename] https://crrev.com/8486a455c6f84b7857c99197bf1482fbefb8a301/overlay-eve/chromeos-base/chromeos-bsp-eve/chromeos-bsp-eve-0.0.1-r33.ebuild
[add] https://crrev.com/8486a455c6f84b7857c99197bf1482fbefb8a301/overlay-eve/chromeos-base/genius-app-data-eve/files/warranty/OpenSansFallback.woff2
[modify] https://crrev.com/8486a455c6f84b7857c99197bf1482fbefb8a301/overlay-eve/chromeos-base/chromeos-bsp-eve/chromeos-bsp-eve-0.0.1.ebuild
[add] https://crrev.com/8486a455c6f84b7857c99197bf1482fbefb8a301/overlay-eve/chromeos-base/genius-app-data-eve/files/warranty/OpenSansLatin.woff2
[add] https://crrev.com/8486a455c6f84b7857c99197bf1482fbefb8a301/overlay-eve/chromeos-base/genius-app-data-eve/files/warranty/index.html
[add] https://crrev.com/8486a455c6f84b7857c99197bf1482fbefb8a301/overlay-eve/chromeos-base/genius-app-data-eve/genius-app-data-eve-0.0.1.ebuild
[add] https://crrev.com/8486a455c6f84b7857c99197bf1482fbefb8a301/overlay-eve/chromeos-base/genius-app-data-eve/genius-app-data-eve-0.0.1-r2.ebuild
Project Member

Comment 13 by bugdroid1@chromium.org, Oct 28 2017 

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/chromeos/overlays/overlay-eve-private/+/3fab4ac909b5b4f9da4d7f57efee63dc526aa8c7

commit 3fab4ac909b5b4f9da4d7f57efee63dc526aa8c7
Author: Mike Frysinger <vapier@chromium.org>
Date: Sat Oct 28 04:54:34 2017

Comment 14 by wzang@chromium.org, Oct 31 2017

Labels: Merge-Request-63
Merge request for the CL in #13 to fix Your Chromebook section on Eve as well as move to public boards as Eve is launched.
Project Member

Comment 15 by sheriffbot@chromium.org, Oct 31 2017

Labels: -Merge-Request-63 Merge-Review-63
This bug requires manual review: M63 has already been promoted to the beta branch, so this requires manual review
Please contact the milestone owner if you have questions.
Owners: cmasso@(Android), cmasso@(iOS), gkihumba@(ChromeOS), govind@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 16 by vapier@chromium.org, Nov 3 2017

Labels: Merge-Request-62

Comment 17 by gkihumba@google.com, Nov 3 2017

Labels: -Merge-Review-63 Merge-Approved-63
Project Member

Comment 18 by sheriffbot@chromium.org, Nov 7 2017

Cc: vapier@chromium.org ketakid@google.com gkihumba@google.com
This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible!

If all merges have been completed, please remove any remaining Merge-Approved labels from this issue.

Thanks for your time! To disable nags, add the Disable-Nags label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 19 by josa...@google.com, Nov 7 2017

Labels: -Merge-Request-62 Merge-Approved-62
Project Member

Comment 20 by bugdroid1@chromium.org, Nov 7 2017

Labels: merge-merged-release-R63-10032.B
The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/board-overlays/+/d461241ba3b29a4db885273ea956b68b16ca657e

commit d461241ba3b29a4db885273ea956b68b16ca657e
Author: Mike Frysinger <vapier@chromium.org>
Date: Tue Nov 07 16:47:45 2017

genius-app-data-eve: move to public overlay

BUG= chromium:753554 
TEST=precq passes

Change-Id: I1a94303e9f72ee308bf04350288b87e1a7be77eb
(cherry picked from commit 8486a455c6f84b7857c99197bf1482fbefb8a301)
Reviewed-on: https://chromium-review.googlesource.com/747582
Reviewed-by: Mike Frysinger <vapier@chromium.org>
Commit-Queue: Mike Frysinger <vapier@chromium.org>
Tested-by: Mike Frysinger <vapier@chromium.org>

[add] https://crrev.com/d461241ba3b29a4db885273ea956b68b16ca657e/overlay-eve/chromeos-base/genius-app-data-eve/files/warranty/images/image02.png
[add] https://crrev.com/d461241ba3b29a4db885273ea956b68b16ca657e/overlay-eve/chromeos-base/genius-app-data-eve/files/warranty/images/image00.png
[add] https://crrev.com/d461241ba3b29a4db885273ea956b68b16ca657e/overlay-eve/chromeos-base/genius-app-data-eve/files/warranty/images/image01.png
[rename] https://crrev.com/d461241ba3b29a4db885273ea956b68b16ca657e/overlay-eve/chromeos-base/chromeos-bsp-eve/chromeos-bsp-eve-0.0.1-r33.ebuild
[add] https://crrev.com/d461241ba3b29a4db885273ea956b68b16ca657e/overlay-eve/chromeos-base/genius-app-data-eve/files/warranty/OpenSansFallback.woff2
[modify] https://crrev.com/d461241ba3b29a4db885273ea956b68b16ca657e/overlay-eve/chromeos-base/chromeos-bsp-eve/chromeos-bsp-eve-0.0.1.ebuild
[add] https://crrev.com/d461241ba3b29a4db885273ea956b68b16ca657e/overlay-eve/chromeos-base/genius-app-data-eve/files/warranty/OpenSansLatin.woff2
[add] https://crrev.com/d461241ba3b29a4db885273ea956b68b16ca657e/overlay-eve/chromeos-base/genius-app-data-eve/files/warranty/index.html
[add] https://crrev.com/d461241ba3b29a4db885273ea956b68b16ca657e/overlay-eve/chromeos-base/genius-app-data-eve/genius-app-data-eve-0.0.1.ebuild
[add] https://crrev.com/d461241ba3b29a4db885273ea956b68b16ca657e/overlay-eve/chromeos-base/genius-app-data-eve/genius-app-data-eve-0.0.1-r2.ebuild
Project Member

Comment 21 by bugdroid1@chromium.org, Nov 7 2017

Labels: merge-merged-release-R62-9901.B
The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/board-overlays/+/fc08d1089d61c58bea33b6c026faacf3544c7a01

commit fc08d1089d61c58bea33b6c026faacf3544c7a01
Author: Mike Frysinger <vapier@chromium.org>
Date: Tue Nov 07 16:47:54 2017

genius-app-data-eve: move to public overlay

BUG= chromium:753554 
TEST=precq passes

Change-Id: I1a94303e9f72ee308bf04350288b87e1a7be77eb
(cherry picked from commit 8486a455c6f84b7857c99197bf1482fbefb8a301)
Reviewed-on: https://chromium-review.googlesource.com/753662
Reviewed-by: Mike Frysinger <vapier@chromium.org>
Commit-Queue: Mike Frysinger <vapier@chromium.org>
Tested-by: Mike Frysinger <vapier@chromium.org>

[add] https://crrev.com/fc08d1089d61c58bea33b6c026faacf3544c7a01/overlay-eve/chromeos-base/genius-app-data-eve/files/warranty/images/image02.png
[add] https://crrev.com/fc08d1089d61c58bea33b6c026faacf3544c7a01/overlay-eve/chromeos-base/genius-app-data-eve/files/warranty/images/image00.png
[add] https://crrev.com/fc08d1089d61c58bea33b6c026faacf3544c7a01/overlay-eve/chromeos-base/genius-app-data-eve/files/warranty/images/image01.png
[add] https://crrev.com/fc08d1089d61c58bea33b6c026faacf3544c7a01/overlay-eve/chromeos-base/chromeos-bsp-eve/chromeos-bsp-eve-0.0.1-r33.ebuild
[add] https://crrev.com/fc08d1089d61c58bea33b6c026faacf3544c7a01/overlay-eve/chromeos-base/genius-app-data-eve/files/warranty/OpenSansFallback.woff2
[modify] https://crrev.com/fc08d1089d61c58bea33b6c026faacf3544c7a01/overlay-eve/chromeos-base/chromeos-bsp-eve/chromeos-bsp-eve-0.0.1.ebuild
[add] https://crrev.com/fc08d1089d61c58bea33b6c026faacf3544c7a01/overlay-eve/chromeos-base/genius-app-data-eve/files/warranty/OpenSansLatin.woff2
[add] https://crrev.com/fc08d1089d61c58bea33b6c026faacf3544c7a01/overlay-eve/chromeos-base/genius-app-data-eve/files/warranty/index.html
[add] https://crrev.com/fc08d1089d61c58bea33b6c026faacf3544c7a01/overlay-eve/chromeos-base/genius-app-data-eve/genius-app-data-eve-0.0.1.ebuild
[add] https://crrev.com/fc08d1089d61c58bea33b6c026faacf3544c7a01/overlay-eve/chromeos-base/genius-app-data-eve/genius-app-data-eve-0.0.1-r2.ebuild

Comment 22 by vapier@chromium.org, Nov 7 2017

Labels: -Restrict-View-Google -Merge-Approved-62 -Merge-Approved-63 Merge-Merged

Comment 23 by gkihumba@google.com, Nov 7 2017

Labels: -Hotlist-Merge-Review

Comment 24 by dchan@chromium.org, Jan 22 2018

Status: Archived (was: Fixed)
►

Sign in to add a comment