New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 753508 link

Starred by 1 user
Status: Fixed
Owner:
dcasta...@chromium.org
Closed: Sep 28
Cc:
█ reve...@chromium.org
█ hoegsberg@chromium.org
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Bug



Sign in to add a comment

ozone: Let drm primary plane to be null.

Project Member Reported by dcasta...@chromium.org, Aug 8 2017 
Currently Ozone enforces that when we schedule a page flip, a primary plane needs to be scheduled.

Since kms allows pageflipping without a primary plane, we should relax Ozone's constraint.
kms guarantees that the pixel not covered by any plane will use the background color (it defaults to black.)

This configuration might be beneficial in cases where we are updating only one overlay on a black background (full screen video playback.)
Project Member

Comment 1 by bugdroid1@chromium.org, Aug 9 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0f1586ab71ac8d45edf979acadda926ee6e5c979

commit 0f1586ab71ac8d45edf979acadda926ee6e5c979
Author: Daniele Castagna <dcastagna@chromium.org>
Date: Wed Aug 09 16:04:57 2017

ozone: Pageflip without a primary plane.

KMS API allows to commit a configuration of planes without a primary one.
It is guranteed that the pixels not covered by any plane will be black
(a background color, that defaults to black.)

This could be convenient in cases where we flip only an overlay and we
have a solid color background.

Bug:  753508 
Test: ozone_demo --enable-overlay --enable-drm-atomic --disable-primary-plane
Change-Id: I758c4db39ce4e36be6c12df3cb9ff42cb6902b6c
Reviewed-on: https://chromium-review.googlesource.com/606993
Reviewed-by: Daniel Nicoara <dnicoara@chromium.org>
Reviewed-by: Robert Kroeger <rjkroege@chromium.org>
Commit-Queue: Daniele Castagna <dcastagna@chromium.org>
Cr-Commit-Position: refs/heads/master@{#493006}
[modify] https://crrev.com/0f1586ab71ac8d45edf979acadda926ee6e5c979/ui/ozone/demo/surfaceless_gl_renderer.cc
[modify] https://crrev.com/0f1586ab71ac8d45edf979acadda926ee6e5c979/ui/ozone/demo/surfaceless_gl_renderer.h
[modify] https://crrev.com/0f1586ab71ac8d45edf979acadda926ee6e5c979/ui/ozone/platform/drm/gpu/crtc_controller.cc
[modify] https://crrev.com/0f1586ab71ac8d45edf979acadda926ee6e5c979/ui/ozone/platform/drm/gpu/hardware_display_controller.cc
[modify] https://crrev.com/0f1586ab71ac8d45edf979acadda926ee6e5c979/ui/ozone/platform/drm/gpu/hardware_display_controller_unittest.cc

Comment 2 by zalcorn@chromium.org, Sep 28 

Triage nag: This Chrome OS bug has an owner but no component. Please add a component so that this can be tracked by the relevant team.

Comment 3 by hoegsberg@google.com, Sep 28

Status: Fixed (was: Started)
►

Sign in to add a comment