New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 753486 link

Starred by 3 users
Status: Started
Owner:
chrisha@chromium.org
Cc:
█ abdulsyed@chromium.org
chrisha@chromium.org
█ holte@chromium.org
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 2
Type: Bug

Blocked on:
issue 776376
issue 791362
Blocking:
issue 731270



Sign in to add a comment

TabManager heuristics UKM report

Project Member Reported by l...@chromium.org, Aug 8 2017 
This bug tracks the implementation of UKM report for TabManager heuristics, metrics we want to collect are:

TabManager.Heuristics.FromBackgroundedToFirstAudioStarts
  * IsMainFrame, boolean
  * Duration in milliseconds

TabManager.Heuristics.FromBackgroundedToFirstTitleUpdated
  * Duration in milliseconds

TabManager.Heuristics.FromBackgroundedToFirstNotificationShown
  * IsMainFrame, boolean
  * Duration in milliseconds

TabManager.Heuristics.FromBackgroundedToFirstAlertShown
  * IsMainFrame, boolean
  * Duration in milliseconds

TabManager.Heuristics.FromBackgroundedToFirstFacviconUpdated
  * IsMainFrame, boolean
  * Duration in milliseconds

Comment 1 by l...@chromium.org, Aug 8 2017

Blocking: 731270

Comment 2 by l...@chromium.org, Aug 8 2017

Cc: holte@chromium.org
Project Member

Comment 3 by bugdroid1@chromium.org, Aug 22 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/255eda8fe05c786f1c70adb8cc8be03c792374b8

commit 255eda8fe05c786f1c70adb8cc8be03c792374b8
Author: Peiyong Lin <lpy@chromium.org>
Date: Tue Aug 22 23:07:53 2017

[GRC] Add UKM report for background tabs audibility.

This patch adds UKM reports for background tabs audibility. Currently we
collect audible signal at frame-level, both main frame and child frames
are using the same source id to report UKM.

BUG= 731270 , 753486

Change-Id: I461ea2d8a6ef742fcb2850250ad68a5b71c89600
Reviewed-on: https://chromium-review.googlesource.com/604515
Commit-Queue: lpy <lpy@chromium.org>
Reviewed-by: Chris Hamilton <chrisha@chromium.org>
Reviewed-by: Oystein Eftevaag <oysteine@chromium.org>
Reviewed-by: Zhen Wang <zhenw@chromium.org>
Reviewed-by: Steven Holte <holte@chromium.org>
Cr-Commit-Position: refs/heads/master@{#496491}
[modify] https://crrev.com/255eda8fe05c786f1c70adb8cc8be03c792374b8/services/resource_coordinator/coordination_unit/metrics_collector.cc
[modify] https://crrev.com/255eda8fe05c786f1c70adb8cc8be03c792374b8/services/resource_coordinator/coordination_unit/metrics_collector.h
[modify] https://crrev.com/255eda8fe05c786f1c70adb8cc8be03c792374b8/tools/metrics/ukm/ukm.xml
Project Member

Comment 4 by bugdroid1@chromium.org, Aug 28 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e31b0b47faf7f774b7ad91d33b828218cc375c17

commit e31b0b47faf7f774b7ad91d33b828218cc375c17
Author: Peiyong Lin <lpy@chromium.org>
Date: Mon Aug 28 22:26:08 2017

[GRC] Add heuristics UKM and refactor MetricsCollector.

This patch:
1. adds heuristics UKM;
2. rafactors MetricsCollector to unify background tabs metrics report;
3. moved metrics report 5-minutes timeout logic to MetricsCollector;
4. adds more unit tests.

BUG= 731270 , 753486

Change-Id: Ica08674bf6b95d88f8de571ef025a7eaf58515d7
Reviewed-on: https://chromium-review.googlesource.com/627594
Reviewed-by: Chris Hamilton <chrisha@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Steven Holte <holte@chromium.org>
Commit-Queue: lpy <lpy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#497900}
[modify] https://crrev.com/e31b0b47faf7f774b7ad91d33b828218cc375c17/chrome/browser/resource_coordinator/resource_coordinator_web_contents_observer.cc
[modify] https://crrev.com/e31b0b47faf7f774b7ad91d33b828218cc375c17/chrome/browser/resource_coordinator/resource_coordinator_web_contents_observer.h
[modify] https://crrev.com/e31b0b47faf7f774b7ad91d33b828218cc375c17/services/resource_coordinator/BUILD.gn
[add] https://crrev.com/e31b0b47faf7f774b7ad91d33b828218cc375c17/services/resource_coordinator/coordination_unit/background_metrics_reporter.h
[modify] https://crrev.com/e31b0b47faf7f774b7ad91d33b828218cc375c17/services/resource_coordinator/coordination_unit/coordination_unit_impl.cc
[modify] https://crrev.com/e31b0b47faf7f774b7ad91d33b828218cc375c17/services/resource_coordinator/coordination_unit/coordination_unit_impl.h
[modify] https://crrev.com/e31b0b47faf7f774b7ad91d33b828218cc375c17/services/resource_coordinator/coordination_unit/metrics_collector.cc
[modify] https://crrev.com/e31b0b47faf7f774b7ad91d33b828218cc375c17/services/resource_coordinator/coordination_unit/metrics_collector.h
[modify] https://crrev.com/e31b0b47faf7f774b7ad91d33b828218cc375c17/services/resource_coordinator/coordination_unit/metrics_collector_unittest.cc
[modify] https://crrev.com/e31b0b47faf7f774b7ad91d33b828218cc375c17/services/resource_coordinator/public/interfaces/signals.mojom
[modify] https://crrev.com/e31b0b47faf7f774b7ad91d33b828218cc375c17/tools/metrics/ukm/ukm.xml
Project Member

Comment 5 by bugdroid1@chromium.org, Aug 29 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/882c1f822459b38b69332ad5370b1eff6d7e482c

commit 882c1f822459b38b69332ad5370b1eff6d7e482c
Author: Tarun Bansal <tbansal@chromium.org>
Date: Tue Aug 29 00:52:42 2017

Speculatively revert "[GRC] Add heuristics UKM and refactor MetricsCollector."

This reverts commit e31b0b47faf7f774b7ad91d33b828218cc375c17.

Reason for speculative revert:
Suspected for breaking tests in build:
https://uberchromegw.corp.google.com/i/chromium.win/builders/Win7%20Tests%20%28dbg%29%281%29/builds/62729


Original change's description:
> [GRC] Add heuristics UKM and refactor MetricsCollector.
> 
> This patch:
> 1. adds heuristics UKM;
> 2. rafactors MetricsCollector to unify background tabs metrics report;
> 3. moved metrics report 5-minutes timeout logic to MetricsCollector;
> 4. adds more unit tests.
> 
> BUG= 731270 , 753486
> 
> Change-Id: Ica08674bf6b95d88f8de571ef025a7eaf58515d7
> Reviewed-on: https://chromium-review.googlesource.com/627594
> Reviewed-by: Chris Hamilton <chrisha@chromium.org>
> Reviewed-by: Daniel Cheng <dcheng@chromium.org>
> Reviewed-by: Steven Holte <holte@chromium.org>
> Commit-Queue: lpy <lpy@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#497900}

TBR=dcheng@chromium.org,chrisha@chromium.org,holte@chromium.org,lpy@chromium.org

Change-Id: I40e09c00036adc133c5c4ab14e94aeea2bffe3e8
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug:  731270 , 753486, 759905
Reviewed-on: https://chromium-review.googlesource.com/639851
Reviewed-by: Tarun Bansal <tbansal@chromium.org>
Commit-Queue: Tarun Bansal <tbansal@chromium.org>
Cr-Commit-Position: refs/heads/master@{#497964}
[modify] https://crrev.com/882c1f822459b38b69332ad5370b1eff6d7e482c/chrome/browser/resource_coordinator/resource_coordinator_web_contents_observer.cc
[modify] https://crrev.com/882c1f822459b38b69332ad5370b1eff6d7e482c/chrome/browser/resource_coordinator/resource_coordinator_web_contents_observer.h
[modify] https://crrev.com/882c1f822459b38b69332ad5370b1eff6d7e482c/services/resource_coordinator/BUILD.gn
[delete] https://crrev.com/dfb14c872c50f0a3728422c6243e560963aa0d06/services/resource_coordinator/coordination_unit/background_metrics_reporter.h
[modify] https://crrev.com/882c1f822459b38b69332ad5370b1eff6d7e482c/services/resource_coordinator/coordination_unit/coordination_unit_impl.cc
[modify] https://crrev.com/882c1f822459b38b69332ad5370b1eff6d7e482c/services/resource_coordinator/coordination_unit/coordination_unit_impl.h
[modify] https://crrev.com/882c1f822459b38b69332ad5370b1eff6d7e482c/services/resource_coordinator/coordination_unit/metrics_collector.cc
[modify] https://crrev.com/882c1f822459b38b69332ad5370b1eff6d7e482c/services/resource_coordinator/coordination_unit/metrics_collector.h
[modify] https://crrev.com/882c1f822459b38b69332ad5370b1eff6d7e482c/services/resource_coordinator/coordination_unit/metrics_collector_unittest.cc
[modify] https://crrev.com/882c1f822459b38b69332ad5370b1eff6d7e482c/services/resource_coordinator/public/interfaces/signals.mojom
[modify] https://crrev.com/882c1f822459b38b69332ad5370b1eff6d7e482c/tools/metrics/ukm/ukm.xml
Project Member

Comment 6 by bugdroid1@chromium.org, Aug 30 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6bc2eb1c983d21de6899c44a0382104ca83a5010

commit 6bc2eb1c983d21de6899c44a0382104ca83a5010
Author: Peiyong Lin <lpy@chromium.org>
Date: Wed Aug 30 08:27:25 2017

Reland "[GRC] Add heuristics UKM and refactor MetricsCollector."

This is a reland of e31b0b47faf7f774b7ad91d33b828218cc375c17
Original change's description:

TBR=chrisha@chromium.org,dcheng@chromium.org,holte@chromium.org
> [GRC] Add heuristics UKM and refactor MetricsCollector.
> 
> This patch:
> 1. adds heuristics UKM;
> 2. rafactors MetricsCollector to unify background tabs metrics report;
> 3. moved metrics report 5-minutes timeout logic to MetricsCollector;
> 4. adds more unit tests.
> 
> BUG= 731270 , 753486
> 
> Change-Id: Ica08674bf6b95d88f8de571ef025a7eaf58515d7
> Reviewed-on: https://chromium-review.googlesource.com/627594
> Reviewed-by: Chris Hamilton <chrisha@chromium.org>
> Reviewed-by: Daniel Cheng <dcheng@chromium.org>
> Reviewed-by: Steven Holte <holte@chromium.org>
> Commit-Queue: lpy <lpy@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#497900}

Bug:  731270 , 753486
Change-Id: I43c99c0cdc7c7d3431f08fae86cb10d6d87d99fa
Reviewed-on: https://chromium-review.googlesource.com/640010
Reviewed-by: lpy <lpy@chromium.org>
Commit-Queue: lpy <lpy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#498395}
[modify] https://crrev.com/6bc2eb1c983d21de6899c44a0382104ca83a5010/chrome/browser/resource_coordinator/resource_coordinator_web_contents_observer.cc
[modify] https://crrev.com/6bc2eb1c983d21de6899c44a0382104ca83a5010/chrome/browser/resource_coordinator/resource_coordinator_web_contents_observer.h
[modify] https://crrev.com/6bc2eb1c983d21de6899c44a0382104ca83a5010/services/resource_coordinator/BUILD.gn
[add] https://crrev.com/6bc2eb1c983d21de6899c44a0382104ca83a5010/services/resource_coordinator/coordination_unit/background_metrics_reporter.h
[modify] https://crrev.com/6bc2eb1c983d21de6899c44a0382104ca83a5010/services/resource_coordinator/coordination_unit/coordination_unit_impl.cc
[modify] https://crrev.com/6bc2eb1c983d21de6899c44a0382104ca83a5010/services/resource_coordinator/coordination_unit/coordination_unit_impl.h
[modify] https://crrev.com/6bc2eb1c983d21de6899c44a0382104ca83a5010/services/resource_coordinator/coordination_unit/metrics_collector.cc
[modify] https://crrev.com/6bc2eb1c983d21de6899c44a0382104ca83a5010/services/resource_coordinator/coordination_unit/metrics_collector.h
[modify] https://crrev.com/6bc2eb1c983d21de6899c44a0382104ca83a5010/services/resource_coordinator/coordination_unit/metrics_collector_unittest.cc
[modify] https://crrev.com/6bc2eb1c983d21de6899c44a0382104ca83a5010/services/resource_coordinator/public/interfaces/signals.mojom
[modify] https://crrev.com/6bc2eb1c983d21de6899c44a0382104ca83a5010/tools/metrics/ukm/ukm.xml
Project Member

Comment 7 by bugdroid1@chromium.org, Aug 30 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8fceb00993ee141501b060988386e201207926fb

commit 8fceb00993ee141501b060988386e201207926fb
Author: Henrik Boström <hbos@chromium.org>
Date: Wed Aug 30 12:54:25 2017

Speculative revert, MetricsCollectorTest.FromBackgroundedToFirst* tests consistently fail on Win7 Tests (dbg)(1)

Revert "Reland "[GRC] Add heuristics UKM and refactor MetricsCollector.""

This reverts commit 6bc2eb1c983d21de6899c44a0382104ca83a5010.

Reason for revert: <INSERT REASONING HERE>

Original change's description:
> Reland "[GRC] Add heuristics UKM and refactor MetricsCollector."
> 
> This is a reland of e31b0b47faf7f774b7ad91d33b828218cc375c17
> Original change's description:
> 
> TBR=chrisha@chromium.org,dcheng@chromium.org,holte@chromium.org
> > [GRC] Add heuristics UKM and refactor MetricsCollector.
> > 
> > This patch:
> > 1. adds heuristics UKM;
> > 2. rafactors MetricsCollector to unify background tabs metrics report;
> > 3. moved metrics report 5-minutes timeout logic to MetricsCollector;
> > 4. adds more unit tests.
> > 
> > BUG= 731270 , 753486
> > 
> > Change-Id: Ica08674bf6b95d88f8de571ef025a7eaf58515d7
> > Reviewed-on: https://chromium-review.googlesource.com/627594
> > Reviewed-by: Chris Hamilton <chrisha@chromium.org>
> > Reviewed-by: Daniel Cheng <dcheng@chromium.org>
> > Reviewed-by: Steven Holte <holte@chromium.org>
> > Commit-Queue: lpy <lpy@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#497900}
> 
> Bug:  731270 , 753486
> Change-Id: I43c99c0cdc7c7d3431f08fae86cb10d6d87d99fa
> Reviewed-on: https://chromium-review.googlesource.com/640010
> Reviewed-by: lpy <lpy@chromium.org>
> Commit-Queue: lpy <lpy@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#498395}

TBR=dcheng@chromium.org,chrisha@chromium.org,holte@chromium.org,lpy@chromium.org

Change-Id: I33981ae07237f24005b2811fb5eca509e8068726
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug:  731270 , 753486
Reviewed-on: https://chromium-review.googlesource.com/643426
Reviewed-by: Henrik Boström <hbos@chromium.org>
Commit-Queue: Henrik Boström <hbos@chromium.org>
Cr-Commit-Position: refs/heads/master@{#498436}
[modify] https://crrev.com/8fceb00993ee141501b060988386e201207926fb/chrome/browser/resource_coordinator/resource_coordinator_web_contents_observer.cc
[modify] https://crrev.com/8fceb00993ee141501b060988386e201207926fb/chrome/browser/resource_coordinator/resource_coordinator_web_contents_observer.h
[modify] https://crrev.com/8fceb00993ee141501b060988386e201207926fb/services/resource_coordinator/BUILD.gn
[delete] https://crrev.com/19397b2658015dbe924370ae9fd999de615c268a/services/resource_coordinator/coordination_unit/background_metrics_reporter.h
[modify] https://crrev.com/8fceb00993ee141501b060988386e201207926fb/services/resource_coordinator/coordination_unit/coordination_unit_impl.cc
[modify] https://crrev.com/8fceb00993ee141501b060988386e201207926fb/services/resource_coordinator/coordination_unit/coordination_unit_impl.h
[modify] https://crrev.com/8fceb00993ee141501b060988386e201207926fb/services/resource_coordinator/coordination_unit/metrics_collector.cc
[modify] https://crrev.com/8fceb00993ee141501b060988386e201207926fb/services/resource_coordinator/coordination_unit/metrics_collector.h
[modify] https://crrev.com/8fceb00993ee141501b060988386e201207926fb/services/resource_coordinator/coordination_unit/metrics_collector_unittest.cc
[modify] https://crrev.com/8fceb00993ee141501b060988386e201207926fb/services/resource_coordinator/public/interfaces/signals.mojom
[modify] https://crrev.com/8fceb00993ee141501b060988386e201207926fb/tools/metrics/ukm/ukm.xml
Project Member

Comment 8 by bugdroid1@chromium.org, Aug 31 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f28e17610a74d58803586e7296b7bf5049619f87

commit f28e17610a74d58803586e7296b7bf5049619f87
Author: Peiyong Lin <lpy@chromium.org>
Date: Thu Aug 31 20:05:44 2017

Reland "Reland "[GRC] Add heuristics UKM and refactor MetricsCollector.""

This is a reland of 6bc2eb1c983d21de6899c44a0382104ca83a5010
Original change's description:
> Reland "[GRC] Add heuristics UKM and refactor MetricsCollector."
> 
> This is a reland of e31b0b47faf7f774b7ad91d33b828218cc375c17
> Original change's description:
> 
> TBR=chrisha@chromium.org,dcheng@chromium.org,holte@chromium.org
> > [GRC] Add heuristics UKM and refactor MetricsCollector.
> > 
> > This patch:
> > 1. adds heuristics UKM;
> > 2. rafactors MetricsCollector to unify background tabs metrics report;
> > 3. moved metrics report 5-minutes timeout logic to MetricsCollector;
> > 4. adds more unit tests.
> > 
> > BUG= 731270 , 753486
> > 
> > Change-Id: Ica08674bf6b95d88f8de571ef025a7eaf58515d7
> > Reviewed-on: https://chromium-review.googlesource.com/627594
> > Reviewed-by: Chris Hamilton <chrisha@chromium.org>
> > Reviewed-by: Daniel Cheng <dcheng@chromium.org>
> > Reviewed-by: Steven Holte <holte@chromium.org>
> > Commit-Queue: lpy <lpy@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#497900}
> 
> Bug:  731270 , 753486
> Change-Id: I43c99c0cdc7c7d3431f08fae86cb10d6d87d99fa
> Reviewed-on: https://chromium-review.googlesource.com/640010
> Reviewed-by: lpy <lpy@chromium.org>
> Commit-Queue: lpy <lpy@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#498395}

TBR=chrisha@chromium.org,dcheng@chromium.org,holte@chromium.org

Bug:  731270 , 753486
Change-Id: I65f2a5bc86e8ddd4af4b1739c306b6d1bc70b4b1
Reviewed-on: https://chromium-review.googlesource.com/643568
Commit-Queue: lpy <lpy@chromium.org>
Reviewed-by: lpy <lpy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#498965}
[modify] https://crrev.com/f28e17610a74d58803586e7296b7bf5049619f87/chrome/browser/resource_coordinator/resource_coordinator_web_contents_observer.cc
[modify] https://crrev.com/f28e17610a74d58803586e7296b7bf5049619f87/chrome/browser/resource_coordinator/resource_coordinator_web_contents_observer.h
[modify] https://crrev.com/f28e17610a74d58803586e7296b7bf5049619f87/services/resource_coordinator/BUILD.gn
[add] https://crrev.com/f28e17610a74d58803586e7296b7bf5049619f87/services/resource_coordinator/coordination_unit/background_metrics_reporter.h
[modify] https://crrev.com/f28e17610a74d58803586e7296b7bf5049619f87/services/resource_coordinator/coordination_unit/coordination_unit_impl.cc
[modify] https://crrev.com/f28e17610a74d58803586e7296b7bf5049619f87/services/resource_coordinator/coordination_unit/coordination_unit_impl.h
[modify] https://crrev.com/f28e17610a74d58803586e7296b7bf5049619f87/services/resource_coordinator/coordination_unit/metrics_collector.cc
[modify] https://crrev.com/f28e17610a74d58803586e7296b7bf5049619f87/services/resource_coordinator/coordination_unit/metrics_collector.h
[modify] https://crrev.com/f28e17610a74d58803586e7296b7bf5049619f87/services/resource_coordinator/coordination_unit/metrics_collector_unittest.cc
[modify] https://crrev.com/f28e17610a74d58803586e7296b7bf5049619f87/services/resource_coordinator/public/interfaces/signals.mojom
[modify] https://crrev.com/f28e17610a74d58803586e7296b7bf5049619f87/tools/metrics/ukm/ukm.xml
Project Member

Comment 9 by bugdroid1@chromium.org, Aug 31 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2f3be9b8cb16c72fcdb0b463af0be3b1b49151cb

commit 2f3be9b8cb16c72fcdb0b463af0be3b1b49151cb
Author: Mike Wittman <wittman@chromium.org>
Date: Thu Aug 31 22:23:56 2017

Revert "Reland "Reland "[GRC] Add heuristics UKM and refactor MetricsCollector."""

This reverts commit f28e17610a74d58803586e7296b7bf5049619f87.

Reason for revert: still fails on Win7 Debug

[ RUN      ] MetricsCollectorTest.FromBackgroundedToFirstNonPersistentNotificationCreatedUMA5MinutesTimeout
../../services/resource_coordinator/coordination_unit/metrics_collector_unittest.cc(33): error: Value of: metrics_collector_->ShouldReportMetrics( CoordinationUnitImpl::ToWebContentsCoordinationUnit(web_contents_cu))
  Actual: false
Expected: true
../../base/test/histogram_tester.cc(72): error:       Expected: count
      Which is: 1
To be equal to: 0
Histogram "TabManager.Heuristics.FromBackgroundedToFirstNonPersistentNotificationCreated" does not exist.
[  FAILED  ] MetricsCollectorTest.FromBackgroundedToFirstNonPersistentNotificationCreatedUMA5MinutesTimeout (2 ms)


Original change's description:
> Reland "Reland "[GRC] Add heuristics UKM and refactor MetricsCollector.""
> 
> This is a reland of 6bc2eb1c983d21de6899c44a0382104ca83a5010
> Original change's description:
> > Reland "[GRC] Add heuristics UKM and refactor MetricsCollector."
> > 
> > This is a reland of e31b0b47faf7f774b7ad91d33b828218cc375c17
> > Original change's description:
> > 
> > TBR=chrisha@chromium.org,dcheng@chromium.org,holte@chromium.org
> > > [GRC] Add heuristics UKM and refactor MetricsCollector.
> > > 
> > > This patch:
> > > 1. adds heuristics UKM;
> > > 2. rafactors MetricsCollector to unify background tabs metrics report;
> > > 3. moved metrics report 5-minutes timeout logic to MetricsCollector;
> > > 4. adds more unit tests.
> > > 
> > > BUG= 731270 , 753486
> > > 
> > > Change-Id: Ica08674bf6b95d88f8de571ef025a7eaf58515d7
> > > Reviewed-on: https://chromium-review.googlesource.com/627594
> > > Reviewed-by: Chris Hamilton <chrisha@chromium.org>
> > > Reviewed-by: Daniel Cheng <dcheng@chromium.org>
> > > Reviewed-by: Steven Holte <holte@chromium.org>
> > > Commit-Queue: lpy <lpy@chromium.org>
> > > Cr-Commit-Position: refs/heads/master@{#497900}
> > 
> > Bug:  731270 , 753486
> > Change-Id: I43c99c0cdc7c7d3431f08fae86cb10d6d87d99fa
> > Reviewed-on: https://chromium-review.googlesource.com/640010
> > Reviewed-by: lpy <lpy@chromium.org>
> > Commit-Queue: lpy <lpy@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#498395}
> 
> TBR=chrisha@chromium.org,dcheng@chromium.org,holte@chromium.org
> 
> Bug:  731270 , 753486
> Change-Id: I65f2a5bc86e8ddd4af4b1739c306b6d1bc70b4b1
> Reviewed-on: https://chromium-review.googlesource.com/643568
> Commit-Queue: lpy <lpy@chromium.org>
> Reviewed-by: lpy <lpy@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#498965}

TBR=dcheng@chromium.org,chrisha@chromium.org,holte@chromium.org,lpy@chromium.org

Change-Id: I2a125eef30d2186f3e3a962d053bfab8b0596569
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug:  731270 , 753486
Reviewed-on: https://chromium-review.googlesource.com/646532
Reviewed-by: Mike Wittman <wittman@chromium.org>
Commit-Queue: Mike Wittman <wittman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#499045}
[modify] https://crrev.com/2f3be9b8cb16c72fcdb0b463af0be3b1b49151cb/chrome/browser/resource_coordinator/resource_coordinator_web_contents_observer.cc
[modify] https://crrev.com/2f3be9b8cb16c72fcdb0b463af0be3b1b49151cb/chrome/browser/resource_coordinator/resource_coordinator_web_contents_observer.h
[modify] https://crrev.com/2f3be9b8cb16c72fcdb0b463af0be3b1b49151cb/services/resource_coordinator/BUILD.gn
[delete] https://crrev.com/e974d892054aaf5ed122d37329c25aaa1010a96f/services/resource_coordinator/coordination_unit/background_metrics_reporter.h
[modify] https://crrev.com/2f3be9b8cb16c72fcdb0b463af0be3b1b49151cb/services/resource_coordinator/coordination_unit/coordination_unit_impl.cc
[modify] https://crrev.com/2f3be9b8cb16c72fcdb0b463af0be3b1b49151cb/services/resource_coordinator/coordination_unit/coordination_unit_impl.h
[modify] https://crrev.com/2f3be9b8cb16c72fcdb0b463af0be3b1b49151cb/services/resource_coordinator/coordination_unit/metrics_collector.cc
[modify] https://crrev.com/2f3be9b8cb16c72fcdb0b463af0be3b1b49151cb/services/resource_coordinator/coordination_unit/metrics_collector.h
[modify] https://crrev.com/2f3be9b8cb16c72fcdb0b463af0be3b1b49151cb/services/resource_coordinator/coordination_unit/metrics_collector_unittest.cc
[modify] https://crrev.com/2f3be9b8cb16c72fcdb0b463af0be3b1b49151cb/services/resource_coordinator/public/interfaces/signals.mojom
[modify] https://crrev.com/2f3be9b8cb16c72fcdb0b463af0be3b1b49151cb/tools/metrics/ukm/ukm.xml
Project Member

Comment 10 by bugdroid1@chromium.org, Sep 1 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/85b2a0fca5a5721bd32d0dc71d703c9b700b6852

commit 85b2a0fca5a5721bd32d0dc71d703c9b700b6852
Author: Peiyong Lin <lpy@chromium.org>
Date: Fri Sep 01 07:29:11 2017

Reland: [GRC] Add heuristics UKM and refactor MetricsCollector.

This patch also disables MetricsCollectorTest on Windows because it
failed on Win 7 dbg.

This is a reland of f28e17610a74d58803586e7296b7bf5049619f87
Original change's description:
> Reland "Reland "[GRC] Add heuristics UKM and refactor MetricsCollector.""
> 
> This is a reland of 6bc2eb1c983d21de6899c44a0382104ca83a5010
> Original change's description:
> > Reland "[GRC] Add heuristics UKM and refactor MetricsCollector."
> > 
> > This is a reland of e31b0b47faf7f774b7ad91d33b828218cc375c17
> > Original change's description:
> > 
> > TBR=chrisha@chromium.org,dcheng@chromium.org,holte@chromium.org
> > > [GRC] Add heuristics UKM and refactor MetricsCollector.
> > > 
> > > This patch:
> > > 1. adds heuristics UKM;
> > > 2. rafactors MetricsCollector to unify background tabs metrics report;
> > > 3. moved metrics report 5-minutes timeout logic to MetricsCollector;
> > > 4. adds more unit tests.
> > > 
> > > BUG= 731270 , 753486
> > > 
> > > Change-Id: Ica08674bf6b95d88f8de571ef025a7eaf58515d7
> > > Reviewed-on: https://chromium-review.googlesource.com/627594
> > > Reviewed-by: Chris Hamilton <chrisha@chromium.org>
> > > Reviewed-by: Daniel Cheng <dcheng@chromium.org>
> > > Reviewed-by: Steven Holte <holte@chromium.org>
> > > Commit-Queue: lpy <lpy@chromium.org>
> > > Cr-Commit-Position: refs/heads/master@{#497900}
> > 
> > Bug:  731270 , 753486
> > Change-Id: I43c99c0cdc7c7d3431f08fae86cb10d6d87d99fa
> > Reviewed-on: https://chromium-review.googlesource.com/640010
> > Reviewed-by: lpy <lpy@chromium.org>
> > Commit-Queue: lpy <lpy@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#498395}
> 
> TBR=chrisha@chromium.org,dcheng@chromium.org,holte@chromium.org
> 
> Bug:  731270 , 753486
> Change-Id: I65f2a5bc86e8ddd4af4b1739c306b6d1bc70b4b1
> Reviewed-on: https://chromium-review.googlesource.com/643568
> Commit-Queue: lpy <lpy@chromium.org>
> Reviewed-by: lpy <lpy@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#498965}

TBR=chrisha@chromium.org,dcheng@chromium.org,holte@chromium.org

Bug:  731270 , 753486
Change-Id: I10d8a16821848c8896e054dad0185b368905dc6e
Reviewed-on: https://chromium-review.googlesource.com/646533
Reviewed-by: lpy <lpy@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Commit-Queue: lpy <lpy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#499148}
[modify] https://crrev.com/85b2a0fca5a5721bd32d0dc71d703c9b700b6852/chrome/browser/resource_coordinator/resource_coordinator_web_contents_observer.cc
[modify] https://crrev.com/85b2a0fca5a5721bd32d0dc71d703c9b700b6852/chrome/browser/resource_coordinator/resource_coordinator_web_contents_observer.h
[modify] https://crrev.com/85b2a0fca5a5721bd32d0dc71d703c9b700b6852/services/resource_coordinator/BUILD.gn
[add] https://crrev.com/85b2a0fca5a5721bd32d0dc71d703c9b700b6852/services/resource_coordinator/coordination_unit/background_metrics_reporter.h
[modify] https://crrev.com/85b2a0fca5a5721bd32d0dc71d703c9b700b6852/services/resource_coordinator/coordination_unit/coordination_unit_impl.cc
[modify] https://crrev.com/85b2a0fca5a5721bd32d0dc71d703c9b700b6852/services/resource_coordinator/coordination_unit/coordination_unit_impl.h
[modify] https://crrev.com/85b2a0fca5a5721bd32d0dc71d703c9b700b6852/services/resource_coordinator/coordination_unit/metrics_collector.cc
[modify] https://crrev.com/85b2a0fca5a5721bd32d0dc71d703c9b700b6852/services/resource_coordinator/coordination_unit/metrics_collector.h
[modify] https://crrev.com/85b2a0fca5a5721bd32d0dc71d703c9b700b6852/services/resource_coordinator/coordination_unit/metrics_collector_unittest.cc
[modify] https://crrev.com/85b2a0fca5a5721bd32d0dc71d703c9b700b6852/services/resource_coordinator/public/interfaces/signals.mojom
[modify] https://crrev.com/85b2a0fca5a5721bd32d0dc71d703c9b700b6852/tools/metrics/ukm/ukm.xml
Project Member

Comment 11 by bugdroid1@chromium.org, Sep 1 2017

Labels: merge-merged-3202
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6998dc25a9a954c33acb6d405a348af129da24f7

commit 6998dc25a9a954c33acb6d405a348af129da24f7
Author: Peiyong Lin <lpy@chromium.org>
Date: Fri Sep 01 18:16:21 2017

Reland: [GRC] Add heuristics UKM and refactor MetricsCollector.

This patch also disables MetricsCollectorTest on Windows because it
failed on Win 7 dbg.

This is a reland of f28e17610a74d58803586e7296b7bf5049619f87
Original change's description:
> Reland "Reland "[GRC] Add heuristics UKM and refactor MetricsCollector.""
> 
> This is a reland of 6bc2eb1c983d21de6899c44a0382104ca83a5010
> Original change's description:
> > Reland "[GRC] Add heuristics UKM and refactor MetricsCollector."
> > 
> > This is a reland of e31b0b47faf7f774b7ad91d33b828218cc375c17
> > Original change's description:
> > 
> > TBR=chrisha@chromium.org,dcheng@chromium.org,holte@chromium.org
> > > [GRC] Add heuristics UKM and refactor MetricsCollector.
> > > 
> > > This patch:
> > > 1. adds heuristics UKM;
> > > 2. rafactors MetricsCollector to unify background tabs metrics report;
> > > 3. moved metrics report 5-minutes timeout logic to MetricsCollector;
> > > 4. adds more unit tests.
> > > 
> > > BUG= 731270 , 753486
> > > 
> > > Change-Id: Ica08674bf6b95d88f8de571ef025a7eaf58515d7
> > > Reviewed-on: https://chromium-review.googlesource.com/627594
> > > Reviewed-by: Chris Hamilton <chrisha@chromium.org>
> > > Reviewed-by: Daniel Cheng <dcheng@chromium.org>
> > > Reviewed-by: Steven Holte <holte@chromium.org>
> > > Commit-Queue: lpy <lpy@chromium.org>
> > > Cr-Commit-Position: refs/heads/master@{#497900}
> > 
> > Bug:  731270 , 753486
> > Change-Id: I43c99c0cdc7c7d3431f08fae86cb10d6d87d99fa
> > Reviewed-on: https://chromium-review.googlesource.com/640010
> > Reviewed-by: lpy <lpy@chromium.org>
> > Commit-Queue: lpy <lpy@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#498395}
> 
> TBR=chrisha@chromium.org,dcheng@chromium.org,holte@chromium.org
> 
> Bug:  731270 , 753486
> Change-Id: I65f2a5bc86e8ddd4af4b1739c306b6d1bc70b4b1
> Reviewed-on: https://chromium-review.googlesource.com/643568
> Commit-Queue: lpy <lpy@chromium.org>
> Reviewed-by: lpy <lpy@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#498965}

TBR=chrisha@chromium.org,dcheng@chromium.org,holte@chromium.org

Bug:  731270 , 753486
Change-Id: I10d8a16821848c8896e054dad0185b368905dc6e
Reviewed-on: https://chromium-review.googlesource.com/646533
Reviewed-by: lpy <lpy@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Commit-Queue: lpy <lpy@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#499148}(cherry picked from commit 85b2a0fca5a5721bd32d0dc71d703c9b700b6852)
Reviewed-on: https://chromium-review.googlesource.com/648186
Cr-Commit-Position: refs/branch-heads/3202@{#7}
Cr-Branched-From: fa6a5d87adff761bc16afc5498c3f5944c1daa68-refs/heads/master@{#499098}
[modify] https://crrev.com/6998dc25a9a954c33acb6d405a348af129da24f7/chrome/browser/resource_coordinator/resource_coordinator_web_contents_observer.cc
[modify] https://crrev.com/6998dc25a9a954c33acb6d405a348af129da24f7/chrome/browser/resource_coordinator/resource_coordinator_web_contents_observer.h
[modify] https://crrev.com/6998dc25a9a954c33acb6d405a348af129da24f7/services/resource_coordinator/BUILD.gn
[add] https://crrev.com/6998dc25a9a954c33acb6d405a348af129da24f7/services/resource_coordinator/coordination_unit/background_metrics_reporter.h
[modify] https://crrev.com/6998dc25a9a954c33acb6d405a348af129da24f7/services/resource_coordinator/coordination_unit/coordination_unit_impl.cc
[modify] https://crrev.com/6998dc25a9a954c33acb6d405a348af129da24f7/services/resource_coordinator/coordination_unit/coordination_unit_impl.h
[modify] https://crrev.com/6998dc25a9a954c33acb6d405a348af129da24f7/services/resource_coordinator/coordination_unit/metrics_collector.cc
[modify] https://crrev.com/6998dc25a9a954c33acb6d405a348af129da24f7/services/resource_coordinator/coordination_unit/metrics_collector.h
[modify] https://crrev.com/6998dc25a9a954c33acb6d405a348af129da24f7/services/resource_coordinator/coordination_unit/metrics_collector_unittest.cc
[modify] https://crrev.com/6998dc25a9a954c33acb6d405a348af129da24f7/services/resource_coordinator/public/interfaces/signals.mojom
[modify] https://crrev.com/6998dc25a9a954c33acb6d405a348af129da24f7/tools/metrics/ukm/ukm.xml

Comment 12 by l...@chromium.org, Sep 5 2017

Labels: Merge-Request-62
Project Member

Comment 13 by sheriffbot@chromium.org, Sep 5 2017

Labels: -Merge-Request-62 Merge-Review-62 Hotlist-Merge-Review
This bug requires manual review: Reverts referenced in bugdroid comments after merge request.
Please contact the milestone owner if you have questions.
Owners: amineer@(Android), cmasso@(iOS), bhthompson@(ChromeOS), abdulsyed@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 14 by l...@chromium.org, Sep 5 2017

Labels: Hotlist-TooManyTabs

Comment 15 by abdulsyed@google.com, Sep 5 2017

Labels: -Merge-Review-62 Merge-Approved-62
Approving merge for M62. This was landed on Friday(branch day), and confirmed with lpy@ that it's well tested in Canary.
Project Member

Comment 16 by sheriffbot@chromium.org, Sep 11 2017

Cc: abdulsyed@google.com
This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible!

If all merges have been completed, please remove any remaining Merge-Approved labels from this issue.

Thanks for your time! To disable nags, add the Disable-Nags label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 17 by l...@chromium.org, Sep 11 2017

Labels: -Merge-Approved-62

Comment 18 by l...@chromium.org, Sep 11 2017

Labels: -Hotlist-Merge-Review
Project Member

Comment 19 by bugdroid1@chromium.org, Oct 5 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c10b27b49c452d8bd72bdbb9bb1a406bfeb3b919

commit c10b27b49c452d8bd72bdbb9bb1a406bfeb3b919
Author: Peiyong Lin <lpy@chromium.org>
Date: Thu Oct 05 17:08:31 2017

[TooManyTabs] Report UKM when background tab is closed or foregrounded.

Adds UKM to report the duration in millisecond from when a tab is backgrounded
to it is closed or foregrounded.

BUG=753486

Change-Id: I995b4002c80c1eb91f3ed36556e23c5b06183edf
Reviewed-on: https://chromium-review.googlesource.com/654144
Commit-Queue: lpy <lpy@chromium.org>
Reviewed-by: Chris Hamilton <chrisha@chromium.org>
Reviewed-by: Steven Holte <holte@chromium.org>
Cr-Commit-Position: refs/heads/master@{#506772}
[modify] https://crrev.com/c10b27b49c452d8bd72bdbb9bb1a406bfeb3b919/chrome/browser/resource_coordinator/tab_manager_web_contents_data.cc
[modify] https://crrev.com/c10b27b49c452d8bd72bdbb9bb1a406bfeb3b919/chrome/browser/resource_coordinator/tab_manager_web_contents_data.h
[modify] https://crrev.com/c10b27b49c452d8bd72bdbb9bb1a406bfeb3b919/tools/metrics/ukm/ukm.xml

Comment 20 by l...@chromium.org, Oct 17 2017

Status: Fixed (was: Started)
This implementation was done.

Comment 21 by chrisha@chromium.org, Oct 19 2017

Owner: chrisha@chromium.org
Status: Started (was: Fixed)
Reopening for one last metric that helps quantify impact of the discarding intervention. Related doc here (Google only): https://docs.google.com/document/d/17hJCMVvAekGTiBDOcNZS68MrGp2oQbEweZ8vWyiM31E/edit#

Comment 22 by chrisha@chromium.org, Oct 19 2017

Blockedon: 776376

Comment 23 by michae...@chromium.org, Dec 19 2017 

#21: That doc appears to be deleted. Is that the case, or is it just an authentication issue I'm having?

Comment 24 by michae...@chromium.org, Dec 19 2017

Blockedon: 791362

Comment 25 by chrisha@chromium.org, Dec 19 2017

Status: Fixed (was: Started)
Regarding comment #23 and the doc in comment #21: that is indeed a broken link. The correct link is here:

https://docs.google.com/document/d/1arevi5YW8wQesncon2iAVdE6skivEHFDZg5Kd-C7PJ4/edit

Comment 26 by chrisha@chromium.org, May 8 2018

Status: Started (was: Fixed)
Repurposing this bug for a couple new metrics related to lifecycle state transitions, for measuring the effectiveness of the feature. Described in this doc:

https://docs.google.com/document/d/1BNQ5nLOtPuwP7oxr9r-XKNKr5iObXEiA_69WXAvuYAo/edit#

Comment 27 by yitingc@chromium.org, May 15 2018 

UKM collection LGTM by privacy.
Project Member

Comment 28 by bugdroid1@chromium.org, May 22 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e0042c0f1b632e43b9f5343822bbdf1294fc6d1c

commit e0042c0f1b632e43b9f5343822bbdf1294fc6d1c
Author: Chris Hamilton <chrisha@chromium.org>
Date: Tue May 22 17:33:50 2018

Create TabManage lifecycle state change UKMs.

This will allow us to evaluate the performance of lifecycles,
determine how often and to which sites they occur, and allow analysis
of the reasons for which they fail most often

BUG=753486

Change-Id: I64884a3314f2170c5e14e5c13dd5a95e5d258a3e
Reviewed-on: https://chromium-review.googlesource.com/1062491
Commit-Queue: Chris Hamilton <chrisha@chromium.org>
Reviewed-by: Robert Kaplow <rkaplow@chromium.org>
Cr-Commit-Position: refs/heads/master@{#560679}
[modify] https://crrev.com/e0042c0f1b632e43b9f5343822bbdf1294fc6d1c/chrome/browser/resource_coordinator/lifecycle_state.h
[modify] https://crrev.com/e0042c0f1b632e43b9f5343822bbdf1294fc6d1c/tools/metrics/ukm/ukm.xml
Project Member

Comment 29 by bugdroid1@chromium.org, May 22 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f1b5912791c4240ebcb05326ba892d07ce99e1cd

commit f1b5912791c4240ebcb05326ba892d07ce99e1cd
Author: Chris Hamilton <chrisha@chromium.org>
Date: Tue May 22 21:05:31 2018

Create DecisionDetails class.

This will be used to encode detailed reasons describing decision taken by
the resource_coordinator policy engine. These will drive web UI and UKM
reporting.

BUG=753486

Change-Id: Iadf7620d75710ed36ce334cc5e4e116cd8ed6c0b
Reviewed-on: https://chromium-review.googlesource.com/1064700
Commit-Queue: Chris Hamilton <chrisha@chromium.org>
Reviewed-by: François Doray <fdoray@chromium.org>
Cr-Commit-Position: refs/heads/master@{#560774}
[modify] https://crrev.com/f1b5912791c4240ebcb05326ba892d07ce99e1cd/chrome/browser/BUILD.gn
[add] https://crrev.com/f1b5912791c4240ebcb05326ba892d07ce99e1cd/chrome/browser/resource_coordinator/decision_details.cc
[add] https://crrev.com/f1b5912791c4240ebcb05326ba892d07ce99e1cd/chrome/browser/resource_coordinator/decision_details.h
[add] https://crrev.com/f1b5912791c4240ebcb05326ba892d07ce99e1cd/chrome/browser/resource_coordinator/decision_details_unittest.cc
[modify] https://crrev.com/f1b5912791c4240ebcb05326ba892d07ce99e1cd/chrome/test/BUILD.gn
Project Member

Comment 30 by bugdroid1@chromium.org, May 30 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/acb6e591439e670b369f613c8dee92b2bf8f7895

commit acb6e591439e670b369f613c8dee92b2bf8f7895
Author: Chris Hamilton <chrisha@chromium.org>
Date: Wed May 30 17:55:45 2018

Add DecisionDetails to CanDiscard and CanFreeze.

This is a first step before using those details to log detailed
success/failure reasons.

BUG=753486

Change-Id: I19a197124b38ebc2bcabc6c438385a3bb3e5e64b
Reviewed-on: https://chromium-review.googlesource.com/1077343
Commit-Queue: Chris Hamilton <chrisha@chromium.org>
Reviewed-by: François Doray <fdoray@chromium.org>
Cr-Commit-Position: refs/heads/master@{#562904}
[modify] https://crrev.com/acb6e591439e670b369f613c8dee92b2bf8f7895/chrome/browser/resource_coordinator/decision_details.cc
[modify] https://crrev.com/acb6e591439e670b369f613c8dee92b2bf8f7895/chrome/browser/resource_coordinator/decision_details.h
[modify] https://crrev.com/acb6e591439e670b369f613c8dee92b2bf8f7895/chrome/browser/resource_coordinator/decision_details_unittest.cc
[modify] https://crrev.com/acb6e591439e670b369f613c8dee92b2bf8f7895/chrome/browser/resource_coordinator/lifecycle_unit.h
[modify] https://crrev.com/acb6e591439e670b369f613c8dee92b2bf8f7895/chrome/browser/resource_coordinator/tab_lifecycle_unit.cc
[modify] https://crrev.com/acb6e591439e670b369f613c8dee92b2bf8f7895/chrome/browser/resource_coordinator/tab_lifecycle_unit.h
[modify] https://crrev.com/acb6e591439e670b369f613c8dee92b2bf8f7895/chrome/browser/resource_coordinator/tab_lifecycle_unit_source_unittest.cc
[modify] https://crrev.com/acb6e591439e670b369f613c8dee92b2bf8f7895/chrome/browser/resource_coordinator/tab_lifecycle_unit_unittest.cc
[modify] https://crrev.com/acb6e591439e670b369f613c8dee92b2bf8f7895/chrome/browser/resource_coordinator/tab_manager.cc
[modify] https://crrev.com/acb6e591439e670b369f613c8dee92b2bf8f7895/chrome/browser/resource_coordinator/tab_manager_delegate_chromeos.cc
[modify] https://crrev.com/acb6e591439e670b369f613c8dee92b2bf8f7895/chrome/browser/resource_coordinator/test_lifecycle_unit.cc
[modify] https://crrev.com/acb6e591439e670b369f613c8dee92b2bf8f7895/chrome/browser/resource_coordinator/test_lifecycle_unit.h

Comment 31 by benhenry@chromium.org, Aug 2

Cc: -abdulsyed@google.com abdulsyed@chromium.org
►

Sign in to add a comment