New issue
Advanced search Search tips

Issue 753483 link

Starred by 4 users

Issue metadata

Status: Fixed
Owner:
Closed: Aug 13
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocking:
issue 563816



Sign in to add a comment

OffscreenCanvas should be able to be a source for WebGL.texImage2D

Project Member Reported by fs...@chromium.org, Aug 8 2017

Issue description

Right now, one needs to .transferToImageBitmap() to be able to render it.


 

Comment 1 by junov@chromium.org, Aug 24 2017

Status: Started (was: Assigned)

Comment 2 by junov@chromium.org, Aug 24 2017

Blocking: 563816
Project Member

Comment 3 by bugdroid1@chromium.org, Jul 25

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c931242dba631dfb1e2b63e84550e5859c07788d

commit c931242dba631dfb1e2b63e84550e5859c07788d
Author: Justin Novosad <junov@chromium.org>
Date: Wed Jul 25 15:08:03 2018

Code cleanup: HTMLCanvasElement::CopiedImage

This change removes the now useless copied reference that is
retained by HTMLCanvas.  This was useful back when the code used
SkBitmap, which did not have copy-on-write semantics.

BUG= 753483 
TBR=zmo@chromium.org

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_layout_tests_layout_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: Ibc047653cbe39f1a13f99f2f2fa16743ba1d3c05
Reviewed-on: https://chromium-review.googlesource.com/1148893
Commit-Queue: Justin Novosad <junov@chromium.org>
Reviewed-by: Stephen White <senorblanco@chromium.org>
Cr-Commit-Position: refs/heads/master@{#577891}
[modify] https://crrev.com/c931242dba631dfb1e2b63e84550e5859c07788d/third_party/blink/renderer/core/editing/editing_utilities.cc
[modify] https://crrev.com/c931242dba631dfb1e2b63e84550e5859c07788d/third_party/blink/renderer/core/html/canvas/html_canvas_element.cc
[modify] https://crrev.com/c931242dba631dfb1e2b63e84550e5859c07788d/third_party/blink/renderer/core/html/canvas/html_canvas_element.h
[modify] https://crrev.com/c931242dba631dfb1e2b63e84550e5859c07788d/third_party/blink/renderer/modules/canvas/canvas2d/canvas_rendering_context_2d_test.cc
[modify] https://crrev.com/c931242dba631dfb1e2b63e84550e5859c07788d/third_party/blink/renderer/modules/webgl/webgl_rendering_context_base.cc

Owner: fs...@chromium.org
Status: Assigned (was: Started)
fserb@:  You own this now.
I have written up a CL that implements this on top of ToT.  It compiles, but I have not had time to test and debug the issue.

The WIP CLs are here:
* chromium: https://chromium-review.googlesource.com/c/chromium/src/+/1150412
* WebGL conformance tests: https://github.com/KhronosGroup/WebGL/pull/2496
Project Member

Comment 5 by bugdroid1@chromium.org, Aug 13

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3882b0e88bf80436a45068651d3b4277612e33a0

commit 3882b0e88bf80436a45068651d3b4277612e33a0
Author: Fernando Serboncini <fserb@chromium.org>
Date: Mon Aug 13 15:57:27 2018

Make OffscreenCanvas usable as a source for texImage*

This CL refactors the existing code path for uploading canvas
element to a WebGL texture by generalizing it to work with
CanvasRenderingContextHost, which is a common base class
of HTMLCanvasElement and OffscreenCanvas

BUG= 753483 

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_layout_tests_slimming_paint_v2;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: I6c1cf783774ff8f8edc4604c10056ba57b0b9ae7
Reviewed-on: https://chromium-review.googlesource.com/1154988
Reviewed-by: Justin Novosad <junov@chromium.org>
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Commit-Queue: Fernando Serboncini <fserb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#582596}
[modify] https://crrev.com/3882b0e88bf80436a45068651d3b4277612e33a0/third_party/blink/renderer/core/html/canvas/canvas_rendering_context_host.h
[modify] https://crrev.com/3882b0e88bf80436a45068651d3b4277612e33a0/third_party/blink/renderer/core/html/canvas/html_canvas_element.h
[modify] https://crrev.com/3882b0e88bf80436a45068651d3b4277612e33a0/third_party/blink/renderer/core/offscreencanvas/offscreen_canvas.h
[modify] https://crrev.com/3882b0e88bf80436a45068651d3b4277612e33a0/third_party/blink/renderer/modules/webgl/webgl2_rendering_context_base.cc
[modify] https://crrev.com/3882b0e88bf80436a45068651d3b4277612e33a0/third_party/blink/renderer/modules/webgl/webgl2_rendering_context_base.h
[modify] https://crrev.com/3882b0e88bf80436a45068651d3b4277612e33a0/third_party/blink/renderer/modules/webgl/webgl_rendering_context_base.cc
[modify] https://crrev.com/3882b0e88bf80436a45068651d3b4277612e33a0/third_party/blink/renderer/modules/webgl/webgl_rendering_context_base.h
[modify] https://crrev.com/3882b0e88bf80436a45068651d3b4277612e33a0/third_party/blink/renderer/modules/webgl/webgl_rendering_context_base.idl
[modify] https://crrev.com/3882b0e88bf80436a45068651d3b4277612e33a0/third_party/blink/renderer/platform/graphics/canvas_2d_layer_bridge.cc

Status: Fixed (was: Assigned)
Project Member

Comment 7 by bugdroid1@chromium.org, Aug 14

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1548e78606431c60ad243b1a78847e41753cdf14

commit 1548e78606431c60ad243b1a78847e41753cdf14
Author: Fernando Serboncini <fserb@chromium.org>
Date: Tue Aug 14 22:08:31 2018

Unite Canvas and OffscreenCanvas snapshot for webgl texImage

TBR=kbr@chromium.org

Bug:  753483 ,  873914 
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_layout_tests_slimming_paint_v2;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: I958694f9db571b66c40baf144025d87acf824dc2
Reviewed-on: https://chromium-review.googlesource.com/1173169
Commit-Queue: Fernando Serboncini <fserb@chromium.org>
Reviewed-by: Fernando Serboncini <fserb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#583050}
[modify] https://crrev.com/1548e78606431c60ad243b1a78847e41753cdf14/third_party/blink/renderer/core/html/canvas/canvas_rendering_context_host.cc
[modify] https://crrev.com/1548e78606431c60ad243b1a78847e41753cdf14/third_party/blink/renderer/core/html/canvas/canvas_rendering_context_host.h
[modify] https://crrev.com/1548e78606431c60ad243b1a78847e41753cdf14/third_party/blink/renderer/core/html/canvas/html_canvas_element.cc
[modify] https://crrev.com/1548e78606431c60ad243b1a78847e41753cdf14/third_party/blink/renderer/core/html/canvas/html_canvas_element.h
[modify] https://crrev.com/1548e78606431c60ad243b1a78847e41753cdf14/third_party/blink/renderer/modules/webgl/webgl_rendering_context_base.cc
[modify] https://crrev.com/1548e78606431c60ad243b1a78847e41753cdf14/third_party/blink/renderer/modules/webgl/webgl_rendering_context_base.h
[modify] https://crrev.com/1548e78606431c60ad243b1a78847e41753cdf14/third_party/blink/renderer/platform/graphics/canvas_2d_layer_bridge.cc
[modify] https://crrev.com/1548e78606431c60ad243b1a78847e41753cdf14/third_party/blink/renderer/platform/graphics/canvas_resource_host.h
[modify] https://crrev.com/1548e78606431c60ad243b1a78847e41753cdf14/third_party/blink/renderer/platform/graphics/static_bitmap_image.h
[modify] https://crrev.com/1548e78606431c60ad243b1a78847e41753cdf14/third_party/blink/renderer/platform/graphics/test/fake_canvas_resource_host.h

Sign in to add a comment