The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7766be4786a8f69b703c1005047f6a17b06268ad

commit 7766be4786a8f69b703c1005047f6a17b06268ad
Author: Ben Chan <benchan@chromium.org>
Date: Wed Aug 16 01:53:56 2017

Mention SIM unlock retry count only when it's available.

shill exposes an optional field 'RetriesLeft' in the
Cellular.SIMLockStatus device property to report the number of remaining
unlock attempts for a particular SIM lock. The information isn't always
available as cellular devices don't always provide such information. When
the information isn't available, the SIM unlock UI currently mentions
'Retries left: 0' in the error message for a failed unlock attempt.
That's misleading and confusing to users. This CL changes the SIM unlock
UI to mention about the remaining retries left only when the information
is available.

BUG= 753470 
TEST=Tested the following:
- Unlock a SIM with the wrong PIN.
- Verify that the SIM unlock UI mentions 'Retries left' in the
  error message only when shill includes 'RetriesLeft' in the
  'Cellular.SIMLockStatus' device property.

Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I7bfa805334540b7c74839520f7d08800050cd6ae
Reviewed-on: https://chromium-review.googlesource.com/614808
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Commit-Queue: Ben Chan <benchan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#494662}
[modify] https://crrev.com/7766be4786a8f69b703c1005047f6a17b06268ad/chrome/browser/resources/settings/internet_page/network_siminfo.js

The following revision refers to this bug:
  https://chromium.googlesource.com/aosp/platform/system/connectivity/shill/+/accb2dd87b06b023ca88a08badd6edf825115972

commit accb2dd87b06b023ca88a08badd6edf825115972
Author: Ben Chan <benchan@chromium.org>
Date: Thu Aug 17 08:56:56 2017

shill: cellular: turn Cellular.SIMLockStatus.RetriesLeft into int32

Chrome converts shill properties into base::Value. Due to the lack of
uint32 support in base::Value, a shill property of type uint32 is held
as a double in base::Value, which often requires special handling on the
Chrome side to convert back and forth between double and uint32. That
incurs unnecessary complexity and makes code more error-prone.

This CL turns the 'RetriesLeft' field in the 'Cellular.SIMLockStatus'
device property from an uint32 value to an int32 value, which simplifies
the handling on the Chrome side.

BUG= chromium:753470 
TEST=Run unit tests.
TEST=Manually perform SIM unlock from the Chrome settings UI and observe
the Cellular.SIMLockStatus property reported in chrome://network.

Change-Id: I8f368ea4e1a094018fc5bbca19e6fbc328646c28
Reviewed-on: https://chromium-review.googlesource.com/615729
Commit-Ready: Ben Chan <benchan@chromium.org>
Tested-by: Ben Chan <benchan@chromium.org>
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>

[modify] https://crrev.com/accb2dd87b06b023ca88a08badd6edf825115972/cellular/cellular_capability_gsm.cc
[modify] https://crrev.com/accb2dd87b06b023ca88a08badd6edf825115972/doc/device-api.txt
[modify] https://crrev.com/accb2dd87b06b023ca88a08badd6edf825115972/cellular/cellular_capability_universal.cc
[modify] https://crrev.com/accb2dd87b06b023ca88a08badd6edf825115972/cellular/cellular_capability_universal.h
[modify] https://crrev.com/accb2dd87b06b023ca88a08badd6edf825115972/cellular/cellular_capability_gsm_unittest.cc
[modify] https://crrev.com/accb2dd87b06b023ca88a08badd6edf825115972/cellular/cellular_capability_universal_unittest.cc

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0cd3fae82c1cfe1b39b6dcbcc3b1d6af231b5344

commit 0cd3fae82c1cfe1b39b6dcbcc3b1d6af231b5344
Author: Ben Chan <benchan@chromium.org>
Date: Thu Aug 17 18:47:49 2017

Treat Cellular.SIMLockStatus.RetriesLeft property as int32.

shill has changed the Cellular.SIMLockStatus.RetriesLeft property from
an uint32 value to an int32 value (CL:615729). This CL updates Chrome
code to treat the property as int32.

BUG= 753470 
TEST=Manually perform SIM unlock from the Chrome settings UI and observe
the Cellular.SIMLockStatus property reported in chrome://network.

Change-Id: Id490886f56df146805aa23d2965a7a1293601b36
Reviewed-on: https://chromium-review.googlesource.com/615758
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Commit-Queue: Ben Chan <benchan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#495254}
[modify] https://crrev.com/0cd3fae82c1cfe1b39b6dcbcc3b1d6af231b5344/chromeos/network/device_state.cc
[modify] https://crrev.com/0cd3fae82c1cfe1b39b6dcbcc3b1d6af231b5344/chromeos/network/device_state.h