New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 753462 link

Starred by 1 user
Status: Fixed
Owner:
ericrk@chromium.org
Closed: Nov 2017
Cc:
█ bsalomon@chromium.org
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 2
Type: Bug



Sign in to add a comment

Additional changes to Skia GPU dither require rebaseline of 3 layout tests

Project Member Reported by ericrk@chromium.org, Aug 8 2017 
Same as  crbug.com/745776 , but for a new dither update.

The following images are expected to change:

virtual/gpu/fast/canvas/canvas-text-alignment.html
virtual/gpu/fast/canvas/fillrect_gradient.html
virtual/gpu/fast/canvas/gradient-add-second-start-end-stop.html
Project Member

Comment 1 by bugdroid1@chromium.org, Aug 9 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/50a82a287458dc945b2991598f3e9ca345c9b382

commit 50a82a287458dc945b2991598f3e9ca345c9b382
Author: Eric Karl <ericrk@chromium.org>
Date: Wed Aug 09 01:04:20 2017

Mark layout tests for rebaseline after Skia GPU dither change

Bug:  753462 
Change-Id: If91bc4f7837c0b54fd30479f0e70f4afec093f30
Reviewed-on: https://chromium-review.googlesource.com/606778
Reviewed-by: Brian Salomon <bsalomon@chromium.org>
Commit-Queue: Eric Karl <ericrk@chromium.org>
Cr-Commit-Position: refs/heads/master@{#492795}
[modify] https://crrev.com/50a82a287458dc945b2991598f3e9ca345c9b382/third_party/WebKit/LayoutTests/TestExpectations
Project Member

Comment 2 by bugdroid1@chromium.org, Sep 7 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/cac8792bec871ef25a3649c0e43eb23fd5c00c0d

commit cac8792bec871ef25a3649c0e43eb23fd5c00c0d
Author: Eric Karl <ericrk@chromium.org>
Date: Thu Sep 07 00:03:18 2017

Rebaseline layout tests for dither changes

Moved from a random-noise dither to a 4x4 dither.

Bug:  753462 
Change-Id: I68665c2b01f31881c6d42a1e96bb0ef83d8c893f
Reviewed-on: https://chromium-review.googlesource.com/620126
Commit-Queue: Eric Karl <ericrk@chromium.org>
Reviewed-by: Brian Salomon <bsalomon@chromium.org>
Cr-Commit-Position: refs/heads/master@{#500147}
[modify] https://crrev.com/cac8792bec871ef25a3649c0e43eb23fd5c00c0d/third_party/WebKit/LayoutTests/TestExpectations
[modify] https://crrev.com/cac8792bec871ef25a3649c0e43eb23fd5c00c0d/third_party/WebKit/LayoutTests/platform/linux/virtual/gpu/fast/canvas/canvas-text-alignment-expected.png
[modify] https://crrev.com/cac8792bec871ef25a3649c0e43eb23fd5c00c0d/third_party/WebKit/LayoutTests/platform/linux/virtual/gpu/fast/canvas/fillrect_gradient-expected.png
[modify] https://crrev.com/cac8792bec871ef25a3649c0e43eb23fd5c00c0d/third_party/WebKit/LayoutTests/platform/mac/virtual/gpu/fast/canvas/canvas-text-alignment-expected.png
[modify] https://crrev.com/cac8792bec871ef25a3649c0e43eb23fd5c00c0d/third_party/WebKit/LayoutTests/platform/mac/virtual/gpu/fast/canvas/fillrect_gradient-expected.png
[modify] https://crrev.com/cac8792bec871ef25a3649c0e43eb23fd5c00c0d/third_party/WebKit/LayoutTests/platform/win/virtual/gpu/fast/canvas/canvas-text-alignment-expected.png
[modify] https://crrev.com/cac8792bec871ef25a3649c0e43eb23fd5c00c0d/third_party/WebKit/LayoutTests/platform/win/virtual/gpu/fast/canvas/fillrect_gradient-expected.png
[modify] https://crrev.com/cac8792bec871ef25a3649c0e43eb23fd5c00c0d/third_party/WebKit/LayoutTests/virtual/gpu/fast/canvas/gradient-add-second-start-end-stop-expected.png

Comment 3 by ericrk@chromium.org, Nov 9 2017

Status: Fixed (was: Started)
►

Sign in to add a comment