Experiment with using transport RTT when computing HTTP RTT estimate |
|||||||||||
Issue descriptionTransport RTT samples are received more frequently than HTTP RTT estimates. In some cases, transport RTT may serve as an early signal of change in the network quality compared to HTTP RTT. We should experiment with using HTTP RTT as a signal for computing the HTTP RTT estimate.
,
Aug 18 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/1337e8acbbbdae695def65acbd7b2209d35aa3fa commit 1337e8acbbbdae695def65acbd7b2209d35aa3fa Author: Tarun Bansal <tbansal@chromium.org> Date: Fri Aug 18 03:57:00 2017 Update field trial params for Network Quality Estimator (NQE). The existing params in the json file are already hard-coded in Chromium, and are no longer needed. Bug: 636090, 753436 Change-Id: Id02bb2e4de06265475937a7e66a3f658d1f98ad0 Reviewed-on: https://chromium-review.googlesource.com/620267 Reviewed-by: Steven Holte <holte@chromium.org> Commit-Queue: Tarun Bansal <tbansal@chromium.org> Cr-Commit-Position: refs/heads/master@{#495456} [modify] https://crrev.com/1337e8acbbbdae695def65acbd7b2209d35aa3fa/testing/variations/fieldtrial_testing_config.json
,
Sep 6 2017
,
Sep 14 2017
,
Nov 9 2017
,
Nov 11 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e19ff26cb85f7ca3fee9205d9ea458e77aa190b7 commit e19ff26cb85f7ca3fee9205d9ea458e77aa190b7 Author: Tarun Bansal <tbansal@chromium.org> Date: Sat Nov 11 00:29:51 2017 Expose the count of RTT observations available when ECT was last computed In the next CL, the transport RTT estimate would be used to clamp the HTTP RTT estimate only if the number of transport RTT observations were more than a certain threshold. Bug: 753436 Cq-Include-Trybots: master.tryserver.chromium.android:android_cronet_tester;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I84d92726b916b3fa1340aa713d5b001c97396830 Reviewed-on: https://chromium-review.googlesource.com/760877 Reviewed-by: Ryan Sturm <ryansturm@chromium.org> Commit-Queue: Tarun Bansal <tbansal@chromium.org> Cr-Commit-Position: refs/heads/master@{#515759} [modify] https://crrev.com/e19ff26cb85f7ca3fee9205d9ea458e77aa190b7/net/nqe/network_quality_estimator.cc [modify] https://crrev.com/e19ff26cb85f7ca3fee9205d9ea458e77aa190b7/net/nqe/network_quality_estimator.h [modify] https://crrev.com/e19ff26cb85f7ca3fee9205d9ea458e77aa190b7/net/nqe/network_quality_estimator_test_util.cc [modify] https://crrev.com/e19ff26cb85f7ca3fee9205d9ea458e77aa190b7/net/nqe/network_quality_estimator_test_util.h [modify] https://crrev.com/e19ff26cb85f7ca3fee9205d9ea458e77aa190b7/net/nqe/network_quality_estimator_unittest.cc [modify] https://crrev.com/e19ff26cb85f7ca3fee9205d9ea458e77aa190b7/net/nqe/observation_buffer.cc [modify] https://crrev.com/e19ff26cb85f7ca3fee9205d9ea458e77aa190b7/net/nqe/observation_buffer.h [modify] https://crrev.com/e19ff26cb85f7ca3fee9205d9ea458e77aa190b7/net/nqe/observation_buffer_unittest.cc
,
Nov 13 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d7b4c626b738de6e8724ece8df2b6fe34559ae3f commit d7b4c626b738de6e8724ece8df2b6fe34559ae3f Author: Tarun Bansal <tbansal@chromium.org> Date: Mon Nov 13 22:07:22 2017 Clamp HTTP RTT only when enough transport RTT observations are present Cq-Include-Trybots: master.tryserver.chromium.android:android_cronet_tester;master.tryserver.chromium.mac:ios-simulator-cronet Bug: 753436 Change-Id: I10a88bac9831ed86251af6e78185bf5a5d6bdf2b Reviewed-on: https://chromium-review.googlesource.com/764964 Reviewed-by: Ryan Sturm <ryansturm@chromium.org> Commit-Queue: Tarun Bansal <tbansal@chromium.org> Cr-Commit-Position: refs/heads/master@{#516072} [modify] https://crrev.com/d7b4c626b738de6e8724ece8df2b6fe34559ae3f/net/nqe/network_quality_estimator.cc [modify] https://crrev.com/d7b4c626b738de6e8724ece8df2b6fe34559ae3f/net/nqe/network_quality_estimator_params.cc [modify] https://crrev.com/d7b4c626b738de6e8724ece8df2b6fe34559ae3f/net/nqe/network_quality_estimator_params.h [modify] https://crrev.com/d7b4c626b738de6e8724ece8df2b6fe34559ae3f/net/nqe/network_quality_estimator_test_util.cc [modify] https://crrev.com/d7b4c626b738de6e8724ece8df2b6fe34559ae3f/net/nqe/network_quality_estimator_test_util.h [modify] https://crrev.com/d7b4c626b738de6e8724ece8df2b6fe34559ae3f/net/nqe/network_quality_estimator_unittest.cc
,
Jan 3 2018
Refreshed during triage.
,
Jan 10 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/1b1ef37d82680fcc4c4a033dd52104659a75f50f commit 1b1ef37d82680fcc4c4a033dd52104659a75f50f Author: Tarun Bansal <tbansal@chromium.org> Date: Wed Jan 10 18:00:06 2018 Use transport RTT as a lower bound for HTTP RTT. In network quality estimator, use the transport RTT as a lower bound for the HTTP RTT. Cq-Include-Trybots: master.tryserver.chromium.android:android_cronet_tester Bug: 753436 Change-Id: Iec080cb49429436cdac8870ee3c1711faa933a09 Reviewed-on: https://chromium-review.googlesource.com/858295 Reviewed-by: Ryan Sturm <ryansturm@chromium.org> Commit-Queue: Tarun Bansal <tbansal@chromium.org> Cr-Commit-Position: refs/heads/master@{#528352} [modify] https://crrev.com/1b1ef37d82680fcc4c4a033dd52104659a75f50f/net/nqe/network_quality_estimator.cc [modify] https://crrev.com/1b1ef37d82680fcc4c4a033dd52104659a75f50f/net/nqe/network_quality_estimator_params.cc [modify] https://crrev.com/1b1ef37d82680fcc4c4a033dd52104659a75f50f/net/nqe/network_quality_estimator_unittest.cc
,
Feb 28 2018
Refreshed during triage.
,
Feb 28 2018
,
Mar 2 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f67b3e7374d8a55ec0330639788dd76ba7ee6b6f commit f67b3e7374d8a55ec0330639788dd76ba7ee6b6f Author: Tarun Bansal <tbansal@chromium.org> Date: Fri Mar 02 06:10:33 2018 NQE: Enable the heuristics for detecting hanging requests In network quality estimator (NQE), enable the heuristical algorithm for detecting hanging GETs. Also, enables the algorithm for detecting hanging throughput observation windows. Bug: 753436 Change-Id: Ic600037e72936adb5eea9881df014bd17aca0021 Reviewed-on: https://chromium-review.googlesource.com/939261 Commit-Queue: Tarun Bansal <tbansal@chromium.org> Reviewed-by: Ryan Sturm <ryansturm@chromium.org> Cr-Commit-Position: refs/heads/master@{#540461} [modify] https://crrev.com/f67b3e7374d8a55ec0330639788dd76ba7ee6b6f/net/nqe/network_quality_estimator.cc [modify] https://crrev.com/f67b3e7374d8a55ec0330639788dd76ba7ee6b6f/net/nqe/network_quality_estimator_params.cc [modify] https://crrev.com/f67b3e7374d8a55ec0330639788dd76ba7ee6b6f/net/nqe/network_quality_estimator_params.h [modify] https://crrev.com/f67b3e7374d8a55ec0330639788dd76ba7ee6b6f/net/nqe/network_quality_estimator_unittest.cc [modify] https://crrev.com/f67b3e7374d8a55ec0330639788dd76ba7ee6b6f/net/nqe/throughput_analyzer.cc [modify] https://crrev.com/f67b3e7374d8a55ec0330639788dd76ba7ee6b6f/net/nqe/throughput_analyzer_unittest.cc
,
Mar 5 2018
Requesting merge approval for CL in c#12 above.
,
Mar 6 2018
Your change meets the bar and is auto-approved for M66. Please go ahead and merge the CL to branch 3359 manually. Please contact milestone owner if you have questions. Owners: cmasso@(Android), cmasso@(iOS), josafat@(ChromeOS), abdulsyed@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Mar 6 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f61b035dc9a41f8936e39a3394f5242d66a6745f commit f61b035dc9a41f8936e39a3394f5242d66a6745f Author: Tarun Bansal <tbansal@chromium.org> Date: Tue Mar 06 23:27:26 2018 NQE: Enable the heuristics for detecting hanging requests In network quality estimator (NQE), enable the heuristical algorithm for detecting hanging GETs. Also, enables the algorithm for detecting hanging throughput observation windows. Bug: 753436 Change-Id: Ic600037e72936adb5eea9881df014bd17aca0021 Reviewed-on: https://chromium-review.googlesource.com/939261 Commit-Queue: Tarun Bansal <tbansal@chromium.org> Reviewed-by: Ryan Sturm <ryansturm@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#540461}(cherry picked from commit f67b3e7374d8a55ec0330639788dd76ba7ee6b6f) Reviewed-on: https://chromium-review.googlesource.com/952422 Reviewed-by: Tarun Bansal <tbansal@chromium.org> Cr-Commit-Position: refs/branch-heads/3359@{#44} Cr-Branched-From: 66afc5e5d10127546cc4b98b9117aff588b5e66b-refs/heads/master@{#540276} [modify] https://crrev.com/f61b035dc9a41f8936e39a3394f5242d66a6745f/net/nqe/network_quality_estimator.cc [modify] https://crrev.com/f61b035dc9a41f8936e39a3394f5242d66a6745f/net/nqe/network_quality_estimator_params.cc [modify] https://crrev.com/f61b035dc9a41f8936e39a3394f5242d66a6745f/net/nqe/network_quality_estimator_params.h [modify] https://crrev.com/f61b035dc9a41f8936e39a3394f5242d66a6745f/net/nqe/network_quality_estimator_unittest.cc [modify] https://crrev.com/f61b035dc9a41f8936e39a3394f5242d66a6745f/net/nqe/throughput_analyzer.cc [modify] https://crrev.com/f61b035dc9a41f8936e39a3394f5242d66a6745f/net/nqe/throughput_analyzer_unittest.cc
,
Apr 16 2018
,
Apr 16 2018
,
Apr 16 2018
|
|||||||||||
►
Sign in to add a comment |
|||||||||||
Comment 1 by bugdroid1@chromium.org
, Aug 8 2017