Smartlock dialog box should appear centered under user pod |
|||||
Issue descriptionOn Sign-In screen for users with smartlock enabled and bluetooth disabled, a dialog appears below and to the left of the user pod. This dialog should appear underneath the user pod and be the same width as the "password incorrect" dialog.
,
Aug 8 2017
Filed crbug/753442
,
Aug 10 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/4b1b41347f0afe0abf358c1c1237ff563132b571 commit 4b1b41347f0afe0abf358c1c1237ff563132b571 Author: Wenzhao Zang <wzang@chromium.org> Date: Thu Aug 10 05:22:18 2017 Adjust smart lock bubble position and PIN keyboard ripple size In response to the second round of UI review: 1) Refactor the codes to reuse the error bubble codes for smart lock bubble. 2) Adjust PIN keyboard ripple size and color. Bug: 753429 , 753426 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I7f48b52b3cf66d150b227e6ff6d2f01f7ca80710 Reviewed-on: https://chromium-review.googlesource.com/607713 Commit-Queue: Wenzhao (Colin) Zang <wzang@chromium.org> Reviewed-by: Alexander Alekseev <alemate@chromium.org> Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#493261} [modify] https://crrev.com/4b1b41347f0afe0abf358c1c1237ff563132b571/chrome/browser/resources/chromeos/quick_unlock/md_pin_keyboard.html [modify] https://crrev.com/4b1b41347f0afe0abf358c1c1237ff563132b571/ui/login/account_picker/md_screen_account_picker.js [modify] https://crrev.com/4b1b41347f0afe0abf358c1c1237ff563132b571/ui/login/account_picker/md_user_pod_row.js
,
Aug 10 2017
,
Aug 10 2017
Approving merge to M61 Chrome OS.
,
Aug 10 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/3d8444b4839743cb1a510fb102e23b61200d8f73 commit 3d8444b4839743cb1a510fb102e23b61200d8f73 Author: Wenzhao Zang <wzang@chromium.org> Date: Thu Aug 10 18:53:58 2017 Adjust smart lock bubble position and PIN keyboard ripple size In response to the second round of UI review: 1) Refactor the codes to reuse the error bubble codes for smart lock bubble. 2) Adjust PIN keyboard ripple size and color. TBR=wzang@chromium.org (cherry picked from commit 4b1b41347f0afe0abf358c1c1237ff563132b571) Bug: 753429 , 753426 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I7f48b52b3cf66d150b227e6ff6d2f01f7ca80710 Reviewed-on: https://chromium-review.googlesource.com/607713 Commit-Queue: Wenzhao (Colin) Zang <wzang@chromium.org> Reviewed-by: Alexander Alekseev <alemate@chromium.org> Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#493261} Reviewed-on: https://chromium-review.googlesource.com/610935 Reviewed-by: Wenzhao (Colin) Zang <wzang@chromium.org> Cr-Commit-Position: refs/branch-heads/3163@{#449} Cr-Branched-From: ff259bab28b35d242e10186cd63af7ed404fae0d-refs/heads/master@{#488528} [modify] https://crrev.com/3d8444b4839743cb1a510fb102e23b61200d8f73/chrome/browser/resources/chromeos/quick_unlock/md_pin_keyboard.html [modify] https://crrev.com/3d8444b4839743cb1a510fb102e23b61200d8f73/ui/login/account_picker/md_screen_account_picker.js [modify] https://crrev.com/3d8444b4839743cb1a510fb102e23b61200d8f73/ui/login/account_picker/md_user_pod_row.js
,
Jan 22 2018
|
|||||
►
Sign in to add a comment |
|||||
Comment 1 by wzang@chromium.org
, Aug 8 2017