New issue
Advanced search Search tips

Issue 753425 link

Starred by 0 users
Status: Available
Owner: ----
Cc:
tandrii@chromium.org
iannu...@google.com
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: ----



Sign in to add a comment

All depot_tools git footer manipulation should use git-interpret-trailers

Project Member Reported by aga...@chromium.org, Aug 8 2017 
We have lots of custom logic for manipulating what we call "git footers". Some of this is for Bug: and TBR lines, some is for commit positions, some is for PRESUBMIT.

All of it should be updated to simply rely on Git's built-in support for trailers:
https://git-scm.com/docs/git-interpret-trailers

This will also natively increase compatibility with Gerrit/JGit.

No need to continue reinventing the wheel.

Comment 1 by tandrii@chromium.org, Aug 8 2017 

I'm in favor with 1 reservation: git trailers allow configuring lots of parameters, most dangerous of them all is trailer.separators. What I worry is that we switch to git trailers and then somebody decides to 
$ git config trailer.separators "="
in all the repos, and then we might end inadvertently support re-spreading of R= and BUG= :(

Comment 2 by aga...@chromium.org, Aug 8 2017 

We're pretty accustomed to overriding git configuration (e.g. user.email) with the environment; I hope/suspect we can do the same here.
Project Member

Comment 3 by sheriffbot@chromium.org, Aug 9

Labels: Hotlist-Recharge-Cold
Status: Untriaged (was: Available)
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue.

Sorry for the inconvenience if the bug really should have been left as Available.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 4 by iannu...@google.com, Oct 18

Cc: -iannucci@chromium.org iannu...@google.com

Comment 5 by ehmaldonado@chromium.org, Jan 10

Labels: Pri-3
Status: Available (was: Untriaged)
►

Sign in to add a comment