Issue metadata
Sign in to add a comment
|
Reviewer suggestion dialog suggests the CQ bot |
||||||||||||||||||||||||
Issue descriptionAffected Version: 2.14.2-2446-ga905fc2b27 What steps will reproduce the problem? 1. Selecting a reviewer shows reviewers in the dropdown, I'm guessing based on past reviewers? What is the expected output? The commit bot is not in the list. What do you see instead? The commit bot is in the list. Please provide any additional information below.
,
Aug 8 2017
We don't have support for excluding a specific account from the reviewer suggestion. The reviewer suggestion excludes existing reviewers. Would if be feasible to automatically add the commit bot as reviewer when the change is created, so that it's then not suggested as reviewer? Reviewer suggestion also filters out accounts that are not visible. So depending on the setting for 'accounts.visibility' on the host the commit bot may be placed into an own group that is not visible to other users. If support for excluding a specific account from the reviewer suggestion should be implemented this could be project setting (list of accounts that should not be suggested as reviewer). Alternatively adding a special property on the account would be possible.
,
Aug 8 2017
Option #1: Make account invisible The accounts.visibility setting would potentially be viable if all the human users on chromium-review are automatically members of a visible group. The requirement is that every account that should be suggestible as reviewer or CC must always be a member of an explicitly visible group. It appears to me that the chromegroupbackend plugin doesn't populate that field. Perhaps that would be a reasonable change to make? Not sure if there are users who would not be members of any group served by chromebackend that ought to be suggested as reviewers or CCs. Option #2: Auto-add bot as reviewer on every change Auto-adding the bot to every change (as either reviewer or CC) would be easy to add to git cl upload. The downside is that it adds visual noise. Option #3: Use chromium_behavior plugin to hide account I'm not sure how this would work exactly, but we could use a plugin in some fashion to filter this suggestion. Option #4: New Gerrit feature to offer a way to blacklist reviewer accounts without depending on group visibility. This would need to be specced out further, and there's a risk that it wouldn't fit on our near-term roadmap.
,
Aug 8 2017
,
Aug 25 2017
,
Sep 11 2017
,
Jan 3 2018
Removing Milestone-Afterglow, as it has ceased to have meaning. More refined milestones may be added back in the near future.
,
Jan 6 2018
The solution for this is not to special-case the CQ bot, but to make intelligent suggestions based on OWNERS files and review history. Duping into bug tracking that work. |
|||||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||||
Comment 1 by logan@google.com
, Aug 7 2017Labels: Milestone-Chromium-Afterglow Priority-2
Owner: ekempin@google.com
Status: Accepted (was: New)