New issue
Advanced search Search tips

Issue 753411 link

Starred by 2 users

Issue metadata

Status: Duplicate
Merged: issue 604736
Owner: ----
Closed: Jan 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Task


Previous locations:
gerrit:6936


Sign in to add a comment

Reviewer suggestion dialog suggests the CQ bot

Project Member Reported by davidben@chromium.org, Aug 3 2017

Issue description

Affected Version: 2.14.2-2446-ga905fc2b27

What steps will reproduce the problem?
1. Selecting a reviewer shows reviewers in the dropdown, I'm guessing based on past reviewers?

What is the expected output?
The commit bot is not in the list.

What do you see instead?
The commit bot is in the list.

Please provide any additional information below.

 

Comment 1 by logan@google.com, Aug 7 2017

Cc: aga...@chromium.org
Labels: Milestone-Chromium-Afterglow Priority-2
Owner: ekempin@google.com
Status: Accepted (was: New)
Edwin, what would be the best way to filter this account from reviewer suggestions?

Comment 2 by ekempin@google.com, Aug 8 2017

Owner: logan@google.com
We don't have support for excluding a specific account from the reviewer suggestion.

The reviewer suggestion excludes existing reviewers. Would if be feasible to automatically add the commit bot as reviewer when the change is created, so that it's then not suggested as reviewer?

Reviewer suggestion also filters out accounts that are not visible. So depending on the setting for 'accounts.visibility' on the host the commit bot may be placed into an own group that is not visible to other users.

If support for excluding a specific account from the reviewer suggestion should be implemented this could be project setting (list of accounts that should not be suggested as reviewer). Alternatively adding a special property on the account would be possible.

Comment 3 by logan@google.com, Aug 8 2017

Components: -PolyGerrit
Labels: -Priority-2 -Milestone-Chromium-Afterglow Proj-Gerrit-Migration
Owner: ----
Status: New (was: Accepted)
Option #1: Make account invisible

The accounts.visibility setting would potentially be viable if all the human users on chromium-review are automatically members of a visible group. The requirement is that every account that should be suggestible as reviewer or CC must always be a member of an explicitly visible group.

It appears to me that the chromegroupbackend plugin doesn't populate that field. Perhaps that would be a reasonable change to make? Not sure if there are users who would not be members of any group served by chromebackend that ought to be suggested as reviewers or CCs.

Option #2: Auto-add bot as reviewer on every change

Auto-adding the bot to every change (as either reviewer or CC) would be easy to add to git cl upload. The downside is that it adds visual noise.

Option #3: Use chromium_behavior plugin to hide account

I'm not sure how this would work exactly, but we could use a plugin in some fashion to filter this suggestion.

Option #4: New Gerrit feature to offer a way to blacklist reviewer accounts without depending on group visibility.

This would need to be specced out further, and there's a risk that it wouldn't fit on our near-term roadmap.

Comment 4 by logan@google.com, Aug 8 2017

Project: chromium
Moved issue gerrit:6936 to now be  issue chromium:753411 .
Components: Infra>Codereview>Gerrit

Comment 6 by aga...@chromium.org, Sep 11 2017

Labels: Milestone-Afterglow Pri-3
Status: Available (was: New)
Labels: -Milestone-Afterglow
Removing Milestone-Afterglow, as it has ceased to have meaning. More refined milestones may be added back in the near future.
Labels: Type-Task
Mergedinto: 604736
Status: Duplicate (was: Available)
The solution for this is not to special-case the CQ bot, but to make intelligent suggestions based on OWNERS files and review history. Duping into bug tracking that work.

Sign in to add a comment