Re-enable start_with_ext.* benchmarks |
||||
Issue descriptionBenchmarks were disabled at issue 563424 . Unclear whether these still work at all. Let's re-enable and see.
,
Aug 8 2017
,
Aug 8 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/afc7dd011216d97d717336c698d0bac4b6802a15 commit afc7dd011216d97d717336c698d0bac4b6802a15 Author: rnephew <rnephew@chromium.org> Date: Tue Aug 08 21:46:54 2017 Revert "[tools/perf] Re-enable start_wit_ext.* benchmarks" This reverts commit 5a8f5e589ba81ef6e155457e3066d31e32ff99be. Reason for revert: <INSERT REASONING HERE> Original change's description: > [tools/perf] Re-enable start_wit_ext.* benchmarks > > The two benchmarks being reenabled everywhere are: > > - startup_with_ext.cold.blank_page > - startup_with_ext.warm.blank_page > > This is part of the benchmark reenabling fix-it, where we're aiming to > bring the stories that are disabled in line with the stories that are > actually still failing. We're also migrating from wholesale benchmark > disabling to per-story disabling when a story fails. > > NOTRY=true > > Bug: 753408 ,713222 > Change-Id: Ie5e188a6a7cea2112583df55b40e1424b241cff2 > Reviewed-on: https://chromium-review.googlesource.com/606427 > Reviewed-by: Ned Nguyen <nednguyen@google.com> > Reviewed-by: rnephew <rnephew@chromium.org> > Commit-Queue: Juan Antonio Navarro Pérez <perezju@chromium.org> > Cr-Commit-Position: refs/heads/master@{#492657} TBR=perezju@chromium.org,nednguyen@google.com,rnephew@chromium.org Change-Id: Ie4866fbaf72f4ddf0e0c16d410a69415dc5e51af No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 753408 , 713222 Reviewed-on: https://chromium-review.googlesource.com/606738 Reviewed-by: rnephew <rnephew@chromium.org> Commit-Queue: rnephew <rnephew@chromium.org> Cr-Commit-Position: refs/heads/master@{#492756} [modify] https://crrev.com/afc7dd011216d97d717336c698d0bac4b6802a15/testing/buildbot/chromium.perf.json [modify] https://crrev.com/afc7dd011216d97d717336c698d0bac4b6802a15/tools/perf/benchmarks/start_with_ext.py
,
Aug 15 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/62a75552b011f0c227a7f0a7e573dfe696c99a46 commit 62a75552b011f0c227a7f0a7e573dfe696c99a46 Author: Juan A. Navarro Perez <perezju@chromium.org> Date: Tue Aug 15 11:03:29 2017 Reland "[tools/perf] Re-enable start_wit_ext.* benchmarks" Changes: Keep the story disabled on Windows where it is still failing. This reverts commit afc7dd011216d97d717336c698d0bac4b6802a15. Original change's description: > Revert "[tools/perf] Re-enable start_wit_ext.* benchmarks" > > This reverts commit 5a8f5e589ba81ef6e155457e3066d31e32ff99be. > > Reason for revert: <INSERT REASONING HERE> > > Original change's description: > > [tools/perf] Re-enable start_wit_ext.* benchmarks > > > > The two benchmarks being reenabled everywhere are: > > > > - startup_with_ext.cold.blank_page > > - startup_with_ext.warm.blank_page > > > > This is part of the benchmark reenabling fix-it, where we're aiming to > > bring the stories that are disabled in line with the stories that are > > actually still failing. We're also migrating from wholesale benchmark > > disabling to per-story disabling when a story fails. > > > > NOTRY=true > > > > Bug: 753408 ,713222 > > Change-Id: Ie5e188a6a7cea2112583df55b40e1424b241cff2 > > Reviewed-on: https://chromium-review.googlesource.com/606427 > > Reviewed-by: Ned Nguyen <nednguyen@google.com> > > Reviewed-by: rnephew <rnephew@chromium.org> > > Commit-Queue: Juan Antonio Navarro Pérez <perezju@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#492657} > > TBR=perezju@chromium.org,nednguyen@google.com,rnephew@chromium.org > > Change-Id: Ie4866fbaf72f4ddf0e0c16d410a69415dc5e51af > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 753408 , 713222 > Reviewed-on: https://chromium-review.googlesource.com/606738 > Reviewed-by: rnephew <rnephew@chromium.org> > Commit-Queue: rnephew <rnephew@chromium.org> > Cr-Commit-Position: refs/heads/master@{#492756} TBR=nednguyen@google.com,rnephew@chromium.org Bug: 753408 , 713222 Change-Id: I6744feef2ec391e787d9ca3c7582c5738e16eb6b Reviewed-on: https://chromium-review.googlesource.com/613160 Commit-Queue: Juan Antonio Navarro Pérez <perezju@chromium.org> Reviewed-by: Juan Antonio Navarro Pérez <perezju@chromium.org> Cr-Commit-Position: refs/heads/master@{#494358} [modify] https://crrev.com/62a75552b011f0c227a7f0a7e573dfe696c99a46/testing/buildbot/chromium.perf.json [modify] https://crrev.com/62a75552b011f0c227a7f0a7e573dfe696c99a46/tools/perf/benchmarks/start_with_ext.py
,
Aug 15 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b678f0b35d8f9ad8bdc7bac1fad366ac1e22a95b commit b678f0b35d8f9ad8bdc7bac1fad366ac1e22a95b Author: Reilly Grant <reillyg@chromium.org> Date: Tue Aug 15 19:25:10 2017 Revert "[tools/perf] Re-enable start_wit_ext.* benchmarks" This reverts commit 62a75552b011f0c227a7f0a7e573dfe696c99a46. Reason for revert: Also still failing on Mac10.10: https://uberchromegw.corp.google.com/i/chromium.mac/builders/Mac10.10%20Tests/builds/22219 Original change's description: > Reland "[tools/perf] Re-enable start_wit_ext.* benchmarks" > > Changes: Keep the story disabled on Windows where it is > still failing. > > This reverts commit afc7dd011216d97d717336c698d0bac4b6802a15. > > Original change's description: > > Revert "[tools/perf] Re-enable start_wit_ext.* benchmarks" > > > > This reverts commit 5a8f5e589ba81ef6e155457e3066d31e32ff99be. > > > > Reason for revert: <INSERT REASONING HERE> > > > > Original change's description: > > > [tools/perf] Re-enable start_wit_ext.* benchmarks > > > > > > The two benchmarks being reenabled everywhere are: > > > > > > - startup_with_ext.cold.blank_page > > > - startup_with_ext.warm.blank_page > > > > > > This is part of the benchmark reenabling fix-it, where we're aiming to > > > bring the stories that are disabled in line with the stories that are > > > actually still failing. We're also migrating from wholesale benchmark > > > disabling to per-story disabling when a story fails. > > > > > > NOTRY=true > > > > > > Bug: 753408 ,713222 > > > Change-Id: Ie5e188a6a7cea2112583df55b40e1424b241cff2 > > > Reviewed-on: https://chromium-review.googlesource.com/606427 > > > Reviewed-by: Ned Nguyen <nednguyen@google.com> > > > Reviewed-by: rnephew <rnephew@chromium.org> > > > Commit-Queue: Juan Antonio Navarro Pérez <perezju@chromium.org> > > > Cr-Commit-Position: refs/heads/master@{#492657} > > > > TBR=perezju@chromium.org,nednguyen@google.com,rnephew@chromium.org > > > > Change-Id: Ie4866fbaf72f4ddf0e0c16d410a69415dc5e51af > > No-Presubmit: true > > No-Tree-Checks: true > > No-Try: true > > Bug: 753408 , 713222 > > Reviewed-on: https://chromium-review.googlesource.com/606738 > > Reviewed-by: rnephew <rnephew@chromium.org> > > Commit-Queue: rnephew <rnephew@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#492756} > > TBR=nednguyen@google.com,rnephew@chromium.org > > Bug: 753408 , 713222 > Change-Id: I6744feef2ec391e787d9ca3c7582c5738e16eb6b > Reviewed-on: https://chromium-review.googlesource.com/613160 > Commit-Queue: Juan Antonio Navarro Pérez <perezju@chromium.org> > Reviewed-by: Juan Antonio Navarro Pérez <perezju@chromium.org> > Cr-Commit-Position: refs/heads/master@{#494358} TBR=perezju@chromium.org,nednguyen@google.com,rnephew@chromium.org Change-Id: I10dc772157f150a5d0d34c88f580c1d13ee96cd5 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 753408 , 713222 Reviewed-on: https://chromium-review.googlesource.com/615741 Reviewed-by: Reilly Grant <reillyg@chromium.org> Commit-Queue: Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#494492} [modify] https://crrev.com/b678f0b35d8f9ad8bdc7bac1fad366ac1e22a95b/testing/buildbot/chromium.perf.json [modify] https://crrev.com/b678f0b35d8f9ad8bdc7bac1fad366ac1e22a95b/tools/perf/benchmarks/start_with_ext.py
,
Aug 16 2017
These benchmarks keep resisting to being re-enabled. I've just noted that (1) they are currently unowned, (2) they haven't run on Mac for 1 year and 9 months, and (3) they haven't actually worked elsewhere since their creation 2 years ago and a month ago. See: https://chromium.googlesource.com/chromium/src/+log/430662b24f90fb9eff40118633e205af8ba3ff6e/tools/perf/benchmarks/start_with_ext.py +erikchen as you own issue 513881 ; could the benchmarks be removed? Or do you want to keep their code but disabled everywhere?
,
Aug 16 2017
I vote for removing this benchmark as well.
,
Aug 18 2017
Benchmarks were removed at: https://chromium-review.googlesource.com/620306 |
||||
►
Sign in to add a comment |
||||
Comment 1 by bugdroid1@chromium.org
, Aug 8 2017