ExternalProtocolHandlerTests flaky |
|||||
Issue descriptionOn multiple platforms, ExternalProtocolHandlerTests will fail or crash on the first attempt before succeeding on the second: https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=unit_tests&tests=ExternalProtocolHandlerTest On rare occasions, this can happen more than once in a single run, resulting in a visible failure: https://luci-milo.appspot.com/buildbot/chromium.linux/Android%20Tests/44547 Failures can come from any of the three ASSERT_TRUEs here: https://codesearch.chromium.org/chromium/src/chrome/browser/external_protocol/external_protocol_handler_unittest.cc?rcl=b0a8dabdd22a2b9ecc755ac7deaad22bee218da9&l=135 while crashes frequently look something like this: base::internal::TaskTracker::BeforePostTask [0x03287DAC+12] base::internal::TaskTracker::WillPostTask [0x03287D4E+30] base::internal::SchedulerSingleThreadTaskRunnerManager::SchedulerSingleThreadTaskRunner::PostDelayedTask [0x032AD79E+110] base::TaskRunner::PostTask [0x03215B93+67] shell_integration::DefaultWebClientWorker::StartCheckIsDefault [0x04354C51+187] ExternalProtocolHandler::LaunchUrlWithDelegate [0x03407088+402] ExternalProtocolHandlerTest::DoTest [0x011A27D6+578] ExternalProtocolHandlerTest_TestLaunchSchemeUnknownChromeUnknown_Test::TestBody [0x011A30F5+21] (source: https://chromium-swarm.appspot.com/task?id=37db47c9a04c5210)
,
Aug 8 2017
+cc chrome/browser/external_protocol/OWNERS
,
Aug 8 2017
I ran into this recently, and I believe this is because of bug 732018 .
,
Aug 9 2017
I have an incoming fix for issue 732018 @ https://chromium-review.googlesource.com/c/538898/ (one test failure to resolve before landing)
,
Aug 10 2017
gab@ could you please take care of this?
,
Aug 10 2017
Yes, finally have a working fix @ https://chromium-review.googlesource.com/c/538898/10
,
Aug 10 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c8cca9965f9ad583cad39ecd9fcd16e9dcea5e7d commit c8cca9965f9ad583cad39ecd9fcd16e9dcea5e7d Author: Gabriel Charette <gab@chromium.org> Date: Thu Aug 10 18:21:49 2017 Always run after-startup-tasks in the scope of the unit test that posted them. Bug: 732018 , 753403 Change-Id: I318e82f3aa2969d6e338a33905ec7cd256d32d9c Reviewed-on: https://chromium-review.googlesource.com/538898 Reviewed-by: Avi Drissman <avi@chromium.org> Reviewed-by: Reilly Grant <reillyg@chromium.org> Reviewed-by: Nico Weber <thakis@chromium.org> Reviewed-by: Charlie Harrison <csharrison@chromium.org> Commit-Queue: Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#493468} [modify] https://crrev.com/c8cca9965f9ad583cad39ecd9fcd16e9dcea5e7d/chrome/browser/chrome_content_browser_client.cc [modify] https://crrev.com/c8cca9965f9ad583cad39ecd9fcd16e9dcea5e7d/chrome/browser/chrome_content_browser_client.h [modify] https://crrev.com/c8cca9965f9ad583cad39ecd9fcd16e9dcea5e7d/chrome/browser/extensions/extension_service_test_base.cc [modify] https://crrev.com/c8cca9965f9ad583cad39ecd9fcd16e9dcea5e7d/chrome/browser/io_thread_unittest.cc [modify] https://crrev.com/c8cca9965f9ad583cad39ecd9fcd16e9dcea5e7d/chrome/browser/subresource_filter/subresource_filter_test_harness.cc [modify] https://crrev.com/c8cca9965f9ad583cad39ecd9fcd16e9dcea5e7d/content/browser/BUILD.gn [add] https://crrev.com/c8cca9965f9ad583cad39ecd9fcd16e9dcea5e7d/content/browser/after_startup_task_utils.cc [add] https://crrev.com/c8cca9965f9ad583cad39ecd9fcd16e9dcea5e7d/content/browser/after_startup_task_utils.h [modify] https://crrev.com/c8cca9965f9ad583cad39ecd9fcd16e9dcea5e7d/content/public/browser/content_browser_client.cc [modify] https://crrev.com/c8cca9965f9ad583cad39ecd9fcd16e9dcea5e7d/content/public/browser/content_browser_client.h [modify] https://crrev.com/c8cca9965f9ad583cad39ecd9fcd16e9dcea5e7d/content/public/test/test_browser_thread_bundle.cc
,
Aug 10 2017
gab: Thanks for taking this over!
,
Aug 10 2017
|
|||||
►
Sign in to add a comment |
|||||
Comment 1 by jbudorick@chromium.org
, Aug 8 2017Labels: OS-Chrome Pri-2 Type-Bug