Loading indicator is not shown in incognito VR Browsing Mode |
||||||||
Issue descriptionChrome Version: 62.0.3178.0 OS: Android What steps will reproduce the problem? (1) Open page (e.g. wikipedia.org) in incognito VR Browsing Mode. (2) Click on link. What is the expected result? Navigates to page and shows loading indicator while transitioning. What happens instead? Navigates to page but doesn't show loading indicator. For graphics-related bugs, please copy/paste the contents of the about:gpu page at the end of this report.
,
Aug 8 2017
,
Aug 8 2017
It looks like the incognito scheme itself is not initialized, so any color not overridden in this scheme is a dice-roll.
,
Aug 8 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/516d9d830d88c80dd83c9d15d5dcc9c5fd7cbf87 commit 516d9d830d88c80dd83c9d15d5dcc9c5fd7cbf87 Author: Christopher Grant <cjgrant@chromium.org> Date: Tue Aug 08 19:52:01 2017 VR: Properly initialize incognito mode color scheme. This fixes (at least) a possibly invisible loading indicator. BUG= 753401 Change-Id: Ib30a98a6b1136da7fc87e0ad270237c53f494969 Reviewed-on: https://chromium-review.googlesource.com/606722 Reviewed-by: Tibor Goldschwendt <tiborg@chromium.org> Commit-Queue: Christopher Grant <cjgrant@chromium.org> Cr-Commit-Position: refs/heads/master@{#492735} [modify] https://crrev.com/516d9d830d88c80dd83c9d15d5dcc9c5fd7cbf87/chrome/browser/vr/color_scheme.cc
,
Aug 8 2017
,
Aug 9 2017
,
Aug 9 2017
This bug requires manual review: M61 has already been promoted to the beta branch, so this requires manual review Please contact the milestone owner if you have questions. Owners: amineer@(Android), cmasso@(iOS), ketakid@(ChromeOS), govind@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Aug 9 2017
Approved for M61 branch 3163.
,
Aug 10 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b4933edd82c85d0ec02e1754bca1fb804302adfb commit b4933edd82c85d0ec02e1754bca1fb804302adfb Author: Christopher Grant <cjgrant@chromium.org> Date: Thu Aug 10 20:28:29 2017 VR: Properly initialize incognito mode colors. This fixes (at least) a possibly invisible loading indicator. BUG= 753401 TBR=cjgrant@chromium.org (cherry picked from commit 516d9d830d88c80dd83c9d15d5dcc9c5fd7cbf87) Change-Id: Ib30a98a6b1136da7fc87e0ad270237c53f494969 Reviewed-on: https://chromium-review.googlesource.com/606722 Reviewed-by: Tibor Goldschwendt <tiborg@chromium.org> Commit-Queue: Christopher Grant <cjgrant@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#492735} Reviewed-on: https://chromium-review.googlesource.com/611039 Reviewed-by: Christopher Grant <cjgrant@chromium.org> Cr-Commit-Position: refs/branch-heads/3163@{#457} Cr-Branched-From: ff259bab28b35d242e10186cd63af7ed404fae0d-refs/heads/master@{#488528} [modify] https://crrev.com/b4933edd82c85d0ec02e1754bca1fb804302adfb/chrome/browser/vr/color_scheme.cc
,
Oct 11 2017
I verified in 63.0.3236.6 that the loading indicator is displayed in incognito mode. |
||||||||
►
Sign in to add a comment |
||||||||
Comment 1 by cjgrant@chromium.org
, Aug 8 2017Owner: cjgrant@chromium.org
Status: Assigned (was: Untriaged)