See description.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/8193c3b67161b41d70173db5baca509ba0df9567 commit 8193c3b67161b41d70173db5baca509ba0df9567 Author: gambard <gambard@chromium.org> Date: Wed Aug 09 12:36:49 2017 Use ContentSuggestions in ios/clean GoogleLandingController does not follow the rules about decoupling responsibilities and roles used in the clean architecture. ContentSuggestions is the new UI for the NTP, following those rules. This CL prepares the NTPHomeCoordinator to use the ContentSuggestions UI. Bug: 753391 Change-Id: Id066c9afd4726f7f3c9a6a20660743664a478ad0 Reviewed-on: https://chromium-review.googlesource.com/607668 Reviewed-by: Mark Cogan <marq@chromium.org> Reviewed-by: Olivier Robin <olivierrobin@chromium.org> Reviewed-by: Marc Treib <treib@chromium.org> Commit-Queue: Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#492953} [add] https://crrev.com/8193c3b67161b41d70173db5baca509ba0df9567/ios/clean/chrome/browser/DEPS [modify] https://crrev.com/8193c3b67161b41d70173db5baca509ba0df9567/ios/clean/chrome/browser/ui/ntp/BUILD.gn [modify] https://crrev.com/8193c3b67161b41d70173db5baca509ba0df9567/ios/clean/chrome/browser/ui/ntp/ntp_home_coordinator.mm [add] https://crrev.com/8193c3b67161b41d70173db5baca509ba0df9567/ios/clean/chrome/browser/ui/ntp/ntp_home_header_view_controller.h [add] https://crrev.com/8193c3b67161b41d70173db5baca509ba0df9567/ios/clean/chrome/browser/ui/ntp/ntp_home_header_view_controller.mm [rename] https://crrev.com/8193c3b67161b41d70173db5baca509ba0df9567/ios/clean/chrome/browser/ui/ntp/ntp_home_header_view_controller_unittest.mm [delete] https://crrev.com/b2bbd380909f6415f6e13a700b9612ca06c40295/ios/clean/chrome/browser/ui/ntp/ntp_home_mediator.h [delete] https://crrev.com/b2bbd380909f6415f6e13a700b9612ca06c40295/ios/clean/chrome/browser/ui/ntp/ntp_home_mediator.mm
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/0136b9e8cba505c3742f34a63d9f2ca255fa1713 commit 0136b9e8cba505c3742f34a63d9f2ca255fa1713 Author: gambard <gambard@chromium.org> Date: Thu Aug 10 16:16:23 2017 [ios clean] Add a header view for the NTP This CL adds the header view to the collection. The header is not using the dispatcher as most of the call needed are not yet implemented. Alerts are used to signal the place were the dispatcher should be called. The header has the constraints of the header used in the old chrome. In particular its height is calculated as if the toolbar is displayed inside the view. This will be addressed in a future CL. Bug: 753391 Change-Id: Ibb26ca42d50c9ef833731e994fc50764dcebd340 Reviewed-on: https://chromium-review.googlesource.com/607872 Commit-Queue: Gauthier Ambard <gambard@chromium.org> Reviewed-by: Mark Cogan <marq@chromium.org> Cr-Commit-Position: refs/heads/master@{#493412} [modify] https://crrev.com/0136b9e8cba505c3742f34a63d9f2ca255fa1713/ios/chrome/browser/content_suggestions/BUILD.gn [modify] https://crrev.com/0136b9e8cba505c3742f34a63d9f2ca255fa1713/ios/chrome/browser/content_suggestions/content_suggestions_coordinator.mm [delete] https://crrev.com/c0c77c7942d0f2270110d92f619a117105d5fef2/ios/chrome/browser/content_suggestions/content_suggestions_header_provider.h [modify] https://crrev.com/0136b9e8cba505c3742f34a63d9f2ca255fa1713/ios/chrome/browser/content_suggestions/content_suggestions_header_view_controller.h [modify] https://crrev.com/0136b9e8cba505c3742f34a63d9f2ca255fa1713/ios/chrome/browser/content_suggestions/content_suggestions_header_view_controller.mm [modify] https://crrev.com/0136b9e8cba505c3742f34a63d9f2ca255fa1713/ios/chrome/browser/content_suggestions/content_suggestions_mediator.mm [modify] https://crrev.com/0136b9e8cba505c3742f34a63d9f2ca255fa1713/ios/chrome/browser/ui/content_suggestions/BUILD.gn [add] https://crrev.com/0136b9e8cba505c3742f34a63d9f2ca255fa1713/ios/chrome/browser/ui/content_suggestions/content_suggestions_header_provider.h [rename] https://crrev.com/0136b9e8cba505c3742f34a63d9f2ca255fa1713/ios/chrome/browser/ui/content_suggestions/content_suggestions_header_view_controller_delegate.h [modify] https://crrev.com/0136b9e8cba505c3742f34a63d9f2ca255fa1713/ios/chrome/browser/ui/ntp/new_tab_page_header_constants.h [modify] https://crrev.com/0136b9e8cba505c3742f34a63d9f2ca255fa1713/ios/chrome/browser/ui/ntp/new_tab_page_header_constants.mm [modify] https://crrev.com/0136b9e8cba505c3742f34a63d9f2ca255fa1713/ios/chrome/browser/ui/ntp/new_tab_page_header_view.mm [modify] https://crrev.com/0136b9e8cba505c3742f34a63d9f2ca255fa1713/ios/clean/chrome/browser/DEPS [modify] https://crrev.com/0136b9e8cba505c3742f34a63d9f2ca255fa1713/ios/clean/chrome/browser/ui/ntp/BUILD.gn [modify] https://crrev.com/0136b9e8cba505c3742f34a63d9f2ca255fa1713/ios/clean/chrome/browser/ui/ntp/ntp_home_coordinator.mm [add] https://crrev.com/0136b9e8cba505c3742f34a63d9f2ca255fa1713/ios/clean/chrome/browser/ui/ntp/ntp_home_header_coordinator.h [add] https://crrev.com/0136b9e8cba505c3742f34a63d9f2ca255fa1713/ios/clean/chrome/browser/ui/ntp/ntp_home_header_coordinator.mm [add] https://crrev.com/0136b9e8cba505c3742f34a63d9f2ca255fa1713/ios/clean/chrome/browser/ui/ntp/ntp_home_header_coordinator_unittest.mm [add] https://crrev.com/0136b9e8cba505c3742f34a63d9f2ca255fa1713/ios/clean/chrome/browser/ui/ntp/ntp_home_header_mediator.h [add] https://crrev.com/0136b9e8cba505c3742f34a63d9f2ca255fa1713/ios/clean/chrome/browser/ui/ntp/ntp_home_header_mediator.mm [add] https://crrev.com/0136b9e8cba505c3742f34a63d9f2ca255fa1713/ios/clean/chrome/browser/ui/ntp/ntp_home_header_mediator_unittest.mm [modify] https://crrev.com/0136b9e8cba505c3742f34a63d9f2ca255fa1713/ios/clean/chrome/browser/ui/ntp/ntp_home_header_view_controller.h [modify] https://crrev.com/0136b9e8cba505c3742f34a63d9f2ca255fa1713/ios/clean/chrome/browser/ui/ntp/ntp_home_header_view_controller.mm
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/79ae89d38759c22149071e008c8372d1fef9af01 commit 79ae89d38759c22149071e008c8372d1fef9af01 Author: gambard <gambard@chromium.org> Date: Thu Aug 10 16:53:42 2017 [ios clean] Add height constraint to NTP header The height of the NTP header is different between clean and old chrome. Old Chrome has the toolbar embedded inside the header and its height must take it into account. Clean's toolbar is outside of the header. Bug: 753391 Change-Id: Ie0471a4083daeb74ccea7ee3467477ee6f80ca70 Reviewed-on: https://chromium-review.googlesource.com/608107 Commit-Queue: Gauthier Ambard <gambard@chromium.org> Reviewed-by: Mark Cogan <marq@chromium.org> Cr-Commit-Position: refs/heads/master@{#493430} [modify] https://crrev.com/79ae89d38759c22149071e008c8372d1fef9af01/ios/chrome/browser/content_suggestions/content_suggestions_coordinator.mm [modify] https://crrev.com/79ae89d38759c22149071e008c8372d1fef9af01/ios/chrome/browser/content_suggestions/content_suggestions_header_view_controller.mm [modify] https://crrev.com/79ae89d38759c22149071e008c8372d1fef9af01/ios/chrome/browser/ui/content_suggestions/BUILD.gn [modify] https://crrev.com/79ae89d38759c22149071e008c8372d1fef9af01/ios/chrome/browser/ui/content_suggestions/content_suggestions_collection_utils.h [modify] https://crrev.com/79ae89d38759c22149071e008c8372d1fef9af01/ios/chrome/browser/ui/content_suggestions/content_suggestions_collection_utils.mm [modify] https://crrev.com/79ae89d38759c22149071e008c8372d1fef9af01/ios/chrome/browser/ui/content_suggestions/content_suggestions_collection_utils_unittest.mm [modify] https://crrev.com/79ae89d38759c22149071e008c8372d1fef9af01/ios/chrome/browser/ui/ntp/BUILD.gn [modify] https://crrev.com/79ae89d38759c22149071e008c8372d1fef9af01/ios/chrome/browser/ui/ntp/google_landing_view_controller.mm [modify] https://crrev.com/79ae89d38759c22149071e008c8372d1fef9af01/ios/clean/chrome/browser/ui/ntp/BUILD.gn [modify] https://crrev.com/79ae89d38759c22149071e008c8372d1fef9af01/ios/clean/chrome/browser/ui/ntp/ntp_home_header_mediator.mm [modify] https://crrev.com/79ae89d38759c22149071e008c8372d1fef9af01/ios/clean/chrome/browser/ui/ntp/ntp_home_header_view_controller.mm
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f7eb376d2215649123695e728dd3c5ff984a92f8 commit f7eb376d2215649123695e728dd3c5ff984a92f8 Author: gambard <gambard@chromium.org> Date: Fri Aug 11 12:36:51 2017 [ios clean] Move alert display to coordinator The UI-spawning code should be in the coordinator, not in the mediator. Bug: 753391 Change-Id: Ia85d0b00471598dd42e9b75c25cdb2b89968de03 Reviewed-on: https://chromium-review.googlesource.com/610055 Reviewed-by: Mark Cogan <marq@chromium.org> Commit-Queue: Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#493706} [modify] https://crrev.com/f7eb376d2215649123695e728dd3c5ff984a92f8/ios/clean/chrome/browser/ui/ntp/ntp_home_header_coordinator.mm [modify] https://crrev.com/f7eb376d2215649123695e728dd3c5ff984a92f8/ios/clean/chrome/browser/ui/ntp/ntp_home_header_mediator.h [modify] https://crrev.com/f7eb376d2215649123695e728dd3c5ff984a92f8/ios/clean/chrome/browser/ui/ntp/ntp_home_header_mediator.mm
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/5f1653ef581c7412c66561f98b152cd274d9a0a9 commit 5f1653ef581c7412c66561f98b152cd274d9a0a9 Author: gambard <gambard@chromium.org> Date: Wed Aug 16 18:05:57 2017 [ios clean] Add consumer for NTPHomeHeader The NTPHomeHeaderViewController should be given a consumer instead of directly the view controller. Bug: 753391 Change-Id: I2eeab40a14123184e06466c57db2be093abd98b5 Reviewed-on: https://chromium-review.googlesource.com/610560 Reviewed-by: Mark Cogan <marq@chromium.org> Commit-Queue: Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#494858} [modify] https://crrev.com/5f1653ef581c7412c66561f98b152cd274d9a0a9/ios/clean/chrome/browser/ui/ntp/BUILD.gn [add] https://crrev.com/5f1653ef581c7412c66561f98b152cd274d9a0a9/ios/clean/chrome/browser/ui/ntp/ntp_home_header_consumer.h [modify] https://crrev.com/5f1653ef581c7412c66561f98b152cd274d9a0a9/ios/clean/chrome/browser/ui/ntp/ntp_home_header_coordinator.mm [modify] https://crrev.com/5f1653ef581c7412c66561f98b152cd274d9a0a9/ios/clean/chrome/browser/ui/ntp/ntp_home_header_mediator.h [modify] https://crrev.com/5f1653ef581c7412c66561f98b152cd274d9a0a9/ios/clean/chrome/browser/ui/ntp/ntp_home_header_mediator.mm [add] https://crrev.com/5f1653ef581c7412c66561f98b152cd274d9a0a9/ios/clean/chrome/browser/ui/ntp/ntp_home_header_provider.h [modify] https://crrev.com/5f1653ef581c7412c66561f98b152cd274d9a0a9/ios/clean/chrome/browser/ui/ntp/ntp_home_header_view_controller.h [modify] https://crrev.com/5f1653ef581c7412c66561f98b152cd274d9a0a9/ios/clean/chrome/browser/ui/ntp/ntp_home_header_view_controller.mm
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b99e10679e4f2a0b5a64f4ab8e18a9ea87736bb5 commit b99e10679e4f2a0b5a64f4ab8e18a9ea87736bb5 Author: gambard <gambard@chromium.org> Date: Thu Aug 17 08:28:54 2017 [ios clean] Use right start order for NTPHomeCoordinator The coordinator should create its view controller before starting child coordinator. This CL ensures the order for the NTPHomeCoordinator |start| method is following the clean guidelines. Bug: 753391 Change-Id: I3077493d50383393d2a27748bf2fc6ab59e47db1 Reviewed-on: https://chromium-review.googlesource.com/610600 Commit-Queue: Gauthier Ambard <gambard@chromium.org> Reviewed-by: Mark Cogan <marq@chromium.org> Cr-Commit-Position: refs/heads/master@{#495109} [modify] https://crrev.com/b99e10679e4f2a0b5a64f4ab8e18a9ea87736bb5/ios/chrome/browser/content_suggestions/content_suggestions_coordinator.mm [modify] https://crrev.com/b99e10679e4f2a0b5a64f4ab8e18a9ea87736bb5/ios/chrome/browser/ui/content_suggestions/content_suggestions_collection_updater.h [modify] https://crrev.com/b99e10679e4f2a0b5a64f4ab8e18a9ea87736bb5/ios/chrome/browser/ui/content_suggestions/content_suggestions_collection_updater.mm [modify] https://crrev.com/b99e10679e4f2a0b5a64f4ab8e18a9ea87736bb5/ios/chrome/browser/ui/content_suggestions/content_suggestions_collection_updater_unittest.mm [modify] https://crrev.com/b99e10679e4f2a0b5a64f4ab8e18a9ea87736bb5/ios/chrome/browser/ui/content_suggestions/content_suggestions_view_controller.h [modify] https://crrev.com/b99e10679e4f2a0b5a64f4ab8e18a9ea87736bb5/ios/chrome/browser/ui/content_suggestions/content_suggestions_view_controller.mm [modify] https://crrev.com/b99e10679e4f2a0b5a64f4ab8e18a9ea87736bb5/ios/clean/chrome/browser/ui/ntp/ntp_home_coordinator.mm [modify] https://crrev.com/b99e10679e4f2a0b5a64f4ab8e18a9ea87736bb5/ios/showcase/content_suggestions/sc_content_suggestions_coordinator.mm
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/101317947479fad8399bfb1600cf14d409714334 commit 101317947479fad8399bfb1600cf14d409714334 Author: Gauthier Ambard <gambard@chromium.org> Date: Thu Aug 17 13:24:39 2017 Move the iPad detection to the ViewController The ViewController should be responsible for adapting itself to the device (iPad/iPhone), not the mediator. Bug: 753391 Change-Id: If0e773102b823bdd7ec6c1ce13a120c1bcfb51d3 Reviewed-on: https://chromium-review.googlesource.com/618887 Commit-Queue: Gauthier Ambard <gambard@chromium.org> Reviewed-by: Mark Cogan <marq@chromium.org> Cr-Commit-Position: refs/heads/master@{#495158} [modify] https://crrev.com/101317947479fad8399bfb1600cf14d409714334/ios/clean/chrome/browser/ui/ntp/ntp_home_header_mediator.mm [modify] https://crrev.com/101317947479fad8399bfb1600cf14d409714334/ios/clean/chrome/browser/ui/ntp/ntp_home_header_view_controller.mm
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/df5451c43b82af7ac6de2d12f0c2cc3032578ecb commit df5451c43b82af7ac6de2d12f0c2cc3032578ecb Author: Gauthier Ambard <gambard@chromium.org> Date: Thu Aug 24 13:27:16 2017 Add bookmarks mediator Move some functionalities of the BookmarkInteractionController to a mediator. This will allow classes in clean/ to reuse them, as the interaction controller cannot be reused as it mainly controls the presentation of the bookmarks. Bug: 753391 Change-Id: I209f2ad28313144ebf7ab601808ce8735fae7fbd Reviewed-on: https://chromium-review.googlesource.com/631719 Commit-Queue: Gauthier Ambard <gambard@chromium.org> Reviewed-by: Eric Noyau <noyau@chromium.org> Cr-Commit-Position: refs/heads/master@{#497024} [modify] https://crrev.com/df5451c43b82af7ac6de2d12f0c2cc3032578ecb/ios/chrome/browser/prefs/browser_prefs.mm [modify] https://crrev.com/df5451c43b82af7ac6de2d12f0c2cc3032578ecb/ios/chrome/browser/ui/bookmarks/BUILD.gn [modify] https://crrev.com/df5451c43b82af7ac6de2d12f0c2cc3032578ecb/ios/chrome/browser/ui/bookmarks/bookmark_edit_view_controller.mm [modify] https://crrev.com/df5451c43b82af7ac6de2d12f0c2cc3032578ecb/ios/chrome/browser/ui/bookmarks/bookmark_interaction_controller.h [modify] https://crrev.com/df5451c43b82af7ac6de2d12f0c2cc3032578ecb/ios/chrome/browser/ui/bookmarks/bookmark_interaction_controller.mm [add] https://crrev.com/df5451c43b82af7ac6de2d12f0c2cc3032578ecb/ios/chrome/browser/ui/bookmarks/bookmark_mediator.h [add] https://crrev.com/df5451c43b82af7ac6de2d12f0c2cc3032578ecb/ios/chrome/browser/ui/bookmarks/bookmark_mediator.mm
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f520c02822a0b662d9198509117fe8c633352222 commit f520c02822a0b662d9198509117fe8c633352222 Author: Gauthier Ambard <gambard@chromium.org> Date: Tue Aug 29 07:42:23 2017 Move the PanelIdentifier to a separate file This CL moves the PanelIdentifier enum to a separate file and a separate target to allow easier includes from clean. Bug: 753391 Change-Id: I3a8e0081d4b33b7cb934b9905e469ad145096e2d Reviewed-on: https://chromium-review.googlesource.com/635769 Reviewed-by: Sylvain Defresne <sdefresne@chromium.org> Commit-Queue: Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#498042} [modify] https://crrev.com/f520c02822a0b662d9198509117fe8c633352222/ios/chrome/browser/content_suggestions/BUILD.gn [modify] https://crrev.com/f520c02822a0b662d9198509117fe8c633352222/ios/chrome/browser/ui/BUILD.gn [modify] https://crrev.com/f520c02822a0b662d9198509117fe8c633352222/ios/chrome/browser/ui/authentication/BUILD.gn [modify] https://crrev.com/f520c02822a0b662d9198509117fe8c633352222/ios/chrome/browser/ui/authentication/signin_interaction_controller_egtest.mm [modify] https://crrev.com/f520c02822a0b662d9198509117fe8c633352222/ios/chrome/browser/ui/browser_view_controller.mm [modify] https://crrev.com/f520c02822a0b662d9198509117fe8c633352222/ios/chrome/browser/ui/content_suggestions/BUILD.gn [modify] https://crrev.com/f520c02822a0b662d9198509117fe8c633352222/ios/chrome/browser/ui/content_suggestions/ntp_home_constant.h [modify] https://crrev.com/f520c02822a0b662d9198509117fe8c633352222/ios/chrome/browser/ui/ntp/BUILD.gn [modify] https://crrev.com/f520c02822a0b662d9198509117fe8c633352222/ios/chrome/browser/ui/ntp/new_tab_page_controller.h [modify] https://crrev.com/f520c02822a0b662d9198509117fe8c633352222/ios/chrome/browser/ui/ntp/new_tab_page_controller.mm [modify] https://crrev.com/f520c02822a0b662d9198509117fe8c633352222/ios/chrome/browser/ui/ntp/new_tab_page_controller_unittest.mm [modify] https://crrev.com/f520c02822a0b662d9198509117fe8c633352222/ios/chrome/browser/ui/ntp/new_tab_page_egtest.mm [modify] https://crrev.com/f520c02822a0b662d9198509117fe8c633352222/ios/chrome/browser/ui/toolbar/BUILD.gn [modify] https://crrev.com/f520c02822a0b662d9198509117fe8c633352222/ios/chrome/browser/ui/toolbar/toolbar_egtest.mm [modify] https://crrev.com/f520c02822a0b662d9198509117fe8c633352222/ios/clean/chrome/browser/ui/ntp/BUILD.gn [modify] https://crrev.com/f520c02822a0b662d9198509117fe8c633352222/ios/clean/chrome/browser/ui/ntp/ntp_mediator.mm [modify] https://crrev.com/f520c02822a0b662d9198509117fe8c633352222/ios/clean/chrome/browser/ui/ntp/ntp_view_controller.mm
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e69be2208a947a05f65fbc6516a1fbba4c097e72 commit e69be2208a947a05f65fbc6516a1fbba4c097e72 Author: Gauthier Ambard <gambard@chromium.org> Date: Thu Aug 31 11:28:06 2017 [ios clean] Broadcast selected panel The currently selected panel is broadcasted, allowing the panel to know if they are currently displayed or not. Bug: 753391 Change-Id: Ia5163e2c76c7767f8bb5a110442de2169228ee63 Reviewed-on: https://chromium-review.googlesource.com/635844 Reviewed-by: Mark Cogan <marq@chromium.org> Commit-Queue: Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#498819} [modify] https://crrev.com/e69be2208a947a05f65fbc6516a1fbba4c097e72/ios/clean/chrome/browser/ui/ntp/BUILD.gn [modify] https://crrev.com/e69be2208a947a05f65fbc6516a1fbba4c097e72/ios/clean/chrome/browser/ui/ntp/ntp_coordinator.mm [modify] https://crrev.com/e69be2208a947a05f65fbc6516a1fbba4c097e72/ios/clean/chrome/browser/ui/ntp/ntp_home_header_coordinator.mm [modify] https://crrev.com/e69be2208a947a05f65fbc6516a1fbba4c097e72/ios/clean/chrome/browser/ui/ntp/ntp_home_header_mediator.h [modify] https://crrev.com/e69be2208a947a05f65fbc6516a1fbba4c097e72/ios/clean/chrome/browser/ui/ntp/ntp_home_header_mediator.mm [modify] https://crrev.com/e69be2208a947a05f65fbc6516a1fbba4c097e72/ios/clean/chrome/browser/ui/ntp/ntp_view_controller.h [modify] https://crrev.com/e69be2208a947a05f65fbc6516a1fbba4c097e72/ios/clean/chrome/browser/ui/ntp/ntp_view_controller.mm [modify] https://crrev.com/e69be2208a947a05f65fbc6516a1fbba4c097e72/ios/shared/chrome/browser/ui/broadcaster/BUILD.gn [modify] https://crrev.com/e69be2208a947a05f65fbc6516a1fbba4c097e72/ios/shared/chrome/browser/ui/broadcaster/chrome_broadcast_observer.h [modify] https://crrev.com/e69be2208a947a05f65fbc6516a1fbba4c097e72/ios/shared/chrome/browser/ui/broadcaster/chrome_broadcaster.mm
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ece24b1d275a2622389d8ed2e7531c8992d42c7e commit ece24b1d275a2622389d8ed2e7531c8992d42c7e Author: Gauthier Ambard <gambard@chromium.org> Date: Sat Sep 02 18:41:27 2017 [ios clean] Add bookmarks to NTP This CL adds the bookmarks ViewController by boxing it in the BookmarksCoordinator. Also add initialization to start the deferred runner loading the bookmarks. Bug: 753391 Change-Id: I46772d7305097c9f1155979f0ada52e987ac06f5 Reviewed-on: https://chromium-review.googlesource.com/632377 Commit-Queue: Gauthier Ambard <gambard@chromium.org> Reviewed-by: Mark Cogan <marq@chromium.org> Reviewed-by: edchin <edchin@chromium.org> Reviewed-by: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#499402} [modify] https://crrev.com/ece24b1d275a2622389d8ed2e7531c8992d42c7e/ios/chrome/app/main_controller.mm [modify] https://crrev.com/ece24b1d275a2622389d8ed2e7531c8992d42c7e/ios/chrome/app/startup_tasks.h [modify] https://crrev.com/ece24b1d275a2622389d8ed2e7531c8992d42c7e/ios/chrome/app/startup_tasks.mm [modify] https://crrev.com/ece24b1d275a2622389d8ed2e7531c8992d42c7e/ios/clean/chrome/app/steps/BUILD.gn [add] https://crrev.com/ece24b1d275a2622389d8ed2e7531c8992d42c7e/ios/clean/chrome/app/steps/scheduled_tasks.h [add] https://crrev.com/ece24b1d275a2622389d8ed2e7531c8992d42c7e/ios/clean/chrome/app/steps/scheduled_tasks.mm [modify] https://crrev.com/ece24b1d275a2622389d8ed2e7531c8992d42c7e/ios/clean/chrome/app/steps/step_collections.mm [modify] https://crrev.com/ece24b1d275a2622389d8ed2e7531c8992d42c7e/ios/clean/chrome/app/steps/step_features.h [modify] https://crrev.com/ece24b1d275a2622389d8ed2e7531c8992d42c7e/ios/clean/chrome/app/steps/step_features.mm [modify] https://crrev.com/ece24b1d275a2622389d8ed2e7531c8992d42c7e/ios/clean/chrome/app/steps/ui_initializer.mm [modify] https://crrev.com/ece24b1d275a2622389d8ed2e7531c8992d42c7e/ios/clean/chrome/browser/DEPS [modify] https://crrev.com/ece24b1d275a2622389d8ed2e7531c8992d42c7e/ios/clean/chrome/browser/ui/BUILD.gn [modify] https://crrev.com/ece24b1d275a2622389d8ed2e7531c8992d42c7e/ios/clean/chrome/browser/ui/bookmarks/BUILD.gn [modify] https://crrev.com/ece24b1d275a2622389d8ed2e7531c8992d42c7e/ios/clean/chrome/browser/ui/bookmarks/bookmarks_coordinator.h [modify] https://crrev.com/ece24b1d275a2622389d8ed2e7531c8992d42c7e/ios/clean/chrome/browser/ui/bookmarks/bookmarks_coordinator.mm [modify] https://crrev.com/ece24b1d275a2622389d8ed2e7531c8992d42c7e/ios/clean/chrome/browser/ui/ntp/ntp_coordinator.mm [add] https://crrev.com/ece24b1d275a2622389d8ed2e7531c8992d42c7e/ios/clean/chrome/browser/ui/url_loader_adaptor.h [add] https://crrev.com/ece24b1d275a2622389d8ed2e7531c8992d42c7e/ios/clean/chrome/browser/ui/url_loader_adaptor.mm
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/29d6bb7fa3c3cdb1ac87501300b3b87c034fedad commit 29d6bb7fa3c3cdb1ac87501300b3b87c034fedad Author: Gauthier Ambard <gambard@chromium.org> Date: Mon Sep 04 07:59:03 2017 [ios clean] Use RecentTabs Allow the NTP to open recent tabs. Bug: 753391 Change-Id: I0e2e4a64aca9d9ddfe8347cb7ccad30306313bb6 Reviewed-on: https://chromium-review.googlesource.com/641154 Commit-Queue: Gauthier Ambard <gambard@chromium.org> Reviewed-by: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by: Sky Malice <skym@chromium.org> Reviewed-by: Mark Cogan <marq@chromium.org> Cr-Commit-Position: refs/heads/master@{#499453} [modify] https://crrev.com/29d6bb7fa3c3cdb1ac87501300b3b87c034fedad/ios/chrome/browser/ui/ntp/recent_tabs/BUILD.gn [add] https://crrev.com/29d6bb7fa3c3cdb1ac87501300b3b87c034fedad/ios/chrome/browser/ui/ntp/recent_tabs/closed_tabs_observer_bridge.h [rename] https://crrev.com/29d6bb7fa3c3cdb1ac87501300b3b87c034fedad/ios/chrome/browser/ui/ntp/recent_tabs/closed_tabs_observer_bridge.mm [delete] https://crrev.com/2b781f033b8d428dbe5d3d36455977fcdc9928da/ios/chrome/browser/ui/ntp/recent_tabs/recent_tabs_bridges.h [modify] https://crrev.com/29d6bb7fa3c3cdb1ac87501300b3b87c034fedad/ios/chrome/browser/ui/ntp/recent_tabs/recent_tabs_table_coordinator.h [modify] https://crrev.com/29d6bb7fa3c3cdb1ac87501300b3b87c034fedad/ios/chrome/browser/ui/ntp/recent_tabs/recent_tabs_table_coordinator.mm [modify] https://crrev.com/29d6bb7fa3c3cdb1ac87501300b3b87c034fedad/ios/chrome/browser/ui/sync/synced_sessions_bridge.h [modify] https://crrev.com/29d6bb7fa3c3cdb1ac87501300b3b87c034fedad/ios/clean/chrome/browser/DEPS [modify] https://crrev.com/29d6bb7fa3c3cdb1ac87501300b3b87c034fedad/ios/clean/chrome/browser/ui/ntp/ntp_coordinator.mm [modify] https://crrev.com/29d6bb7fa3c3cdb1ac87501300b3b87c034fedad/ios/clean/chrome/browser/ui/recent_tabs/BUILD.gn [modify] https://crrev.com/29d6bb7fa3c3cdb1ac87501300b3b87c034fedad/ios/clean/chrome/browser/ui/recent_tabs/recent_tabs_coordinator.mm
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a43f36c5374c30ecbea71d2f0ea582ea53c1b15b commit a43f36c5374c30ecbea71d2f0ea582ea53c1b15b Author: Gauthier Ambard <gambard@chromium.org> Date: Mon Sep 04 12:10:59 2017 [ios clean] Refactor NTP Home Header This CL refactors the NTP Home Header by removing its mediator as all its functionalities were related to UI. It also moves the ContentSuggestionsViewController to the header controller as it only has methods related to the header. Bug: 753391 Change-Id: I0b65956e93e41f7ccba15dfc4ddbf247f7d3c434 Reviewed-on: https://chromium-review.googlesource.com/647626 Reviewed-by: Mark Cogan <marq@chromium.org> Commit-Queue: Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#499482} [modify] https://crrev.com/a43f36c5374c30ecbea71d2f0ea582ea53c1b15b/ios/chrome/browser/content_suggestions/content_suggestions_coordinator.mm [modify] https://crrev.com/a43f36c5374c30ecbea71d2f0ea582ea53c1b15b/ios/chrome/browser/content_suggestions/content_suggestions_header_view_controller.mm [modify] https://crrev.com/a43f36c5374c30ecbea71d2f0ea582ea53c1b15b/ios/chrome/browser/ui/content_suggestions/BUILD.gn [modify] https://crrev.com/a43f36c5374c30ecbea71d2f0ea582ea53c1b15b/ios/chrome/browser/ui/content_suggestions/content_suggestions_collection_controlling.h [modify] https://crrev.com/a43f36c5374c30ecbea71d2f0ea582ea53c1b15b/ios/chrome/browser/ui/content_suggestions/content_suggestions_header_controlling.h [modify] https://crrev.com/a43f36c5374c30ecbea71d2f0ea582ea53c1b15b/ios/chrome/browser/ui/content_suggestions/content_suggestions_header_synchronizer.mm [modify] https://crrev.com/a43f36c5374c30ecbea71d2f0ea582ea53c1b15b/ios/chrome/browser/ui/content_suggestions/content_suggestions_header_synchronizing.h [modify] https://crrev.com/a43f36c5374c30ecbea71d2f0ea582ea53c1b15b/ios/chrome/browser/ui/content_suggestions/content_suggestions_view_controller.h [modify] https://crrev.com/a43f36c5374c30ecbea71d2f0ea582ea53c1b15b/ios/chrome/browser/ui/content_suggestions/content_suggestions_view_controller.mm [delete] https://crrev.com/a8e0102bd7251be33d03c2b2d3d1afa1a3161921/ios/chrome/browser/ui/content_suggestions/content_suggestions_view_controller_delegate.h [modify] https://crrev.com/a43f36c5374c30ecbea71d2f0ea582ea53c1b15b/ios/clean/chrome/browser/ui/ntp/BUILD.gn [modify] https://crrev.com/a43f36c5374c30ecbea71d2f0ea582ea53c1b15b/ios/clean/chrome/browser/ui/ntp/ntp_home_coordinator.mm [delete] https://crrev.com/a8e0102bd7251be33d03c2b2d3d1afa1a3161921/ios/clean/chrome/browser/ui/ntp/ntp_home_header_consumer.h [modify] https://crrev.com/a43f36c5374c30ecbea71d2f0ea582ea53c1b15b/ios/clean/chrome/browser/ui/ntp/ntp_home_header_coordinator.h [modify] https://crrev.com/a43f36c5374c30ecbea71d2f0ea582ea53c1b15b/ios/clean/chrome/browser/ui/ntp/ntp_home_header_coordinator.mm [delete] https://crrev.com/a8e0102bd7251be33d03c2b2d3d1afa1a3161921/ios/clean/chrome/browser/ui/ntp/ntp_home_header_mediator.h [delete] https://crrev.com/a8e0102bd7251be33d03c2b2d3d1afa1a3161921/ios/clean/chrome/browser/ui/ntp/ntp_home_header_mediator.mm [delete] https://crrev.com/a8e0102bd7251be33d03c2b2d3d1afa1a3161921/ios/clean/chrome/browser/ui/ntp/ntp_home_header_mediator_unittest.mm [delete] https://crrev.com/a8e0102bd7251be33d03c2b2d3d1afa1a3161921/ios/clean/chrome/browser/ui/ntp/ntp_home_header_provider.h [modify] https://crrev.com/a43f36c5374c30ecbea71d2f0ea582ea53c1b15b/ios/clean/chrome/browser/ui/ntp/ntp_home_header_view_controller.h [modify] https://crrev.com/a43f36c5374c30ecbea71d2f0ea582ea53c1b15b/ios/clean/chrome/browser/ui/ntp/ntp_home_header_view_controller.mm
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/78518faaef294f7d68a289c15c0a6b67071d378a commit 78518faaef294f7d68a289c15c0a6b67071d378a Author: Gauthier Ambard <gambard@chromium.org> Date: Mon Sep 04 12:17:43 2017 Set the sync delegate inside the synchronizer The synchronizer delegate used by the ContentSuggestions controller can be set inside the synchronizer, allowing an easier init. Bug: 753391 Change-Id: I9f70ebdd714aeb3d1a1013f0fcffbe971e850899 Reviewed-on: https://chromium-review.googlesource.com/647529 Commit-Queue: Gauthier Ambard <gambard@chromium.org> Reviewed-by: Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#499483} [modify] https://crrev.com/78518faaef294f7d68a289c15c0a6b67071d378a/ios/chrome/browser/content_suggestions/content_suggestions_coordinator.mm [modify] https://crrev.com/78518faaef294f7d68a289c15c0a6b67071d378a/ios/chrome/browser/content_suggestions/content_suggestions_header_view_controller.h [modify] https://crrev.com/78518faaef294f7d68a289c15c0a6b67071d378a/ios/chrome/browser/ui/content_suggestions/content_suggestions_collection_controlling.h [modify] https://crrev.com/78518faaef294f7d68a289c15c0a6b67071d378a/ios/chrome/browser/ui/content_suggestions/content_suggestions_header_controlling.h [modify] https://crrev.com/78518faaef294f7d68a289c15c0a6b67071d378a/ios/chrome/browser/ui/content_suggestions/content_suggestions_header_synchronizer.mm [modify] https://crrev.com/78518faaef294f7d68a289c15c0a6b67071d378a/ios/chrome/browser/ui/content_suggestions/content_suggestions_view_controller.h [modify] https://crrev.com/78518faaef294f7d68a289c15c0a6b67071d378a/ios/clean/chrome/browser/ui/ntp/ntp_home_coordinator.mm
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f125b287652ff87af5d4d70fe7e46691c9887ca5 commit f125b287652ff87af5d4d70fe7e46691c9887ca5 Author: Gauthier Ambard <gambard@chromium.org> Date: Mon Sep 04 14:20:15 2017 Use PanelIndentifier instead of Integer for NTPBar The NewTabPageBarItem was using a NSInteger to store a PanelIdentifier value. Use directly the enum to avoid conversions. Bug: 753391 Change-Id: I74e319db566cdb65e93a83b09d1d923b7b446c6f Reviewed-on: https://chromium-review.googlesource.com/645958 Reviewed-by: Mark Cogan <marq@chromium.org> Commit-Queue: Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#499497} [modify] https://crrev.com/f125b287652ff87af5d4d70fe7e46691c9887ca5/ios/chrome/browser/ui/ntp/BUILD.gn [modify] https://crrev.com/f125b287652ff87af5d4d70fe7e46691c9887ca5/ios/chrome/browser/ui/ntp/new_tab_page_bar_item.h [modify] https://crrev.com/f125b287652ff87af5d4d70fe7e46691c9887ca5/ios/chrome/browser/ui/ntp/new_tab_page_bar_item.mm [modify] https://crrev.com/f125b287652ff87af5d4d70fe7e46691c9887ca5/ios/chrome/browser/ui/ntp/new_tab_page_bar_unittest.mm [modify] https://crrev.com/f125b287652ff87af5d4d70fe7e46691c9887ca5/ios/chrome/browser/ui/ntp/new_tab_page_controller.mm [modify] https://crrev.com/f125b287652ff87af5d4d70fe7e46691c9887ca5/ios/clean/chrome/browser/ui/ntp/ntp_view_controller.mm [modify] https://crrev.com/f125b287652ff87af5d4d70fe7e46691c9887ca5/ios/showcase/ntp/BUILD.gn [modify] https://crrev.com/f125b287652ff87af5d4d70fe7e46691c9887ca5/ios/showcase/ntp/sc_ntp_coordinator.mm
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/9d9b6f21fda90dde8d63d8131ec16dfd3e06dc3e commit 9d9b6f21fda90dde8d63d8131ec16dfd3e06dc3e Author: Gauthier Ambard <gambard@chromium.org> Date: Mon Sep 04 15:06:22 2017 [ios clean] Fix start order for NTP coordinator The NTP coordinator was doing too many things in childCoordinatorDidStart:. This CL fixes it by changing the init method of the object created to allow setting the properties after the init. Bug: 753391 Change-Id: I4c1ef8e4e09507ed39bf126c826fe2dccd1335f9 Reviewed-on: https://chromium-review.googlesource.com/647533 Commit-Queue: Gauthier Ambard <gambard@chromium.org> Reviewed-by: Mark Cogan <marq@chromium.org> Cr-Commit-Position: refs/heads/master@{#499502} [modify] https://crrev.com/9d9b6f21fda90dde8d63d8131ec16dfd3e06dc3e/ios/chrome/browser/content_suggestions/content_suggestions_coordinator.mm [modify] https://crrev.com/9d9b6f21fda90dde8d63d8131ec16dfd3e06dc3e/ios/chrome/browser/ui/ntp/google_landing_mediator.h [modify] https://crrev.com/9d9b6f21fda90dde8d63d8131ec16dfd3e06dc3e/ios/chrome/browser/ui/ntp/google_landing_mediator.mm [modify] https://crrev.com/9d9b6f21fda90dde8d63d8131ec16dfd3e06dc3e/ios/chrome/browser/ui/ntp/google_landing_view_controller_unittest.mm [modify] https://crrev.com/9d9b6f21fda90dde8d63d8131ec16dfd3e06dc3e/ios/chrome/browser/ui/ntp/new_tab_page_controller.mm [modify] https://crrev.com/9d9b6f21fda90dde8d63d8131ec16dfd3e06dc3e/ios/clean/chrome/browser/ui/ntp/ntp_home_coordinator.mm
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/01104c900737d9ad2223a81c179ee27ce82b89b2 commit 01104c900737d9ad2223a81c179ee27ce82b89b2 Author: Gauthier Ambard <gambard@chromium.org> Date: Mon Sep 04 16:07:05 2017 [ios clean] Add ApplicationCommandsAdaptor This CL adds an adaptor for the application commands used in the old architecture, to add it in the components from the old architecture used in the new architecture. Bug: 753391 Change-Id: I3d924ce724e57e1d6a5197b0eb7cd5872261d97b Reviewed-on: https://chromium-review.googlesource.com/643806 Commit-Queue: Gauthier Ambard <gambard@chromium.org> Reviewed-by: Mark Cogan <marq@chromium.org> Cr-Commit-Position: refs/heads/master@{#499505} [modify] https://crrev.com/01104c900737d9ad2223a81c179ee27ce82b89b2/ios/clean/chrome/browser/ui/BUILD.gn [add] https://crrev.com/01104c900737d9ad2223a81c179ee27ce82b89b2/ios/clean/chrome/browser/ui/adaptor/BUILD.gn [add] https://crrev.com/01104c900737d9ad2223a81c179ee27ce82b89b2/ios/clean/chrome/browser/ui/adaptor/application_commands_adaptor.h [add] https://crrev.com/01104c900737d9ad2223a81c179ee27ce82b89b2/ios/clean/chrome/browser/ui/adaptor/application_commands_adaptor.mm [rename] https://crrev.com/01104c900737d9ad2223a81c179ee27ce82b89b2/ios/clean/chrome/browser/ui/adaptor/url_loader_adaptor.h [rename] https://crrev.com/01104c900737d9ad2223a81c179ee27ce82b89b2/ios/clean/chrome/browser/ui/adaptor/url_loader_adaptor.mm [modify] https://crrev.com/01104c900737d9ad2223a81c179ee27ce82b89b2/ios/clean/chrome/browser/ui/bookmarks/BUILD.gn [modify] https://crrev.com/01104c900737d9ad2223a81c179ee27ce82b89b2/ios/clean/chrome/browser/ui/bookmarks/bookmarks_coordinator.mm [modify] https://crrev.com/01104c900737d9ad2223a81c179ee27ce82b89b2/ios/clean/chrome/browser/ui/recent_tabs/BUILD.gn [modify] https://crrev.com/01104c900737d9ad2223a81c179ee27ce82b89b2/ios/clean/chrome/browser/ui/recent_tabs/recent_tabs_coordinator.mm
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b93cb9fb4acedbc93c1206abd86a83b432ad1916 commit b93cb9fb4acedbc93c1206abd86a83b432ad1916 Author: Gauthier Ambard <gambard@chromium.org> Date: Mon Sep 04 16:18:35 2017 Change scroll ending based on toolbar presence The NTP doesn't display a half-shown toolbar. In the old architecture this means finishing the scroll of the Collection to hide or display it completely. In the new architecture the toolbar is not part of the collection so this displacement in scrolling should be removed. Bug: 753391 Change-Id: I7a7b7794784e097292179271edbe43038bb1652d Reviewed-on: https://chromium-review.googlesource.com/649150 Commit-Queue: Gauthier Ambard <gambard@chromium.org> Reviewed-by: Mark Cogan <marq@chromium.org> Cr-Commit-Position: refs/heads/master@{#499508} [modify] https://crrev.com/b93cb9fb4acedbc93c1206abd86a83b432ad1916/ios/chrome/browser/content_suggestions/content_suggestions_coordinator.mm [modify] https://crrev.com/b93cb9fb4acedbc93c1206abd86a83b432ad1916/ios/chrome/browser/ui/content_suggestions/content_suggestions_collection_utils.h [modify] https://crrev.com/b93cb9fb4acedbc93c1206abd86a83b432ad1916/ios/chrome/browser/ui/content_suggestions/content_suggestions_view_controller.h [modify] https://crrev.com/b93cb9fb4acedbc93c1206abd86a83b432ad1916/ios/chrome/browser/ui/content_suggestions/content_suggestions_view_controller.mm [modify] https://crrev.com/b93cb9fb4acedbc93c1206abd86a83b432ad1916/ios/clean/chrome/browser/ui/ntp/ntp_home_coordinator.mm
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/84048b02407dd8451ce16ede5b10e879b9a302c7 commit 84048b02407dd8451ce16ede5b10e879b9a302c7 Author: Gauthier Ambard <gambard@chromium.org> Date: Tue Sep 05 09:13:26 2017 [ios clean] Add BrowserCommandsAdaptor This CL adds BrowserCommandsAdaptor, an adaptor to use the BrowserCommands of the old architecture in the new architecture. Bug: 753391 Change-Id: I007a4ecfebc2ff4e293690a58450015467faad85 Reviewed-on: https://chromium-review.googlesource.com/649848 Reviewed-by: Mark Cogan <marq@chromium.org> Commit-Queue: Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#499590} [modify] https://crrev.com/84048b02407dd8451ce16ede5b10e879b9a302c7/ios/clean/chrome/browser/ui/adaptor/BUILD.gn [add] https://crrev.com/84048b02407dd8451ce16ede5b10e879b9a302c7/ios/clean/chrome/browser/ui/adaptor/browser_commands_adaptor.h [add] https://crrev.com/84048b02407dd8451ce16ede5b10e879b9a302c7/ios/clean/chrome/browser/ui/adaptor/browser_commands_adaptor.mm [modify] https://crrev.com/84048b02407dd8451ce16ede5b10e879b9a302c7/ios/clean/chrome/browser/ui/ntp/BUILD.gn [modify] https://crrev.com/84048b02407dd8451ce16ede5b10e879b9a302c7/ios/clean/chrome/browser/ui/ntp/ntp_home_coordinator.mm [modify] https://crrev.com/84048b02407dd8451ce16ede5b10e879b9a302c7/ios/clean/chrome/browser/ui/recent_tabs/recent_tabs_coordinator.mm
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/10533a5183f29c544538378ad25a9ac6faaf9180 commit 10533a5183f29c544538378ad25a9ac6faaf9180 Author: Gauthier Ambard <gambard@chromium.org> Date: Wed Sep 06 09:19:50 2017 [ios clean] Add presentation mode for NTP The Recent Tabs and Bookmarks coordinators need to know in which mode their ViewController will be presented. This CL adds this information. Bug: 753391 Change-Id: Ie71b891431563781ae45eaebe809271d559aff2e Reviewed-on: https://chromium-review.googlesource.com/650290 Commit-Queue: Gauthier Ambard <gambard@chromium.org> Reviewed-by: Mark Cogan <marq@chromium.org> Cr-Commit-Position: refs/heads/master@{#499915} [modify] https://crrev.com/10533a5183f29c544538378ad25a9ac6faaf9180/ios/chrome/browser/ui/coordinators/browser_coordinator+internal.h [modify] https://crrev.com/10533a5183f29c544538378ad25a9ac6faaf9180/ios/chrome/browser/ui/coordinators/browser_coordinator.h [modify] https://crrev.com/10533a5183f29c544538378ad25a9ac6faaf9180/ios/clean/chrome/browser/ui/bookmarks/bookmarks_coordinator.h [modify] https://crrev.com/10533a5183f29c544538378ad25a9ac6faaf9180/ios/clean/chrome/browser/ui/bookmarks/bookmarks_coordinator.mm [modify] https://crrev.com/10533a5183f29c544538378ad25a9ac6faaf9180/ios/clean/chrome/browser/ui/ntp/ntp_coordinator.mm [modify] https://crrev.com/10533a5183f29c544538378ad25a9ac6faaf9180/ios/clean/chrome/browser/ui/recent_tabs/recent_tabs_coordinator.h [modify] https://crrev.com/10533a5183f29c544538378ad25a9ac6faaf9180/ios/clean/chrome/browser/ui/recent_tabs/recent_tabs_coordinator.mm
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/5db75eceaaeb9f77c888aed84c419d6b311d4a9a commit 5db75eceaaeb9f77c888aed84c419d6b311d4a9a Author: Gauthier Ambard <gambard@chromium.org> Date: Thu Sep 14 13:39:15 2017 [ios clean] NTP Coordinator uses mediator Use the mediator in the coordinator to avoid code duplication. Bug: 764720 , 753391 Change-Id: Ib56cda9e0267e5dc98f7f51fdc3ee2185a245228 Reviewed-on: https://chromium-review.googlesource.com/665237 Commit-Queue: Gauthier Ambard <gambard@chromium.org> Reviewed-by: Mark Cogan <marq@chromium.org> Cr-Commit-Position: refs/heads/master@{#501942} [modify] https://crrev.com/5db75eceaaeb9f77c888aed84c419d6b311d4a9a/ios/chrome/browser/content_suggestions/ntp_home_mediator.h [modify] https://crrev.com/5db75eceaaeb9f77c888aed84c419d6b311d4a9a/ios/chrome/browser/ui/content_suggestions/content_suggestions_header_view_controller_delegate.h [modify] https://crrev.com/5db75eceaaeb9f77c888aed84c419d6b311d4a9a/ios/clean/chrome/browser/ui/ntp/BUILD.gn [modify] https://crrev.com/5db75eceaaeb9f77c888aed84c419d6b311d4a9a/ios/clean/chrome/browser/ui/ntp/ntp_home_coordinator.mm [modify] https://crrev.com/5db75eceaaeb9f77c888aed84c419d6b311d4a9a/ios/clean/chrome/browser/ui/ntp/ntp_home_header_coordinator.h [modify] https://crrev.com/5db75eceaaeb9f77c888aed84c419d6b311d4a9a/ios/clean/chrome/browser/ui/ntp/ntp_home_header_coordinator.mm [modify] https://crrev.com/5db75eceaaeb9f77c888aed84c419d6b311d4a9a/ios/clean/chrome/browser/ui/ntp/ntp_home_header_view_controller.h [modify] https://crrev.com/5db75eceaaeb9f77c888aed84c419d6b311d4a9a/ios/clean/chrome/browser/ui/ntp/ntp_home_header_view_controller.mm
Comment 1 by gambard@chromium.org
, Aug 9 2017