New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 753384 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Aug 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 2
Type: Bug



Sign in to add a comment

[WebPayments] Desktop PR should have consistent casing per platform

Project Member Reported by zkoch@chromium.org, Aug 8 2017

Issue description

We have casing inconsistencies (some title, some sentence). We should make it consistent and follow platform best practices.

Shimi will help us with this.
 

Comment 1 by zkoch@chromium.org, Aug 8 2017

Cc: tmartino@chromium.org
Components: UI>Browser>Payments
Labels: -Pri-3 M-62 OS-Chrome OS-Linux OS-Mac OS-Windows Pri-2
Owner: anthonyvd@chromium.org
Status: Assigned (was: Untriaged)

Comment 2 by zkoch@chromium.org, Aug 8 2017

Guidance from Shimi:

Mac and iOS: Title case for titles, buttons, menus, and menu items. Sentence case for other labels, like checkbox or radio button labels.

Chrome OS, Win, and Linux: Sentence case for everything, per Google UX writing guidelines
Cc: -tmartino@chromium.org anthonyvd@chromium.org zkoch@chromium.org
Owner: tmartino@chromium.org
Status: Started (was: Assigned)
Summary: [WebPayments] Desktop PR should have consistent casing per platform (was: Desktop PR should have consistent casing per platform)
Cc: ram...@chromium.org
cc ramine@: FYI Mac and iOS are getting Title Case strings, which will make some of the payments UI untranslated for several weeks after the next branch.
Android should be using sentence case, by the way.
Project Member

Comment 6 by bugdroid1@chromium.org, Aug 15 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/273b2f6a3c4112d2dab0ecbcdc441eb48494f5cd

commit 273b2f6a3c4112d2dab0ecbcdc441eb48494f5cd
Author: Tommy Martino <tmartino@chromium.org>
Date: Tue Aug 15 20:58:13 2017

[WebPayments] Correcting string casing per-platform

This CL introduces Title-Cased strings to be used on iOS/Mac, and
ensures that sentence-casing is used on other platforms. Also lightly
reorganizes the existing strings, and removes a couple duplicate
or unused strings.

Bug:  753384 
Change-Id: Ibe1370736f95048fa29122e70c4c51b780c32033
Reviewed-on: https://chromium-review.googlesource.com/611659
Reviewed-by: Rouslan Solomakhin <rouslan@chromium.org>
Reviewed-by: Anthony Vallee-Dubois <anthonyvd@chromium.org>
Commit-Queue: Tommy Martino <tmartino@chromium.org>
Cr-Commit-Position: refs/heads/master@{#494536}
[modify] https://crrev.com/273b2f6a3c4112d2dab0ecbcdc441eb48494f5cd/chrome/browser/ui/views/payments/payment_sheet_view_controller.cc
[modify] https://crrev.com/273b2f6a3c4112d2dab0ecbcdc441eb48494f5cd/chrome/browser/ui/views/payments/profile_list_view_controller.cc
[modify] https://crrev.com/273b2f6a3c4112d2dab0ecbcdc441eb48494f5cd/components/payments_strings.grdp

Status: Fixed (was: Started)

Sign in to add a comment