New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 753383 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Aug 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 2
Type: Feature

Blocking:
issue 583292



Sign in to add a comment

[Local NTP] OGB: Theming

Project Member Reported by treib@chromium.org, Aug 8 2017

Issue description

The OneGoogleBar on the local NTP should respond to themes. In particular, for themes with a dark background, it'd be nice to make icons and fonts a light color, because otherwise they can become barely visible.
 
Labels: zine-triaged
Project Member

Comment 2 by bugdroid1@chromium.org, Aug 9 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/10f0a9255c44398e29fe72e0c1f16b78e668c04a

commit 10f0a9255c44398e29fe72e0c1f16b78e668c04a
Author: Marc Treib <treib@chromium.org>
Date: Wed Aug 09 13:40:53 2017

OneGoogleBar on local NTP: Basic theming support

This changes the foreground style of the OneGoogleBar to "light" if the
theme has a dark background, similar to what the remote NTP does.

Bug:  753383 
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: Ic0d4a087a09fe78e38383e96758d9600d8822168
Reviewed-on: https://chromium-review.googlesource.com/605951
Commit-Queue: Marc Treib <treib@chromium.org>
Reviewed-by: Chris Pickel <sfiera@chromium.org>
Cr-Commit-Position: refs/heads/master@{#492961}
[modify] https://crrev.com/10f0a9255c44398e29fe72e0c1f16b78e668c04a/chrome/browser/resources/local_ntp/local_ntp.js

Comment 3 by treib@chromium.org, Aug 9 2017

Status: Fixed (was: Started)

Sign in to add a comment