In-product-help : The text bubble is not pointing to the menu button when it has a long text |
||||||
Issue descriptionI feel this issue usually comes up when the bubble has a long text. Here the popup message appears to be a rectangle (without the arrow) and starts from left of the screen. I will attach a screenshot.
,
Aug 10 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/edb2f348f3abf7021492bbfd44299cbe613c821e commit edb2f348f3abf7021492bbfd44299cbe613c821e Author: Shakti Sahu <shaktisahu@chromium.org> Date: Thu Aug 10 05:44:15 2017 IPH : Fixed the horizontal misalignment of text bubble on long text For texts that span multi-line, somehow the bubble is misaligned horizontally. This is probably happening due to WRAP_CONTENT being set for the popup and the text view. This CL fixes the issue by calling an update() with proper width. Bug: 753375 Change-Id: I9e65f26f62dd3ca4bdb9155d69f9546666964ad4 Reviewed-on: https://chromium-review.googlesource.com/606668 Commit-Queue: Shakti Sahu <shaktisahu@chromium.org> Reviewed-by: David Trainor <dtrainor@chromium.org> Cr-Commit-Position: refs/heads/master@{#493298} [modify] https://crrev.com/edb2f348f3abf7021492bbfd44299cbe613c821e/chrome/android/java/src/org/chromium/chrome/browser/widget/textbubble/TextBubble.java
,
Aug 10 2017
,
Aug 14 2017
,
Aug 14 2017
This bug requires manual review: M61 has already been promoted to the beta branch, so this requires manual review Please contact the milestone owner if you have questions. Owners: amineer@(Android), cmasso@(iOS), ketakid@(ChromeOS), govind@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Aug 15 2017
Merge approved for M61 branch 3163.
,
Aug 15 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/8473650b15adaa767f7570c55605a0ae545b5bee commit 8473650b15adaa767f7570c55605a0ae545b5bee Author: Shakti Sahu <shaktisahu@chromium.org> Date: Tue Aug 15 20:59:02 2017 IPH : Fixed the horizontal misalignment of text bubble on long text For texts that span multi-line, somehow the bubble is misaligned horizontally. This is probably happening due to WRAP_CONTENT being set for the popup and the text view. This CL fixes the issue by calling an update() with proper width. TBR=shaktisahu@chromium.org (cherry picked from commit edb2f348f3abf7021492bbfd44299cbe613c821e) Bug: 753375 Change-Id: I9e65f26f62dd3ca4bdb9155d69f9546666964ad4 Reviewed-on: https://chromium-review.googlesource.com/606668 Commit-Queue: Shakti Sahu <shaktisahu@chromium.org> Reviewed-by: David Trainor <dtrainor@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#493298} Reviewed-on: https://chromium-review.googlesource.com/616020 Reviewed-by: Shakti Sahu <shaktisahu@chromium.org> Cr-Commit-Position: refs/branch-heads/3163@{#584} Cr-Branched-From: ff259bab28b35d242e10186cd63af7ed404fae0d-refs/heads/master@{#488528} [modify] https://crrev.com/8473650b15adaa767f7570c55605a0ae545b5bee/chrome/android/java/src/org/chromium/chrome/browser/widget/textbubble/TextBubble.java |
||||||
►
Sign in to add a comment |
||||||
Comment 1 by shaktisahu@chromium.org
, Aug 8 2017Status: Started (was: Available)