Issue metadata
Sign in to add a comment
|
Reevaluate timeout needed for the perf waterfall |
||||||||||||||||||||
Issue descriptionIn https://chromium-review.googlesource.com/c/605930, we doubled the perf waterfall cycle time from 10h to 20h in order to ensure that the benchmark reenabling fix-it didn't cause us to exceed our current timeout of 10h. 20h is just a safe guess for a timeout that we don't think we'll actually come close to. After the fix-it is complete, we should look at go/perf-waterfall-cycle-time to reevaluate what a more reasonable value would be.
,
Aug 9 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a4c8077e9017d25b8a254765a9d47e09af006019 commit a4c8077e9017d25b8a254765a9d47e09af006019 Author: rnephew <rnephew@chromium.org> Date: Wed Aug 09 06:34:16 2017 [Telemetry] Double the perf waterfall timeout from 10h to 20h. We're reenabling disabled benchmarks on platforms where they should be enabled, but this will increase the overall cycle time. We need to increase the overall perf waterfall timeout to reflect that. TBR=charliea@chromium.org Bug: 713222, 753367 Change-Id: I841d5e86d7932ad48ddfe0c08ac25693a786a268 Reviewed-on: https://chromium-review.googlesource.com/607389 Reviewed-by: rnephew <rnephew@chromium.org> Commit-Queue: rnephew <rnephew@chromium.org> Cr-Commit-Position: refs/heads/master@{#492858} [modify] https://crrev.com/a4c8077e9017d25b8a254765a9d47e09af006019/testing/buildbot/chromium.perf.fyi.json [modify] https://crrev.com/a4c8077e9017d25b8a254765a9d47e09af006019/testing/buildbot/chromium.perf.json [modify] https://crrev.com/a4c8077e9017d25b8a254765a9d47e09af006019/tools/perf/core/perf_data_generator.py [modify] https://crrev.com/a4c8077e9017d25b8a254765a9d47e09af006019/tools/perf/core/perf_data_generator_unittest.py
,
Aug 15 2017
The NextAction date has arrived: 2017-08-15
,
Aug 16 2017
According to http://go/perf-waterfall-cycle-time, I think we should do about 10 hours again. The mac mini bot has about a 10 hour cycle time, so I think that's a good limit. Anyone else have opinions?
,
Aug 21 2017
If we didn't have any problems with the 10h, lets go back there and increase slowly if we see additional porblems. Charlie can you own that since you did the original increase?
,
Aug 21 2017
Charlie is currently very swarmed, can either you or Stephen take this instead?
,
Aug 21 2017
,
Aug 21 2017
,
Aug 23 2017
Unfortunately
,
Aug 31 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/0132b4f748f7dd117c9000adfb7a267c55fdfc9e commit 0132b4f748f7dd117c9000adfb7a267c55fdfc9e Author: Stephen Martinis <martiniss@chromium.org> Date: Thu Aug 31 21:42:30 2017 Change timeout back to 10 hours Nothing seems to be really hitting this timeout that badly. I think this should be safe. Bug: 753367 Change-Id: I09a27952d90b3238d1287ab00c5f81bfab54a4fd Reviewed-on: https://chromium-review.googlesource.com/624177 Commit-Queue: Stephen Martinis <martiniss@chromium.org> Reviewed-by: Ned Nguyen <nednguyen@google.com> Cr-Commit-Position: refs/heads/master@{#499017} [modify] https://crrev.com/0132b4f748f7dd117c9000adfb7a267c55fdfc9e/testing/buildbot/chromium.perf.fyi.json [modify] https://crrev.com/0132b4f748f7dd117c9000adfb7a267c55fdfc9e/testing/buildbot/chromium.perf.json [modify] https://crrev.com/0132b4f748f7dd117c9000adfb7a267c55fdfc9e/tools/perf/core/perf_data_generator.py [modify] https://crrev.com/0132b4f748f7dd117c9000adfb7a267c55fdfc9e/tools/perf/core/perf_data_generator_unittest.py
,
Sep 1 2017
Ok, I changed it back to 10 hours. Not sure if we want to keep this open or not? In the future, assuming we get our cycle time down more, we'd want to decrease the timeout more.
,
Sep 1 2017
How we do timeout for benchmark will be completely different in the one build bot step world. So we can close this as Fixed.
,
Sep 23 2017
The NextAction date has arrived: 2017-09-23
,
Sep 25 2017
I think we could afford to decrease the timeout, but not sure how worth it doing this would be. I'll push back the next action for 2 more months.
,
Nov 23 2017
The NextAction date has arrived: 2017-11-23 |
|||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||
Comment 1 by charliea@chromium.org
, Aug 8 2017