Issue metadata
Sign in to add a comment
|
Omnibox doesn't occupies full screen on dismissing GLIF |
||||||||||||||||||||||
Issue descriptionApp Version: 61.0.3163.25, 62.0.3179.0 canary iOS Version: 10.3.3, iOS 11 beta 5 Device : iPhone5, iPhone7+ Steps to reproduce: 1. Launch chrome. 2. Scroll the ntp to full screen. 3. Tap on GLIF icon 4. Dismiss the GLIF icon Observed results: Omnibox doesn't occupies full screen Expected results: Omnibox should occupy full screen. Number of times you were able to reproduce: 5/5 Bug reproducible after clean install: Yes Bug reproducible after clearing cache and cookies: Yes Bug reproducible on Chrome Mobile on Android: NA Bug reproducible on Dolphin/Safari/Firefox: Safari : NA Bug reproducible on current stable build (App Version, iOS Version): No in 60.0.3112.89 Bug reproducible on the current beta channel build (App Version, iOS Version): Yes in 61.0.3163.25 Link to video : https://drive.google.com/a/google.com/file/d/0B--UpU2GW2EpdkVBWGtIZ244ZGs/view?usp=sharing
,
Aug 9 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a195bb62b1fd607f6d57bd45747c5d50ab258833 commit a195bb62b1fd607f6d57bd45747c5d50ab258833 Author: gambard <gambard@chromium.org> Date: Wed Aug 09 08:08:25 2017 Update the fake omnibox when layouting subviews When the subviews of the GoogleLandingViewController are laid out, the constraints must be updated. The fake omnibox constraints need to take into account the position of the omnibox vertically to update its width. Bug: 753356 Change-Id: Iad7827dfb0de0809450db747cd22db498c5b948f Reviewed-on: https://chromium-review.googlesource.com/605850 Commit-Queue: Gauthier Ambard <gambard@chromium.org> Reviewed-by: Justin Cohen <justincohen@chromium.org> Cr-Commit-Position: refs/heads/master@{#492892} [modify] https://crrev.com/a195bb62b1fd607f6d57bd45747c5d50ab258833/ios/chrome/browser/ui/ntp/google_landing_view_controller.mm [modify] https://crrev.com/a195bb62b1fd607f6d57bd45747c5d50ab258833/ios/chrome/browser/ui/ntp/new_tab_page_header_view.mm
,
Aug 9 2017
,
Aug 15 2017
Verified in 62.0.3186.0 canary, iPhone 6 plus iOS 10.3.3, iPhone 7 iOS11 Omnibox occupies full screen on dismissing GLIF Looks good. |
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by gambard@chromium.org
, Aug 9 2017Status: Assigned (was: Untriaged)